René's URL Explorer Experiment


Title: Fix `binascii.b2a_qp` CRLF boundary check by YangSiJun528 · Pull Request #8358 · RustPython/RustPython · GitHub

Open Graph Title: Fix `binascii.b2a_qp` CRLF boundary check by YangSiJun528 · Pull Request #8358 · RustPython/RustPython

X Title: Fix `binascii.b2a_qp` CRLF boundary check by YangSiJun528 · Pull Request #8358 · RustPython/RustPython

Description: Related to #8325 (RUSTPY-0010-binascii-b2a-qp-underflow) This PR follows our AI policy Summary Prevent binascii.b2a_qp() from panicking when the input starts with \n. Match CPython's boundary check when detecting CRLF line endings. When the first byte is \n, in_idx remains zero and accessing buf[in_idx - 1] causes an integer underflow. This change checks in_idx > 0 before accessing the preceding byte. Testing cargo run -- -c 'import binascii; assert binascii.b2a_qp(b"\n") == b"\n"' cargo run --release -- -m test test_binascii Before this change, the RustPython command panicked with: attempt to subtract with overflow AI assistance Codex (GPT‑5.6 Sol) was used to investigate and implement this change. I reviewed and validated all AI-assisted work. Summary by CodeRabbit Bug Fixes Improved quoted-printable encoding’s carriage-return detection to avoid incorrect line-ending handling near buffer boundaries. Added tighter boundary checks so CR detection only occurs when the previous byte is safely accessible.

Open Graph Description: Related to #8325 (RUSTPY-0010-binascii-b2a-qp-underflow) This PR follows our AI policy Summary Prevent binascii.b2a_qp() from panicking when the input starts with \n. Match CPython's boundar...

X Description: Related to #8325 (RUSTPY-0010-binascii-b2a-qp-underflow) This PR follows our AI policy Summary Prevent binascii.b2a_qp() from panicking when the input starts with \n. Match CPython's bou...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8358

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8acaa165-1ddf-dada-6ecc-ab1ece825d88
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A98:311640:33A8ECB:41BB81B:6B01DE78
html-safe-noncee3763105194a385dc898b3e7fb91c537f45b2125f74a84bceac3d39e20d43604
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTk4OjMxMTY0MDozM0E4RUNCOjQxQkI4MUI6NkIwMURFNzgiLCJ2aXNpdG9yX2lkIjoiMTAxMTY1ODEwMzU5NjM3NTY3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8fdf8c2efc95e6004be2f7a50de53e348d99a9a369a68417b5d06c15d762cf38
hovercard-subject-tagpull_request:4124406936
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8358/files
twitter:imagehttps://avatars.githubusercontent.com/u/80192911?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/80192911?s=400&v=4
og:image:altRelated to #8325 (RUSTPY-0010-binascii-b2a-qp-underflow) This PR follows our AI policy Summary Prevent binascii.b2a_qp() from panicking when the input starts with \n. Match CPython's boundar...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/8358/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8358%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8358%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/8358/files
Reloadhttps://github.com/RustPython/RustPython/pull/8358/files
Reloadhttps://github.com/RustPython/RustPython/pull/8358/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
YangSiJun528:fix-b2a-qp-crlf-checkhttps://github.com/YangSiJun528/RustPython/tree/fix-b2a-qp-crlf-check
Conversation 3 https://github.com/RustPython/RustPython/pull/8358
Commits 1 https://github.com/RustPython/RustPython/pull/8358/commits
Checks 25 https://github.com/RustPython/RustPython/pull/8358/checks
Files changed https://github.com/RustPython/RustPython/pull/8358/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8358/files
Fix binascii.b2a_qp CRLF boundary check https://github.com/RustPython/RustPython/pull/8358/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/8358/files
d73df27 Fix b2a_qp CRLF boundary check YangSiJun528 Jul 24, 2026 https://github.com/RustPython/RustPython/pull/8358/commits/d73df270b18876472a282134a459deddc2d32e05
Clear filters https://github.com/RustPython/RustPython/pull/8358/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8358/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8358/files
crates/stdlib/src/binascii.rshttps://github.com/RustPython/RustPython/pull/8358/files#diff-320603fd2cff5effce8920ead11397601761668ce71ad5f7eac5fa7118ea504e
View file https://github.com/YangSiJun528/RustPython/blob/d73df270b18876472a282134a459deddc2d32e05/crates/stdlib/src/binascii.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/8358/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/8358/files#diff-320603fd2cff5effce8920ead11397601761668ce71ad5f7eac5fa7118ea504e
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8358/files
https://github.com/RustPython/RustPython/pull/8358/files#diff-320603fd2cff5effce8920ead11397601761668ce71ad5f7eac5fa7118ea504e
Please reload this pagehttps://github.com/RustPython/RustPython/pull/8358/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.