René's URL Explorer Experiment

Title: Take a borrow in invoke_exception instead of an owned type by kangdora · Pull Request #8327 · RustPython/RustPython · GitHub

Open Graph Title: Take a borrow in invoke_exception instead of an owned type by kangdora · Pull Request #8327 · RustPython/RustPython

X Title: Take a borrow in invoke_exception instead of an owned type by kangdora · Pull Request #8327 · RustPython/RustPython

Description: Closes #8320 This PR follows our AI policy Summary VirtualMachine::invoke_exception took its class argument as an owned PyTypeRef, but it never takes ownership — it only borrows cls for PyType::call (which itself is defined as fn call(zelf: &Py, ...)) and for Display in the error message. cls is never moved or stored. Because the signature demanded ownership, callers holding only a borrow had to .to_owned() — an atomic refcount bump and later decrement — purely to satisfy the type, even though the reference was dropped immediately after the call. This changes the parameter to &Py, the exact borrowed form (PyTypeRef = PyRef derefs to Py), and drops those .to_owned() calls. Call sites updated: file before stdlib/_io.rs (3×) vm.ctx.exceptions.blocking_io_error.to_owned() stdlib/sys.rs vm.ctx.exceptions.system_exit.to_owned() stdlib/builtins.rs vm.ctx.exceptions.system_exit.to_owned() stdlib/_thread.rs vm.ctx.exceptions.system_exit.to_owned() vm/mod.rs vm.ctx.exceptions.system_exit.to_owned() vm/vm_new.rs vm.ctx.exceptions.stop_iteration.to_owned() exception_group.rs vm.ctx.exceptions.base_exception_group.to_owned() exceptions.rs typ.to_owned() capi/pyerrors.rs exc_type.to_owned() ExceptionCtor::instantiate / instantiate_value own their cls via the self match, so they just pass &cls — no clone either way. No behavior change; this is an API/ergonomics cleanup that removes unnecessary refcount churn and makes the helper consistent with the PyType::call it wraps. Test plan test_exceptions, test_sys, test_io (667 tests, covering the BlockingIOError sites), extra_tests/snippets/builtin_exceptions.py: no regressions (the single test_exceptions failure, test_badisinstance, is pre-existing on main). Exercised each touched path manually: sys.exit / exit() / _thread.exit, raise ValueError and raise ValueError(...) via ExceptionCtor, ExceptionGroup, generator StopIteration, OSError from a failed open, and the genuine Err path of invoke_exception (a BaseException subclass whose __new__ returns a non-exception). cargo fmt --check / cargo clippy: clean. Assisted-by: Claude Code:claude-fable-5 Summary by CodeRabbit Refactor Streamlined internal exception creation across the runtime by avoiding unnecessary exception-type copies. Preserved existing behavior for SystemExit, BlockingIOError, StopIteration, COM errors, and other exception paths. Improved exception handling efficiency without changing public functionality or error messages.

Open Graph Description: Closes #8320 This PR follows our AI policy Summary VirtualMachine::invoke_exception took its class argument as an owned PyTypeRef, but it never takes ownership — it only borrows cls for PyType::c...

X Description: Closes #8320 This PR follows our AI policy Summary VirtualMachine::invoke_exception took its class argument as an owned PyTypeRef, but it never takes ownership — it only borrows cls for PyType::c...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8327

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width