René's URL Explorer Experiment

Title: ctypes: fix Windows pip truststore by youknowone · Pull Request #8314 · RustPython/RustPython · GitHub

Open Graph Title: ctypes: fix Windows pip truststore by youknowone · Pull Request #8314 · RustPython/RustPython

X Title: ctypes: fix Windows pip truststore by youknowone · Pull Request #8314 · RustPython/RustPython

Description: Summary preserve the foreign-call result when a ctypes errcheck callback returns the exact args tuple accept c_char_p and c_wchar_p instances when initializing matching pointer arrays add focused stdlib_ctypes.py regressions and a Windows pip HTTPS smoke test using pip's vendored truststore implement PyEval_SaveThread/PyEval_RestoreThread so blocking C API callers detach from stop-the-world Closes #8281. Root cause RustPython unconditionally replaced a foreign function's result with the value returned by errcheck. Truststore returns the original args tuple to request normal result processing, so RustPython changed the Windows certificate-store handle into a tuple. Passing that tuple to the next c_void_p argument raised TypeError: wrong type. After preserving the handle, truststore reached its enhanced-key-usage setup and initialized a c_char_p array from an existing c_char_p instance. RustPython's specialized string-pointer array writer accepted bytes and integer addresses, but not a matching ctypes pointer instance. CI hang root cause The Ubuntu C API job exposed an existing threading bug: PyEval_SaveThread and PyEval_RestoreThread were no-ops. A parent test thread could therefore remain attached while joining a child that requested stop-the-world, leaving each thread waiting for the other. The implementation now preserves the VM stack and GILState-owned VM across detach/restore, and the C API test forces a stop-the-world cycle to cover the deadlock deterministically. Validation uvx prek run --all-files cargo clippy -p rustpython-vm -p rustpython-capi --all-targets supported Windows workspace test suite Linux C API suite (98 tests), including 100 repeated parallel runs all snippet tests under CPython 3.14 and RustPython (400 passed, 4 skipped) uvx zizmor --min-severity low .github/workflows/ci.yaml isolated ensurepip followed by pip download six over HTTPS on Windows Summary by CodeRabbit New Features Added native thread save/restore support that preserves VM/GIL context when threads detach and later restore (threading feature). Bug Fixes Improved _ctypes errcheck handling so the original result is only replaced when the checker returns a different value. Enhanced _ctypes array element writing for c_char_p/c_wchar_p-style pointer types to write pointer values directly from compatible simple instances. Updated Windows overlapped I/O completion to run with threads allowed to prevent blocking VM thread execution. Tests Expanded _ctypes snippet coverage for char pointers and Windows kernel32 ctypes validation. CI Added a Windows-only HTTPS trust-store connectivity smoke test for pip snippet execution.

Open Graph Description: Summary preserve the foreign-call result when a ctypes errcheck callback returns the exact args tuple accept c_char_p and c_wchar_p instances when initializing matching pointer arrays add focused ...

X Description: Summary preserve the foreign-call result when a ctypes errcheck callback returns the exact args tuple accept c_char_p and c_wchar_p instances when initializing matching pointer arrays add focused ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8314

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width