René's URL Explorer Experiment

Title: bytes: support keyword arguments in hex() by devyubin · Pull Request #8312 · RustPython/RustPython · GitHub

Open Graph Title: bytes: support keyword arguments in hex() by devyubin · Pull Request #8312 · RustPython/RustPython

X Title: bytes: support keyword arguments in hex() by devyubin · Pull Request #8312 · RustPython/RustPython

Description: This PR follows our AI policy Summary bytes/bytearray/memoryview's hex() rejected its sep and bytes_per_sep arguments when passed by keyword, even though CPython accepts them either positionally or by keyword. b'\xb9\x01\xef'.hex(sep=':', bytes_per_sep=2) # before: TypeError: Unexpected keyword argument sep # after: 'b9:01ef' # matches CPython Cause hex() took its arguments as bare OptionalArg method parameters, whose FromArgs only consumes positionals (take_positional()) and never keywords. The argument names were never registered, so sep= / bytes_per_sep= stayed in kwargs and tripped check_kwargs_empty. Fix Move the arguments into a #[derive(FromArgs)] struct (ByteInnerHexOptions) with #[pyarg(any, optional)] fields, which generates take_positional_keyword so both positional and keyword forms are accepted — matching CPython's positional-or-keyword signature (no / or * in its Argument Clinic definition). Applied consistently to bytes, bytearray, and memoryview; the computation still delegates to the existing inner.hex(...), so the error cases are preserved (None → TypeError, separator len != 1 → ValueError). Re-enables test_hex_separator_basics by removing its expectedFailure marker. Test Verified locally: cargo run -- -m test test_bytes -v → Tests result: SUCCESS (Ran 317 tests, OK (skipped=15, expected failures=18)) test_hex_separator_basics (BytesTest / ByteArrayTest) ... ok test_hex_separator_five_bytes / test_hex_separator_six_bytes / test_hex ... ok Assisted-by: Claude Code:claude-opus-4-8 Summary by CodeRabbit Improvements Standardized hexadecimal formatting options across bytes, bytearray, and memoryview. Consistent support for custom separators and configurable bytes-per-group formatting. Existing .hex() behavior remains unchanged while argument handling is more consistent across these types.

Open Graph Description: This PR follows our AI policy Summary bytes/bytearray/memoryview's hex() rejected its sep and bytes_per_sep arguments when passed by keyword, even though CPython accepts them either positional...

X Description: This PR follows our AI policy Summary bytes/bytearray/memoryview's hex() rejected its sep and bytes_per_sep arguments when passed by keyword, even though CPython accepts them either positi...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8312

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width