René's URL Explorer Experiment

Title: module: honor module-level __dir__ (PEP 562) by JaceJung-dev · Pull Request #8271 · RustPython/RustPython · GitHub

Open Graph Title: module: honor module-level __dir__ (PEP 562) by JaceJung-dev · Pull Request #8271 · RustPython/RustPython

X Title: module: honor module-level __dir__ (PEP 562) by JaceJung-dev · Pull Request #8271 · RustPython/RustPython

Description: Closes #8231 This PR follows our AI policy Summary A module-level __dir__ function (PEP 562) was ignored: dir(module) returned the raw __dict__ keys instead of calling the module's __dir__. # mod.py def __dir__(): return ['gamma', 'alpha', 'beta'] # before: dir(mod) -> ['__builtins__', '__cached__', '__dir__', ...] # after: dir(mod) -> ['alpha', 'beta', 'gamma'] # matches CPython (dir() sorts) Cause PyModule::__dir__ (crates/vm/src/builtins/module.rs) unconditionally returned the module dict's keys, with no check for a module-level __dir__. Fix This ports the behavior of CPython's module_dir() in Objects/moduleobject.c, which is the reference implementation for this change: look up __dir__ in the module's __dict__ first and, if present, call it and return its result; otherwise fall back to list(__dict__). The lookup is a direct dict access, so neither the module-level __getattr__ nor the type's own __dir__ slot is involved. A non-callable or wrongly-signed __dir__ raises TypeError, matching CPython. The @unittest.expectedFailure # TODO: RUSTPYTHON markers on test_module_dir and test_module_dir_errors are removed since both now pass. Side effect Honoring a module-level __dir__ also fixes dir() for stdlib modules that define one, which flips two previously-failing tests to passing. Their stale @unittest.expectedFailure # TODO: RUSTPYTHON markers are removed as well (otherwise they would be reported as unexpected successes and fail CI): test_zoneinfo.test_dir_contains_all — zoneinfo.__dir__ makes dir(zoneinfo) contain everything in __all__. test_support.test_check__all__ — support.check__all__ iterates dir(module); unittest.__dir__ now surfaces IsolatedAsyncioTestCase (declared in unittest.__all__ but lazily loaded via PEP 562), so the check matches __all__. Test Verified locally: cargo run --release -- -m test test_module -v → SUCCESS (run=39) (test_module_dir / test_module_dir_errors ... ok) cargo run --release -- -m test test_zoneinfo → SUCCESS (test_dir_contains_all now passes) cargo run --release -- -m test test_support → SUCCESS (test_check__all__ now passes via dir(unittest)) cargo run --release -- -m test test_unittest test_concurrent_futures → SUCCESS (the other stdlib modules with a module-level __dir__; no regressions) Assisted-by: Claude Code:claude-opus-4-8 Summary by CodeRabbit New Features Modules can now define a custom __dir__ function to control the names returned when inspecting available attributes. Existing default behavior remains unchanged when no custom __dir__ is provided.

Open Graph Description: Closes #8231 This PR follows our AI policy Summary A module-level __dir__ function (PEP 562) was ignored: dir(module) returned the raw __dict__ keys instead of calling the module's __dir__. #...

X Description: Closes #8231 This PR follows our AI policy Summary A module-level __dir__ function (PEP 562) was ignored: dir(module) returned the raw __dict__ keys instead of calling the module's __dir_...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8271

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width