| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:ec821d28-079a-949f-345c-e3ef61a73450 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D248:3BFF6D:2A6DB:3AA63:6A5FE438 |
| html-safe-nonce | 778e88954bdc4647764c73c4cb4da9dff0f1beefb7e88a209c00d75dd062d449 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjQ4OjNCRkY2RDoyQTZEQjozQUE2Mzo2QTVGRTQzOCIsInZpc2l0b3JfaWQiOiIxNjkzMTEyOTY0OTgyMjM2MjE2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c026689ec946204f7fb46654c540a320a469a48b15219c397df78d7b7d763711 |
| hovercard-subject-tag | pull_request:4034450204 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/8254 |
| twitter:image | https://opengraph.githubassets.com/79c4dfe16f34fa5699d710ecb6fc7dc1ee8deb40b8c07c08f908c15ad5da1e04/RustPython/RustPython/pull/8254 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/79c4dfe16f34fa5699d710ecb6fc7dc1ee8deb40b8c07c08f908c15ad5da1e04/RustPython/RustPython/pull/8254 |
| og:image:alt | Closes csv.writer ignores a dialect's quoting and lineterminator #8253
This PR follows our AI policy
Summary
csv.writer ignored the quoting and lineterminator defined by a dialect (passed by ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jinmay |
| hostname | github.com |
| expected-hostname | github.com |
| None | 78938542173c0d8e4ad1aefc7954896e81c10ce2620286603ef14cf593bd5a11 |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1a427601e09953033b696253e754ebc7328096a7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/RustPython/RustPython/pull/8254#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8254 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8254 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/8254 |
| Reload | https://github.com/RustPython/RustPython/pull/8254 |
| Reload | https://github.com/RustPython/RustPython/pull/8254 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8254 |
|
RustPython
| https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
|
Notifications
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Fork
1.5k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Star
22.2k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
294
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
105
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security and quality
0
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security and quality
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| jinmay:csv-writer-dialect-quoting | https://github.com/jinmay/RustPython/tree/csv-writer-dialect-quoting |
| Conversation | https://github.com/RustPython/RustPython/pull/8254 |
| Commits2 (2) | https://github.com/RustPython/RustPython/pull/8254/commits |
| Checks | https://github.com/RustPython/RustPython/pull/8254/checks |
| Files changed | https://github.com/RustPython/RustPython/pull/8254/files |
| csv: apply dialect quoting and lineterminator in writer | https://github.com/RustPython/RustPython/pull/8254#top |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| jinmay:csv-writer-dialect-quoting | https://github.com/jinmay/RustPython/tree/csv-writer-dialect-quoting |
|
| https://github.com/jinmay |
| jinmay | https://github.com/jinmay |
| Jul 11, 2026 | https://github.com/RustPython/RustPython/pull/8254#issue-4861119245 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8254 |
| csv.writer ignores a dialect's quoting and lineterminator #8253 | https://github.com/RustPython/RustPython/issues/8253 |
| AI policy | https://github.com/RustPython/.github/blob/main/AI_POLICY.md |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8254 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
| Jul 11, 2026 | https://github.com/RustPython/RustPython/pull/8254#issuecomment-4943472860 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8254 |
| https://app.coderabbit.ai/change-stack/RustPython/RustPython/pull/8254?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack |
| 7145002 | https://github.com/RustPython/RustPython/commit/71450021a8eaeff58863af131fc36ef2ad05e357 |
| 13ef019 | https://github.com/RustPython/RustPython/commit/13ef0191230cf3a87419cc5282740fb6bf659c78 |
| RustPython/RustPython#7834 | https://github.com/RustPython/RustPython/pull/7834 |
| RustPython/RustPython#8109 | https://github.com/RustPython/RustPython/pull/8109 |
| RustPython/RustPython#8201 | https://github.com/RustPython/RustPython/pull/8201 |
| CodeRabbit | https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=RustPython/RustPython&utm_content=8254 |
| X | https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai |
| Mastodon | https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai |
| Reddit | https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai |
| LinkedIn | https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8254 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Jul 11, 2026 | https://github.com/RustPython/RustPython/pull/8254#issuecomment-4943481427 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8254 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8254 |
| https://github.com/jinmay |
| jinmay | https://github.com/jinmay |
| July 11, 2026 15:29 | https://github.com/RustPython/RustPython/pull/8254#event-27855439353 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
z-ca-2026
| https://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3Az-ca-2026 |
| Jul 12, 2026 | https://github.com/RustPython/RustPython/pull/8254#event-27873328130 |
| https://github.com/doma17 |
| doma17 | https://github.com/doma17 |
| Jul 12, 2026 | https://github.com/RustPython/RustPython/pull/8254#issuecomment-4951658642 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8254 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8254 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Jul 13, 2026 | https://github.com/RustPython/RustPython/pull/8254#issuecomment-4954629155 |
| @doma17 | https://github.com/doma17 |
| @jinmay | https://github.com/jinmay |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8254 |
| jinmay | https://github.com/jinmay |
| July 14, 2026 07:42 | https://github.com/RustPython/RustPython/pull/8254#commits-pushed-a753b32 |
|
| https://github.com/jinmay |
| csv: map QUOTE_MINIMAL to Necessary quote style | https://github.com/RustPython/RustPython/pull/8254/commits/a753b328184ecb7e682230a923f097b2e74c59aa |
| a753b32 | https://github.com/RustPython/RustPython/pull/8254/commits/a753b328184ecb7e682230a923f097b2e74c59aa |
|
| https://github.com/jinmay |
| csv: apply dialect quoting and lineterminator in writer | https://github.com/RustPython/RustPython/pull/8254/commits/13ef0191230cf3a87419cc5282740fb6bf659c78 |
| 13ef019 | https://github.com/RustPython/RustPython/pull/8254/commits/13ef0191230cf3a87419cc5282740fb6bf659c78 |
| https://github.com/jinmay |
| jinmay | https://github.com/jinmay |
| force-pushed | https://github.com/RustPython/RustPython/compare/71450021a8eaeff58863af131fc36ef2ad05e357..13ef0191230cf3a87419cc5282740fb6bf659c78 |
| 7145002 | https://github.com/RustPython/RustPython/commit/71450021a8eaeff58863af131fc36ef2ad05e357 |
| 13ef019 | https://github.com/RustPython/RustPython/commit/13ef0191230cf3a87419cc5282740fb6bf659c78 |
|
Compare
| https://github.com/RustPython/RustPython/compare/71450021a8eaeff58863af131fc36ef2ad05e357..13ef0191230cf3a87419cc5282740fb6bf659c78 |
| July 13, 2026 22:42 | https://github.com/RustPython/RustPython/pull/8254#event-27934396259 |
| https://github.com/jinmay |
| jinmay | https://github.com/jinmay |
| Jul 16, 2026 | https://github.com/RustPython/RustPython/pull/8254#issuecomment-4988560792 |
| @doma17 | https://github.com/doma17 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8254 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Jul 16, 2026
| https://github.com/RustPython/RustPython/pull/8254#pullrequestreview-4711945130 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/8254/files/13ef0191230cf3a87419cc5282740fb6bf659c78 |
| youknowone | https://github.com/youknowone |
| https://github.com/RustPython/RustPython/pull/8254#pullrequestreview-4711945130 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @jinmay | https://github.com/jinmay |
| @doma17 | https://github.com/doma17 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8254 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| 5154e7e | https://github.com/RustPython/RustPython/commit/5154e7e5a269bd3945456f8669b66eb0dd11f4c5 |
| Jul 16, 2026 | https://github.com/RustPython/RustPython/pull/8254#event-28059389752 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8254 |
| https://github.com/jinmay |
| jinmay | https://github.com/jinmay |
|
Jul 17, 2026
| https://github.com/RustPython/RustPython/pull/8254#ref-issue-4909687639 |
|
csv.writer: embedded \r/\n not quoted with a custom lineterminator (QUOTE_MINIMAL)
#8302
| https://github.com/RustPython/RustPython/issues/8302 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
|
Jul 18, 2026
| https://github.com/RustPython/RustPython/pull/8254#ref-pullrequest-4918241712 |
|
csv: quote embedded CR/LF under QUOTE_MINIMAL
#8315
| https://github.com/RustPython/RustPython/pull/8315 |
| https://github.com/jinmay |
| jinmay | https://github.com/jinmay |
|
Jul 18, 2026
| https://github.com/RustPython/RustPython/pull/8254#ref-issue-4918631714 |
|
csv.writer: embedded \r/\n not quoted with a custom lineterminator (QUOTE_MINIMAL)
#8317
| https://github.com/RustPython/RustPython/issues/8317 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
|
Jul 20, 2026
| https://github.com/RustPython/RustPython/pull/8254#ref-pullrequest-4925135217 |
|
csv: support multi-character lineterminator in writer
#8328
| https://github.com/RustPython/RustPython/pull/8328 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F8254 |
|
| https://github.com/youknowone |
|
youknowone
| https://github.com/youknowone |
|
| https://github.com/RustPython/RustPython/pull/8254/files/13ef0191230cf3a87419cc5282740fb6bf659c78 |
|
z-ca-2026
| https://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3Az-ca-2026 |
|
csv.writer ignores a dialect's quoting and lineterminator
| https://github.com/RustPython/RustPython/issues/8253 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/8254 |
|
| https://github.com/jinmay |
|
| https://github.com/doma17 |
|
| https://github.com/youknowone |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |