René's URL Explorer Experiment

Title: ctypes: unify the foreign-call path on a single host_env `call()` API by youknowone · Pull Request #8235 · RustPython/RustPython · GitHub

Open Graph Title: ctypes: unify the foreign-call path on a single host_env `call()` API by youknowone · Pull Request #8235 · RustPython/RustPython

X Title: ctypes: unify the foreign-call path on a single host_env `call()` API by youknowone · Pull Request #8235 · RustPython/RustPython

Description: Summary Introduce a single libffi-hiding foreign-call entry point in host_env (ctypes::call) and route the VM _ctypes module through it, replacing the per-call libffi Type/Arg marshalling. On top of that, pass and return Structure/Union by value, and delete the now-unused pre-call scaffolding. Commits host_env: add unified high-level call foreign-call API — a call(addr, &[CallArg], CallRet, CallOptions) -> Result entry point that takes ctypes type codes and recursive CTypeLayouts plus raw buffers instead of libffi Type/Arg. Built on the existing Cif/ffi_* primitives; aggregate returns go through Cif::call_return_into. Adds 16 ABI unit tests over local extern "C" functions. _ctypes: route the VM call path through host_env call() — a behavior-preserving migration of ctypes_callproc and the argument/return marshalling onto call; the errno / last-error swap moves into CallOptions. _ctypes: pass and return structs and unions by value — struct/union arguments lower to CallArg::Aggregate and struct/union returns to CallRet::Aggregate. StgInfo carries per-field CTypeLayouts built incrementally from the base class, so struct inheritance is reflected. Also fixes a latent self-deadlock in the result path (a restype StgInfo read guard was held across result-instance construction, which write-locks the same StgInfo to finalize it — unreachable until a struct was actually returned by value). host_env: remove the pre-call foreign-call scaffolding — delete the old callproc / callproc_simple paths and the libffi-type builders (ffi_type_for_layout, CTypeParamKind, ffi_type_from_tag, …) that no longer have a consumer. Testing python -m test test_ctypes: run=322 skipped=58, unchanged across all four commits. New extra_tests/snippets/stdlib_ctypes_calls.py (libc calls over the live FFI path) and stdlib_ctypes_byvalue.py (div/imaxdiv struct returns, inet_ntoa struct and union arguments); output matches CPython. host_env ABI unit tests, workspace test suite, clippy, and pre-commit all pass. Known limitation carried over from the previous libffi field-type path: _pack_ / _swappedbytes_ layouts stay approximate, since CTypeLayout carries no explicit field offsets. Opening as a draft for early visibility / CI. 🤖 Generated with Claude Code Summary by CodeRabbit New Features ctypes now supports additional native call patterns, including passing and returning structs/unions by value. Improved foreign-call handling for simple scalar, pointer, and array types. Added mechanisms to preserve referenced buffer memory across calls. Bug Fixes Fixed foreign-call result decoding, including aggregate return values. Improved error handling for null function pointers, unsupported/unknown type codes, and short aggregate buffers. Enhanced errno/last-error behavior during calls. Tests Added new ctypes integration and regression coverage for by-value and call/errno scenarios.

Open Graph Description: Summary Introduce a single libffi-hiding foreign-call entry point in host_env (ctypes::call) and route the VM _ctypes module through it, replacing the per-call libffi Type/Arg marshalling. On top o...

X Description: Summary Introduce a single libffi-hiding foreign-call entry point in host_env (ctypes::call) and route the VM _ctypes module through it, replacing the per-call libffi Type/Arg marshalling. On top o...

Opengraph URL: https://github.com/RustPython/RustPython/pull/8235

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width