René's URL Explorer Experiment


Title: Enable some pedantic clippy lints by ShaharNaveh · Pull Request #7764 · RustPython/RustPython · GitHub

Open Graph Title: Enable some pedantic clippy lints by ShaharNaveh · Pull Request #7764 · RustPython/RustPython

X Title: Enable some pedantic clippy lints by ShaharNaveh · Pull Request #7764 · RustPython/RustPython

Description: A Python Interpreter written in Rust. Contribute to RustPython/RustPython development by creating an account on GitHub.

Open Graph Description: Since the codebase is very large, enabling all the pedantic lints at once will be a impossible to review. I'll try to make relatively small incremental changes Summary by CodeRabbit Chores ...

X Description: Since the codebase is very large, enabling all the pedantic lints at once will be a impossible to review. I'll try to make relatively small incremental changes Summary by CodeRabbit Chor...

Opengraph URL: https://github.com/RustPython/RustPython/pull/7764

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:47f628f0-8d47-8473-44ab-e995ed52d2da
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC3F6:3213A4:A7ADF6:DCFDD7:6A5B6152
html-safe-nonce58785aa2e5b7466d95bb819674ed522f67763062d71f4f92a4eee156482fe449
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDM0Y2OjMyMTNBNDpBN0FERjY6RENGREQ3OjZBNUI2MTUyIiwidmlzaXRvcl9pZCI6IjQ1NDcxNTcwMzU2OTIyODYyOTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6e2f671c28ef8f920816b26f608a188e210af9c3e8c4d93adbd8a93841ff3289
hovercard-subject-tagpull_request:3617802997
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/7764/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1038f24c549bf129d7d6c4224bb9ac19df4100e08e1891aff3c9d8325d7229ed/RustPython/RustPython/pull/7764
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1038f24c549bf129d7d6c4224bb9ac19df4100e08e1891aff3c9d8325d7229ed/RustPython/RustPython/pull/7764
og:image:altSince the codebase is very large, enabling all the pedantic lints at once will be a impossible to review. I'll try to make relatively small incremental changes Summary by CodeRabbit Chores ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameShaharNaveh
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/7764#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F7764
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F7764
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/7764
Reloadhttps://github.com/RustPython/RustPython/pull/7764
Reloadhttps://github.com/RustPython/RustPython/pull/7764
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7764
RustPython https://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Notifications https://github.com/login?return_to=%2FRustPython%2FRustPython
Fork 1.5k https://github.com/login?return_to=%2FRustPython%2FRustPython
Star 22.2k https://github.com/login?return_to=%2FRustPython%2FRustPython
Code https://github.com/RustPython/RustPython
Issues 291 https://github.com/RustPython/RustPython/issues
Pull requests 103 https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality 0 https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
Code https://github.com/RustPython/RustPython
Issues https://github.com/RustPython/RustPython/issues
Pull requests https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
ShaharNaveh:clippy-lints-0https://github.com/ShaharNaveh/RustPython/tree/clippy-lints-0
Conversationhttps://github.com/RustPython/RustPython/pull/7764
Commits14 (14)https://github.com/RustPython/RustPython/pull/7764/commits
Checkshttps://github.com/RustPython/RustPython/pull/7764/checks
Files changedhttps://github.com/RustPython/RustPython/pull/7764/files
Enable some pedantic clippy lintshttps://github.com/RustPython/RustPython/pull/7764#top
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
ShaharNaveh:clippy-lints-0https://github.com/ShaharNaveh/RustPython/tree/clippy-lints-0
https://github.com/ShaharNaveh
ShaharNavehhttps://github.com/ShaharNaveh
May 2, 2026https://github.com/RustPython/RustPython/pull/7764#issue-4368877529
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7764
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7764
ShaharNavehhttps://github.com/ShaharNaveh
May 2, 2026 14:32https://github.com/RustPython/RustPython/pull/7764#commits-pushed-b54c1aa
https://github.com/ShaharNaveh
Set #[must_use] where possiblehttps://github.com/RustPython/RustPython/pull/7764/commits/b54c1aafddb875e128a218576ac68eded23145b8
b54c1aahttps://github.com/RustPython/RustPython/pull/7764/commits/b54c1aafddb875e128a218576ac68eded23145b8
https://github.com/ShaharNaveh
redundant_elsehttps://github.com/RustPython/RustPython/pull/7764/commits/f3587f66a3ed5f2044c406967cfdc39f398f44f8
f3587f6https://github.com/RustPython/RustPython/pull/7764/commits/f3587f66a3ed5f2044c406967cfdc39f398f44f8
https://github.com/ShaharNaveh
Fix dochttps://github.com/RustPython/RustPython/pull/7764/commits/7e08309aa667bd9e2aac33dbb71dd47b5ed0954c
7e08309https://github.com/RustPython/RustPython/pull/7764/commits/7e08309aa667bd9e2aac33dbb71dd47b5ed0954c
https://github.com/ShaharNaveh
Add some clippy ruleshttps://github.com/RustPython/RustPython/pull/7764/commits/938790a522cadacf7ef23d54ab86f43ecbc57b1d
938790ahttps://github.com/RustPython/RustPython/pull/7764/commits/938790a522cadacf7ef23d54ab86f43ecbc57b1d
https://github.com/ShaharNaveh
Enfore cloned_instead_of_copiedhttps://github.com/RustPython/RustPython/pull/7764/commits/d2f0c6fb940b98831342e67d8aef0fafdc46d6bc
d2f0c6fhttps://github.com/RustPython/RustPython/pull/7764/commits/d2f0c6fb940b98831342e67d8aef0fafdc46d6bc
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
May 2, 2026https://github.com/RustPython/RustPython/pull/7764#issuecomment-4363769380
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7764
Add some clippy lints #7755https://github.com/RustPython/RustPython/pull/7755
Bytecode parity CFG normalization and jump cleanup #7721https://github.com/RustPython/RustPython/pull/7721
Bytecode parity - for-loop cleanup, return duplication, late jump threading fix #7580https://github.com/RustPython/RustPython/pull/7580
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7764
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
May 2, 2026 https://github.com/RustPython/RustPython/pull/7764#pullrequestreview-4214942905
View reviewed changes https://github.com/RustPython/RustPython/pull/7764/files/d2f0c6fb940b98831342e67d8aef0fafdc46d6bc
coderabbitaihttps://github.com/apps/coderabbitai
https://github.com/RustPython/RustPython/pull/7764#pullrequestreview-4214942905
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
926d69bhttps://github.com/RustPython/RustPython/commit/926d69b50ab8afbcd2b190b848ba745797fa33cd
d2f0c6fhttps://github.com/RustPython/RustPython/commit/d2f0c6fb940b98831342e67d8aef0fafdc46d6bc
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7764
Cargo.tomlhttps://github.com/RustPython/RustPython/pull/7764/files/d2f0c6fb940b98831342e67d8aef0fafdc46d6bc#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7764
crates/host_env/src/syslog.rshttps://github.com/RustPython/RustPython/pull/7764/files/d2f0c6fb940b98831342e67d8aef0fafdc46d6bc#diff-4454cfa87b79316db55ef0dc9c1ab3de85b4cf65b44756eeb2df34ae18701148
coderabbitaihttps://github.com/apps/coderabbitai
May 2, 2026https://github.com/RustPython/RustPython/pull/7764#discussion_r3176620086
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/syslog.h.htmlhttps://pubs.opengroup.org/onlinepubs/9799919799/basedefs/syslog.h.html
https://pubs.opengroup.org/onlinepubs/9799919799.2024edition/basedefs/syslog.h.htmlhttps://pubs.opengroup.org/onlinepubs/9799919799.2024edition/basedefs/syslog.h.html
https://pubs.opengroup.org/onlinepubs/9699919799.2016edition/basedefs/syslog.h.htmlhttps://pubs.opengroup.org/onlinepubs/9699919799.2016edition/basedefs/syslog.h.html
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7764
crates/vm/src/macros.rshttps://github.com/RustPython/RustPython/pull/7764/files/d2f0c6fb940b98831342e67d8aef0fafdc46d6bc#diff-141ba3b28d834fbba43ef1d717a4c359fae4860295bece21d5b4db3836f3ce54
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7764
ShaharNavehhttps://github.com/ShaharNaveh
May 2, 2026 15:40https://github.com/RustPython/RustPython/pull/7764#commits-pushed-840fc07
https://github.com/ShaharNaveh
Remove dup importhttps://github.com/RustPython/RustPython/pull/7764/commits/840fc07955fac40e03dfb2b07f0c94f46cd83a5b
840fc07https://github.com/RustPython/RustPython/pull/7764/commits/840fc07955fac40e03dfb2b07f0c94f46cd83a5b
https://github.com/ShaharNaveh
Fix morehttps://github.com/RustPython/RustPython/pull/7764/commits/37418c55a7cd18e081c5a75f0aa94f87fe0248c9
37418c5https://github.com/RustPython/RustPython/pull/7764/commits/37418c55a7cd18e081c5a75f0aa94f87fe0248c9
https://github.com/ShaharNaveh
ShaharNavehhttps://github.com/ShaharNaveh
force-pushedhttps://github.com/RustPython/RustPython/compare/408a4987a35d8b68293ad23b6bf38b379ed99750..37418c55a7cd18e081c5a75f0aa94f87fe0248c9
408a498https://github.com/RustPython/RustPython/commit/408a4987a35d8b68293ad23b6bf38b379ed99750
37418c5https://github.com/RustPython/RustPython/commit/37418c55a7cd18e081c5a75f0aa94f87fe0248c9
Compare https://github.com/RustPython/RustPython/compare/408a4987a35d8b68293ad23b6bf38b379ed99750..37418c55a7cd18e081c5a75f0aa94f87fe0248c9
May 2, 2026 13:39https://github.com/RustPython/RustPython/pull/7764#event-25094306139
ShaharNavehhttps://github.com/ShaharNaveh
May 2, 2026 16:46https://github.com/RustPython/RustPython/pull/7764#commits-pushed-6326047
https://github.com/ShaharNaveh
fix wasmhttps://github.com/RustPython/RustPython/pull/7764/commits/6326047e492d3a0cdec05e5dd7264fe4a850053b
6326047https://github.com/RustPython/RustPython/pull/7764/commits/6326047e492d3a0cdec05e5dd7264fe4a850053b
https://github.com/ShaharNaveh
morehttps://github.com/RustPython/RustPython/pull/7764/commits/55444fc539e676c215b7ca24ab615b8750a7ceb9
55444fchttps://github.com/RustPython/RustPython/pull/7764/commits/55444fc539e676c215b7ca24ab615b8750a7ceb9
https://github.com/ShaharNaveh
morehttps://github.com/RustPython/RustPython/pull/7764/commits/3dd0fb5ed622b7cb7bda957195b89abc72a37635
3dd0fb5https://github.com/RustPython/RustPython/pull/7764/commits/3dd0fb5ed622b7cb7bda957195b89abc72a37635
https://github.com/ShaharNaveh
fixhttps://github.com/RustPython/RustPython/pull/7764/commits/b017713b81c1a26dd9bda65c9a08413fab04d305
b017713https://github.com/RustPython/RustPython/pull/7764/commits/b017713b81c1a26dd9bda65c9a08413fab04d305
https://github.com/ShaharNaveh
Merge remote-tracking branch 'upstream/main' into clippy-lints-0https://github.com/RustPython/RustPython/pull/7764/commits/d01b2793673ef29f5198817d088db3b5ce9218ee
d01b279https://github.com/RustPython/RustPython/pull/7764/commits/d01b2793673ef29f5198817d088db3b5ce9218ee
https://github.com/ShaharNaveh
Fix morehttps://github.com/RustPython/RustPython/pull/7764/commits/d293a258103ba1d4e0f0d6a76e58064cc078d544
d293a25https://github.com/RustPython/RustPython/pull/7764/commits/d293a258103ba1d4e0f0d6a76e58064cc078d544
https://github.com/ShaharNaveh
Fix typohttps://github.com/RustPython/RustPython/pull/7764/commits/8a56ff19dccd01b0490159ff1224f032f0f4431e
8a56ff1https://github.com/RustPython/RustPython/pull/7764/commits/8a56ff19dccd01b0490159ff1224f032f0f4431e
https://github.com/youknowone
youknowonehttps://github.com/youknowone
May 4, 2026 https://github.com/RustPython/RustPython/pull/7764#pullrequestreview-4217105126
View reviewed changes https://github.com/RustPython/RustPython/pull/7764/files/8a56ff19dccd01b0490159ff1224f032f0f4431e
https://github.com/youknowone
youknowonehttps://github.com/youknowone
ee5e9d0https://github.com/RustPython/RustPython/commit/ee5e9d00017a64e1049536dcce73d2c03d5b702b
May 4, 2026https://github.com/RustPython/RustPython/pull/7764#event-25115337042
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7764
Move dependencies to workspace for common crate #7771 https://github.com/RustPython/RustPython/pull/7771
Fix clippy pedantic lint #7772 https://github.com/RustPython/RustPython/pull/7772
more hostenv impl #7604 https://github.com/RustPython/RustPython/pull/7604
Add map_unwrap_or clippy rule #7829 https://github.com/RustPython/RustPython/pull/7829
Add more pedantic clippy rules #7830 https://github.com/RustPython/RustPython/pull/7830
Clippy warn uninlined_format_args & redundant_else #7873 https://github.com/RustPython/RustPython/pull/7873
Clippy nursery lints #7875 https://github.com/RustPython/RustPython/pull/7875
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
May 24, 2026 https://github.com/RustPython/RustPython/pull/7764#ref-pullrequest-4511179698
Clippy rules (test related) #7968 https://github.com/RustPython/RustPython/pull/7968
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Jun 6, 2026 https://github.com/RustPython/RustPython/pull/7764#ref-pullrequest-4596282645
more clippy rules #8050 https://github.com/RustPython/RustPython/pull/8050
clippy enum_glob_use #8121 https://github.com/RustPython/RustPython/pull/8121
More clippy rules #8127 https://github.com/RustPython/RustPython/pull/8127
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F7764
https://github.com/apps/coderabbitai
coderabbitai[bot] https://github.com/apps/coderabbitai
https://github.com/RustPython/RustPython/pull/7764/files/d2f0c6fb940b98831342e67d8aef0fafdc46d6bc
https://github.com/youknowone
youknowone https://github.com/youknowone
https://github.com/RustPython/RustPython/pull/7764/files/8a56ff19dccd01b0490159ff1224f032f0f4431e
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7764
https://github.com/ShaharNaveh
https://github.com/youknowone
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.