René's URL Explorer Experiment


Title: Preserve __dict__ and __slots__ state in deque.__reduce__ by changjoon-park · Pull Request #7699 · RustPython/RustPython · GitHub

Open Graph Title: Preserve __dict__ and __slots__ state in deque.__reduce__ by changjoon-park · Pull Request #7699 · RustPython/RustPython

X Title: Preserve __dict__ and __slots__ state in deque.__reduce__ by changjoon-park · Pull Request #7699 · RustPython/RustPython

Description: Background pickle.dumps(d) calls d.__reduce__(), which returns a 5-tuple (cls, args, state, listiter, dictiter). The state slot is meant to carry whatever __setstate__ (or the default attribute-restore path) needs to reconstruct subclass-specific data: typically __dict__, or (__dict__, slots_dict) when __slots__ is in play. RustPython's deque.__reduce__ passed None for state, so any attribute set on a deque subclass was lost across a pickle round-trip. CPython's deque___reduce___impl (Modules/_collectionsmodule.c::deque___reduce___impl) calls _PyObject_GetState to get the right value. Repro import pickle from collections import deque class D(deque): pass class DS(deque): __slots__ = ('x', 'y', '__dict__') for cls in D, DS: d = cls('abc') d.x = ['x'] # slot for DS, dict for D d.z = ['z'] # always dict e = pickle.loads(pickle.dumps(d)) # CPython 3.14 (and now RustPython): e.x and e.z preserved. # RustPython before this PR: AttributeError on e.x. Fix Replace the vm.ctx.none() placeholder with the result of __getstate__() on the instance. object.__getstate__ already handles both __dict__ and the dict/slots tuple form, matching CPython's _PyObject_GetState. No code duplication. Tests unmasked test_deque.TestSubclass.test_copy_pickle test_pickle_recursive still expected-fails for an unrelated recursion issue and stays marked. Verification 10 modules pass with no regressions: test_deque test_collections test_pickle test_copy test_dataclasses test_descr test_class test_typing test_inspect test_functools (2,562 tests) CPython 3.14.4 byte-identical for the repro on both subclass shapes copy.copy(d) continues to drop attributes (matches CPython — the __copy__ path doesn't go through __reduce__) copy.deepcopy(d) preserves attributes via the new __reduce__ Plain deque, deque(maxlen=...), and empty deque round-trip unchanged Summary by CodeRabbit Bug Fixes Improved serialization handling for collection data structures to properly preserve state during pickling and unpickling operations.

Open Graph Description: Background pickle.dumps(d) calls d.__reduce__(), which returns a 5-tuple (cls, args, state, listiter, dictiter). The state slot is meant to carry whatever __setstate__ (or the default attribute-res...

X Description: Background pickle.dumps(d) calls d.__reduce__(), which returns a 5-tuple (cls, args, state, listiter, dictiter). The state slot is meant to carry whatever __setstate__ (or the default attribute-res...

Opengraph URL: https://github.com/RustPython/RustPython/pull/7699

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c009d3de-bc69-b30e-dd23-022e7774a46e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id900C:24D752:3AF6D2:4FBE4B:6B0029A8
html-safe-noncea8ff2bb3c1c4e0bafc748945999314d05bbfa84cfcd92214f2d7268060b77f41
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDBDOjI0RDc1MjozQUY2RDI6NEZCRTRCOjZCMDAyOUE4IiwidmlzaXRvcl9pZCI6IjkxMDY2MzUwMDM2MzgzMjc3MjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac02f3b1b5c9110786564c3fb2a86cb2f9a7e045de013c33b353772ac144afa100
hovercard-subject-tagpull_request:3589503041
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/7699/files
twitter:imagehttps://avatars.githubusercontent.com/u/131537123?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/131537123?s=400&v=4
og:image:altBackground pickle.dumps(d) calls d.__reduce__(), which returns a 5-tuple (cls, args, state, listiter, dictiter). The state slot is meant to carry whatever __setstate__ (or the default attribute-res...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/7699/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F7699%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F7699%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/7699/files
Reloadhttps://github.com/RustPython/RustPython/pull/7699/files
Reloadhttps://github.com/RustPython/RustPython/pull/7699/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests144 (144)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
changjoon-park:fix-deque-reduce-preserve-dicthttps://github.com/changjoon-park/RustPython/tree/fix-deque-reduce-preserve-dict
Conversation 3 https://github.com/RustPython/RustPython/pull/7699
Commits 1 https://github.com/RustPython/RustPython/pull/7699/commits
Checks 20 https://github.com/RustPython/RustPython/pull/7699/checks
Files changed https://github.com/RustPython/RustPython/pull/7699/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7699/files
Preserve __dict__ and __slots__ state in deque.__reduce__ https://github.com/RustPython/RustPython/pull/7699/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/7699/files
0dea5c4 Preserve __dict__ and __slots__ state in deque.__reduce__ changjoon-park Apr 27, 2026 https://github.com/RustPython/RustPython/pull/7699/commits/0dea5c4aea1b9228bf4e2c57b78eec4406f6a50f
Clear filters https://github.com/RustPython/RustPython/pull/7699/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7699/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7699/files
test_deque.py https://github.com/RustPython/RustPython/pull/7699/files#diff-167e36632c2236795b832ecccdc5e6ecd09fd836f83d788b474a094ae3b97723
_collections.rs https://github.com/RustPython/RustPython/pull/7699/files#diff-b843141b8e6f6469647984c0bf98eb863ed1da2b30f3f77e0803edba966c1249
Lib/test/test_deque.pyhttps://github.com/RustPython/RustPython/pull/7699/files#diff-167e36632c2236795b832ecccdc5e6ecd09fd836f83d788b474a094ae3b97723
View file https://github.com/changjoon-park/RustPython/blob/0dea5c4aea1b9228bf4e2c57b78eec4406f6a50f/Lib/test/test_deque.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7699/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7699/files#diff-167e36632c2236795b832ecccdc5e6ecd09fd836f83d788b474a094ae3b97723
https://github.com/RustPython/RustPython/pull/7699/files#diff-167e36632c2236795b832ecccdc5e6ecd09fd836f83d788b474a094ae3b97723
crates/vm/src/stdlib/_collections.rshttps://github.com/RustPython/RustPython/pull/7699/files#diff-b843141b8e6f6469647984c0bf98eb863ed1da2b30f3f77e0803edba966c1249
View file https://github.com/changjoon-park/RustPython/blob/0dea5c4aea1b9228bf4e2c57b78eec4406f6a50f/crates/vm/src/stdlib/_collections.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7699/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7699/files#diff-b843141b8e6f6469647984c0bf98eb863ed1da2b30f3f77e0803edba966c1249
https://github.com/RustPython/RustPython/pull/7699/files#diff-b843141b8e6f6469647984c0bf98eb863ed1da2b30f3f77e0803edba966c1249
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7699/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.