Title: Preserve __dict__ and __slots__ state in deque.__reduce__ by changjoon-park · Pull Request #7699 · RustPython/RustPython · GitHub
Open Graph Title: Preserve __dict__ and __slots__ state in deque.__reduce__ by changjoon-park · Pull Request #7699 · RustPython/RustPython
X Title: Preserve __dict__ and __slots__ state in deque.__reduce__ by changjoon-park · Pull Request #7699 · RustPython/RustPython
Description: Background pickle.dumps(d) calls d.__reduce__(), which returns a 5-tuple (cls, args, state, listiter, dictiter). The state slot is meant to carry whatever __setstate__ (or the default attribute-restore path) needs to reconstruct subclass-specific data: typically __dict__, or (__dict__, slots_dict) when __slots__ is in play. RustPython's deque.__reduce__ passed None for state, so any attribute set on a deque subclass was lost across a pickle round-trip. CPython's deque___reduce___impl (Modules/_collectionsmodule.c::deque___reduce___impl) calls _PyObject_GetState to get the right value. Repro import pickle from collections import deque class D(deque): pass class DS(deque): __slots__ = ('x', 'y', '__dict__') for cls in D, DS: d = cls('abc') d.x = ['x'] # slot for DS, dict for D d.z = ['z'] # always dict e = pickle.loads(pickle.dumps(d)) # CPython 3.14 (and now RustPython): e.x and e.z preserved. # RustPython before this PR: AttributeError on e.x. Fix Replace the vm.ctx.none() placeholder with the result of __getstate__() on the instance. object.__getstate__ already handles both __dict__ and the dict/slots tuple form, matching CPython's _PyObject_GetState. No code duplication. Tests unmasked test_deque.TestSubclass.test_copy_pickle test_pickle_recursive still expected-fails for an unrelated recursion issue and stays marked. Verification 10 modules pass with no regressions: test_deque test_collections test_pickle test_copy test_dataclasses test_descr test_class test_typing test_inspect test_functools (2,562 tests) CPython 3.14.4 byte-identical for the repro on both subclass shapes copy.copy(d) continues to drop attributes (matches CPython — the __copy__ path doesn't go through __reduce__) copy.deepcopy(d) preserves attributes via the new __reduce__ Plain deque, deque(maxlen=...), and empty deque round-trip unchanged Summary by CodeRabbit Bug Fixes Improved serialization handling for collection data structures to properly preserve state during pickling and unpickling operations.
Open Graph Description: Background pickle.dumps(d) calls d.__reduce__(), which returns a 5-tuple (cls, args, state, listiter, dictiter). The state slot is meant to carry whatever __setstate__ (or the default attribute-res...
X Description: Background pickle.dumps(d) calls d.__reduce__(), which returns a 5-tuple (cls, args, state, listiter, dictiter). The state slot is meant to carry whatever __setstate__ (or the default attribute-res...
Opengraph URL: https://github.com/RustPython/RustPython/pull/7699
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c009d3de-bc69-b30e-dd23-022e7774a46e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 900C:24D752:3AF6D2:4FBE4B:6B0029A8 |
| html-safe-nonce | a8ff2bb3c1c4e0bafc748945999314d05bbfa84cfcd92214f2d7268060b77f41 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDBDOjI0RDc1MjozQUY2RDI6NEZCRTRCOjZCMDAyOUE4IiwidmlzaXRvcl9pZCI6IjkxMDY2MzUwMDM2MzgzMjc3MjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 02f3b1b5c9110786564c3fb2a86cb2f9a7e045de013c33b353772ac144afa100 |
| hovercard-subject-tag | pull_request:3589503041 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/7699/files |
| twitter:image | https://avatars.githubusercontent.com/u/131537123?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/131537123?s=400&v=4 |
| og:image:alt | Background pickle.dumps(d) calls d.__reduce__(), which returns a 5-tuple (cls, args, state, listiter, dictiter). The state slot is meant to carry whatever __setstate__ (or the default attribute-res... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width