René's URL Explorer Experiment


Title: Fix pyclass memory layout to prevent silent UB in inherited getter dispatch by 1ndahous3 · Pull Request #7663 · RustPython/RustPython · GitHub

Open Graph Title: Fix pyclass memory layout to prevent silent UB in inherited getter dispatch by 1ndahous3 · Pull Request #7663 · RustPython/RustPython

X Title: Fix pyclass memory layout to prevent silent UB in inherited getter dispatch by 1ndahous3 · Pull Request #7663 · RustPython/RustPython

Description: Derived #[pyclass] structs that mix pointer-sized and non-pointer-sized fields are silently miscompiled: Rust's default #[repr(Rust)] layout algorithm places the base field at a non-zero offset, while the inherited getter dispatcher unconditionally assumes it is at offset 0. The result is undefined behaviour that manifests as a SIGSEGV at runtime. This PR fixes the root cause by: Auto-inserting #[repr(C)] on derived structs that carry no explicit repr (guarantees declaration-order layout, keeping the base field at offset 0). Emitting a const_assert via offset_of! as belt-and-suspenders: catches the remaining case where a user supplies an explicit repr that does not guarantee offset 0. Here is my minimal code that causes SIGSEGV/ACCESS_VIOLATION on Windows/Linux: use rustpython_vm::Interpreter; use rustpython_vm::PyObjectRef; use rustpython_vm::pyclass; use rustpython_vm::class::PyClassImpl; use rustpython_vm::PyPayload; fn main() { #[pyclass(module = false, name = "Base")] #[derive(Debug, PyPayload)] struct Base { field: PyObjectRef, } #[pyclass] impl Base { #[pygetset] fn field(&self) -> PyObjectRef { self.field.clone() } } #[pyclass(module = false, name = "Derived", base = Base)] #[derive(Debug)] struct Derived { // No #[repr(C)] — triggers the bug _base: Base, extra: Option, // displaces _base in memory under #[repr(Rust)] } #[pyclass] impl Derived { #[pygetset] fn extra(&self) -> Option { self.extra } // No `field` getter — relies on inherited Base getter -> crash } let interp = Interpreter::without_stdlib(Default::default()); interp.enter(|vm| { Base::make_static_type(); Derived::make_static_type(); let obj = vm.new_pyobj(Derived { _base: Base { field: vm.ctx.new_int(42).into() }, extra: Some(99), }); // Accessing `extra` (own getter) is fine. let _extra = obj.get_attr("extra", vm).expect("extra getter ok"); // Accessing `field` (inherited getter) -> SIGSEGV without the fix let _field = obj.get_attr("field", vm).expect("field getter ok"); }); } Summary by CodeRabbit Refactor Strengthened compile-time validation of struct memory layout for base classes, now detecting and validating the primary base field and asserting correct offsets. Automatically enforce a compatible memory representation when a base is declared so derived types meet layout expectations. Removed several explicit memory-layout annotations from internal types to streamline layout handling and reduce redundant declarations.

Open Graph Description: Derived #[pyclass] structs that mix pointer-sized and non-pointer-sized fields are silently miscompiled: Rust's default #[repr(Rust)] layout algorithm places the base field at a non-zero offset...

X Description: Derived #[pyclass] structs that mix pointer-sized and non-pointer-sized fields are silently miscompiled: Rust's default #[repr(Rust)] layout algorithm places the base field at a non-zero of...

Opengraph URL: https://github.com/RustPython/RustPython/pull/7663

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bf4b12c0-1224-93e1-e2ea-36272eecf4b4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCFF6:D1D28:15551EB:1C504EF:6B01FE27
html-safe-nonce3ef5610a8f87e254e1d095fd7895a7d3f553d008e4995c66849ee3027dd50559
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRkY2OkQxRDI4OjE1NTUxRUI6MUM1MDRFRjo2QjAxRkUyNyIsInZpc2l0b3JfaWQiOiIzNzQzMzQ2Nzg2ODQxMzQ3OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7e47c15e3d683aac4b5f0cef5f4851fbbdaabc7a2600449649bd88bc573fb951
hovercard-subject-tagpull_request:3574665436
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/7663/files
twitter:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9205230?s=400&v=4
og:image:altDerived #[pyclass] structs that mix pointer-sized and non-pointer-sized fields are silently miscompiled: Rust's default #[repr(Rust)] layout algorithm places the base field at a non-zero offset...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/7663/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F7663%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F7663%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/7663/files
Reloadhttps://github.com/RustPython/RustPython/pull/7663/files
Reloadhttps://github.com/RustPython/RustPython/pull/7663/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests133 (133)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
1ndahous3:pyclass_mem_layouthttps://github.com/1ndahous3/RustPython/tree/pyclass_mem_layout
Conversation 9 https://github.com/RustPython/RustPython/pull/7663
Commits 3 https://github.com/RustPython/RustPython/pull/7663/commits
Checks 19 https://github.com/RustPython/RustPython/pull/7663/checks
Files changed https://github.com/RustPython/RustPython/pull/7663/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7663/files
Fix pyclass memory layout to prevent silent UB in inherited getter dispatch https://github.com/RustPython/RustPython/pull/7663/files#top
Show all changes 3 commits https://github.com/RustPython/RustPython/pull/7663/files
48311be Fix pyclass memory layout to prevent silent UB in inherited getter di… 1ndahous3 Apr 23, 2026 https://github.com/RustPython/RustPython/pull/7663/commits/48311be40777dd5207a623823ae031311b66b031
2980ad1 Fix linter 1ndahous3 Apr 23, 2026 https://github.com/RustPython/RustPython/pull/7663/commits/2980ad175b89b6c10818320242cb7b17559b1cb5
280ecd3 Update crates/derive-impl/src/pyclass.rs 1ndahous3 Apr 23, 2026 https://github.com/RustPython/RustPython/pull/7663/commits/280ecd3955a95c06e56da3b2b5c9b27bf126ccb5
Clear filters https://github.com/RustPython/RustPython/pull/7663/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7663/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7663/files
pyclass.rs https://github.com/RustPython/RustPython/pull/7663/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
_asyncio.rs https://github.com/RustPython/RustPython/pull/7663/files#diff-b037b755b683da52a52725ec7a97d87b359ba95b4326e33d0673c8e11eb457a3
builtin_func.rs https://github.com/RustPython/RustPython/pull/7663/files#diff-3803ec9c4612463addd109dc797e558433c26a49228b43b3963ec1d4c3cfebe8
crates/derive-impl/src/pyclass.rshttps://github.com/RustPython/RustPython/pull/7663/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
View file https://github.com/1ndahous3/RustPython/blob/280ecd3955a95c06e56da3b2b5c9b27bf126ccb5/crates/derive-impl/src/pyclass.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7663/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7663/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/7663/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/7663/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/7663/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/7663/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/7663/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/7663/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/7663/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
https://github.com/RustPython/RustPython/pull/7663/files#diff-26c99b2025ccb53d8e726042a48a5886526d898281c27735bd1b6ebd51e55feb
crates/stdlib/src/_asyncio.rshttps://github.com/RustPython/RustPython/pull/7663/files#diff-b037b755b683da52a52725ec7a97d87b359ba95b4326e33d0673c8e11eb457a3
View file https://github.com/1ndahous3/RustPython/blob/280ecd3955a95c06e56da3b2b5c9b27bf126ccb5/crates/stdlib/src/_asyncio.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7663/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7663/files#diff-b037b755b683da52a52725ec7a97d87b359ba95b4326e33d0673c8e11eb457a3
https://github.com/RustPython/RustPython/pull/7663/files#diff-b037b755b683da52a52725ec7a97d87b359ba95b4326e33d0673c8e11eb457a3
https://github.com/RustPython/RustPython/pull/7663/files#diff-b037b755b683da52a52725ec7a97d87b359ba95b4326e33d0673c8e11eb457a3
https://github.com/RustPython/RustPython/pull/7663/files#diff-b037b755b683da52a52725ec7a97d87b359ba95b4326e33d0673c8e11eb457a3
crates/vm/src/builtins/builtin_func.rshttps://github.com/RustPython/RustPython/pull/7663/files#diff-3803ec9c4612463addd109dc797e558433c26a49228b43b3963ec1d4c3cfebe8
View file https://github.com/1ndahous3/RustPython/blob/280ecd3955a95c06e56da3b2b5c9b27bf126ccb5/crates/vm/src/builtins/builtin_func.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7663/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7663/files#diff-3803ec9c4612463addd109dc797e558433c26a49228b43b3963ec1d4c3cfebe8
https://github.com/RustPython/RustPython/pull/7663/files#diff-3803ec9c4612463addd109dc797e558433c26a49228b43b3963ec1d4c3cfebe8
https://github.com/RustPython/RustPython/pull/7663/files#diff-3803ec9c4612463addd109dc797e558433c26a49228b43b3963ec1d4c3cfebe8
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7663/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.