Title: Use borrowed pointers in TYPE_CACHE instead of strong references by youknowone · Pull Request #7384 · RustPython/RustPython · GitHub
Open Graph Title: Use borrowed pointers in TYPE_CACHE instead of strong references by youknowone · Pull Request #7384 · RustPython/RustPython
X Title: Use borrowed pointers in TYPE_CACHE instead of strong references by youknowone · Pull Request #7384 · RustPython/RustPython
Description: The method cache (TYPE_CACHE) was storing strong references (Arc clones) to cached attribute values, which inflated sys.getrefcount(). This caused intermittent test_memoryview failures where refcount assertions would fail depending on GC collection timing. Store borrowed raw pointers instead. Safety is guaranteed because: type_cache_clear() nullifies all entries during GC collection, before the collector breaks cycles type_cache_clear_version() nullifies entries when a type is modified, before the source dict entry is removed Readers use try_to_owned_from_ptr (safe_inc) to atomically validate and increment the refcount on cache hit Summary by CodeRabbit Refactor Optimized type cache memory management in the virtual machine for improved efficiency.
Open Graph Description: The method cache (TYPE_CACHE) was storing strong references (Arc clones) to cached attribute values, which inflated sys.getrefcount(). This caused intermittent test_memoryview failures where refcou...
X Description: The method cache (TYPE_CACHE) was storing strong references (Arc clones) to cached attribute values, which inflated sys.getrefcount(). This caused intermittent test_memoryview failures where refcou...
Opengraph URL: https://github.com/RustPython/RustPython/pull/7384
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d7ed03e2-08e7-54bc-bcc0-a5cecc19f181 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E6AA:2AE2E2:4AE937C:6181DF8:6A5D5501 |
| html-safe-nonce | a496dfc82957b7123ad0808db12d530a3650f4190f35e25425d52947158db168 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkFBOjJBRTJFMjo0QUU5MzdDOjYxODFERjg6NkE1RDU1MDEiLCJ2aXNpdG9yX2lkIjoiNDE4OTE0MzE5NDg1MTQzMTY4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 256d97e0b6e9ffdff96bb13389a469996d8cf69e65f670e90c0083fa6b027cfe |
| hovercard-subject-tag | pull_request:3369748005 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/7384/files |
| twitter:image | https://avatars.githubusercontent.com/u/69878?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/69878?s=400&v=4 |
| og:image:alt | The method cache (TYPE_CACHE) was storing strong references (Arc clones) to cached attribute values, which inflated sys.getrefcount(). This caused intermittent test_memoryview failures where refcou... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width