René's URL Explorer Experiment


Title: Implement locale-aware 'n' format specifier for int, float, complex by youknowone · Pull Request #7350 · RustPython/RustPython · GitHub

Open Graph Title: Implement locale-aware 'n' format specifier for int, float, complex by youknowone · Pull Request #7350 · RustPython/RustPython

X Title: Implement locale-aware 'n' format specifier for int, float, complex by youknowone · Pull Request #7350 · RustPython/RustPython

Description: Add LocaleInfo struct and locale-aware formatting methods to FormatSpec. The 'n' format type now reads thousands_sep, decimal_point, and grouping from C localeconv() and applies proper locale-based number grouping. Remove @unittest.skip from test_format.test_locale. Summary by CodeRabbit New Features Locale-aware number formatting for integers, floats, and complex numbers, respecting thousands separator, decimal point, and grouping with sensible platform fallbacks. Bug Fixes Format-spec parse errors are now raised as proper Python exceptions, improving clarity and consistency of formatting error reporting.

Open Graph Description: Add LocaleInfo struct and locale-aware formatting methods to FormatSpec. The 'n' format type now reads thousands_sep, decimal_point, and grouping from C localeconv() and applies proper loca...

X Description: Add LocaleInfo struct and locale-aware formatting methods to FormatSpec. The 'n' format type now reads thousands_sep, decimal_point, and grouping from C localeconv() and applies pro...

Opengraph URL: https://github.com/RustPython/RustPython/pull/7350

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c7f617a8-2125-d5dc-ad53-fd38b11c6267
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD86:2AD163:22C9BCB:2F4A47C:6B0029AC
html-safe-nonce9103780961a51365bc3c9175508c710cfa1518edd7c2decb278ef6929eddd45e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDg2OjJBRDE2MzoyMkM5QkNCOjJGNEE0N0M6NkIwMDI5QUMiLCJ2aXNpdG9yX2lkIjoiOTAwMjIyNDYwMjA3NTYzODE4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc54a05a3b988abbb8118d8db1e9d9aa02472dd61c71a6aa88ce25ddb7c130c4e
hovercard-subject-tagpull_request:3354265981
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/7350/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altAdd LocaleInfo struct and locale-aware formatting methods to FormatSpec. The 'n' format type now reads thousands_sep, decimal_point, and grouping from C localeconv() and applies proper loca...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/7350/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F7350%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F7350%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/7350/files
Reloadhttps://github.com/RustPython/RustPython/pull/7350/files
Reloadhttps://github.com/RustPython/RustPython/pull/7350/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests144 (144)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:locale-nhttps://github.com/youknowone/RustPython/tree/locale-n
Conversation 12 https://github.com/RustPython/RustPython/pull/7350
Commits 3 https://github.com/RustPython/RustPython/pull/7350/commits
Checks 13 https://github.com/RustPython/RustPython/pull/7350/checks
Files changed https://github.com/RustPython/RustPython/pull/7350/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7350/files
Implement locale-aware 'n' format specifier for int, float, complex https://github.com/RustPython/RustPython/pull/7350/files#top
Show all changes 3 commits https://github.com/RustPython/RustPython/pull/7350/files
d79baa5 Implement locale-aware 'n' format specifier for int, float, complex youknowone Mar 4, 2026 https://github.com/RustPython/RustPython/pull/7350/commits/d79baa5b31fe3d4012fab513654563f7472f74f9
c585541 Fix complex 'n' format and remove locale expectedFailure markers youknowone Mar 5, 2026 https://github.com/RustPython/RustPython/pull/7350/commits/c585541108acd00a0bfce8add2ff091ecb6bcc19
a2d3d59 Auto-format: cargo fmt --all github-actions[bot] Mar 5, 2026 https://github.com/RustPython/RustPython/pull/7350/commits/a2d3d59997849fdc0bb798d64266a02c6052a1aa
Clear filters https://github.com/RustPython/RustPython/pull/7350/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7350/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7350/files
test_format.py https://github.com/RustPython/RustPython/pull/7350/files#diff-abdba5791a8f0143685a423eba82d53f951df55e45d87b5bea45a1e3acd43351
test_types.py https://github.com/RustPython/RustPython/pull/7350/files#diff-d5154ccf7a97612e4a8b06a6f0f48f15554e426e72e698f246d17d3dd8e3a75a
format.rs https://github.com/RustPython/RustPython/pull/7350/files#diff-47d8fa943b6ea1840ae9d06a3785a14c7a57610a113e4a7958709acb47e87e4c
complex.rs https://github.com/RustPython/RustPython/pull/7350/files#diff-b0ba58a1a769c49088c60a0a76a7a99bc1e710180d4373aaf2d287a004a362f5
float.rs https://github.com/RustPython/RustPython/pull/7350/files#diff-4deb5676286995e76a9c87099407a5d64a7a57a6ee9ca97a059e79e649bc0dca
int.rs https://github.com/RustPython/RustPython/pull/7350/files#diff-6f6fb35904d4bdd7481e9d90622e7fc41a1eff225053e762f724150581464887
format.rs https://github.com/RustPython/RustPython/pull/7350/files#diff-43fb8f046cebfbb782eb9a4c87fc7c9eb590451c182695489c6070dc7f881b4f
Lib/test/test_format.pyhttps://github.com/RustPython/RustPython/pull/7350/files#diff-abdba5791a8f0143685a423eba82d53f951df55e45d87b5bea45a1e3acd43351
View file https://github.com/youknowone/RustPython/blob/a2d3d59997849fdc0bb798d64266a02c6052a1aa/Lib/test/test_format.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7350/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7350/files#diff-abdba5791a8f0143685a423eba82d53f951df55e45d87b5bea45a1e3acd43351
https://github.com/RustPython/RustPython/pull/7350/files#diff-abdba5791a8f0143685a423eba82d53f951df55e45d87b5bea45a1e3acd43351
Lib/test/test_types.pyhttps://github.com/RustPython/RustPython/pull/7350/files#diff-d5154ccf7a97612e4a8b06a6f0f48f15554e426e72e698f246d17d3dd8e3a75a
View file https://github.com/youknowone/RustPython/blob/a2d3d59997849fdc0bb798d64266a02c6052a1aa/Lib/test/test_types.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7350/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7350/files#diff-d5154ccf7a97612e4a8b06a6f0f48f15554e426e72e698f246d17d3dd8e3a75a
https://github.com/RustPython/RustPython/pull/7350/files#diff-d5154ccf7a97612e4a8b06a6f0f48f15554e426e72e698f246d17d3dd8e3a75a
https://github.com/RustPython/RustPython/pull/7350/files#diff-d5154ccf7a97612e4a8b06a6f0f48f15554e426e72e698f246d17d3dd8e3a75a
crates/common/src/format.rshttps://github.com/RustPython/RustPython/pull/7350/files#diff-47d8fa943b6ea1840ae9d06a3785a14c7a57610a113e4a7958709acb47e87e4c
View file https://github.com/youknowone/RustPython/blob/a2d3d59997849fdc0bb798d64266a02c6052a1aa/crates/common/src/format.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7350/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7350/files#diff-47d8fa943b6ea1840ae9d06a3785a14c7a57610a113e4a7958709acb47e87e4c
https://github.com/RustPython/RustPython/pull/7350/files#diff-47d8fa943b6ea1840ae9d06a3785a14c7a57610a113e4a7958709acb47e87e4c
https://github.com/RustPython/RustPython/pull/7350/files#diff-47d8fa943b6ea1840ae9d06a3785a14c7a57610a113e4a7958709acb47e87e4c
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7350/files
coderabbitaihttps://github.com/apps/coderabbitai
Mar 5, 2026https://github.com/RustPython/RustPython/pull/7350/files#r2889468440
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7350/files
coderabbitaihttps://github.com/apps/coderabbitai
Mar 5, 2026https://github.com/RustPython/RustPython/pull/7350/files#r2889506280
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7350/files
https://github.com/RustPython/RustPython/pull/7350/files#diff-47d8fa943b6ea1840ae9d06a3785a14c7a57610a113e4a7958709acb47e87e4c
crates/vm/src/builtins/complex.rshttps://github.com/RustPython/RustPython/pull/7350/files#diff-b0ba58a1a769c49088c60a0a76a7a99bc1e710180d4373aaf2d287a004a362f5
View file https://github.com/youknowone/RustPython/blob/a2d3d59997849fdc0bb798d64266a02c6052a1aa/crates/vm/src/builtins/complex.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7350/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7350/files#diff-b0ba58a1a769c49088c60a0a76a7a99bc1e710180d4373aaf2d287a004a362f5
https://github.com/RustPython/RustPython/pull/7350/files#diff-b0ba58a1a769c49088c60a0a76a7a99bc1e710180d4373aaf2d287a004a362f5
crates/vm/src/builtins/float.rshttps://github.com/RustPython/RustPython/pull/7350/files#diff-4deb5676286995e76a9c87099407a5d64a7a57a6ee9ca97a059e79e649bc0dca
View file https://github.com/youknowone/RustPython/blob/a2d3d59997849fdc0bb798d64266a02c6052a1aa/crates/vm/src/builtins/float.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7350/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7350/files#diff-4deb5676286995e76a9c87099407a5d64a7a57a6ee9ca97a059e79e649bc0dca
https://github.com/RustPython/RustPython/pull/7350/files#diff-4deb5676286995e76a9c87099407a5d64a7a57a6ee9ca97a059e79e649bc0dca
crates/vm/src/builtins/int.rshttps://github.com/RustPython/RustPython/pull/7350/files#diff-6f6fb35904d4bdd7481e9d90622e7fc41a1eff225053e762f724150581464887
View file https://github.com/youknowone/RustPython/blob/a2d3d59997849fdc0bb798d64266a02c6052a1aa/crates/vm/src/builtins/int.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7350/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7350/files#diff-6f6fb35904d4bdd7481e9d90622e7fc41a1eff225053e762f724150581464887
https://github.com/RustPython/RustPython/pull/7350/files#diff-6f6fb35904d4bdd7481e9d90622e7fc41a1eff225053e762f724150581464887
crates/vm/src/format.rshttps://github.com/RustPython/RustPython/pull/7350/files#diff-43fb8f046cebfbb782eb9a4c87fc7c9eb590451c182695489c6070dc7f881b4f
View file https://github.com/youknowone/RustPython/blob/a2d3d59997849fdc0bb798d64266a02c6052a1aa/crates/vm/src/format.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7350/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7350/files#diff-43fb8f046cebfbb782eb9a4c87fc7c9eb590451c182695489c6070dc7f881b4f
coderabbitaihttps://github.com/apps/coderabbitai
Mar 5, 2026https://github.com/RustPython/RustPython/pull/7350/files#r2886859483
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
man7.orghttps://man7.org/linux/man-pages/man7/locale.7.html?utm_source=openai
man.netbsd.orghttps://man.netbsd.org/localeconv.3?utm_source=openai
gnu.orghttps://www.gnu.org/software/gnulib/manual/html_node/localeconv.html?utm_source=openai
https://man7.org/linux/man-pages/man7/locale.7.html?utm_source=openaihttps://man7.org/linux/man-pages/man7/locale.7.html?utm_source=openai
https://man.netbsd.org/localeconv.3?utm_source=openaihttps://man.netbsd.org/localeconv.3?utm_source=openai
https://www.gnu.org/software/gnulib/manual/html_node/localeconv.html?utm_source=openaihttps://www.gnu.org/software/gnulib/manual/html_node/localeconv.html?utm_source=openai
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7350/files
https://github.com/RustPython/RustPython/pull/7350/files#diff-43fb8f046cebfbb782eb9a4c87fc7c9eb590451c182695489c6070dc7f881b4f
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7350/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.