René's URL Explorer Experiment


Title: Revert class lookup by youknowone · Pull Request #7306 · RustPython/RustPython · GitHub

Open Graph Title: Revert class lookup by youknowone · Pull Request #7306 · RustPython/RustPython

X Title: Revert class lookup by youknowone · Pull Request #7306 · RustPython/RustPython

Description: A Python Interpreter written in Rust. Contribute to RustPython/RustPython development by creating an account on GitHub.

Open Graph Description: wrong optimization Summary by CodeRabbit Improvements Made isinstance/issubclass checks more consistent by always resolving an object’s class via attribute lookup. This reduces edge-case inconsi...

X Description: wrong optimization Summary by CodeRabbit Improvements Made isinstance/issubclass checks more consistent by always resolving an object’s class via attribute lookup. This reduces edge-case inconsi...

Opengraph URL: https://github.com/RustPython/RustPython/pull/7306

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7ffd3955-3ab1-41ec-b261-7bcaaaf65e3c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8DA:F87C0:2A9D44:3CF8EA:6A621E0B
html-safe-nonce7de61ccf6a469f7e906e3712350a35f1de311b057bc108c10752c6ed206c9cf7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOERBOkY4N0MwOjJBOUQ0NDozQ0Y4RUE6NkE2MjFFMEIiLCJ2aXNpdG9yX2lkIjoiMzc1NDQ1MDUyNTQ4NjE5NDE4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf7b08c9a4a5de58d9deb034eb84c05fe96fc9f05007e1892130e029048bc9567
hovercard-subject-tagpull_request:3342208622
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/7306/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/74f4903ad0f95688f199f2c7334e9bec1e20e5bd030eaf28eb17910e0170009b/RustPython/RustPython/pull/7306
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/74f4903ad0f95688f199f2c7334e9bec1e20e5bd030eaf28eb17910e0170009b/RustPython/RustPython/pull/7306
og:image:altwrong optimization Summary by CodeRabbit Improvements Made isinstance/issubclass checks more consistent by always resolving an object’s class via attribute lookup. This reduces edge-case inconsi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameyouknowone
hostnamegithub.com
expected-hostnamegithub.com
Nonebe68eaf9abf2a202afbd94047d7200fb88b7edb0338f533bf171bbb1a69fab4e
turbo-cache-controlno-cache
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3d00b04c8874615454dfbdb32a7d2ca4db66d3f4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/7306#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F7306
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F7306
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/7306
Reloadhttps://github.com/RustPython/RustPython/pull/7306
Reloadhttps://github.com/RustPython/RustPython/pull/7306
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7306
RustPython https://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Notifications https://github.com/login?return_to=%2FRustPython%2FRustPython
Fork 1.5k https://github.com/login?return_to=%2FRustPython%2FRustPython
Star 22.2k https://github.com/login?return_to=%2FRustPython%2FRustPython
Code https://github.com/RustPython/RustPython
Issues 294 https://github.com/RustPython/RustPython/issues
Pull requests 104 https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality 0 https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
Code https://github.com/RustPython/RustPython
Issues https://github.com/RustPython/RustPython/issues
Pull requests https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:skip-classhttps://github.com/youknowone/RustPython/tree/skip-class
Conversationhttps://github.com/RustPython/RustPython/pull/7306
Commits2 (2)https://github.com/RustPython/RustPython/pull/7306/commits
Checkshttps://github.com/RustPython/RustPython/pull/7306/checks
Files changedhttps://github.com/RustPython/RustPython/pull/7306/files
Revert class lookuphttps://github.com/RustPython/RustPython/pull/7306#top
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:skip-classhttps://github.com/youknowone/RustPython/tree/skip-class
https://github.com/youknowone
youknowonehttps://github.com/youknowone
Mar 2, 2026https://github.com/RustPython/RustPython/pull/7306#issue-4008889619
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7306
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7306
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Mar 2, 2026https://github.com/RustPython/RustPython/pull/7306#issuecomment-3981627867
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7306
Align is_instance #5855https://github.com/RustPython/RustPython/pull/5855
Skip __class__ lookup in object_isinstance for standard getattro #7303https://github.com/RustPython/RustPython/pull/7303
Fix isinstance #5869https://github.com/RustPython/RustPython/pull/5869
CodeRabbithttps://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=RustPython/RustPython&utm_content=7306
Xhttps://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai
Mastodonhttps://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai
Reddithttps://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai
LinkedInhttps://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7306
https://github.com/youknowone
youknowonehttps://github.com/youknowone
March 2, 2026 03:40https://github.com/RustPython/RustPython/pull/7306#event-23180082370
https://github.com/youknowone
Revert __class__ lookup skip in object_isinstancehttps://github.com/RustPython/RustPython/pull/7306/commits/863fd73034fed799fa1c067e95a71b999a69cabd
863fd73https://github.com/RustPython/RustPython/pull/7306/commits/863fd73034fed799fa1c067e95a71b999a69cabd
https://github.com/youknowone
youknowonehttps://github.com/youknowone
force-pushedhttps://github.com/RustPython/RustPython/compare/e642ed3b87290f04531704ef90779ed5340c3702..863fd73034fed799fa1c067e95a71b999a69cabd
e642ed3https://github.com/RustPython/RustPython/commit/e642ed3b87290f04531704ef90779ed5340c3702
863fd73https://github.com/RustPython/RustPython/commit/863fd73034fed799fa1c067e95a71b999a69cabd
Compare https://github.com/RustPython/RustPython/compare/e642ed3b87290f04531704ef90779ed5340c3702..863fd73034fed799fa1c067e95a71b999a69cabd
March 2, 2026 04:13https://github.com/RustPython/RustPython/pull/7306#event-23180499673
https://github.com/youknowone
youknowonehttps://github.com/youknowone
Mar 2, 2026https://github.com/RustPython/RustPython/pull/7306#event-23180505359
https://github.com/youknowone
Collapse nested if in object_isinstance for clippyhttps://github.com/RustPython/RustPython/pull/7306/commits/864bf57b0c6e4891d203f82e8982c697f588e07a
864bf57https://github.com/RustPython/RustPython/pull/7306/commits/864bf57b0c6e4891d203f82e8982c697f588e07a
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Mar 2, 2026 https://github.com/RustPython/RustPython/pull/7306#pullrequestreview-3874014801
View reviewed changes https://github.com/RustPython/RustPython/pull/7306/files/864bf57b0c6e4891d203f82e8982c697f588e07a
coderabbitaihttps://github.com/apps/coderabbitai
https://github.com/RustPython/RustPython/pull/7306#pullrequestreview-3874014801
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
863fd73https://github.com/RustPython/RustPython/commit/863fd73034fed799fa1c067e95a71b999a69cabd
864bf57https://github.com/RustPython/RustPython/commit/864bf57b0c6e4891d203f82e8982c697f588e07a
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7306
https://github.com/youknowone
youknowonehttps://github.com/youknowone
3865fdbhttps://github.com/RustPython/RustPython/commit/3865fdbf5bda502efd9c0d3ea7af747997cf2c9d
Mar 2, 2026https://github.com/RustPython/RustPython/pull/7306#event-23188601340
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7306
https://github.com/youknowone
youknowonehttps://github.com/youknowone
March 2, 2026 10:41https://github.com/RustPython/RustPython/pull/7306#event-23188602217
youknowonehttps://github.com/youknowone
Mar 22, 2026 https://github.com/RustPython/RustPython/pull/7306#ref-commit-76053fc
https://github.com/youknowone
Revert class lookup (https://github.com/youknowone/RustPython/commit/76053fc1a20025f5c58d21e0d7c5e6747b106def
RustPython#7306https://github.com/RustPython/RustPython/pull/7306
)https://github.com/youknowone/RustPython/commit/76053fc1a20025f5c58d21e0d7c5e6747b106def
76053fchttps://github.com/youknowone/RustPython/commit/76053fc1a20025f5c58d21e0d7c5e6747b106def
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F7306
https://github.com/apps/coderabbitai
coderabbitai[bot] https://github.com/apps/coderabbitai
https://github.com/RustPython/RustPython/pull/7306/files/864bf57b0c6e4891d203f82e8982c697f588e07a
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7306
https://github.com/youknowone
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.