René's URL Explorer Experiment


Title: Fix _hashlib.compare_digest to reject non-ASCII strings by ever0de · Pull Request #7280 · RustPython/RustPython · GitHub

Open Graph Title: Fix _hashlib.compare_digest to reject non-ASCII strings by ever0de · Pull Request #7280 · RustPython/RustPython

X Title: Fix _hashlib.compare_digest to reject non-ASCII strings by ever0de · Pull Request #7280 · RustPython/RustPython

Description: Add non-ASCII string check to _hashlib.compare_digest, matching the behavior of _operator._compare_digest. When both arguments are strings, non-ASCII characters now correctly raise TypeError. Also replace the non-constant-time == comparison with constant_time_eq for proper timing-attack resistance, and return PyResult instead of PyResult. Summary by CodeRabbit Chores Added a dependency to support constant-time cryptographic comparisons. Bug Fixes Digest comparison now yields a direct boolean result and uses constant-time comparison under the hood. Stricter input validation with clearer errors for non-ASCII strings and incompatible/bytes-like inputs.

Open Graph Description: Add non-ASCII string check to _hashlib.compare_digest, matching the behavior of _operator._compare_digest. When both arguments are strings, non-ASCII characters now correctly raise TypeError. Also ...

X Description: Add non-ASCII string check to _hashlib.compare_digest, matching the behavior of _operator._compare_digest. When both arguments are strings, non-ASCII characters now correctly raise TypeError. Also ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/7280

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f55a6fbc-5388-c090-5736-4407cc2979df
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA536:210405:8E8E586:BF91CE5:6A5E55A7
html-safe-nonce130240fd03ee1a8333c654a1d5cf4889267f49d8064957b1ab9af4b6e9e9856f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTM2OjIxMDQwNTo4RThFNTg2OkJGOTFDRTU6NkE1RTU1QTciLCJ2aXNpdG9yX2lkIjoiNTcwMzEyNDkxMjIzODk3NTExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb2e28383dfc195d1235693dc2e78a79c982f280b4f0f7925f86e2a3a3ff0e5a3
hovercard-subject-tagpull_request:3339039325
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/7280/files
twitter:imagehttps://avatars.githubusercontent.com/u/27040963?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/27040963?s=400&v=4
og:image:altAdd non-ASCII string check to _hashlib.compare_digest, matching the behavior of _operator._compare_digest. When both arguments are strings, non-ASCII characters now correctly raise TypeError. Also ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7034b9f0130cdfcbd93bbcf3e8c0f4cc3007af54a2804bfd31f70d472b22852b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee75cd8524a0802713165f77a0088258ff9261683
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/7280/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F7280%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F7280%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/7280/files
Reloadhttps://github.com/RustPython/RustPython/pull/7280/files
Reloadhttps://github.com/RustPython/RustPython/pull/7280/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7280/files
RustPython https://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Notifications https://github.com/login?return_to=%2FRustPython%2FRustPython
Fork 1.5k https://github.com/login?return_to=%2FRustPython%2FRustPython
Star 22.2k https://github.com/login?return_to=%2FRustPython%2FRustPython
Code https://github.com/RustPython/RustPython
Issues 290 https://github.com/RustPython/RustPython/issues
Pull requests 100 https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality 0 https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
Code https://github.com/RustPython/RustPython
Issues https://github.com/RustPython/RustPython/issues
Pull requests https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
ever0de:fix/hashlib-compare-digest-ascii-checkhttps://github.com/ever0de/RustPython/tree/fix/hashlib-compare-digest-ascii-check
Conversation 6 https://github.com/RustPython/RustPython/pull/7280
Commits 1 https://github.com/RustPython/RustPython/pull/7280/commits
Checks 13 https://github.com/RustPython/RustPython/pull/7280/checks
Files changed https://github.com/RustPython/RustPython/pull/7280/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7280/files
Fix _hashlib.compare_digest to reject non-ASCII strings https://github.com/RustPython/RustPython/pull/7280/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/7280/files
c100b7f Fix _hashlib.compare_digest to reject non-ASCII strings ever0de Feb 28, 2026 https://github.com/RustPython/RustPython/pull/7280/commits/c100b7f66d9f5fb7c772bd7845f13bf9b4568e04
Clear filters https://github.com/RustPython/RustPython/pull/7280/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7280/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7280/files
Cargo.lock https://github.com/RustPython/RustPython/pull/7280/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87e
test_hmac.py https://github.com/RustPython/RustPython/pull/7280/files#diff-5e7ad86d959e018763fc3acb166f079b633d2ec9ceb72fceb903d89c4f463e3c
Cargo.toml https://github.com/RustPython/RustPython/pull/7280/files#diff-206ca536c8a0e972ae8dd6a3c7f1b87f2cf39bc248bc1ea0735ef140ab4b290c
hashlib.rs https://github.com/RustPython/RustPython/pull/7280/files#diff-ebba2dae44d3c112446c0f1604775e6435b95da9e3123111f705916342a5392c
Cargo.lockhttps://github.com/RustPython/RustPython/pull/7280/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87e
View file https://github.com/ever0de/RustPython/blob/c100b7f66d9f5fb7c772bd7845f13bf9b4568e04/Cargo.lock
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7280/files
Lib/test/test_hmac.pyhttps://github.com/RustPython/RustPython/pull/7280/files#diff-5e7ad86d959e018763fc3acb166f079b633d2ec9ceb72fceb903d89c4f463e3c
View file https://github.com/ever0de/RustPython/blob/c100b7f66d9f5fb7c772bd7845f13bf9b4568e04/Lib/test/test_hmac.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7280/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7280/files#diff-5e7ad86d959e018763fc3acb166f079b633d2ec9ceb72fceb903d89c4f463e3c
https://github.com/RustPython/RustPython/pull/7280/files#diff-5e7ad86d959e018763fc3acb166f079b633d2ec9ceb72fceb903d89c4f463e3c
crates/stdlib/Cargo.tomlhttps://github.com/RustPython/RustPython/pull/7280/files#diff-206ca536c8a0e972ae8dd6a3c7f1b87f2cf39bc248bc1ea0735ef140ab4b290c
View file https://github.com/ever0de/RustPython/blob/c100b7f66d9f5fb7c772bd7845f13bf9b4568e04/crates/stdlib/Cargo.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7280/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7280/files#diff-206ca536c8a0e972ae8dd6a3c7f1b87f2cf39bc248bc1ea0735ef140ab4b290c
https://github.com/RustPython/RustPython/pull/7280/files#diff-206ca536c8a0e972ae8dd6a3c7f1b87f2cf39bc248bc1ea0735ef140ab4b290c
crates/stdlib/src/hashlib.rshttps://github.com/RustPython/RustPython/pull/7280/files#diff-ebba2dae44d3c112446c0f1604775e6435b95da9e3123111f705916342a5392c
View file https://github.com/ever0de/RustPython/blob/c100b7f66d9f5fb7c772bd7845f13bf9b4568e04/crates/stdlib/src/hashlib.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7280/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7280/files#diff-ebba2dae44d3c112446c0f1604775e6435b95da9e3123111f705916342a5392c
https://github.com/RustPython/RustPython/pull/7280/files#diff-ebba2dae44d3c112446c0f1604775e6435b95da9e3123111f705916342a5392c
https://github.com/RustPython/RustPython/pull/7280/files#diff-ebba2dae44d3c112446c0f1604775e6435b95da9e3123111f705916342a5392c
coderabbitaihttps://github.com/apps/coderabbitai
Feb 28, 2026https://github.com/RustPython/RustPython/pull/7280/files#r2867641080
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7280/files
https://github.com/RustPython/RustPython/pull/7280/files#diff-ebba2dae44d3c112446c0f1604775e6435b95da9e3123111f705916342a5392c
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7280/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.