René's URL Explorer Experiment


Title: Align symtable filename handling and global error locations with CPython by moreal · Pull Request #7142 · RustPython/RustPython · GitHub

Open Graph Title: Align symtable filename handling and global error locations with CPython by moreal · Pull Request #7142 · RustPython/RustPython

X Title: Align symtable filename handling and global error locations with CPython by moreal · Pull Request #7142 · RustPython/RustPython

Description: Summary This PR removes one @unittest.expectedFailure in test_symtable by aligning RustPython's _symtable.symtable behavior with CPython for filename handling and symbol-table-time error location reporting. Fixed Test test.test_symtable.SymtableTest.test_filename_correct Compatibility gap before this PR For symbol-table-time syntax errors such as def f(x): global x, RustPython reported SyntaxError.offset using the identifier location (x) instead of the directive statement location (global ...). _symtable.symtable in RustPython accepted filename as str only, while CPython accepts filesystem-decoded path inputs. How CPython handles it In cpython/Python/symtable.c, Global_kind and Nonlocal_kind use statement location data via LOCATION(s) for both directive recording and syntax error location (SET_ERROR_LOCATION(st->st_filename, LOCATION(s));), so offsets point to the directive statement start. In cpython/Modules/symtablemodule.c, _symtable.symtable declares filename: unicode_fs_decoded, which accepts str | bytes | os.PathLike. How RustPython now handles it In crates/codegen/src/symboltable.rs, Stmt::Global and Stmt::Nonlocal now pass statement.range() to symbol registration so symtable-build-time SyntaxError.offset matches CPython's statement-based location semantics. In crates/vm/src/stdlib/symtable.rs, _symtable.symtable now takes filename: OsPath and uses to_string_lossy() before compilation. OsPath uses TryFromObject and delegates to PathConverter::try_path, which accepts str and bytes (and path-like objects through __fspath__), so existing PyStrRef-style str behavior is preserved while adding CPython-compatible filename inputs. Behavioral outcome SyntaxError.filename, SyntaxError.lineno, and SyntaxError.offset now match CPython for both parse-time and symtable-build-time failures in test_filename_correct. symtable.symtable("pass", b"spam", "exec") is now accepted, while invalid containers such as bytearray, memoryview, and list still raise TypeError.

Open Graph Description: Summary This PR removes one @unittest.expectedFailure in test_symtable by aligning RustPython's _symtable.symtable behavior with CPython for filename handling and symbol-table-time error locati...

X Description: Summary This PR removes one @unittest.expectedFailure in test_symtable by aligning RustPython's _symtable.symtable behavior with CPython for filename handling and symbol-table-time error lo...

Opengraph URL: https://github.com/RustPython/RustPython/pull/7142

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7e080860-e388-3595-e098-b574533f4bc0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC402:3E1398:54969B:713D15:6B003116
html-safe-nonce70b570338a6ed3e6c3f2657cb64df705c174d2598f7752b63da6fabfb93c5bef
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDAyOjNFMTM5ODo1NDk2OUI6NzEzRDE1OjZCMDAzMTE2IiwidmlzaXRvcl9pZCI6IjczOTAzMzIxODQ4NjQ3NjQxODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac187ee7e444daa5ddd9f48029d8e58653dbfd15bff53db67197248c3fcd4a117d
hovercard-subject-tagpull_request:3284563131
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/7142/files
twitter:imagehttps://avatars.githubusercontent.com/u/26626194?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/26626194?s=400&v=4
og:image:altSummary This PR removes one @unittest.expectedFailure in test_symtable by aligning RustPython's _symtable.symtable behavior with CPython for filename handling and symbol-table-time error locati...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/7142/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F7142%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F7142%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/7142/files
Reloadhttps://github.com/RustPython/RustPython/pull/7142/files
Reloadhttps://github.com/RustPython/RustPython/pull/7142/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests144 (144)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
morealhttps://github.com/moreal
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
moreal:fix/fail-symtable-test_filename_correcthttps://github.com/moreal/RustPython/tree/fix/fail-symtable-test_filename_correct
Conversation 3 https://github.com/RustPython/RustPython/pull/7142
Commits 1 https://github.com/RustPython/RustPython/pull/7142/commits
Checks 1 https://github.com/RustPython/RustPython/pull/7142/checks
Files changed https://github.com/RustPython/RustPython/pull/7142/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7142/files
Align symtable filename handling and global error locations with CPython https://github.com/RustPython/RustPython/pull/7142/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/7142/files
5a048a6 Align symtable filename handling and global error locations with CPython moreal Feb 14, 2026 https://github.com/RustPython/RustPython/pull/7142/commits/5a048a63e759dc05d8857d1717b91beb731dd1d0
Clear filters https://github.com/RustPython/RustPython/pull/7142/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7142/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7142/files
test_symtable.py https://github.com/RustPython/RustPython/pull/7142/files#diff-8b54623778faa6ed44f4b123a1f45f426729dbd3ffdebc90a94e9d777b152d0a
symboltable.rs https://github.com/RustPython/RustPython/pull/7142/files#diff-7e251aa58ffb659d1cf1ee90837d9e467e5c3e1c699f5c1e42655c2f03489b12
symtable.rs https://github.com/RustPython/RustPython/pull/7142/files#diff-bddc54bd2adb71a09cbb5680edb73046e3aeee5f2ce356d7a2aae96cb739c411
Lib/test/test_symtable.pyhttps://github.com/RustPython/RustPython/pull/7142/files#diff-8b54623778faa6ed44f4b123a1f45f426729dbd3ffdebc90a94e9d777b152d0a
View file https://github.com/moreal/RustPython/blob/5a048a63e759dc05d8857d1717b91beb731dd1d0/Lib/test/test_symtable.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7142/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7142/files#diff-8b54623778faa6ed44f4b123a1f45f426729dbd3ffdebc90a94e9d777b152d0a
https://github.com/RustPython/RustPython/pull/7142/files#diff-8b54623778faa6ed44f4b123a1f45f426729dbd3ffdebc90a94e9d777b152d0a
crates/codegen/src/symboltable.rshttps://github.com/RustPython/RustPython/pull/7142/files#diff-7e251aa58ffb659d1cf1ee90837d9e467e5c3e1c699f5c1e42655c2f03489b12
View file https://github.com/moreal/RustPython/blob/5a048a63e759dc05d8857d1717b91beb731dd1d0/crates/codegen/src/symboltable.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7142/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7142/files#diff-7e251aa58ffb659d1cf1ee90837d9e467e5c3e1c699f5c1e42655c2f03489b12
https://github.com/RustPython/RustPython/pull/7142/files#diff-7e251aa58ffb659d1cf1ee90837d9e467e5c3e1c699f5c1e42655c2f03489b12
crates/vm/src/stdlib/symtable.rshttps://github.com/RustPython/RustPython/pull/7142/files#diff-bddc54bd2adb71a09cbb5680edb73046e3aeee5f2ce356d7a2aae96cb739c411
View file https://github.com/moreal/RustPython/blob/5a048a63e759dc05d8857d1717b91beb731dd1d0/crates/vm/src/stdlib/symtable.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/7142/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/7142/files#diff-bddc54bd2adb71a09cbb5680edb73046e3aeee5f2ce356d7a2aae96cb739c411
https://github.com/RustPython/RustPython/pull/7142/files#diff-bddc54bd2adb71a09cbb5680edb73046e3aeee5f2ce356d7a2aae96cb739c411
https://github.com/RustPython/RustPython/pull/7142/files#diff-bddc54bd2adb71a09cbb5680edb73046e3aeee5f2ce356d7a2aae96cb739c411
https://github.com/RustPython/RustPython/pull/7142/files#diff-bddc54bd2adb71a09cbb5680edb73046e3aeee5f2ce356d7a2aae96cb739c411
Please reload this pagehttps://github.com/RustPython/RustPython/pull/7142/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.