Title: Use CRT functions for time module on Windows by youknowone · Pull Request #7090 · RustPython/RustPython · GitHub
Open Graph Title: Use CRT functions for time module on Windows by youknowone · Pull Request #7090 · RustPython/RustPython
X Title: Use CRT functions for time module on Windows by youknowone · Pull Request #7090 · RustPython/RustPython
Description: Replace chrono with CRT functions (wcsftime, _gmtime64_s, _localtime64_s, _mktime64) on Windows for correct behavior Fix timezone name corruption: use take_while instead of filter for null-terminated wide strings in TIME_ZONE_INFORMATION Fix wcsftime symbol name (_wcsftime -> wcsftime) Fix CString import cfg to unix-only Remove 13 expectedFailure markers from test_time for Windows Summary by CodeRabbit Refactor Unified time/timezone handling across Unix, Windows, and other targets; centralized mktime/gmtime/localtime/struct_time conversion and formatting for consistent cross-platform behavior. Bug Fixes More robust timezone name extraction and safer local/UTC conversions. Improved strftime/strptime with OS-specific validation, proper wide/ASCII handling on Windows, and preserved non-Unix/non-Windows fallbacks.
Open Graph Description: Replace chrono with CRT functions (wcsftime, _gmtime64_s, _localtime64_s, _mktime64) on Windows for correct behavior Fix timezone name corruption: use take_while instead of filter for null-terminat...
X Description: Replace chrono with CRT functions (wcsftime, _gmtime64_s, _localtime64_s, _mktime64) on Windows for correct behavior Fix timezone name corruption: use take_while instead of filter for null-terminat...
Opengraph URL: https://github.com/RustPython/RustPython/pull/7090
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:97f795a9-07e4-d65f-3f30-10357b62a424 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 947C:3EE21F:126DDF9:17E4F50:6A5C4364 |
| html-safe-nonce | f461744a8d17e52fc6645dac27c6670a296853bf624f1ada015a669dcfeeb215 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDdDOjNFRTIxRjoxMjZEREY5OjE3RTRGNTA6NkE1QzQzNjQiLCJ2aXNpdG9yX2lkIjoiODc4ODA1MTI4MTg0NjIyMzcxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8430c6b00dbb1c1871a30e19d5c4b1ce0734c61e36726f3940d73c104535f78c |
| hovercard-subject-tag | pull_request:3272500864 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/7090/files |
| twitter:image | https://avatars.githubusercontent.com/u/69878?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/69878?s=400&v=4 |
| og:image:alt | Replace chrono with CRT functions (wcsftime, _gmtime64_s, _localtime64_s, _mktime64) on Windows for correct behavior Fix timezone name corruption: use take_while instead of filter for null-terminat... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width