| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:611f4a09-86cd-e4d5-48f3-f7d6e4ba69ca |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B6CC:216B79:A1EAA5:D52BA6:696B535C |
| html-safe-nonce | bbf5921cc9451c1a005897849a9a5c43385726b3f35de98281a370acea95aeaa |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkNDOjIxNkI3OTpBMUVBQTU6RDUyQkE2OjY5NkI1MzVDIiwidmlzaXRvcl9pZCI6IjkwNzY4MzE4NjkwNjI1NjY3NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1c89aa622254f6345952b0276485a9b5db35cc17f340798ca7ed46478d4ab602 |
| hovercard-subject-tag | pull_request:3129862236 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/6524/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/56a833a4254a9cb1126f7ffe18f3432f09423d8a5b5087d7eebcf3991b50ae96/RustPython/RustPython/pull/6524 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/56a833a4254a9cb1126f7ffe18f3432f09423d8a5b5087d7eebcf3991b50ae96/RustPython/RustPython/pull/6524 |
| og:image:alt | Implements python/cpython#102870
Summary by CodeRabbit
Refactor
Optimized internal compilation logic for comparison operations and boolean expressions, improving code maintainability.
Docume... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ShaharNaveh |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/RustPython/RustPython/pull/6524#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F6524 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F6524 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/6524 |
| Reload | https://github.com/RustPython/RustPython/pull/6524 |
| Reload | https://github.com/RustPython/RustPython/pull/6524 |
|
RustPython
| https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
|
Notifications
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Fork
1.4k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Star
21.7k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
278
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
91
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
0
| https://github.com/RustPython/RustPython/projects |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/RustPython/RustPython/security |
| Please reload this page | https://github.com/RustPython/RustPython/pull/6524 |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/RustPython/RustPython/pull/6524#issue-comment-box |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| ShaharNaveh:bytecode-remove-jump-if-true-false-pop | https://github.com/ShaharNaveh/RustPython/tree/bytecode-remove-jump-if-true-false-pop |
|
Reduce usage JumpIfTrueOrPop & JumpIfFalseOrPop opcdes. Refactor compile_compare
| https://github.com/RustPython/RustPython/pull/6524#top |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| ShaharNaveh:bytecode-remove-jump-if-true-false-pop | https://github.com/ShaharNaveh/RustPython/tree/bytecode-remove-jump-if-true-false-pop |
|
Conversation
6
| https://github.com/RustPython/RustPython/pull/6524 |
|
Commits
8
| https://github.com/RustPython/RustPython/pull/6524/commits |
|
Checks
12
| https://github.com/RustPython/RustPython/pull/6524/checks |
|
Files changed
| https://github.com/RustPython/RustPython/pull/6524/files |
| Please reload this page | https://github.com/RustPython/RustPython/pull/6524 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
|
| https://github.com/ShaharNaveh |
| ShaharNaveh | https://github.com/ShaharNaveh |
| Dec 25, 2025 | https://github.com/RustPython/RustPython/pull/6524#issue-3761840848 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/6524 |
| python/cpython#102870 | https://github.com/python/cpython/pull/102870 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/6524 |
|
| https://github.com/ShaharNaveh |
| Remove JumpIfTrueOrPop & JumpIfFalseOrPop opcdes | https://github.com/RustPython/RustPython/pull/6524/commits/1445698a3ca66e84568cd78db4f365ba30855e72 |
| 1445698 | https://github.com/RustPython/RustPython/pull/6524/commits/1445698a3ca66e84568cd78db4f365ba30855e72 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
| Dec 25, 2025 | https://github.com/RustPython/RustPython/pull/6524#issuecomment-3691347033 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/6524 |
| Align opcode names in dis #6526 | https://github.com/RustPython/RustPython/pull/6526 |
| Remove Rotate* & Duplicate* instructions #6303 | https://github.com/RustPython/RustPython/pull/6303 |
| CodeRabbit | https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=RustPython/RustPython&utm_content=6524 |
| X | https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai |
| Mastodon | https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai |
| Reddit | https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai |
| LinkedIn | https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code |
| Please reload this page | https://github.com/RustPython/RustPython/pull/6524 |
| ShaharNaveh | https://github.com/ShaharNaveh |
| December 25, 2025 16:49 | https://github.com/RustPython/RustPython/pull/6524#commits-pushed-70ef6d0 |
|
| https://github.com/ShaharNaveh |
| Merge remote-tracking branch 'upstream/main' into bytecode-remove-jum… | https://github.com/RustPython/RustPython/pull/6524/commits/70ef6d0837c95c32e0a33a34cbcd2fc1d1d7d895 |
| 70ef6d0 | https://github.com/RustPython/RustPython/pull/6524/commits/70ef6d0837c95c32e0a33a34cbcd2fc1d1d7d895 |
|
| https://github.com/ShaharNaveh |
| Use correct instruction name | https://github.com/RustPython/RustPython/pull/6524/commits/62259f378328591acce66f5537c9ac2cbad871e3 |
| 62259f3 | https://github.com/RustPython/RustPython/pull/6524/commits/62259f378328591acce66f5537c9ac2cbad871e3 |
|
| https://github.com/ShaharNaveh |
| Extract compile_cmpop to its own method | https://github.com/RustPython/RustPython/pull/6524/commits/999f6ac380877b6f7fc1c4e7574b90cf716eef37 |
| 999f6ac | https://github.com/RustPython/RustPython/pull/6524/commits/999f6ac380877b6f7fc1c4e7574b90cf716eef37 |
|
| https://github.com/ShaharNaveh |
| Better alignment with CPython code | https://github.com/RustPython/RustPython/pull/6524/commits/186b9145364764b9755df9b8b8b12fcf53e11626 |
| 186b914 | https://github.com/RustPython/RustPython/pull/6524/commits/186b9145364764b9755df9b8b8b12fcf53e11626 |
|
| https://github.com/ShaharNaveh |
| Merge remote-tracking branch 'upstream/main' into bytecode-remove-jum… | https://github.com/RustPython/RustPython/pull/6524/commits/a1399bcfc9254d21df5c6343a9395aee185e9918 |
| a1399bc | https://github.com/RustPython/RustPython/pull/6524/commits/a1399bcfc9254d21df5c6343a9395aee185e9918 |
|
| https://github.com/ShaharNaveh |
| Restore PopJumpIf instructions | https://github.com/RustPython/RustPython/pull/6524/commits/48f377228a4c4ff94d2448c32a97d3769d1fed69 |
| 48f3772 | https://github.com/RustPython/RustPython/pull/6524/commits/48f377228a4c4ff94d2448c32a97d3769d1fed69 |
|
| https://github.com/ShaharNaveh |
| Revert PopJumpIfFalse for comparisons | https://github.com/RustPython/RustPython/pull/6524/commits/582d1e03c6a1a78962c73714bb2599e52d3b5908 |
| 582d1e0 | https://github.com/RustPython/RustPython/pull/6524/commits/582d1e03c6a1a78962c73714bb2599e52d3b5908 |
| https://github.com/ShaharNaveh |
| ShaharNaveh | https://github.com/ShaharNaveh |
| Dec 26, 2025 | https://github.com/RustPython/RustPython/pull/6524#event-21758873401 |
| https://github.com/ShaharNaveh |
| ShaharNaveh | https://github.com/ShaharNaveh |
| December 26, 2025 12:29 | https://github.com/RustPython/RustPython/pull/6524#event-21758873889 |
| https://github.com/ShaharNaveh |
| ShaharNaveh | https://github.com/ShaharNaveh |
| Dec 26, 2025 | https://github.com/RustPython/RustPython/pull/6524#issuecomment-3692807061 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/6524 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
|
Dec 26, 2025
| https://github.com/RustPython/RustPython/pull/6524#pullrequestreview-3613378586 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/6524/files/582d1e03c6a1a78962c73714bb2599e52d3b5908 |
| coderabbitai | https://github.com/apps/coderabbitai |
| https://github.com/RustPython/RustPython/pull/6524#pullrequestreview-3613378586 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| c9bf8df | https://github.com/RustPython/RustPython/commit/c9bf8df19ca9b88e6848b9513308f62637792b9c |
| 582d1e0 | https://github.com/RustPython/RustPython/commit/582d1e03c6a1a78962c73714bb2599e52d3b5908 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/6524 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Dec 26, 2025
| https://github.com/RustPython/RustPython/pull/6524#pullrequestreview-3613384929 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/6524/files/582d1e03c6a1a78962c73714bb2599e52d3b5908 |
| crates/codegen/src/compile.rs | https://github.com/RustPython/RustPython/pull/6524/files/582d1e03c6a1a78962c73714bb2599e52d3b5908#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca |
| youknowone | https://github.com/youknowone |
| Dec 26, 2025 | https://github.com/RustPython/RustPython/pull/6524#discussion_r2648145752 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/6524 |
| ShaharNaveh | https://github.com/ShaharNaveh |
| Dec 26, 2025 | https://github.com/RustPython/RustPython/pull/6524#discussion_r2648275418 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| RustPython/Lib/test/test_compile.py | https://github.com/RustPython/RustPython/blob/61ddd98b893072d9b067a953318d93a22a68d3ca/Lib/test/test_compile.py#L1073-L1081 |
| 61ddd98 | https://github.com/RustPython/RustPython/commit/61ddd98b893072d9b067a953318d93a22a68d3ca |
| Please reload this page | https://github.com/RustPython/RustPython/pull/6524 |
| youknowone | https://github.com/youknowone |
| Dec 26, 2025 | https://github.com/RustPython/RustPython/pull/6524#discussion_r2648362247 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/6524 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Dec 26, 2025
| https://github.com/RustPython/RustPython/pull/6524#pullrequestreview-3613604587 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/6524/files/582d1e03c6a1a78962c73714bb2599e52d3b5908 |
| crates/codegen/src/compile.rs | https://github.com/RustPython/RustPython/pull/6524/files/582d1e03c6a1a78962c73714bb2599e52d3b5908#diff-6a53a11ca0aa1a372032c6b54644b8cda74af0c771efa40d3668da4a042cf7ca |
| youknowone | https://github.com/youknowone |
| Dec 26, 2025 | https://github.com/RustPython/RustPython/pull/6524#discussion_r2648362247 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/6524 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| b704f42 | https://github.com/RustPython/RustPython/commit/b704f42158e8be9a5de781497585207b3f8f576e |
| Dec 26, 2025 | https://github.com/RustPython/RustPython/pull/6524#event-21760016065 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/6524 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F6524 |
|
| https://github.com/apps/coderabbitai |
|
coderabbitai[bot]
| https://github.com/apps/coderabbitai |
|
| https://github.com/RustPython/RustPython/pull/6524/files/582d1e03c6a1a78962c73714bb2599e52d3b5908 |
|
| https://github.com/youknowone |
|
youknowone
| https://github.com/youknowone |
|
| https://github.com/RustPython/RustPython/pull/6524/files/582d1e03c6a1a78962c73714bb2599e52d3b5908 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/6524 |
|
| https://github.com/ShaharNaveh |
|
| https://github.com/youknowone |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |