René's URL Explorer Experiment


Title: Move weakref object type to obj module by BenLewis-Seequent · Pull Request #636 · RustPython/RustPython · GitHub

Open Graph Title: Move weakref object type to obj module by BenLewis-Seequent · Pull Request #636 · RustPython/RustPython

X Title: Move weakref object type to obj module by BenLewis-Seequent · Pull Request #636 · RustPython/RustPython

Description: Promote weakref to be a core type by moving it out of its stdlib module and into the obj module. This is required to implement weakref callbacks, which I will redo in a followup PR. This was originally implemented as part of the outdated #488 PR. Also, I have migrated the weakref type to use the 'any' payload and new style functions. I built this on top of #635, so I could use PyRef::new_with_type.

Open Graph Description: Promote weakref to be a core type by moving it out of its stdlib module and into the obj module. This is required to implement weakref callbacks, which I will redo in a followup PR. This was origin...

X Description: Promote weakref to be a core type by moving it out of its stdlib module and into the obj module. This is required to implement weakref callbacks, which I will redo in a followup PR. This was origin...

Opengraph URL: https://github.com/RustPython/RustPython/pull/636

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:87600bad-cf60-bcd2-bc20-b2dcaaad78c9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id852A:61DF9:2C94577:3FC91EB:6A5909C0
html-safe-nonced064740ac984e5bf84695e8ed6bb7de6d5ca6522026f7ffabce8c41c86fd87b3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTJBOjYxREY5OjJDOTQ1Nzc6M0ZDOTFFQjo2QTU5MDlDMCIsInZpc2l0b3JfaWQiOiI1MDIwODE5NDQ5NzQ1OTI0NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5e8be98ac18cf047d80fabb917d3ab7ebc42ea9b943de1a3d4e5544fb462026e
hovercard-subject-tagpull_request:259664886
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/636/files
twitter:imagehttps://avatars.githubusercontent.com/u/7391596?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7391596?s=400&v=4
og:image:altPromote weakref to be a core type by moving it out of its stdlib module and into the obj module. This is required to implement weakref callbacks, which I will redo in a followup PR. This was origin...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4eb8ea312922ccce63e833964f9606d971cffb2d5b6c10a62c4a7dcc48d826e2
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release886a6c6fbce3d3caad5b3b995ef09ff6ca23f10e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/636/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F636%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F636%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/636/files
Reloadhttps://github.com/RustPython/RustPython/pull/636/files
Reloadhttps://github.com/RustPython/RustPython/pull/636/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/636/files
RustPython https://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Notifications https://github.com/login?return_to=%2FRustPython%2FRustPython
Fork 1.5k https://github.com/login?return_to=%2FRustPython%2FRustPython
Star 22.2k https://github.com/login?return_to=%2FRustPython%2FRustPython
Code https://github.com/RustPython/RustPython
Issues 287 https://github.com/RustPython/RustPython/issues
Pull requests 100 https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality 0 https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
Code https://github.com/RustPython/RustPython
Issues https://github.com/RustPython/RustPython/issues
Pull requests https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
OddCoincidencehttps://github.com/OddCoincidence
RustPython:masterhttps://github.com/RustPython/RustPython/tree/master
BenLewis-Seequent:weakref_typehttps://github.com/BenLewis-Seequent/RustPython/tree/weakref_type
Conversation 3 https://github.com/RustPython/RustPython/pull/636
Commits 2 https://github.com/RustPython/RustPython/pull/636/commits
Checks 0 https://github.com/RustPython/RustPython/pull/636/checks
Files changed https://github.com/RustPython/RustPython/pull/636/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/636/files
Move weakref object type to obj module https://github.com/RustPython/RustPython/pull/636/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/636/files
7c5be7d Add proper weakref type skinnyBat Mar 9, 2019 https://github.com/RustPython/RustPython/pull/636/commits/7c5be7d6b7d97e96daf4fb26e451db76c7d4a6ec
6024e3e Fix irrefutable pattern errors OddCoincidence Mar 10, 2019 https://github.com/RustPython/RustPython/pull/636/commits/6024e3ea0c70f237e698d293f93ea9b51f83aa96
Clear filters https://github.com/RustPython/RustPython/pull/636/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/636/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/636/files
mod.rs https://github.com/RustPython/RustPython/pull/636/files#diff-cb3f6c41256bb969446b58293c3ac50ccca42261ef0b04671401eec0ed8c1bde
objweakref.rs https://github.com/RustPython/RustPython/pull/636/files#diff-a276a0ac998c01613d6cdb5687babdb77cde8a56502cf2a5527ac4ada3452b40
pyobject.rs https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
re.rs https://github.com/RustPython/RustPython/pull/636/files#diff-36a3e55c1f0b3dbb49d10d94923184eea5de23c3c1f464973e39985b37dabda6
socket.rs https://github.com/RustPython/RustPython/pull/636/files#diff-cf07c9f4edf06942366ed886d1cea593b56e44cfd2b7d79edd82afb4ddc4889a
weakref.rs https://github.com/RustPython/RustPython/pull/636/files#diff-e53b406e90801c6b61a5ee6c3aff4d1218bb364b5d343f1dda92a1643567705c
vm/src/obj/mod.rshttps://github.com/RustPython/RustPython/pull/636/files#diff-cb3f6c41256bb969446b58293c3ac50ccca42261ef0b04671401eec0ed8c1bde
View file https://github.com/BenLewis-Seequent/RustPython/blob/6024e3ea0c70f237e698d293f93ea9b51f83aa96/vm/src/obj/mod.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/636/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/636/files#diff-cb3f6c41256bb969446b58293c3ac50ccca42261ef0b04671401eec0ed8c1bde
vm/src/obj/objweakref.rshttps://github.com/RustPython/RustPython/pull/636/files#diff-a276a0ac998c01613d6cdb5687babdb77cde8a56502cf2a5527ac4ada3452b40
View file https://github.com/BenLewis-Seequent/RustPython/blob/6024e3ea0c70f237e698d293f93ea9b51f83aa96/vm/src/obj/objweakref.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/636/{{ revealButtonHref }}
vm/src/pyobject.rshttps://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
View file https://github.com/BenLewis-Seequent/RustPython/blob/6024e3ea0c70f237e698d293f93ea9b51f83aa96/vm/src/pyobject.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/636/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
https://github.com/RustPython/RustPython/pull/636/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
vm/src/stdlib/re.rshttps://github.com/RustPython/RustPython/pull/636/files#diff-36a3e55c1f0b3dbb49d10d94923184eea5de23c3c1f464973e39985b37dabda6
View file https://github.com/BenLewis-Seequent/RustPython/blob/6024e3ea0c70f237e698d293f93ea9b51f83aa96/vm/src/stdlib/re.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/636/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/636/files#diff-36a3e55c1f0b3dbb49d10d94923184eea5de23c3c1f464973e39985b37dabda6
vm/src/stdlib/socket.rshttps://github.com/RustPython/RustPython/pull/636/files#diff-cf07c9f4edf06942366ed886d1cea593b56e44cfd2b7d79edd82afb4ddc4889a
View file https://github.com/BenLewis-Seequent/RustPython/blob/6024e3ea0c70f237e698d293f93ea9b51f83aa96/vm/src/stdlib/socket.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/636/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/636/files#diff-cf07c9f4edf06942366ed886d1cea593b56e44cfd2b7d79edd82afb4ddc4889a
https://github.com/RustPython/RustPython/pull/636/files#diff-cf07c9f4edf06942366ed886d1cea593b56e44cfd2b7d79edd82afb4ddc4889a
vm/src/stdlib/weakref.rshttps://github.com/RustPython/RustPython/pull/636/files#diff-e53b406e90801c6b61a5ee6c3aff4d1218bb364b5d343f1dda92a1643567705c
View file https://github.com/BenLewis-Seequent/RustPython/blob/6024e3ea0c70f237e698d293f93ea9b51f83aa96/vm/src/stdlib/weakref.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/636/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/636/files#diff-e53b406e90801c6b61a5ee6c3aff4d1218bb364b5d343f1dda92a1643567705c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.