René's URL Explorer Experiment


Title: Unify property like objects by BenLewis-Seequent · Pull Request #635 · RustPython/RustPython · GitHub

Open Graph Title: Unify property like objects by BenLewis-Seequent · Pull Request #635 · RustPython/RustPython

X Title: Unify property like objects by BenLewis-Seequent · Pull Request #635 · RustPython/RustPython

Description: Followup to #619, migrates property to the newer style and unify property like objects by: making data descriptors an actual property, removing the need for an extra class. making any property created from rust, which only has a getter(any use of vm.new_property) a readonly property. This means they can be overridden by the instance dict, hopefully leading to more consistent behavior. changes member descriptors to be properties

Open Graph Description: Followup to #619, migrates property to the newer style and unify property like objects by: making data descriptors an actual property, removing the need for an extra class. making any property cre...

X Description: Followup to #619, migrates property to the newer style and unify property like objects by: making data descriptors an actual property, removing the need for an extra class. making any property cre...

Opengraph URL: https://github.com/RustPython/RustPython/pull/635

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:639f6d3f-6846-f09b-d313-7d023ca2c982
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE0C6:8C7D0:B23890:1030BB5:6A58A360
html-safe-noncef1c23924386506fc9f8c5166e3b7584fe9ba0d16240532db57e11771f749fb5e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEM2OjhDN0QwOkIyMzg5MDoxMDMwQkI1OjZBNThBMzYwIiwidmlzaXRvcl9pZCI6Ijc2Njk4Mzg0OTQ1ODQ4NDEwNTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac15438f3cd91c7c5b6c3a84acbb7a8a1385d4379960a6a5d2159422b22adaed68
hovercard-subject-tagpull_request:259660713
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/635/files
twitter:imagehttps://avatars.githubusercontent.com/u/7391596?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7391596?s=400&v=4
og:image:altFollowup to #619, migrates property to the newer style and unify property like objects by: making data descriptors an actual property, removing the need for an extra class. making any property cre...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/635/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F635%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F635%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/635/files
Reloadhttps://github.com/RustPython/RustPython/pull/635/files
Reloadhttps://github.com/RustPython/RustPython/pull/635/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/635/files
RustPython https://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Notifications https://github.com/login?return_to=%2FRustPython%2FRustPython
Fork 1.5k https://github.com/login?return_to=%2FRustPython%2FRustPython
Star 22.2k https://github.com/login?return_to=%2FRustPython%2FRustPython
Code https://github.com/RustPython/RustPython
Issues 287 https://github.com/RustPython/RustPython/issues
Pull requests 101 https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality 0 https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
Code https://github.com/RustPython/RustPython
Issues https://github.com/RustPython/RustPython/issues
Pull requests https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
cthulahoopshttps://github.com/cthulahoops
RustPython:masterhttps://github.com/RustPython/RustPython/tree/master
BenLewis-Seequent:property_refactorhttps://github.com/BenLewis-Seequent/RustPython/tree/property_refactor
Conversation 3 https://github.com/RustPython/RustPython/pull/635
Commits 6 https://github.com/RustPython/RustPython/pull/635/commits
Checks 0 https://github.com/RustPython/RustPython/pull/635/checks
Files changed https://github.com/RustPython/RustPython/pull/635/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/635/files
Unify property like objects https://github.com/RustPython/RustPython/pull/635/files#top
Show all changes 6 commits https://github.com/RustPython/RustPython/pull/635/files
5abc674 Change property implementation to have rust payload and to use new skinnyBat Mar 8, 2019 https://github.com/RustPython/RustPython/pull/635/commits/5abc674737c6fb154a7cdb3623ef37d4c1af5240
3fe32d0 Merge branch 'master' into property_refactor skinnyBat Mar 8, 2019 https://github.com/RustPython/RustPython/pull/635/commits/3fe32d0527747a6dee3af0d44e6e01e270d0d65a
2edfe4c Migrate usage of member_descriptor and data_descriptor to skinnyBat Mar 9, 2019 https://github.com/RustPython/RustPython/pull/635/commits/2edfe4c7be09484f1b7a3c64747daab92ffb92e0
0ec034d Change property.__new__ to use new style function and construct skinnyBat Mar 9, 2019 https://github.com/RustPython/RustPython/pull/635/commits/0ec034df51adb15c4808f658f2221fabf6780a76
3c3c1f2 Fixed new_attribute_error and added more tests for property skinnyBat Mar 9, 2019 https://github.com/RustPython/RustPython/pull/635/commits/3c3c1f2b6f6fd8e1938b63153554f90cfa611ac9
7d01323 Merge branch 'master' into property_refactor skinnyBat Mar 9, 2019 https://github.com/RustPython/RustPython/pull/635/commits/7d01323e0939a3ccf1e4804c0a77c9ea9cecb809
Clear filters https://github.com/RustPython/RustPython/pull/635/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/635/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/635/files
class.py https://github.com/RustPython/RustPython/pull/635/files#diff-332e36f024cb4d668a9c354a8d0a370a60b53d8148ad0d3a414f887c961634f0
property.py https://github.com/RustPython/RustPython/pull/635/files#diff-1d38338ea063177e7a434dd6d851eaa365224cf281e2f9f64b59075eec596da1
function.rs https://github.com/RustPython/RustPython/pull/635/files#diff-854cafe834e9096a7a4629a1227bd9ffd665fafedc669049f35a387ea41fc124
objcode.rs https://github.com/RustPython/RustPython/pull/635/files#diff-0e150b6cf6cfb83cf6bb1d0985a32ffb9051d7a22813e66b0bc3a53e18091600
objfunction.rs https://github.com/RustPython/RustPython/pull/635/files#diff-eb175989654a293391bc5198ba14c8a0b1cdc38e850226cd90598f5a18048524
objobject.rs https://github.com/RustPython/RustPython/pull/635/files#diff-f68d8eb04b2ffda267001c9cedd61d225e47d736485315b06bafff5fb4a619cc
objproperty.rs https://github.com/RustPython/RustPython/pull/635/files#diff-c9743418a213c62dc4a3a717e1a39cedb1c2b75950326b38265516f57694d3cf
objtype.rs https://github.com/RustPython/RustPython/pull/635/files#diff-46a1291f828c8e7ed91d6c0f019c80b93cd33405254b258cf89cfc2f53d7f2b5
pyobject.rs https://github.com/RustPython/RustPython/pull/635/files#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
vm.rs https://github.com/RustPython/RustPython/pull/635/files#diff-c44c9a77e94801c68d29dc6d259e2ba6dc1d30c09e228f423aa539c4e8533fcf
tests/snippets/class.pyhttps://github.com/RustPython/RustPython/pull/635/files#diff-332e36f024cb4d668a9c354a8d0a370a60b53d8148ad0d3a414f887c961634f0
View file https://github.com/BenLewis-Seequent/RustPython/blob/7d01323e0939a3ccf1e4804c0a77c9ea9cecb809/tests/snippets/class.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/635/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/635/files#diff-332e36f024cb4d668a9c354a8d0a370a60b53d8148ad0d3a414f887c961634f0
https://github.com/RustPython/RustPython/pull/635/files#diff-332e36f024cb4d668a9c354a8d0a370a60b53d8148ad0d3a414f887c961634f0
tests/snippets/property.pyhttps://github.com/RustPython/RustPython/pull/635/files#diff-1d38338ea063177e7a434dd6d851eaa365224cf281e2f9f64b59075eec596da1
View file https://github.com/BenLewis-Seequent/RustPython/blob/7d01323e0939a3ccf1e4804c0a77c9ea9cecb809/tests/snippets/property.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/635/{{ revealButtonHref }}
vm/src/function.rshttps://github.com/RustPython/RustPython/pull/635/files#diff-854cafe834e9096a7a4629a1227bd9ffd665fafedc669049f35a387ea41fc124
View file https://github.com/BenLewis-Seequent/RustPython/blob/7d01323e0939a3ccf1e4804c0a77c9ea9cecb809/vm/src/function.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/635/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/635/files#diff-854cafe834e9096a7a4629a1227bd9ffd665fafedc669049f35a387ea41fc124
https://github.com/RustPython/RustPython/pull/635/files#diff-854cafe834e9096a7a4629a1227bd9ffd665fafedc669049f35a387ea41fc124
https://github.com/RustPython/RustPython/pull/635/files#diff-854cafe834e9096a7a4629a1227bd9ffd665fafedc669049f35a387ea41fc124
https://github.com/RustPython/RustPython/pull/635/files#diff-854cafe834e9096a7a4629a1227bd9ffd665fafedc669049f35a387ea41fc124
vm/src/obj/objcode.rshttps://github.com/RustPython/RustPython/pull/635/files#diff-0e150b6cf6cfb83cf6bb1d0985a32ffb9051d7a22813e66b0bc3a53e18091600
View file https://github.com/BenLewis-Seequent/RustPython/blob/7d01323e0939a3ccf1e4804c0a77c9ea9cecb809/vm/src/obj/objcode.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/635/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/635/files#diff-0e150b6cf6cfb83cf6bb1d0985a32ffb9051d7a22813e66b0bc3a53e18091600
https://github.com/RustPython/RustPython/pull/635/files#diff-0e150b6cf6cfb83cf6bb1d0985a32ffb9051d7a22813e66b0bc3a53e18091600
https://github.com/RustPython/RustPython/pull/635/files#diff-0e150b6cf6cfb83cf6bb1d0985a32ffb9051d7a22813e66b0bc3a53e18091600
https://github.com/RustPython/RustPython/pull/635/files#diff-0e150b6cf6cfb83cf6bb1d0985a32ffb9051d7a22813e66b0bc3a53e18091600
vm/src/obj/objfunction.rshttps://github.com/RustPython/RustPython/pull/635/files#diff-eb175989654a293391bc5198ba14c8a0b1cdc38e850226cd90598f5a18048524
View file https://github.com/BenLewis-Seequent/RustPython/blob/7d01323e0939a3ccf1e4804c0a77c9ea9cecb809/vm/src/obj/objfunction.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/635/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/635/files#diff-eb175989654a293391bc5198ba14c8a0b1cdc38e850226cd90598f5a18048524
https://github.com/RustPython/RustPython/pull/635/files#diff-eb175989654a293391bc5198ba14c8a0b1cdc38e850226cd90598f5a18048524
https://github.com/RustPython/RustPython/pull/635/files#diff-eb175989654a293391bc5198ba14c8a0b1cdc38e850226cd90598f5a18048524
https://github.com/RustPython/RustPython/pull/635/files#diff-eb175989654a293391bc5198ba14c8a0b1cdc38e850226cd90598f5a18048524
https://github.com/RustPython/RustPython/pull/635/files#diff-eb175989654a293391bc5198ba14c8a0b1cdc38e850226cd90598f5a18048524
vm/src/obj/objobject.rshttps://github.com/RustPython/RustPython/pull/635/files#diff-f68d8eb04b2ffda267001c9cedd61d225e47d736485315b06bafff5fb4a619cc
View file https://github.com/BenLewis-Seequent/RustPython/blob/7d01323e0939a3ccf1e4804c0a77c9ea9cecb809/vm/src/obj/objobject.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/635/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/635/files#diff-f68d8eb04b2ffda267001c9cedd61d225e47d736485315b06bafff5fb4a619cc
https://github.com/RustPython/RustPython/pull/635/files#diff-f68d8eb04b2ffda267001c9cedd61d225e47d736485315b06bafff5fb4a619cc
https://github.com/RustPython/RustPython/pull/635/files#diff-f68d8eb04b2ffda267001c9cedd61d225e47d736485315b06bafff5fb4a619cc
https://github.com/RustPython/RustPython/pull/635/files#diff-f68d8eb04b2ffda267001c9cedd61d225e47d736485315b06bafff5fb4a619cc
https://github.com/RustPython/RustPython/pull/635/files#diff-f68d8eb04b2ffda267001c9cedd61d225e47d736485315b06bafff5fb4a619cc
Please reload this pagehttps://github.com/RustPython/RustPython/pull/635/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.