René's URL Explorer Experiment


Title: Unify property like objects by BenLewis-Seequent · Pull Request #635 · RustPython/RustPython · GitHub

Open Graph Title: Unify property like objects by BenLewis-Seequent · Pull Request #635 · RustPython/RustPython

X Title: Unify property like objects by BenLewis-Seequent · Pull Request #635 · RustPython/RustPython

Description: A Python Interpreter written in Rust. Contribute to RustPython/RustPython development by creating an account on GitHub.

Open Graph Description: Followup to #619, migrates property to the newer style and unify property like objects by: making data descriptors an actual property, removing the need for an extra class. making any property cre...

X Description: Followup to #619, migrates property to the newer style and unify property like objects by: making data descriptors an actual property, removing the need for an extra class. making any property cre...

Opengraph URL: https://github.com/RustPython/RustPython/pull/635

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f297550e-e7c0-7813-a1fc-288673538636
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED92:2201C9:C92579:11DD7E1:6A588D9C
html-safe-nonce43f62377c6bc0a59f44007e4c4d682cc7c7b3892aa5509347fbd430a0d22480d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDkyOjIyMDFDOTpDOTI1Nzk6MTFERDdFMTo2QTU4OEQ5QyIsInZpc2l0b3JfaWQiOiIxNjQxODcwMzU0NDE4MjczNjkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3d8772176dfccee3bbbbfc8dfac7683dbf109c63e9fe02d87c34c3299bf978cd
hovercard-subject-tagpull_request:259660713
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/635/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b693efb5c08eed9dcd294311c5fcc74a24fecfd038dd47fd40006eedbc54d484/RustPython/RustPython/pull/635
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b693efb5c08eed9dcd294311c5fcc74a24fecfd038dd47fd40006eedbc54d484/RustPython/RustPython/pull/635
og:image:altFollowup to #619, migrates property to the newer style and unify property like objects by: making data descriptors an actual property, removing the need for an extra class. making any property cre...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBenLewis-Seequent
hostnamegithub.com
expected-hostnamegithub.com
None5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6
turbo-cache-controlno-cache
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/635#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F635
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F635
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/635
Reloadhttps://github.com/RustPython/RustPython/pull/635
Reloadhttps://github.com/RustPython/RustPython/pull/635
Please reload this pagehttps://github.com/RustPython/RustPython/pull/635
RustPython https://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Notifications https://github.com/login?return_to=%2FRustPython%2FRustPython
Fork 1.5k https://github.com/login?return_to=%2FRustPython%2FRustPython
Star 22.2k https://github.com/login?return_to=%2FRustPython%2FRustPython
Code https://github.com/RustPython/RustPython
Issues 289 https://github.com/RustPython/RustPython/issues
Pull requests 103 https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality 0 https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
Code https://github.com/RustPython/RustPython
Issues https://github.com/RustPython/RustPython/issues
Pull requests https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
cthulahoopshttps://github.com/cthulahoops
RustPython:masterhttps://github.com/RustPython/RustPython/tree/master
BenLewis-Seequent:property_refactorhttps://github.com/BenLewis-Seequent/RustPython/tree/property_refactor
Conversationhttps://github.com/RustPython/RustPython/pull/635
Commits6 (6)https://github.com/RustPython/RustPython/pull/635/commits
Checkshttps://github.com/RustPython/RustPython/pull/635/checks
Files changedhttps://github.com/RustPython/RustPython/pull/635/files
Unify property like objectshttps://github.com/RustPython/RustPython/pull/635#top
cthulahoopshttps://github.com/cthulahoops
RustPython:masterhttps://github.com/RustPython/RustPython/tree/master
BenLewis-Seequent:property_refactorhttps://github.com/BenLewis-Seequent/RustPython/tree/property_refactor
https://github.com/BenLewis-Seequent
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
Mar 9, 2019https://github.com/RustPython/RustPython/pull/635#issue-419026534
#619https://github.com/RustPython/RustPython/pull/619
Please reload this pagehttps://github.com/RustPython/RustPython/pull/635
skinnyBathttps://github.com/skinnyBat
March 9, 2019 12:11https://github.com/RustPython/RustPython/pull/635#commits-pushed-5abc674
https://github.com/skinnyBat
Change property implementation to have rust payload and to use newhttps://github.com/RustPython/RustPython/pull/635/commits/5abc674737c6fb154a7cdb3623ef37d4c1af5240
5abc674https://github.com/RustPython/RustPython/pull/635/commits/5abc674737c6fb154a7cdb3623ef37d4c1af5240
https://github.com/skinnyBat
Merge branch 'master' into property_refactorhttps://github.com/RustPython/RustPython/pull/635/commits/3fe32d0527747a6dee3af0d44e6e01e270d0d65a
3fe32d0https://github.com/RustPython/RustPython/pull/635/commits/3fe32d0527747a6dee3af0d44e6e01e270d0d65a
https://github.com/skinnyBat
Migrate usage of member_descriptor and data_descriptor tohttps://github.com/RustPython/RustPython/pull/635/commits/2edfe4c7be09484f1b7a3c64747daab92ffb92e0
2edfe4chttps://github.com/RustPython/RustPython/pull/635/commits/2edfe4c7be09484f1b7a3c64747daab92ffb92e0
https://github.com/skinnyBat
Change property.__new__ to use new style function and constructhttps://github.com/RustPython/RustPython/pull/635/commits/0ec034df51adb15c4808f658f2221fabf6780a76
0ec034dhttps://github.com/RustPython/RustPython/pull/635/commits/0ec034df51adb15c4808f658f2221fabf6780a76
https://github.com/codecov-io
codecov-iohttps://github.com/codecov-io
Mar 9, 2019https://github.com/RustPython/RustPython/pull/635#issuecomment-471141574
Please reload this pagehttps://github.com/RustPython/RustPython/pull/635
Codecovhttps://codecov.io/gh/RustPython/RustPython/pull/635?src=pr&el=h1
#635https://codecov.io/gh/RustPython/RustPython/pull/635?src=pr&el=desc
masterhttps://codecov.io/gh/RustPython/RustPython/commit/010969f2d2e8ea5cc4eedd5ccb8f8ab74a02068f?src=pr&el=desc
https://codecov.io/gh/RustPython/RustPython/pull/635?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/RustPython/RustPython/pull/635?src=pr&el=tree
vm/src/obj/objfunction.rshttps://codecov.io/gh/RustPython/RustPython/pull/635/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmpmdW5jdGlvbi5ycw==
vm/src/obj/objobject.rshttps://codecov.io/gh/RustPython/RustPython/pull/635/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmpvYmplY3QucnM=
vm/src/obj/objcode.rshttps://codecov.io/gh/RustPython/RustPython/pull/635/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmpjb2RlLnJz
vm/src/obj/objtype.rshttps://codecov.io/gh/RustPython/RustPython/pull/635/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmp0eXBlLnJz
vm/src/obj/objproperty.rshttps://codecov.io/gh/RustPython/RustPython/pull/635/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmpwcm9wZXJ0eS5ycw==
vm/src/pyobject.rshttps://codecov.io/gh/RustPython/RustPython/pull/635/diff?src=pr&el=tree#diff-dm0vc3JjL3B5b2JqZWN0LnJz
vm/src/vm.rshttps://codecov.io/gh/RustPython/RustPython/pull/635/diff?src=pr&el=tree#diff-dm0vc3JjL3ZtLnJz
vm/src/function.rshttps://codecov.io/gh/RustPython/RustPython/pull/635/diff?src=pr&el=tree#diff-dm0vc3JjL2Z1bmN0aW9uLnJz
6 morehttps://codecov.io/gh/RustPython/RustPython/pull/635/diff?src=pr&el=tree-more
Continue to review full report at Codecovhttps://codecov.io/gh/RustPython/RustPython/pull/635?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/RustPython/RustPython/pull/635?src=pr&el=footer
010969f...7d01323https://codecov.io/gh/RustPython/RustPython/pull/635?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/RustPython/RustPython/pull/635
https://github.com/BenLewis-Seequent
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
Mar 9, 2019 https://github.com/RustPython/RustPython/pull/635#ref-pullrequest-419032681
Move weakref object type to obj module #636 https://github.com/RustPython/RustPython/pull/636
https://github.com/windelbouwman
windelbouwmanhttps://github.com/windelbouwman
Mar 9, 2019 https://github.com/RustPython/RustPython/pull/635#pullrequestreview-212556899
View reviewed changes https://github.com/RustPython/RustPython/pull/635/files/0ec034df51adb15c4808f658f2221fabf6780a76
vm/src/vm.rshttps://github.com/RustPython/RustPython/pull/635/files/0ec034df51adb15c4808f658f2221fabf6780a76#diff-c44c9a77e94801c68d29dc6d259e2ba6dc1d30c09e228f423aa539c4e8533fcf
Please reload this pagehttps://github.com/RustPython/RustPython/pull/635
https://github.com/windelbouwman
windelbouwmanhttps://github.com/windelbouwman
cthulahoopshttps://github.com/cthulahoops
March 9, 2019 10:57https://github.com/RustPython/RustPython/pull/635#event-2191730781
https://github.com/windelbouwman
windelbouwmanhttps://github.com/windelbouwman
Mar 9, 2019https://github.com/RustPython/RustPython/pull/635#issuecomment-471167053
@cthulahoopshttps://github.com/cthulahoops
Please reload this pagehttps://github.com/RustPython/RustPython/pull/635
skinnyBathttps://github.com/skinnyBat
March 10, 2019 09:01https://github.com/RustPython/RustPython/pull/635#commits-pushed-3c3c1f2
https://github.com/skinnyBat
Fixed new_attribute_error and added more tests for propertyhttps://github.com/RustPython/RustPython/pull/635/commits/3c3c1f2b6f6fd8e1938b63153554f90cfa611ac9
3c3c1f2https://github.com/RustPython/RustPython/pull/635/commits/3c3c1f2b6f6fd8e1938b63153554f90cfa611ac9
https://github.com/skinnyBat
Merge branch 'master' into property_refactorhttps://github.com/RustPython/RustPython/pull/635/commits/7d01323e0939a3ccf1e4804c0a77c9ea9cecb809
7d01323https://github.com/RustPython/RustPython/pull/635/commits/7d01323e0939a3ccf1e4804c0a77c9ea9cecb809
https://github.com/cthulahoops
cthulahoopshttps://github.com/cthulahoops
Mar 10, 2019 https://github.com/RustPython/RustPython/pull/635#pullrequestreview-212600493
View reviewed changes https://github.com/RustPython/RustPython/pull/635/files/7d01323e0939a3ccf1e4804c0a77c9ea9cecb809
https://github.com/cthulahoops
cthulahoopshttps://github.com/cthulahoops
9e5b76chttps://github.com/RustPython/RustPython/commit/9e5b76c9b6bb71a007549d6e2245846728c82790
Mar 10, 2019https://github.com/RustPython/RustPython/pull/635#event-2192279478
https://github.com/BenLewis-Seequent
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
March 29, 2019 06:06https://github.com/RustPython/RustPython/pull/635#event-2238309103
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F635
https://github.com/cthulahoops
cthulahoops https://github.com/cthulahoops
https://github.com/RustPython/RustPython/pull/635/files/7d01323e0939a3ccf1e4804c0a77c9ea9cecb809
https://github.com/windelbouwman
windelbouwman https://github.com/windelbouwman
https://github.com/RustPython/RustPython/pull/635/files/0ec034df51adb15c4808f658f2221fabf6780a76
Please reload this pagehttps://github.com/RustPython/RustPython/pull/635
https://github.com/BenLewis-Seequent
https://github.com/codecov-io
https://github.com/windelbouwman
https://github.com/cthulahoops
https://github.com/skinnyBat
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.