Title: refactor(sqlite): add check_cursor_valid method for cursor state validation by ever0de · Pull Request #6342 · RustPython/RustPython · GitHub
Open Graph Title: refactor(sqlite): add check_cursor_valid method for cursor state validation by ever0de · Pull Request #6342 · RustPython/RustPython
X Title: refactor(sqlite): add check_cursor_valid method for cursor state validation by ever0de · Pull Request #6342 · RustPython/RustPython
Description: Extract cursor validity check into a separate method that doesn't hold the lock. This is useful for executescript which only needs to verify the cursor state but doesn't need to modify CursorInner. Add check_cursor_valid() method that checks if cursor is initialized and not closed without retaining the mutex guard Use check_cursor_valid() in executescript instead of inner() since executescript doesn't modify CursorInner Summary by CodeRabbit Refactor Consolidated repeated cursor-state checks into shared validation helpers to reduce duplication and improve maintainability. Added a non-mutating validation path so callers can verify cursor state without acquiring mutation locks. Script execution now validates cursor state without cloning internal state. Existing behavior for closed or uninitialized cursors and public APIs remain unchanged. ✏️ Tip: You can customize this high-level summary in your review settings.
Open Graph Description: Extract cursor validity check into a separate method that doesn't hold the lock. This is useful for executescript which only needs to verify the cursor state but doesn't need to modify Curs...
X Description: Extract cursor validity check into a separate method that doesn't hold the lock. This is useful for executescript which only needs to verify the cursor state but doesn't need to mod...
Opengraph URL: https://github.com/RustPython/RustPython/pull/6342
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5a6c6712-cf4e-d16e-3b08-185e6e8a2bc5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EB16:222345:14EF5F:1B8624:696B307E |
| html-safe-nonce | 36ae076882bd58698e17e77a78ca8506e5f0706a99c1d7950532140214535f52 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjE2OjIyMjM0NToxNEVGNUY6MUI4NjI0OjY5NkIzMDdFIiwidmlzaXRvcl9pZCI6Ijg5NDIwOTMyNDMxMzM5MzE2NDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f886b59816f8dfad08cb94b63a6245e55e90733a892f9388665b00dc828fbc60 |
| hovercard-subject-tag | pull_request:3080524018 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/6342/files |
| twitter:image | https://avatars.githubusercontent.com/u/27040963?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/27040963?s=400&v=4 |
| og:image:alt | Extract cursor validity check into a separate method that doesn't hold the lock. This is useful for executescript which only needs to verify the cursor state but doesn't need to modify Curs... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width