René's URL Explorer Experiment

Title: Sort `Instruction` variants + Ensure each holds a singular oparg type by ShaharNaveh · Pull Request #6312 · RustPython/RustPython · GitHub

Open Graph Title: Sort `Instruction` variants + Ensure each holds a singular oparg type by ShaharNaveh · Pull Request #6312 · RustPython/RustPython

X Title: Sort `Instruction` variants + Ensure each holds a singular oparg type by ShaharNaveh · Pull Request #6312 · RustPython/RustPython

Description: One of the changes made is to sort all variants alphabetically, this will makes it easier for finding if an instruction exist, especially when comparing it to https://github.com/python/cpython/blob/cfcd52490d6531f3b0e8ddd4bb2b40fb6baee854/Include/opcode_ids.h (which is sorted alphabetically). The second change I did was to change each named field to an associated value because we are only holding the oparg type. For example: Foo { index: Arg } to: Foo(Arg) IMO this has the following benefits: signals that the Instruction only holds the oparg type not the actual value. Will make the Instruction easier to auto-generate (what #6174 tried to do). The reason why we had named fields was because in the first iterations of the Instruction enum we held the actual oparg value as a named field inside the Instruction, which is no longer the case. IMO this enum should be renamed to Opcode and have a method called oparg that looks like: enum Opcode { Foo, Bar, ... } impl Opcode { fn oparg(self) -> Option { ... } } but that's a different discussion Summary by CodeRabbit Refactor Standardized the instruction/bytecode representation across the compiler, VM, and JIT for a simpler, more consistent surface. New Features Broader VM/JIT support for many additional bytecode operations, improving data-structure construction, call patterns, async/with, and iterator flows. Bug Fixes Improved import/name resolution, mapping/unpacking, exception unwinding, and async/context-manager protocol handling for more correct runtime behavior. ✏️ Tip: You can customize this high-level summary in your review settings.

Open Graph Description: One of the changes made is to sort all variants alphabetically, this will makes it easier for finding if an instruction exist, especially when comparing it to https://github.com/python/cpython/blob...

X Description: One of the changes made is to sort all variants alphabetically, this will makes it easier for finding if an instruction exist, especially when comparing it to https://github.com/python/cpython/blob...

Opengraph URL: https://github.com/RustPython/RustPython/pull/6312

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width