Title: Fix sqlite Connection initialization check by ever0de · Pull Request #6199 · RustPython/RustPython · GitHub
Open Graph Title: Fix sqlite Connection initialization check by ever0de · Pull Request #6199 · RustPython/RustPython
X Title: Fix sqlite Connection initialization check by ever0de · Pull Request #6199 · RustPython/RustPython
Description: Add proper init validation for sqlite3.Connection to ensure base class init is called before using connection methods. This fixes the test_connection_constructor_call_check test case. Changes: Modified Connection.py_new to detect subclassing For base Connection class, initialization happens immediately in py_new For subclassed Connection, db is initialized as None Added init method that performs actual database initialization Updated _db_lock error message to match CPython: 'Base Connection.init not called.' Summary by CodeRabbit Bug Fixes Clearer error message when attempting to use an uninitialized SQLite connection, making initialization issues easier to diagnose. Improvements Refined SQLite connection setup so base connections initialize immediately while derived connections defer initialization until explicitly initialized, ensuring correct configuration (path, timeouts, isolation) and preserving threading/locking behavior.
Open Graph Description: Add proper init validation for sqlite3.Connection to ensure base class init is called before using connection methods. This fixes the test_connection_constructor_call_check test case. Changes: Mod...
X Description: Add proper init validation for sqlite3.Connection to ensure base class init is called before using connection methods. This fixes the test_connection_constructor_call_check test case. Changes: Mod...
Opengraph URL: https://github.com/RustPython/RustPython/pull/6199
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:ab39f948-070d-2fcd-d42b-4f45c1933e11 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | BD78:22F52E:7B2C4:A6C5C:696A6CAC |
| html-safe-nonce | 0b6bfa0d970d6c158d61e5788f3a263646f1477606b72609ba4d6efe83f7c442 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDc4OjIyRjUyRTo3QjJDNDpBNkM1Qzo2OTZBNkNBQyIsInZpc2l0b3JfaWQiOiIyNDQyOTY2MTY0MDk4OTM1OTgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0aaecef12ee36ef6d16a3c5d5b6546356c27a1b81a06e79f2a27520b479fa305 |
| hovercard-subject-tag | pull_request:2930312869 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/6199/checks |
| twitter:image | https://avatars.githubusercontent.com/u/27040963?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/27040963?s=400&v=4 |
| og:image:alt | Add proper init validation for sqlite3.Connection to ensure base class init is called before using connection methods. This fixes the test_connection_constructor_call_check test case. Changes: Mod... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6fea32d5b7276b841b7a803796d9715bc6cfb31ed549fdf9de2948ac25d12ba6 |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f2d9f6432a5a115ec709295ae70623f33bb80aee |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width