René's URL Explorer Experiment


Title: Fix __class__ by BenLewis-Seequent · Pull Request #619 · RustPython/RustPython · GitHub

Open Graph Title: Fix __class__ by BenLewis-Seequent · Pull Request #619 · RustPython/RustPython

X Title: Fix __class__ by BenLewis-Seequent · Pull Request #619 · RustPython/RustPython

Description: A Python Interpreter written in Rust. Contribute to RustPython/RustPython development by creating an account on GitHub.

Open Graph Description: Fixes #583 Moves the __class__ property to object, so lookup of it works properly, this matches CPython. Also to make lookup work the property has to have a __set__ method, at this point it always ...

X Description: Fixes #583 Moves the __class__ property to object, so lookup of it works properly, this matches CPython. Also to make lookup work the property has to have a __set__ method, at this point it always ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/619

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8496df40-484e-2ca4-a7a9-13f3620633c0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCEDC:607CA:10DE4B0:184806C:6A58A275
html-safe-nonce8893560a29f0f9607f34e0c172cc880f5f56d08121d874f9d3ef70193032897f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRURDOjYwN0NBOjEwREU0QjA6MTg0ODA2Qzo2QTU4QTI3NSIsInZpc2l0b3JfaWQiOiI5MTI1OTM2NDg3ODcxMzI0Nzg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8333547babed6371ae84c9b03e29a539948f873434ed4846534e48e12c2b7ae5
hovercard-subject-tagpull_request:259009173
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/619/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/02fd5f8d242b345e1b0b7412f4c85d8784e1f1a7b19a1ff426f55d8b66dcebd0/RustPython/RustPython/pull/619
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/02fd5f8d242b345e1b0b7412f4c85d8784e1f1a7b19a1ff426f55d8b66dcebd0/RustPython/RustPython/pull/619
og:image:altFixes #583 Moves the __class__ property to object, so lookup of it works properly, this matches CPython. Also to make lookup work the property has to have a __set__ method, at this point it always ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBenLewis-Seequent
hostnamegithub.com
expected-hostnamegithub.com
None5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6
turbo-cache-controlno-cache
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/619#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F619
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F619
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/619
Reloadhttps://github.com/RustPython/RustPython/pull/619
Reloadhttps://github.com/RustPython/RustPython/pull/619
Please reload this pagehttps://github.com/RustPython/RustPython/pull/619
RustPython https://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Notifications https://github.com/login?return_to=%2FRustPython%2FRustPython
Fork 1.5k https://github.com/login?return_to=%2FRustPython%2FRustPython
Star 22.2k https://github.com/login?return_to=%2FRustPython%2FRustPython
Code https://github.com/RustPython/RustPython
Issues 287 https://github.com/RustPython/RustPython/issues
Pull requests 101 https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality 0 https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
Code https://github.com/RustPython/RustPython
Issues https://github.com/RustPython/RustPython/issues
Pull requests https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
cthulahoopshttps://github.com/cthulahoops
RustPython:masterhttps://github.com/RustPython/RustPython/tree/master
BenLewis-Seequent:class_propertyhttps://github.com/BenLewis-Seequent/RustPython/tree/class_property
Conversationhttps://github.com/RustPython/RustPython/pull/619
Commits4 (4)https://github.com/RustPython/RustPython/pull/619/commits
Checkshttps://github.com/RustPython/RustPython/pull/619/checks
Files changedhttps://github.com/RustPython/RustPython/pull/619/files
Fix __class__https://github.com/RustPython/RustPython/pull/619#top
cthulahoopshttps://github.com/cthulahoops
RustPython:masterhttps://github.com/RustPython/RustPython/tree/master
BenLewis-Seequent:class_propertyhttps://github.com/BenLewis-Seequent/RustPython/tree/class_property
https://github.com/BenLewis-Seequent
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
Mar 7, 2019https://github.com/RustPython/RustPython/pull/619#issue-418175880
#583https://github.com/RustPython/RustPython/issues/583
Please reload this pagehttps://github.com/RustPython/RustPython/pull/619
skinnyBathttps://github.com/skinnyBat
March 7, 2019 20:47https://github.com/RustPython/RustPython/pull/619#commits-pushed-9d03abf
https://github.com/skinnyBat
Move __class__ attribute to object to make it work in more situationshttps://github.com/RustPython/RustPython/pull/619/commits/9d03abf652dca9f1606121570a82d63527b458c2
9d03abfhttps://github.com/RustPython/RustPython/pull/619/commits/9d03abf652dca9f1606121570a82d63527b458c2
https://github.com/skinnyBat
Convert __class__ descriptor to use new style functionshttps://github.com/RustPython/RustPython/pull/619/commits/720bec2f4f480b8520736b7c5a95fa4b406855a9
720bec2https://github.com/RustPython/RustPython/pull/619/commits/720bec2f4f480b8520736b7c5a95fa4b406855a9
https://github.com/codecov-io
codecov-iohttps://github.com/codecov-io
Mar 7, 2019https://github.com/RustPython/RustPython/pull/619#issuecomment-470430355
Please reload this pagehttps://github.com/RustPython/RustPython/pull/619
Codecovhttps://codecov.io/gh/RustPython/RustPython/pull/619?src=pr&el=h1
#619https://codecov.io/gh/RustPython/RustPython/pull/619?src=pr&el=desc
masterhttps://codecov.io/gh/RustPython/RustPython/commit/d7f8961a120f0dbe6f65c23707464846c77d0688?src=pr&el=desc
https://codecov.io/gh/RustPython/RustPython/pull/619?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/RustPython/RustPython/pull/619?src=pr&el=tree
vm/src/obj/objtype.rshttps://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmp0eXBlLnJz
vm/src/obj/objobject.rshttps://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmpvYmplY3QucnM=
vm/src/obj/objfunction.rshttps://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmpmdW5jdGlvbi5ycw==
vm/src/pyobject.rshttps://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL3B5b2JqZWN0LnJz
vm/src/obj/objfloat.rshttps://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmpmbG9hdC5ycw==
vm/src/obj/objbool.rshttps://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmpib29sLnJz
vm/src/obj/objrange.rshttps://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmpyYW5nZS5ycw==
vm/src/obj/objsequence.rshttps://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmpzZXF1ZW5jZS5ycw==
vm/src/function.rshttps://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL2Z1bmN0aW9uLnJz
9 morehttps://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree-more
Continue to review full report at Codecovhttps://codecov.io/gh/RustPython/RustPython/pull/619?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/RustPython/RustPython/pull/619?src=pr&el=footer
d7f8961...4b1cd72https://codecov.io/gh/RustPython/RustPython/pull/619?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/RustPython/RustPython/pull/619
https://github.com/OddCoincidence
OddCoincidencehttps://github.com/OddCoincidence
Mar 7, 2019 https://github.com/RustPython/RustPython/pull/619#pullrequestreview-211893449
View reviewed changes https://github.com/RustPython/RustPython/pull/619/files/720bec2f4f480b8520736b7c5a95fa4b406855a9
vm/src/obj/objfunction.rshttps://github.com/RustPython/RustPython/pull/619/files/720bec2f4f480b8520736b7c5a95fa4b406855a9#diff-eb175989654a293391bc5198ba14c8a0b1cdc38e850226cd90598f5a18048524
Please reload this pagehttps://github.com/RustPython/RustPython/pull/619
https://github.com/skinnyBat
Remove debug statementshttps://github.com/RustPython/RustPython/pull/619/commits/f2f0f1d7429d01dc434de122c4293c5bf1d1d673
f2f0f1dhttps://github.com/RustPython/RustPython/pull/619/commits/f2f0f1d7429d01dc434de122c4293c5bf1d1d673
https://github.com/cthulahoops
cthulahoopshttps://github.com/cthulahoops
Mar 7, 2019https://github.com/RustPython/RustPython/pull/619#issuecomment-470618921
Please reload this pagehttps://github.com/RustPython/RustPython/pull/619
https://github.com/cthulahoops
cthulahoopshttps://github.com/cthulahoops
Mar 7, 2019 https://github.com/RustPython/RustPython/pull/619#pullrequestreview-211919547
View reviewed changes https://github.com/RustPython/RustPython/pull/619/files/f2f0f1d7429d01dc434de122c4293c5bf1d1d673
vm/src/obj/objobject.rshttps://github.com/RustPython/RustPython/pull/619/files/f2f0f1d7429d01dc434de122c4293c5bf1d1d673#diff-f68d8eb04b2ffda267001c9cedd61d225e47d736485315b06bafff5fb4a619cc
Please reload this pagehttps://github.com/RustPython/RustPython/pull/619
https://github.com/BenLewis-Seequent
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
Mar 7, 2019https://github.com/RustPython/RustPython/pull/619#issuecomment-470633864
Please reload this pagehttps://github.com/RustPython/RustPython/pull/619
https://github.com/cthulahoops
cthulahoopshttps://github.com/cthulahoops
Mar 7, 2019https://github.com/RustPython/RustPython/pull/619#issuecomment-470662911
Please reload this pagehttps://github.com/RustPython/RustPython/pull/619
https://github.com/skinnyBat
Add todo for using PyClassRef when that landshttps://github.com/RustPython/RustPython/pull/619/commits/4b1cd723558227c7d053e91263a75a6c51715f90
4b1cd72https://github.com/RustPython/RustPython/pull/619/commits/4b1cd723558227c7d053e91263a75a6c51715f90
https://github.com/cthulahoops
cthulahoopshttps://github.com/cthulahoops
406ec46https://github.com/RustPython/RustPython/commit/406ec46ce896e727214e2b8aef097779724acf45
Mar 8, 2019https://github.com/RustPython/RustPython/pull/619#event-2189316080
https://github.com/BenLewis-Seequent
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
Mar 9, 2019 https://github.com/RustPython/RustPython/pull/619#ref-pullrequest-419026534
Unify property like objects #635 https://github.com/RustPython/RustPython/pull/635
https://github.com/BenLewis-Seequent
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
March 29, 2019 06:04https://github.com/RustPython/RustPython/pull/619#event-2238306321
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F619
https://github.com/cthulahoops
cthulahoops https://github.com/cthulahoops
https://github.com/RustPython/RustPython/pull/619/files/f2f0f1d7429d01dc434de122c4293c5bf1d1d673
https://github.com/OddCoincidence
OddCoincidence https://github.com/OddCoincidence
https://github.com/RustPython/RustPython/pull/619/files/720bec2f4f480b8520736b7c5a95fa4b406855a9
Please reload this pagehttps://github.com/RustPython/RustPython/pull/619
https://github.com/BenLewis-Seequent
https://github.com/codecov-io
https://github.com/cthulahoops
https://github.com/OddCoincidence
https://github.com/skinnyBat
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.