| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8496df40-484e-2ca4-a7a9-13f3620633c0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CEDC:607CA:10DE4B0:184806C:6A58A275 |
| html-safe-nonce | 8893560a29f0f9607f34e0c172cc880f5f56d08121d874f9d3ef70193032897f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRURDOjYwN0NBOjEwREU0QjA6MTg0ODA2Qzo2QTU4QTI3NSIsInZpc2l0b3JfaWQiOiI5MTI1OTM2NDg3ODcxMzI0Nzg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8333547babed6371ae84c9b03e29a539948f873434ed4846534e48e12c2b7ae5 |
| hovercard-subject-tag | pull_request:259009173 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/619/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/02fd5f8d242b345e1b0b7412f4c85d8784e1f1a7b19a1ff426f55d8b66dcebd0/RustPython/RustPython/pull/619 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/02fd5f8d242b345e1b0b7412f4c85d8784e1f1a7b19a1ff426f55d8b66dcebd0/RustPython/RustPython/pull/619 |
| og:image:alt | Fixes #583
Moves the __class__ property to object, so lookup of it works properly, this matches CPython. Also to make lookup work the property has to have a __set__ method, at this point it always ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | BenLewis-Seequent |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6 |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/RustPython/RustPython/pull/619#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F619 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F619 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/619 |
| Reload | https://github.com/RustPython/RustPython/pull/619 |
| Reload | https://github.com/RustPython/RustPython/pull/619 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/619 |
|
RustPython
| https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
|
Notifications
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Fork
1.5k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Star
22.2k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
287
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
101
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security and quality
0
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security and quality
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
| cthulahoops | https://github.com/cthulahoops |
| RustPython:master | https://github.com/RustPython/RustPython/tree/master |
| BenLewis-Seequent:class_property | https://github.com/BenLewis-Seequent/RustPython/tree/class_property |
| Conversation | https://github.com/RustPython/RustPython/pull/619 |
| Commits4 (4) | https://github.com/RustPython/RustPython/pull/619/commits |
| Checks | https://github.com/RustPython/RustPython/pull/619/checks |
| Files changed | https://github.com/RustPython/RustPython/pull/619/files |
| Fix __class__ | https://github.com/RustPython/RustPython/pull/619#top |
| cthulahoops | https://github.com/cthulahoops |
| RustPython:master | https://github.com/RustPython/RustPython/tree/master |
| BenLewis-Seequent:class_property | https://github.com/BenLewis-Seequent/RustPython/tree/class_property |
|
| https://github.com/BenLewis-Seequent |
| BenLewis-Seequent | https://github.com/BenLewis-Seequent |
| Mar 7, 2019 | https://github.com/RustPython/RustPython/pull/619#issue-418175880 |
| #583 | https://github.com/RustPython/RustPython/issues/583 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/619 |
| skinnyBat | https://github.com/skinnyBat |
| March 7, 2019 20:47 | https://github.com/RustPython/RustPython/pull/619#commits-pushed-9d03abf |
|
| https://github.com/skinnyBat |
| Move __class__ attribute to object to make it work in more situations | https://github.com/RustPython/RustPython/pull/619/commits/9d03abf652dca9f1606121570a82d63527b458c2 |
| 9d03abf | https://github.com/RustPython/RustPython/pull/619/commits/9d03abf652dca9f1606121570a82d63527b458c2 |
|
| https://github.com/skinnyBat |
| Convert __class__ descriptor to use new style functions | https://github.com/RustPython/RustPython/pull/619/commits/720bec2f4f480b8520736b7c5a95fa4b406855a9 |
| 720bec2 | https://github.com/RustPython/RustPython/pull/619/commits/720bec2f4f480b8520736b7c5a95fa4b406855a9 |
| https://github.com/codecov-io |
| codecov-io | https://github.com/codecov-io |
| Mar 7, 2019 | https://github.com/RustPython/RustPython/pull/619#issuecomment-470430355 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/619 |
| Codecov | https://codecov.io/gh/RustPython/RustPython/pull/619?src=pr&el=h1 |
| #619 | https://codecov.io/gh/RustPython/RustPython/pull/619?src=pr&el=desc |
| master | https://codecov.io/gh/RustPython/RustPython/commit/d7f8961a120f0dbe6f65c23707464846c77d0688?src=pr&el=desc |
| https://codecov.io/gh/RustPython/RustPython/pull/619?src=pr&el=tree |
| Impacted Files | https://codecov.io/gh/RustPython/RustPython/pull/619?src=pr&el=tree |
| vm/src/obj/objtype.rs | https://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmp0eXBlLnJz |
| vm/src/obj/objobject.rs | https://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmpvYmplY3QucnM= |
| vm/src/obj/objfunction.rs | https://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmpmdW5jdGlvbi5ycw== |
| vm/src/pyobject.rs | https://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL3B5b2JqZWN0LnJz |
| vm/src/obj/objfloat.rs | https://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmpmbG9hdC5ycw== |
| vm/src/obj/objbool.rs | https://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmpib29sLnJz |
| vm/src/obj/objrange.rs | https://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmpyYW5nZS5ycw== |
| vm/src/obj/objsequence.rs | https://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmpzZXF1ZW5jZS5ycw== |
| vm/src/function.rs | https://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree#diff-dm0vc3JjL2Z1bmN0aW9uLnJz |
| 9 more | https://codecov.io/gh/RustPython/RustPython/pull/619/diff?src=pr&el=tree-more |
| Continue to review full report at Codecov | https://codecov.io/gh/RustPython/RustPython/pull/619?src=pr&el=continue |
| Click here to learn more | https://docs.codecov.io/docs/codecov-delta |
| Codecov | https://codecov.io/gh/RustPython/RustPython/pull/619?src=pr&el=footer |
| d7f8961...4b1cd72 | https://codecov.io/gh/RustPython/RustPython/pull/619?src=pr&el=lastupdated |
| comment docs | https://docs.codecov.io/docs/pull-request-comments |
| Please reload this page | https://github.com/RustPython/RustPython/pull/619 |
| https://github.com/OddCoincidence |
| OddCoincidence | https://github.com/OddCoincidence |
|
Mar 7, 2019
| https://github.com/RustPython/RustPython/pull/619#pullrequestreview-211893449 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/619/files/720bec2f4f480b8520736b7c5a95fa4b406855a9 |
| vm/src/obj/objfunction.rs | https://github.com/RustPython/RustPython/pull/619/files/720bec2f4f480b8520736b7c5a95fa4b406855a9#diff-eb175989654a293391bc5198ba14c8a0b1cdc38e850226cd90598f5a18048524 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/619 |
|
| https://github.com/skinnyBat |
| Remove debug statements | https://github.com/RustPython/RustPython/pull/619/commits/f2f0f1d7429d01dc434de122c4293c5bf1d1d673 |
| f2f0f1d | https://github.com/RustPython/RustPython/pull/619/commits/f2f0f1d7429d01dc434de122c4293c5bf1d1d673 |
| https://github.com/cthulahoops |
| cthulahoops | https://github.com/cthulahoops |
| Mar 7, 2019 | https://github.com/RustPython/RustPython/pull/619#issuecomment-470618921 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/619 |
| https://github.com/cthulahoops |
| cthulahoops | https://github.com/cthulahoops |
|
Mar 7, 2019
| https://github.com/RustPython/RustPython/pull/619#pullrequestreview-211919547 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/619/files/f2f0f1d7429d01dc434de122c4293c5bf1d1d673 |
| vm/src/obj/objobject.rs | https://github.com/RustPython/RustPython/pull/619/files/f2f0f1d7429d01dc434de122c4293c5bf1d1d673#diff-f68d8eb04b2ffda267001c9cedd61d225e47d736485315b06bafff5fb4a619cc |
| Please reload this page | https://github.com/RustPython/RustPython/pull/619 |
| https://github.com/BenLewis-Seequent |
| BenLewis-Seequent | https://github.com/BenLewis-Seequent |
| Mar 7, 2019 | https://github.com/RustPython/RustPython/pull/619#issuecomment-470633864 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/619 |
| https://github.com/cthulahoops |
| cthulahoops | https://github.com/cthulahoops |
| Mar 7, 2019 | https://github.com/RustPython/RustPython/pull/619#issuecomment-470662911 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/619 |
|
| https://github.com/skinnyBat |
| Add todo for using PyClassRef when that lands | https://github.com/RustPython/RustPython/pull/619/commits/4b1cd723558227c7d053e91263a75a6c51715f90 |
| 4b1cd72 | https://github.com/RustPython/RustPython/pull/619/commits/4b1cd723558227c7d053e91263a75a6c51715f90 |
| https://github.com/cthulahoops |
| cthulahoops | https://github.com/cthulahoops |
| 406ec46 | https://github.com/RustPython/RustPython/commit/406ec46ce896e727214e2b8aef097779724acf45 |
| Mar 8, 2019 | https://github.com/RustPython/RustPython/pull/619#event-2189316080 |
| https://github.com/BenLewis-Seequent |
| BenLewis-Seequent | https://github.com/BenLewis-Seequent |
|
Mar 9, 2019
| https://github.com/RustPython/RustPython/pull/619#ref-pullrequest-419026534 |
|
Unify property like objects
#635
| https://github.com/RustPython/RustPython/pull/635 |
| https://github.com/BenLewis-Seequent |
| BenLewis-Seequent | https://github.com/BenLewis-Seequent |
| March 29, 2019 06:04 | https://github.com/RustPython/RustPython/pull/619#event-2238306321 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F619 |
|
| https://github.com/cthulahoops |
|
cthulahoops
| https://github.com/cthulahoops |
|
| https://github.com/RustPython/RustPython/pull/619/files/f2f0f1d7429d01dc434de122c4293c5bf1d1d673 |
|
| https://github.com/OddCoincidence |
|
OddCoincidence
| https://github.com/OddCoincidence |
|
| https://github.com/RustPython/RustPython/pull/619/files/720bec2f4f480b8520736b7c5a95fa4b406855a9 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/619 |
|
| https://github.com/BenLewis-Seequent |
|
| https://github.com/codecov-io |
|
| https://github.com/cthulahoops |
|
| https://github.com/OddCoincidence |
|
| https://github.com/skinnyBat |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |