Title: Apply clippy suggestions to switch to let chains by coolreader18 · Pull Request #6126 · RustPython/RustPython · GitHub
Open Graph Title: Apply clippy suggestions to switch to let chains by coolreader18 · Pull Request #6126 · RustPython/RustPython
X Title: Apply clippy suggestions to switch to let chains by coolreader18 · Pull Request #6126 · RustPython/RustPython
Description: Raising the rust-version to 1.89 prompts clippy to start recommending replacing nested if lets with let chains. This is the result of doing exactly that and running cargo clippy --fix --workspace. It's a big diff but I think the prevented rightward creep really does aid in clarity. Reviewed well with whitespace-insensitivity turned on. Summary by CodeRabbit Refactor Simplified and consolidated many internal conditional checks across the compiler, VM, stdlib, JIT, WASM, and tooling to improve readability; no behavioral or API changes. Chores Raised the workspace minimum Rust compiler version to 1.89.0. Notes No user-facing feature or bug fix; runtime behavior unchanged. Developers must build with Rust 1.89.0 or newer.
Open Graph Description: Raising the rust-version to 1.89 prompts clippy to start recommending replacing nested if lets with let chains. This is the result of doing exactly that and running cargo clippy --fix --workspace. ...
X Description: Raising the rust-version to 1.89 prompts clippy to start recommending replacing nested if lets with let chains. This is the result of doing exactly that and running cargo clippy --fix --workspace. ...
Opengraph URL: https://github.com/RustPython/RustPython/pull/6126
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5a368477-ef76-c34c-12a8-1867c5b30798 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8920:22EDB8:2B44814:39042BF:696B2EF5 |
| html-safe-nonce | 81bf45dd3b9263dc60e66043b6a3efffde4349f0fe829b62464afd3001ac98f3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTIwOjIyRURCODoyQjQ0ODE0OjM5MDQyQkY6Njk2QjJFRjUiLCJ2aXNpdG9yX2lkIjoiNDI1NjYyMzE2OTc3OTc0MDQwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cbe0e7ba5f980fd20cee6bbfd723f03cd60a4b0c9d503820fb9fb2c3b046d362 |
| hovercard-subject-tag | pull_request:2797946554 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/6126/files |
| twitter:image | https://avatars.githubusercontent.com/u/33094578?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/33094578?s=400&v=4 |
| og:image:alt | Raising the rust-version to 1.89 prompts clippy to start recommending replacing nested if lets with let chains. This is the result of doing exactly that and running cargo clippy --fix --workspace. ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width