Title: Apply clippy suggestions to switch to let chains by coolreader18 · Pull Request #6126 · RustPython/RustPython · GitHub
Open Graph Title: Apply clippy suggestions to switch to let chains by coolreader18 · Pull Request #6126 · RustPython/RustPython
X Title: Apply clippy suggestions to switch to let chains by coolreader18 · Pull Request #6126 · RustPython/RustPython
Description: Raising the rust-version to 1.89 prompts clippy to start recommending replacing nested if lets with let chains. This is the result of doing exactly that and running cargo clippy --fix --workspace. It's a big diff but I think the prevented rightward creep really does aid in clarity. Reviewed well with whitespace-insensitivity turned on. Summary by CodeRabbit Refactor Simplified and consolidated many internal conditional checks across the compiler, VM, stdlib, JIT, WASM, and tooling to improve readability; no behavioral or API changes. Chores Raised the workspace minimum Rust compiler version to 1.89.0. Notes No user-facing feature or bug fix; runtime behavior unchanged. Developers must build with Rust 1.89.0 or newer.
Open Graph Description: Raising the rust-version to 1.89 prompts clippy to start recommending replacing nested if lets with let chains. This is the result of doing exactly that and running cargo clippy --fix --workspace. ...
X Description: Raising the rust-version to 1.89 prompts clippy to start recommending replacing nested if lets with let chains. This is the result of doing exactly that and running cargo clippy --fix --workspace. ...
Opengraph URL: https://github.com/RustPython/RustPython/pull/6126
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:be8e1162-8bb7-7502-47ad-bd2f59d7a64b |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | C54E:23348E:2111A50:2BBD51B:696B0DAC |
| html-safe-nonce | 46e1a00e2714f1dbf82391aa22ca516cfa53d45c033e35e1d5277ccedc38ca43 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTRFOjIzMzQ4RToyMTExQTUwOjJCQkQ1MUI6Njk2QjBEQUMiLCJ2aXNpdG9yX2lkIjoiNTU2MTEyMTI2NDMzMjYzOTY2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f943c2c2ada96738b992770d9f9a404625a4727447ab7c88f51e2f88f0906bf7 |
| hovercard-subject-tag | pull_request:2797946554 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/6126/checks |
| twitter:image | https://avatars.githubusercontent.com/u/33094578?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/33094578?s=400&v=4 |
| og:image:alt | Raising the rust-version to 1.89 prompts clippy to start recommending replacing nested if lets with let chains. This is the result of doing exactly that and running cargo clippy --fix --workspace. ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width