Title: Replace `compiler::source` module with `ruff_source_file` by ShaharNaveh · Pull Request #6016 · RustPython/RustPython · GitHub
Open Graph Title: Replace `compiler::source` module with `ruff_source_file` by ShaharNaveh · Pull Request #6016 · RustPython/RustPython
X Title: Replace `compiler::source` module with `ruff_source_file` by ShaharNaveh · Pull Request #6016 · RustPython/RustPython
Description: I saw that compiler/source was mainly re-exporting items from ruff_source_file, so I replaced it with the upstream ruff_source_file::SourceFile which is a bit better implementation of what we have currently as it's uses Arc internally so it's practically free to clone & replaces the need for a dedicated SourceCodeOwned as SourceFile is already owned. This PR contains a lot of noise as I renamed: source_code -> source_file SourceCode -> SourceFile SourceCodeOwned -> SourceFile Feel free to close this PR if this is an unwanted change. Summary by CodeRabbit Refactor Unified the handling of source code representation across the compiler and VM by replacing the previous type with a new, consistent type throughout all relevant modules and interfaces. Updated numerous method and function signatures to accept the new source type, improving maintainability and consistency. Deprecated and removed references to legacy source handling components. Adjusted dependencies to reflect the new approach and removed obsolete packages. Chores Reformatted configuration files and cleaned up commented-out or unused dependencies.
Open Graph Description: I saw that compiler/source was mainly re-exporting items from ruff_source_file, so I replaced it with the upstream ruff_source_file::SourceFile which is a bit better implementation of what we have ...
X Description: I saw that compiler/source was mainly re-exporting items from ruff_source_file, so I replaced it with the upstream ruff_source_file::SourceFile which is a bit better implementation of what we have ...
Opengraph URL: https://github.com/RustPython/RustPython/pull/6016
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e0c1bb94-89eb-c17b-585d-e60b09654aeb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CCAC:154180:108C5F9:15B0EB3:696B0E8E |
| html-safe-nonce | 09b45a9130eee10a93f77e71dd29a75894845104bc95ace7d83f7c6220cf5d7e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0FDOjE1NDE4MDoxMDhDNUY5OjE1QjBFQjM6Njk2QjBFOEUiLCJ2aXNpdG9yX2lkIjoiMzE1NjY5OTQxNDEyMTg3NzEzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7e5da89299c7550c03231bf30ec3c41e42b1e152ec47d262dfad94c130d99852 |
| hovercard-subject-tag | pull_request:2683258526 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/6016/files |
| twitter:image | https://avatars.githubusercontent.com/u/50263213?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/50263213?s=400&v=4 |
| og:image:alt | I saw that compiler/source was mainly re-exporting items from ruff_source_file, so I replaced it with the upstream ruff_source_file::SourceFile which is a bit better implementation of what we have ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width