| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8899d551-39cb-fb52-8bc7-1c0d7d29793e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A4D4:2A4B31:198D5B:22A820:6B0020D7 |
| html-safe-nonce | 25cb2fad42131533d90a4b6640b0b4dd305d7ee6f6286b566fba87bc1d94dc48 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEQ0OjJBNEIzMToxOThENUI6MjJBODIwOjZCMDAyMEQ3IiwidmlzaXRvcl9pZCI6IjgyNDIxMzUwMzEyOTI2MzMzMDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fabe95618cb4f477c05116860e5fcc8bc47db9984a6eb3d24b9c7049a2a0bbfc |
| hovercard-subject-tag | pull_request:2420865785 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/5629/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/afdf7a4814127660556f7d3860a48fc4c6e5ff85072b2e5cc4a95ccc40c3fc77/RustPython/RustPython/pull/5629 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/afdf7a4814127660556f7d3860a48fc4c6e5ff85072b2e5cc4a95ccc40c3fc77/RustPython/RustPython/pull/5629 |
| og:image:alt | Because ruff represents string literals as str, we have to reparse every string that might have a surrogate \uDXXX escape as wtf8. Then there were a bunch of crashes to fix, because surrogate strin... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | coolreader18 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/RustPython/RustPython/pull/5629#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5629 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5629 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/5629 |
| Reload | https://github.com/RustPython/RustPython/pull/5629 |
| Reload | https://github.com/RustPython/RustPython/pull/5629 |
| RustPython | https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
| Code | https://github.com/RustPython/RustPython |
| Issues195 (195) | https://github.com/RustPython/RustPython/issues |
| Pull requests144 (144) | https://github.com/RustPython/RustPython/pulls |
| Discussions | https://github.com/RustPython/RustPython/discussions |
| Actions | https://github.com/RustPython/RustPython/actions |
| Projects | https://github.com/RustPython/RustPython/projects |
| Wiki | https://github.com/RustPython/RustPython/wiki |
| Security and quality | https://github.com/RustPython/RustPython/security |
| Insights | https://github.com/RustPython/RustPython/insights |
| https://github.com/RustPython/RustPython |
| coolreader18 | https://github.com/coolreader18 |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| coolreader18:surrogate-literals | https://github.com/coolreader18/RustPython/tree/surrogate-literals |
| Conversation | https://github.com/RustPython/RustPython/pull/5629 |
| Commits3 (3) | https://github.com/RustPython/RustPython/pull/5629/commits |
| Checks | https://github.com/RustPython/RustPython/pull/5629/checks |
| Files changed | https://github.com/RustPython/RustPython/pull/5629/files |
| Parse surrogates in string literals properly | https://github.com/RustPython/RustPython/pull/5629#top |
| coolreader18 | https://github.com/coolreader18 |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| coolreader18:surrogate-literals | https://github.com/coolreader18/RustPython/tree/surrogate-literals |
|
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| Mar 27, 2025 | https://github.com/RustPython/RustPython/pull/5629#issue-2951211821 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5629 |
|
| https://github.com/coolreader18 |
| Parse surrogates in string literals properly | https://github.com/RustPython/RustPython/pull/5629/commits/c6cab4c43af41368e03153afbd509bbd307de337 |
| c6cab4c | https://github.com/RustPython/RustPython/pull/5629/commits/c6cab4c43af41368e03153afbd509bbd307de337 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| force-pushed | https://github.com/RustPython/RustPython/compare/960e86cffe1e4abe21ace7fd1e5b0b20537c8037..b4e35586a26f7d5501d5729f9df31b137d298c60 |
| 960e86c | https://github.com/RustPython/RustPython/commit/960e86cffe1e4abe21ace7fd1e5b0b20537c8037 |
| b4e3558 | https://github.com/RustPython/RustPython/commit/b4e35586a26f7d5501d5729f9df31b137d298c60 |
|
Compare
| https://github.com/RustPython/RustPython/compare/960e86cffe1e4abe21ace7fd1e5b0b20537c8037..b4e35586a26f7d5501d5729f9df31b137d298c60 |
| March 27, 2025 03:48 | https://github.com/RustPython/RustPython/pull/5629#event-17004251752 |
|
| https://github.com/coolreader18 |
| Fix more surrogate crashes | https://github.com/RustPython/RustPython/pull/5629/commits/0a07cd931f5437f3f24201ee2dec6e4e431e52f6 |
| 0a07cd9 | https://github.com/RustPython/RustPython/pull/5629/commits/0a07cd931f5437f3f24201ee2dec6e4e431e52f6 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| force-pushed | https://github.com/RustPython/RustPython/compare/b4e35586a26f7d5501d5729f9df31b137d298c60..0a07cd931f5437f3f24201ee2dec6e4e431e52f6 |
| b4e3558 | https://github.com/RustPython/RustPython/commit/b4e35586a26f7d5501d5729f9df31b137d298c60 |
| 0a07cd9 | https://github.com/RustPython/RustPython/commit/0a07cd931f5437f3f24201ee2dec6e4e431e52f6 |
|
Compare
| https://github.com/RustPython/RustPython/compare/b4e35586a26f7d5501d5729f9df31b137d298c60..0a07cd931f5437f3f24201ee2dec6e4e431e52f6 |
| March 27, 2025 04:12 | https://github.com/RustPython/RustPython/pull/5629#event-17004574096 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
| March 27, 2025 04:29 | https://github.com/RustPython/RustPython/pull/5629#event-17004748621 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Mar 27, 2025 | https://github.com/RustPython/RustPython/pull/5629#issuecomment-2756642525 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5629 |
|
| https://github.com/apps/copilot-pull-request-reviewer |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
|
Mar 27, 2025
| https://github.com/RustPython/RustPython/pull/5629#pullrequestreview-2719620877 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6 |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
| https://github.com/RustPython/RustPython/pull/5629#pullrequestreview-2719620877 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5629 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| Mar 27, 2025 | https://github.com/RustPython/RustPython/pull/5629#issuecomment-2756677937 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5629 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Mar 27, 2025
| https://github.com/RustPython/RustPython/pull/5629#pullrequestreview-2719921345 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6 |
| common/src/wtf8/mod.rs | https://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6#diff-432c363a00cbbfa14e9e04ae98bdc76a465cbddef43fad201c601eb81b1d0ba6 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5629 |
| vm/src/stdlib/codecs.rs | https://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6#diff-d5b060eef44229ae13660184e8cb3fb02d387fd073a92c5ddd6defc53eee672b |
| youknowone | https://github.com/youknowone |
| Mar 27, 2025 | https://github.com/RustPython/RustPython/pull/5629#discussion_r2015977535 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5629 |
| compiler/codegen/src/string_parser.rs | https://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6#diff-68fc5c3cb2695fe64cce03f267d2a20ddc1b09c25a07fc93ed9905aefe847834 |
| youknowone | https://github.com/youknowone |
| Mar 27, 2025 | https://github.com/RustPython/RustPython/pull/5629#discussion_r2016027147 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5629 |
| coolreader18 | https://github.com/coolreader18 |
| Mar 27, 2025 | https://github.com/RustPython/RustPython/pull/5629#discussion_r2016910960 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5629 |
| fanninpm | https://github.com/fanninpm |
| Mar 27, 2025 | https://github.com/RustPython/RustPython/pull/5629#discussion_r2017427846 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @MichaReiser | https://github.com/MichaReiser |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5629 |
| MichaReiser | https://github.com/MichaReiser |
| Mar 27, 2025 | https://github.com/RustPython/RustPython/pull/5629#discussion_r2017483828 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| astral-sh/ruff#13666 | https://github.com/astral-sh/ruff/issues/13666 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5629 |
|
| https://github.com/coolreader18 |
|
| https://github.com/youknowone |
| Update common/src/wtf8/mod.rs | https://github.com/RustPython/RustPython/pull/5629/commits/dd467f6c73bc31e04c11f990b919014e298ee631 |
| dd467f6 | https://github.com/RustPython/RustPython/pull/5629/commits/dd467f6c73bc31e04c11f990b919014e298ee631 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| b6aacbf | https://github.com/RustPython/RustPython/commit/b6aacbf4016ec614b3508fd2778de4b3a29d4aef |
| Mar 27, 2025 | https://github.com/RustPython/RustPython/pull/5629#event-17015940959 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| March 27, 2025 15:15 | https://github.com/RustPython/RustPython/pull/5629#event-17015945839 |
| https://github.com/MichaReiser |
| MichaReiser | https://github.com/MichaReiser |
|
Mar 27, 2025
| https://github.com/RustPython/RustPython/pull/5629#ref-issue-2570926058 |
|
Surrogate code points are internally represented as U+FFFD REPLACEMENT CHARACTER
astral-sh/ruff#13666
| https://github.com/astral-sh/ruff/issues/13666 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Aug 25, 2026
| https://github.com/RustPython/RustPython/pull/5629#ref-pullrequest-5103856689 |
|
Make native parser the default
python/mypy#21823
| https://github.com/python/mypy/pull/21823 |
| https://github.com/YangSiJun528 |
| YangSiJun528 | https://github.com/YangSiJun528 |
|
Oct 6, 2026
| https://github.com/RustPython/RustPython/pull/5629#ref-issue-5723894128 |
|
Review issues that appear resolved for closure
#8982
| https://github.com/RustPython/RustPython/issues/8982 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5629 |
|
| https://github.com/fanninpm |
|
fanninpm
| https://github.com/fanninpm |
|
| https://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6 |
|
Copilot code review
| https://github.com/apps/copilot-pull-request-reviewer |
|
Copilot
| https://github.com/apps/copilot-pull-request-reviewer |
| Learn more about Copilot code review. | https://gh.io/copilot-code-review-docs |
|
| https://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6 |
|
| https://github.com/youknowone |
|
youknowone
| https://github.com/youknowone |
|
| https://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6 |
|
| https://github.com/MichaReiser |
|
MichaReiser
| https://github.com/MichaReiser |
|
| https://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5629 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5629 |
|
| https://github.com/coolreader18 |
|
| https://github.com/youknowone |
|
| https://github.com/MichaReiser |
|
| https://github.com/fanninpm |
|
| https://github.com/apps/copilot-pull-request-reviewer |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |