René's URL Explorer Experiment


Title: Parse surrogates in string literals properly by coolreader18 · Pull Request #5629 · RustPython/RustPython · GitHub

Open Graph Title: Parse surrogates in string literals properly by coolreader18 · Pull Request #5629 · RustPython/RustPython

X Title: Parse surrogates in string literals properly by coolreader18 · Pull Request #5629 · RustPython/RustPython

Description: A Python Interpreter written in Rust. Contribute to RustPython/RustPython development by creating an account on GitHub.

Open Graph Description: Because ruff represents string literals as str, we have to reparse every string that might have a surrogate \uDXXX escape as wtf8. Then there were a bunch of crashes to fix, because surrogate strin...

X Description: Because ruff represents string literals as str, we have to reparse every string that might have a surrogate \uDXXX escape as wtf8. Then there were a bunch of crashes to fix, because surrogate strin...

Opengraph URL: https://github.com/RustPython/RustPython/pull/5629

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8899d551-39cb-fb52-8bc7-1c0d7d29793e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA4D4:2A4B31:198D5B:22A820:6B0020D7
html-safe-nonce25cb2fad42131533d90a4b6640b0b4dd305d7ee6f6286b566fba87bc1d94dc48
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEQ0OjJBNEIzMToxOThENUI6MjJBODIwOjZCMDAyMEQ3IiwidmlzaXRvcl9pZCI6IjgyNDIxMzUwMzEyOTI2MzMzMDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfabe95618cb4f477c05116860e5fcc8bc47db9984a6eb3d24b9c7049a2a0bbfc
hovercard-subject-tagpull_request:2420865785
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/5629/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/afdf7a4814127660556f7d3860a48fc4c6e5ff85072b2e5cc4a95ccc40c3fc77/RustPython/RustPython/pull/5629
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/afdf7a4814127660556f7d3860a48fc4c6e5ff85072b2e5cc4a95ccc40c3fc77/RustPython/RustPython/pull/5629
og:image:altBecause ruff represents string literals as str, we have to reparse every string that might have a surrogate \uDXXX escape as wtf8. Then there were a bunch of crashes to fix, because surrogate strin...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecoolreader18
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/5629#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5629
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5629
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/5629
Reloadhttps://github.com/RustPython/RustPython/pull/5629
Reloadhttps://github.com/RustPython/RustPython/pull/5629
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests144 (144)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
https://github.com/RustPython/RustPython
coolreader18https://github.com/coolreader18
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
coolreader18:surrogate-literalshttps://github.com/coolreader18/RustPython/tree/surrogate-literals
Conversationhttps://github.com/RustPython/RustPython/pull/5629
Commits3 (3)https://github.com/RustPython/RustPython/pull/5629/commits
Checkshttps://github.com/RustPython/RustPython/pull/5629/checks
Files changedhttps://github.com/RustPython/RustPython/pull/5629/files
Parse surrogates in string literals properlyhttps://github.com/RustPython/RustPython/pull/5629#top
coolreader18https://github.com/coolreader18
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
coolreader18:surrogate-literalshttps://github.com/coolreader18/RustPython/tree/surrogate-literals
https://github.com/coolreader18
coolreader18https://github.com/coolreader18
Mar 27, 2025https://github.com/RustPython/RustPython/pull/5629#issue-2951211821
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5629
https://github.com/coolreader18
Parse surrogates in string literals properlyhttps://github.com/RustPython/RustPython/pull/5629/commits/c6cab4c43af41368e03153afbd509bbd307de337
c6cab4chttps://github.com/RustPython/RustPython/pull/5629/commits/c6cab4c43af41368e03153afbd509bbd307de337
https://github.com/coolreader18
coolreader18https://github.com/coolreader18
force-pushedhttps://github.com/RustPython/RustPython/compare/960e86cffe1e4abe21ace7fd1e5b0b20537c8037..b4e35586a26f7d5501d5729f9df31b137d298c60
960e86chttps://github.com/RustPython/RustPython/commit/960e86cffe1e4abe21ace7fd1e5b0b20537c8037
b4e3558https://github.com/RustPython/RustPython/commit/b4e35586a26f7d5501d5729f9df31b137d298c60
Compare https://github.com/RustPython/RustPython/compare/960e86cffe1e4abe21ace7fd1e5b0b20537c8037..b4e35586a26f7d5501d5729f9df31b137d298c60
March 27, 2025 03:48https://github.com/RustPython/RustPython/pull/5629#event-17004251752
https://github.com/coolreader18
Fix more surrogate crasheshttps://github.com/RustPython/RustPython/pull/5629/commits/0a07cd931f5437f3f24201ee2dec6e4e431e52f6
0a07cd9https://github.com/RustPython/RustPython/pull/5629/commits/0a07cd931f5437f3f24201ee2dec6e4e431e52f6
https://github.com/coolreader18
coolreader18https://github.com/coolreader18
force-pushedhttps://github.com/RustPython/RustPython/compare/b4e35586a26f7d5501d5729f9df31b137d298c60..0a07cd931f5437f3f24201ee2dec6e4e431e52f6
b4e3558https://github.com/RustPython/RustPython/commit/b4e35586a26f7d5501d5729f9df31b137d298c60
0a07cd9https://github.com/RustPython/RustPython/commit/0a07cd931f5437f3f24201ee2dec6e4e431e52f6
Compare https://github.com/RustPython/RustPython/compare/b4e35586a26f7d5501d5729f9df31b137d298c60..0a07cd931f5437f3f24201ee2dec6e4e431e52f6
March 27, 2025 04:12https://github.com/RustPython/RustPython/pull/5629#event-17004574096
https://github.com/youknowone
youknowonehttps://github.com/youknowone
Copilothttps://github.com/apps/copilot-pull-request-reviewer
March 27, 2025 04:29https://github.com/RustPython/RustPython/pull/5629#event-17004748621
https://github.com/youknowone
youknowonehttps://github.com/youknowone
Mar 27, 2025https://github.com/RustPython/RustPython/pull/5629#issuecomment-2756642525
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5629
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Mar 27, 2025 https://github.com/RustPython/RustPython/pull/5629#pullrequestreview-2719620877
View reviewed changes https://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/RustPython/RustPython/pull/5629#pullrequestreview-2719620877
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5629
https://github.com/coolreader18
coolreader18https://github.com/coolreader18
Mar 27, 2025https://github.com/RustPython/RustPython/pull/5629#issuecomment-2756677937
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5629
https://github.com/youknowone
youknowonehttps://github.com/youknowone
Mar 27, 2025 https://github.com/RustPython/RustPython/pull/5629#pullrequestreview-2719921345
View reviewed changes https://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6
common/src/wtf8/mod.rshttps://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6#diff-432c363a00cbbfa14e9e04ae98bdc76a465cbddef43fad201c601eb81b1d0ba6
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5629
vm/src/stdlib/codecs.rshttps://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6#diff-d5b060eef44229ae13660184e8cb3fb02d387fd073a92c5ddd6defc53eee672b
youknowonehttps://github.com/youknowone
Mar 27, 2025https://github.com/RustPython/RustPython/pull/5629#discussion_r2015977535
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5629
compiler/codegen/src/string_parser.rshttps://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6#diff-68fc5c3cb2695fe64cce03f267d2a20ddc1b09c25a07fc93ed9905aefe847834
youknowonehttps://github.com/youknowone
Mar 27, 2025https://github.com/RustPython/RustPython/pull/5629#discussion_r2016027147
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5629
coolreader18https://github.com/coolreader18
Mar 27, 2025https://github.com/RustPython/RustPython/pull/5629#discussion_r2016910960
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5629
fanninpmhttps://github.com/fanninpm
Mar 27, 2025https://github.com/RustPython/RustPython/pull/5629#discussion_r2017427846
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@MichaReiserhttps://github.com/MichaReiser
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5629
MichaReiserhttps://github.com/MichaReiser
Mar 27, 2025https://github.com/RustPython/RustPython/pull/5629#discussion_r2017483828
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
astral-sh/ruff#13666https://github.com/astral-sh/ruff/issues/13666
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5629
https://github.com/coolreader18
https://github.com/youknowone
Update common/src/wtf8/mod.rshttps://github.com/RustPython/RustPython/pull/5629/commits/dd467f6c73bc31e04c11f990b919014e298ee631
dd467f6https://github.com/RustPython/RustPython/pull/5629/commits/dd467f6c73bc31e04c11f990b919014e298ee631
https://github.com/coolreader18
coolreader18https://github.com/coolreader18
b6aacbfhttps://github.com/RustPython/RustPython/commit/b6aacbf4016ec614b3508fd2778de4b3a29d4aef
Mar 27, 2025https://github.com/RustPython/RustPython/pull/5629#event-17015940959
https://github.com/coolreader18
coolreader18https://github.com/coolreader18
March 27, 2025 15:15https://github.com/RustPython/RustPython/pull/5629#event-17015945839
https://github.com/MichaReiser
MichaReiserhttps://github.com/MichaReiser
Mar 27, 2025 https://github.com/RustPython/RustPython/pull/5629#ref-issue-2570926058
Surrogate code points are internally represented as U+FFFD REPLACEMENT CHARACTER astral-sh/ruff#13666 https://github.com/astral-sh/ruff/issues/13666
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
Aug 25, 2026 https://github.com/RustPython/RustPython/pull/5629#ref-pullrequest-5103856689
Make native parser the default python/mypy#21823 https://github.com/python/mypy/pull/21823
https://github.com/YangSiJun528
YangSiJun528https://github.com/YangSiJun528
Oct 6, 2026 https://github.com/RustPython/RustPython/pull/5629#ref-issue-5723894128
Review issues that appear resolved for closure #8982 https://github.com/RustPython/RustPython/issues/8982
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5629
https://github.com/fanninpm
fanninpm https://github.com/fanninpm
https://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
Learn more about Copilot code review.https://gh.io/copilot-code-review-docs
https://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6
https://github.com/youknowone
youknowone https://github.com/youknowone
https://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6
https://github.com/MichaReiser
MichaReiser https://github.com/MichaReiser
https://github.com/RustPython/RustPython/pull/5629/files/0a07cd931f5437f3f24201ee2dec6e4e431e52f6
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5629
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5629
https://github.com/coolreader18
https://github.com/youknowone
https://github.com/MichaReiser
https://github.com/fanninpm
https://github.com/apps/copilot-pull-request-reviewer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.