| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e7fb8528-e247-665c-295f-0e886df59fb1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B5C0:3A114F:F8224B:1527A3E:6971D662 |
| html-safe-nonce | 89af52fe6c0b2325a4ccf0fbb3c9600e1959bceb6ddd4e665b7532f776bb4966 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUMwOjNBMTE0RjpGODIyNEI6MTUyN0EzRTo2OTcxRDY2MiIsInZpc2l0b3JfaWQiOiI3MjUyODY0Mjc0Njk3MTQ4MDAyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 77dc81917101da7f53f35f0e315f88fd9b10c9e6f80a749ce7d8d170115a731f |
| hovercard-subject-tag | pull_request:2010827184 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/5390/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3ff91f1f3bbff0f31842984809b316efe41f25b366462d8e37a9ad1a9e54384a/RustPython/RustPython/pull/5390 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3ff91f1f3bbff0f31842984809b316efe41f25b366462d8e37a9ad1a9e54384a/RustPython/RustPython/pull/5390 |
| og:image:alt | originated from, and close #4875
also merge and close #4211 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | youknowone |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7476eb4140129667a7530d10cfb7688f701883e35a4dcaa4673e3ec599af5199 |
| turbo-cache-control | no-preview |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2cc0827c872b538cd08371730242ae4951d2d61a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/RustPython/RustPython/pull/5390#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5390 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5390 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/5390 |
| Reload | https://github.com/RustPython/RustPython/pull/5390 |
| Reload | https://github.com/RustPython/RustPython/pull/5390 |
|
RustPython
| https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
|
Notifications
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Fork
1.4k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Star
21.7k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
276
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
92
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
0
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/RustPython/RustPython/security |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5390 |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/RustPython/RustPython/pull/5390#issue-comment-box |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| youknowone:wasmbind | https://github.com/youknowone/RustPython/tree/wasmbind |
|
recreating wasmbind patch
| https://github.com/RustPython/RustPython/pull/5390#top |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| youknowone:wasmbind | https://github.com/youknowone/RustPython/tree/wasmbind |
|
Conversation
0
| https://github.com/RustPython/RustPython/pull/5390 |
|
Commits
13
| https://github.com/RustPython/RustPython/pull/5390/commits |
|
Checks
0
| https://github.com/RustPython/RustPython/pull/5390/checks |
|
Files changed
| https://github.com/RustPython/RustPython/pull/5390/files |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5390 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
|
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Aug 8, 2024 | https://github.com/RustPython/RustPython/pull/5390#issue-2456111759 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5390 |
| #4875 | https://github.com/RustPython/RustPython/pull/4875 |
| #4211 | https://github.com/RustPython/RustPython/pull/4211 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5390 |
| bdemann | https://github.com/bdemann |
| August 9, 2024 00:29 | https://github.com/RustPython/RustPython/pull/5390#commits-pushed-4f80d70 |
|
| https://github.com/bdemann |
|
| https://github.com/youknowone |
| add wasmbind feature | https://github.com/RustPython/RustPython/pull/5390/commits/4f80d7013ea035dd93fa88d0ef2102b41d6552c5 |
| 4f80d70 | https://github.com/RustPython/RustPython/pull/5390/commits/4f80d7013ea035dd93fa88d0ef2102b41d6552c5 |
|
| https://github.com/bdemann |
|
| https://github.com/youknowone |
| address pr notes | https://github.com/RustPython/RustPython/pull/5390/commits/f1dac5087ef88c9e30fb35479380233cd7e4a4ff |
| f1dac50 | https://github.com/RustPython/RustPython/pull/5390/commits/f1dac5087ef88c9e30fb35479380233cd7e4a4ff |
|
| https://github.com/bdemann |
|
| https://github.com/youknowone |
| run the first block if wasmbind is not present | https://github.com/RustPython/RustPython/pull/5390/commits/63c9909aa0af669e5a4167c8b1a7633a852fe1b2 |
| 63c9909 | https://github.com/RustPython/RustPython/pull/5390/commits/63c9909aa0af669e5a4167c8b1a7633a852fe1b2 |
|
| https://github.com/bdemann |
|
| https://github.com/youknowone |
| add cfg for not wasmbind for time | https://github.com/RustPython/RustPython/pull/5390/commits/dbb6794a41bdd03f409f90b308914764d08e93be |
| dbb6794 | https://github.com/RustPython/RustPython/pull/5390/commits/dbb6794a41bdd03f409f90b308914764d08e93be |
|
| https://github.com/bdemann |
|
| https://github.com/youknowone |
| enable js feature of getrandom only for wasmbind | https://github.com/RustPython/RustPython/pull/5390/commits/d8c35770ab429f6994f150b787746a020e998f9a |
| d8c3577 | https://github.com/RustPython/RustPython/pull/5390/commits/d8c35770ab429f6994f150b787746a020e998f9a |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Aug 8, 2024
| https://github.com/RustPython/RustPython/pull/5390#ref-pullrequest-1668956144 |
|
add wasmbind feature
#4875
| https://github.com/RustPython/RustPython/pull/4875 |
| youknowone | https://github.com/youknowone |
| August 9, 2024 00:58 | https://github.com/RustPython/RustPython/pull/5390#commits-pushed-d2a4a33 |
|
| https://github.com/youknowone |
| following chrono/wasmbind convention | https://github.com/RustPython/RustPython/pull/5390/commits/d2a4a330f9a319a680584f966c45d56a89524f34 |
| d2a4a33 | https://github.com/RustPython/RustPython/pull/5390/commits/d2a4a330f9a319a680584f966c45d56a89524f34 |
|
| https://github.com/youknowone |
| revert unnecessary change | https://github.com/RustPython/RustPython/pull/5390/commits/3f28309b7b7e81b82894ae45a65824146812d710 |
| 3f28309 | https://github.com/RustPython/RustPython/pull/5390/commits/3f28309b7b7e81b82894ae45a65824146812d710 |
|
| https://github.com/youknowone |
| rustpython_wasm uses the new feature | https://github.com/RustPython/RustPython/pull/5390/commits/b6e9a3f37e456319f4419a9e80846e6922142732 |
| b6e9a3f | https://github.com/RustPython/RustPython/pull/5390/commits/b6e9a3f37e456319f4419a9e80846e6922142732 |
|
| https://github.com/coolreader18 |
|
| https://github.com/youknowone |
| Make rustpython-vm compatible with non-js wasm32-unknown & add tests | https://github.com/RustPython/RustPython/pull/5390/commits/7dfb7604213301b6b01493dcf17b2c5f8fb58570 |
| 7dfb760 | https://github.com/RustPython/RustPython/pull/5390/commits/7dfb7604213301b6b01493dcf17b2c5f8fb58570 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/eadc47b3cfe4ba03afb94f071fddeaada00e1580..11c7f67d93a923355ee777af9e1eb32b428a15c0 |
| eadc47b | https://github.com/RustPython/RustPython/commit/eadc47b3cfe4ba03afb94f071fddeaada00e1580 |
| 11c7f67 | https://github.com/RustPython/RustPython/commit/11c7f67d93a923355ee777af9e1eb32b428a15c0 |
|
Compare
| https://github.com/RustPython/RustPython/compare/eadc47b3cfe4ba03afb94f071fddeaada00e1580..11c7f67d93a923355ee777af9e1eb32b428a15c0 |
| August 8, 2024 17:21 | https://github.com/RustPython/RustPython/pull/5390#event-13810090836 |
| youknowone | https://github.com/youknowone |
| August 9, 2024 02:23 | https://github.com/RustPython/RustPython/pull/5390#commits-pushed-a829827 |
|
| https://github.com/youknowone |
| fix getrandom | https://github.com/RustPython/RustPython/pull/5390/commits/a82982725e73441eb7ae122805ed653f9523c0e8 |
| a829827 | https://github.com/RustPython/RustPython/pull/5390/commits/a82982725e73441eb7ae122805ed653f9523c0e8 |
|
| https://github.com/youknowone |
| separate wasm-unknown-test | https://github.com/RustPython/RustPython/pull/5390/commits/fe63ca762f290c9eb1a25dc7f360c37fd12cd40d |
| fe63ca7 | https://github.com/RustPython/RustPython/pull/5390/commits/fe63ca762f290c9eb1a25dc7f360c37fd12cd40d |
|
| https://github.com/coolreader18 |
|
| https://github.com/youknowone |
| Fix compilation without compiler feature | https://github.com/RustPython/RustPython/pull/5390/commits/ea11d78995c281f4eeae0513d69d8d2eb127d855 |
| ea11d78 | https://github.com/RustPython/RustPython/pull/5390/commits/ea11d78995c281f4eeae0513d69d8d2eb127d855 |
|
| https://github.com/youknowone |
| apply suggestion | https://github.com/RustPython/RustPython/pull/5390/commits/42bba6920e0ab0e0fbd576d83229e5191d92444c |
| 42bba69 | https://github.com/RustPython/RustPython/pull/5390/commits/42bba6920e0ab0e0fbd576d83229e5191d92444c |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/11c7f67d93a923355ee777af9e1eb32b428a15c0..42bba6920e0ab0e0fbd576d83229e5191d92444c |
| 11c7f67 | https://github.com/RustPython/RustPython/commit/11c7f67d93a923355ee777af9e1eb32b428a15c0 |
| 42bba69 | https://github.com/RustPython/RustPython/commit/42bba6920e0ab0e0fbd576d83229e5191d92444c |
|
Compare
| https://github.com/RustPython/RustPython/compare/11c7f67d93a923355ee777af9e1eb32b428a15c0..42bba6920e0ab0e0fbd576d83229e5191d92444c |
| August 8, 2024 17:23 | https://github.com/RustPython/RustPython/pull/5390#event-13810115530 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| coolreader18 | https://github.com/coolreader18 |
| August 8, 2024 17:26 | https://github.com/RustPython/RustPython/pull/5390#event-13810145996 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| 060db59 | https://github.com/RustPython/RustPython/commit/060db5983cd921d1c11943f8fca4a8f90c59310a |
| Aug 9, 2024 | https://github.com/RustPython/RustPython/pull/5390#event-13814256905 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| August 9, 2024 00:37 | https://github.com/RustPython/RustPython/pull/5390#event-13814257031 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5390 |
|
| https://github.com/coolreader18 |
|
coolreader18
| https://github.com/coolreader18 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5390 |
|
| https://github.com/youknowone |
|
| https://github.com/bdemann |
|
| https://github.com/coolreader18 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |