| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2976e23a-af98-f666-4298-3545814798e8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8954:177D5B:302B058:3FABBA5:6B0029A9 |
| html-safe-nonce | 6c10534a7ed18e9c74b9a8e1c4922e8b041d67e2a9ba3ba9f06c4557838ffa95 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTU0OjE3N0Q1QjozMDJCMDU4OjNGQUJCQTU6NkIwMDI5QTkiLCJ2aXNpdG9yX2lkIjoiNDA4MjY4MzU3ODUwMzE0NTg5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e4819ece69d2033e4c8379113aefd5f1d3d9fcc67af2996df8e3a6932fca6a79 |
| hovercard-subject-tag | pull_request:1879519630 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/5334/files |
| twitter:image | https://avatars.githubusercontent.com/u/32135041?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/32135041?s=400&v=4 |
| og:image:alt | Added await in list comprehension.
The list comprehension turns into an awaitable, which is then awaited to get the final list value.
Closes #5315 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/RustPython/RustPython/pull/5334/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5334%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5334%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/5334/files |
| Reload | https://github.com/RustPython/RustPython/pull/5334/files |
| Reload | https://github.com/RustPython/RustPython/pull/5334/files |
| RustPython | https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
| Code | https://github.com/RustPython/RustPython |
| Issues195 (195) | https://github.com/RustPython/RustPython/issues |
| Pull requests144 (144) | https://github.com/RustPython/RustPython/pulls |
| Discussions | https://github.com/RustPython/RustPython/discussions |
| Actions | https://github.com/RustPython/RustPython/actions |
| Projects | https://github.com/RustPython/RustPython/projects |
| Wiki | https://github.com/RustPython/RustPython/wiki |
| Security and quality | https://github.com/RustPython/RustPython/security |
| Insights | https://github.com/RustPython/RustPython/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| hydrogen602:await-in-list-comprehension | https://github.com/hydrogen602/RustPython/tree/await-in-list-comprehension |
|
Conversation
15
| https://github.com/RustPython/RustPython/pull/5334 |
|
Commits
9
| https://github.com/RustPython/RustPython/pull/5334/commits |
|
Checks
0
| https://github.com/RustPython/RustPython/pull/5334/checks |
|
Files changed
| https://github.com/RustPython/RustPython/pull/5334/files |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334/files |
|
await in list comprehension
| https://github.com/RustPython/RustPython/pull/5334/files#top |
|
Show all changes
9 commits
| https://github.com/RustPython/RustPython/pull/5334/files |
|
461a511
await in list comprehension
hydrogen602 May 21, 2024
| https://github.com/RustPython/RustPython/pull/5334/commits/461a5112754b76b9c62b691f0386e743d1d68a8a |
|
e68475e
specific handling for generators
hydrogen602 May 22, 2024
| https://github.com/RustPython/RustPython/pull/5334/commits/e68475e9952d39e147ce4111a797290a4529f2f3 |
|
070c440
check if comprehension element contains await
hydrogen602 May 25, 2024
| https://github.com/RustPython/RustPython/pull/5334/commits/070c4408a43bf01defa14794b7eb024919b5b9a0 |
|
1ec93a9
add await if regular for, not async for
hydrogen602 May 25, 2024
| https://github.com/RustPython/RustPython/pull/5334/commits/1ec93a9587807e0bbbc346f51905daeb2198c950 |
|
83e84ae
testing of hopefully all async comprehension variants and tweaked log…
hydrogen602 May 26, 2024
| https://github.com/RustPython/RustPython/pull/5334/commits/83e84aee4772e94ee11ad94e88ffdf657ea66197 |
|
dc5f07f
force execution to pause in async gen
hydrogen602 May 26, 2024
| https://github.com/RustPython/RustPython/pull/5334/commits/dc5f07fa00c11e8cae08edd2e015eca7cb008f51 |
|
abd1fcc
fix for async for list comprehension
hydrogen602 May 27, 2024
| https://github.com/RustPython/RustPython/pull/5334/commits/abd1fcc0856eb4630dc8e31db2179ad2b96cf966 |
|
d03ff15
enable now-working test
hydrogen602 May 27, 2024
| https://github.com/RustPython/RustPython/pull/5334/commits/d03ff15b3e47e88c28c75c5d8bc2c4e13b8b0757 |
|
a32dd3c
rename test file
youknowone May 27, 2024
| https://github.com/RustPython/RustPython/pull/5334/commits/a32dd3c9d80e9257be3e76961430abd16f718c47 |
|
Clear filters
| https://github.com/RustPython/RustPython/pull/5334/files |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334/files |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334/files |
|
test_asyncgen.py
| https://github.com/RustPython/RustPython/pull/5334/files#diff-1da5f0220b91e20c669b0e63724b978d4cf603373c850fbdc705abb2d5937f40 |
|
compile.rs
| https://github.com/RustPython/RustPython/pull/5334/files#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
|
syntax_async_comprehension.py
| https://github.com/RustPython/RustPython/pull/5334/files#diff-385eb4ec2da600e3c8bb4d21762220767147fc0107206c7f3d1444f3961000bd |
| Lib/test/test_asyncgen.py | https://github.com/RustPython/RustPython/pull/5334/files#diff-1da5f0220b91e20c669b0e63724b978d4cf603373c850fbdc705abb2d5937f40 |
|
View file
| https://github.com/hydrogen602/RustPython/blob/a32dd3c9d80e9257be3e76961430abd16f718c47/Lib/test/test_asyncgen.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/5334/{{ revealButtonHref }} |
|
| https://github.com/RustPython/RustPython/pull/5334/files#diff-1da5f0220b91e20c669b0e63724b978d4cf603373c850fbdc705abb2d5937f40 |
|
| https://github.com/RustPython/RustPython/pull/5334/files#diff-1da5f0220b91e20c669b0e63724b978d4cf603373c850fbdc705abb2d5937f40 |
| compiler/codegen/src/compile.rs | https://github.com/RustPython/RustPython/pull/5334/files#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
|
View file
| https://github.com/hydrogen602/RustPython/blob/a32dd3c9d80e9257be3e76961430abd16f718c47/compiler/codegen/src/compile.rs |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/5334/{{ revealButtonHref }} |
|
| https://github.com/RustPython/RustPython/pull/5334/files#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
|
| https://github.com/RustPython/RustPython/pull/5334/files#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
|
| https://github.com/RustPython/RustPython/pull/5334/files#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
|
| https://github.com/RustPython/RustPython/pull/5334/files#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
|
| https://github.com/RustPython/RustPython/pull/5334/files#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
|
| https://github.com/RustPython/RustPython/pull/5334/files#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
|
| https://github.com/RustPython/RustPython/pull/5334/files#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
|
| https://github.com/RustPython/RustPython/pull/5334/files#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
|
| https://github.com/RustPython/RustPython/pull/5334/files#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
|
| https://github.com/RustPython/RustPython/pull/5334/files#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
|
| https://github.com/RustPython/RustPython/pull/5334/files#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
|
| https://github.com/RustPython/RustPython/pull/5334/files#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
|
| https://github.com/RustPython/RustPython/pull/5334/files#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
|
| https://github.com/RustPython/RustPython/pull/5334/files#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
|
| https://github.com/RustPython/RustPython/pull/5334/files#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |