| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e1392f08-d38d-5921-7869-6d4970cfc23a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9794:2F2EB9:2E24FC7:3D23249:6B002666 |
| html-safe-nonce | 54b7c747f99ff0c5104d2cb6ae69178eefd29d91a407e66d6c1bf31a5c87ea98 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Nzk0OjJGMkVCOToyRTI0RkM3OjNEMjMyNDk6NkIwMDI2NjYiLCJ2aXNpdG9yX2lkIjoiNTM3MzUyNDY1NTI4Mzk5NDYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | fcb9465f8d5cce644e7586d2deef3c534a95ba60195b40b1abd51b88dd6f6e67 |
| hovercard-subject-tag | pull_request:1879519630 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/5334/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b3e7f4e2614010401648808c0984962530cedb49354eda08973dcff8a5f8be2a/RustPython/RustPython/pull/5334 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b3e7f4e2614010401648808c0984962530cedb49354eda08973dcff8a5f8be2a/RustPython/RustPython/pull/5334 |
| og:image:alt | Added await in list comprehension.
The list comprehension turns into an awaitable, which is then awaited to get the final list value.
Closes #5315 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hydrogen602 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/RustPython/RustPython/pull/5334#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5334 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5334 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/5334 |
| Reload | https://github.com/RustPython/RustPython/pull/5334 |
| Reload | https://github.com/RustPython/RustPython/pull/5334 |
| RustPython | https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
| Code | https://github.com/RustPython/RustPython |
| Issues195 (195) | https://github.com/RustPython/RustPython/issues |
| Pull requests144 (144) | https://github.com/RustPython/RustPython/pulls |
| Discussions | https://github.com/RustPython/RustPython/discussions |
| Actions | https://github.com/RustPython/RustPython/actions |
| Projects | https://github.com/RustPython/RustPython/projects |
| Wiki | https://github.com/RustPython/RustPython/wiki |
| Security and quality | https://github.com/RustPython/RustPython/security |
| Insights | https://github.com/RustPython/RustPython/insights |
| https://github.com/RustPython/RustPython |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| hydrogen602:await-in-list-comprehension | https://github.com/hydrogen602/RustPython/tree/await-in-list-comprehension |
| Conversation | https://github.com/RustPython/RustPython/pull/5334 |
| Commits9 (9) | https://github.com/RustPython/RustPython/pull/5334/commits |
| Checks | https://github.com/RustPython/RustPython/pull/5334/checks |
| Files changed | https://github.com/RustPython/RustPython/pull/5334/files |
| await in list comprehension | https://github.com/RustPython/RustPython/pull/5334#top |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| hydrogen602:await-in-list-comprehension | https://github.com/hydrogen602/RustPython/tree/await-in-list-comprehension |
|
| https://github.com/hydrogen602 |
| hydrogen602 | https://github.com/hydrogen602 |
| May 21, 2024 | https://github.com/RustPython/RustPython/pull/5334#issue-2307266891 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| #5315 | https://github.com/RustPython/RustPython/issues/5315 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
|
| https://github.com/hydrogen602 |
| await in list comprehension | https://github.com/RustPython/RustPython/pull/5334/commits/461a5112754b76b9c62b691f0386e743d1d68a8a |
| 461a511 | https://github.com/RustPython/RustPython/pull/5334/commits/461a5112754b76b9c62b691f0386e743d1d68a8a |
| https://github.com/hydrogen602 |
| hydrogen602 | https://github.com/hydrogen602 |
| May 21, 2024 | https://github.com/RustPython/RustPython/pull/5334#issuecomment-2121778820 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| May 22, 2024 | https://github.com/RustPython/RustPython/pull/5334#issuecomment-2123793905 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| https://github.com/RustPython/RustPython/blob/main/vm/src/frame.rs#L977-L1047 | https://github.com/RustPython/RustPython/blob/main/vm/src/frame.rs#L977-L1047 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| https://github.com/hydrogen602 |
| hydrogen602 | https://github.com/hydrogen602 |
| May 22, 2024 | https://github.com/RustPython/RustPython/pull/5334#issuecomment-2123851702 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| #4859 | https://github.com/RustPython/RustPython/issues/4859 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
|
| https://github.com/hydrogen602 |
| specific handling for generators | https://github.com/RustPython/RustPython/pull/5334/commits/e68475e9952d39e147ce4111a797290a4529f2f3 |
| e68475e | https://github.com/RustPython/RustPython/pull/5334/commits/e68475e9952d39e147ce4111a797290a4529f2f3 |
| https://github.com/hydrogen602 |
| hydrogen602 | https://github.com/hydrogen602 |
| May 22, 2024 | https://github.com/RustPython/RustPython/pull/5334#issuecomment-2124618843 |
| @youknowone | https://github.com/youknowone |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| May 24, 2024 | https://github.com/RustPython/RustPython/pull/5334#issuecomment-2129923350 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| https://github.com/hydrogen602 |
| hydrogen602 | https://github.com/hydrogen602 |
| May 24, 2024 | https://github.com/RustPython/RustPython/pull/5334#issuecomment-2130509149 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| https://github.com/hydrogen602 |
| hydrogen602 | https://github.com/hydrogen602 |
| May 24, 2024 | https://github.com/RustPython/RustPython/pull/5334#event-12930345632 |
| https://github.com/hydrogen602 |
| hydrogen602 | https://github.com/hydrogen602 |
| May 24, 2024 | https://github.com/RustPython/RustPython/pull/5334#event-12930346061 |
| https://github.com/hydrogen602 |
| hydrogen602 | https://github.com/hydrogen602 |
| May 24, 2024 | https://github.com/RustPython/RustPython/pull/5334#issuecomment-2130509334 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| May 25, 2024 | https://github.com/RustPython/RustPython/pull/5334#issuecomment-2130847981 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| hydrogen602 | https://github.com/hydrogen602 |
| May 25, 2024 17:58 | https://github.com/RustPython/RustPython/pull/5334#commits-pushed-070c440 |
|
| https://github.com/hydrogen602 |
| check if comprehension element contains await | https://github.com/RustPython/RustPython/pull/5334/commits/070c4408a43bf01defa14794b7eb024919b5b9a0 |
| 070c440 | https://github.com/RustPython/RustPython/pull/5334/commits/070c4408a43bf01defa14794b7eb024919b5b9a0 |
|
| https://github.com/hydrogen602 |
| add await if regular for, not async for | https://github.com/RustPython/RustPython/pull/5334/commits/1ec93a9587807e0bbbc346f51905daeb2198c950 |
| 1ec93a9 | https://github.com/RustPython/RustPython/pull/5334/commits/1ec93a9587807e0bbbc346f51905daeb2198c950 |
| https://github.com/hydrogen602 |
| hydrogen602 | https://github.com/hydrogen602 |
| May 26, 2024 00:20 | https://github.com/RustPython/RustPython/pull/5334#event-12934396069 |
| https://github.com/hydrogen602 |
| hydrogen602 | https://github.com/hydrogen602 |
| May 26, 2024 | https://github.com/RustPython/RustPython/pull/5334#issuecomment-2131780551 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
May 26, 2024
| https://github.com/RustPython/RustPython/pull/5334#pullrequestreview-2079625411 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/5334/files/1ec93a9587807e0bbbc346f51905daeb2198c950 |
| compiler/codegen/src/compile.rs | https://github.com/RustPython/RustPython/pull/5334/files/1ec93a9587807e0bbbc346f51905daeb2198c950#diff-d25ba64ade9a22e41075dadb2be789665671a50c036292ccb7f35de6e6daf3ee |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
May 26, 2024
| https://github.com/RustPython/RustPython/pull/5334#pullrequestreview-2079628017 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/5334/files/1ec93a9587807e0bbbc346f51905daeb2198c950 |
| youknowone | https://github.com/youknowone |
| https://github.com/RustPython/RustPython/pull/5334#pullrequestreview-2079628017 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
|
| https://github.com/hydrogen602 |
| testing of hopefully all async comprehension variants and tweaked log… | https://github.com/RustPython/RustPython/pull/5334/commits/83e84aee4772e94ee11ad94e88ffdf657ea66197 |
| 83e84ae | https://github.com/RustPython/RustPython/pull/5334/commits/83e84aee4772e94ee11ad94e88ffdf657ea66197 |
| https://github.com/hydrogen602 |
| hydrogen602 | https://github.com/hydrogen602 |
| May 26, 2024 | https://github.com/RustPython/RustPython/pull/5334#issuecomment-2132401550 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| hydrogen602 | https://github.com/hydrogen602 |
| May 26, 2024 16:41 | https://github.com/RustPython/RustPython/pull/5334#commits-pushed-dc5f07f |
|
| https://github.com/hydrogen602 |
| force execution to pause in async gen | https://github.com/RustPython/RustPython/pull/5334/commits/dc5f07fa00c11e8cae08edd2e015eca7cb008f51 |
| dc5f07f | https://github.com/RustPython/RustPython/pull/5334/commits/dc5f07fa00c11e8cae08edd2e015eca7cb008f51 |
|
| https://github.com/hydrogen602 |
| fix for async for list comprehension | https://github.com/RustPython/RustPython/pull/5334/commits/abd1fcc0856eb4630dc8e31db2179ad2b96cf966 |
| abd1fcc | https://github.com/RustPython/RustPython/pull/5334/commits/abd1fcc0856eb4630dc8e31db2179ad2b96cf966 |
|
| https://github.com/hydrogen602 |
| enable now-working test | https://github.com/RustPython/RustPython/pull/5334/commits/d03ff15b3e47e88c28c75c5d8bc2c4e13b8b0757 |
| d03ff15 | https://github.com/RustPython/RustPython/pull/5334/commits/d03ff15b3e47e88c28c75c5d8bc2c4e13b8b0757 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
May 27, 2024
| https://github.com/RustPython/RustPython/pull/5334#pullrequestreview-2080229601 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/5334/files/d03ff15b3e47e88c28c75c5d8bc2c4e13b8b0757 |
| youknowone | https://github.com/youknowone |
| https://github.com/RustPython/RustPython/pull/5334#pullrequestreview-2080229601 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
|
| https://github.com/youknowone |
| rename test file | https://github.com/RustPython/RustPython/pull/5334/commits/a32dd3c9d80e9257be3e76961430abd16f718c47 |
| a32dd3c | https://github.com/RustPython/RustPython/pull/5334/commits/a32dd3c9d80e9257be3e76961430abd16f718c47 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| May 27, 2024 | https://github.com/RustPython/RustPython/pull/5334#issuecomment-2132867990 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| 7996a10 | https://github.com/RustPython/RustPython/commit/7996a10116681e9f85eda03413d5011b805e577f |
| May 27, 2024 | https://github.com/RustPython/RustPython/pull/5334#event-12942037672 |
| https://github.com/YangSiJun528 |
| YangSiJun528 | https://github.com/YangSiJun528 |
|
Oct 6, 2026
| https://github.com/RustPython/RustPython/pull/5334#ref-issue-5723894128 |
|
Review issues that appear resolved for closure
#8982
| https://github.com/RustPython/RustPython/issues/8982 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5334 |
|
| https://github.com/youknowone |
|
youknowone
| https://github.com/youknowone |
|
| https://github.com/RustPython/RustPython/pull/5334/files/d03ff15b3e47e88c28c75c5d8bc2c4e13b8b0757 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
|
await not allowed in comprehension in async def
| https://github.com/RustPython/RustPython/issues/5315 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5334 |
|
| https://github.com/hydrogen602 |
|
| https://github.com/youknowone |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |