René's URL Explorer Experiment


Title: Fix `encodings` related error messages to be less confusing by youknowone · Pull Request #5049 · RustPython/RustPython · GitHub

Open Graph Title: Fix `encodings` related error messages to be less confusing by youknowone · Pull Request #5049 · RustPython/RustPython

X Title: Fix `encodings` related error messages to be less confusing by youknowone · Pull Request #5049 · RustPython/RustPython

Description: Don't try import encodings when Settings::path_list is empty And adding . is now part of rustpython crate. Users can skip it when they don't want to add cwd to path_list when they create their own interpreter. More information from encoding failure error messages for both interpreter developers/users and rustpython-vm users. cc @dannasman

Open Graph Description: Don't try import encodings when Settings::path_list is empty And adding . is now part of rustpython crate. Users can skip it when they don't want to add cwd to path_list when they create t...

X Description: Don't try import encodings when Settings::path_list is empty And adding . is now part of rustpython crate. Users can skip it when they don't want to add cwd to path_list when they ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/5049

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e8132549-ff20-9096-21ce-54052017837c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE12C:2AD163:22CB3B8:2F4C6B2:6B0029B4
html-safe-noncedb1d2a2a66853f685527c989a45a813df41c055af959a172e299c9a02bc185bd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTJDOjJBRDE2MzoyMkNCM0I4OjJGNEM2QjI6NkIwMDI5QjQiLCJ2aXNpdG9yX2lkIjoiMTYwMDM3MzkwOTQyMzY2MzU0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccd2b963b8810cb0219423767096dd36727e327841109c8bf96d44cb31104195b
hovercard-subject-tagpull_request:1491038255
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/5049/files
twitter:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/69878?s=400&v=4
og:image:altDon't try import encodings when Settings::path_list is empty And adding . is now part of rustpython crate. Users can skip it when they don't want to add cwd to path_list when they create t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/5049/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5049%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5049%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/5049/files
Reloadhttps://github.com/RustPython/RustPython/pull/5049/files
Reloadhttps://github.com/RustPython/RustPython/pull/5049/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests144 (144)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:import-encodingshttps://github.com/youknowone/RustPython/tree/import-encodings
Conversation 7 https://github.com/RustPython/RustPython/pull/5049
Commits 8 https://github.com/RustPython/RustPython/pull/5049/commits
Checks 0 https://github.com/RustPython/RustPython/pull/5049/checks
Files changed https://github.com/RustPython/RustPython/pull/5049/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5049/files
Fix encodings related error messages to be less confusing https://github.com/RustPython/RustPython/pull/5049/files#top
Show all changes 8 commits https://github.com/RustPython/RustPython/pull/5049/files
7aea958 Move cwd setup to interpreter code youknowone Aug 27, 2023 https://github.com/RustPython/RustPython/pull/5049/commits/7aea958306e3c0a64abb0e4284ffbc7d70da7054
159c3a7 rework import encodings failure message youknowone Aug 27, 2023 https://github.com/RustPython/RustPython/pull/5049/commits/159c3a7913cc0dfc8c8f694a96c821f2aa473425
e970ff8 try import_encodings only when `path_list` is set youknowone Aug 27, 2023 https://github.com/RustPython/RustPython/pull/5049/commits/e970ff8e569c115f9f40692b616b45a3dc4a6169
9b8f9f6 Fix grammars youknowone Aug 29, 2023 https://github.com/RustPython/RustPython/pull/5049/commits/9b8f9f6b4eb98b8565b63bec4ec7dedbda0cd82b
0f3fa4b std::mem::take instead of drain(..).collect() youknowone Aug 29, 2023 https://github.com/RustPython/RustPython/pull/5049/commits/0f3fa4b96193bdfdda63c4bd12e38346da24d96a
dae977d Add empty path_list warnings to import_encodings youknowone Aug 29, 2023 https://github.com/RustPython/RustPython/pull/5049/commits/dae977d1245504442bfa43a5f249fe9e3f4aa120
3fa8773 Prepend current working directory when !safe_path youknowone Aug 30, 2023 https://github.com/RustPython/RustPython/pull/5049/commits/3fa877321488e1c1b119457a3cce707733858cfb
d587fb7 Apply suggestions from code review youknowone Aug 30, 2023 https://github.com/RustPython/RustPython/pull/5049/commits/d587fb71231ab0dd64b250b0b91ffe0a2552d2ae
Clear filters https://github.com/RustPython/RustPython/pull/5049/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5049/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5049/files
interpreter.rs https://github.com/RustPython/RustPython/pull/5049/files#diff-60405aaba3dc351a041fce3e90f17b63dee9a214bc9c35ae6a5126d003100e55
lib.rs https://github.com/RustPython/RustPython/pull/5049/files#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759
mod.rs https://github.com/RustPython/RustPython/pull/5049/files#diff-ff3611b35b56a4b3849268552fd67a4d8673b049608bbb68a9ccd6ffa4d1699d
setting.rs https://github.com/RustPython/RustPython/pull/5049/files#diff-6069c7347fb3b638643f83d349915be5d736b1900aa1bb04633916baebbb7dd1
src/interpreter.rshttps://github.com/RustPython/RustPython/pull/5049/files#diff-60405aaba3dc351a041fce3e90f17b63dee9a214bc9c35ae6a5126d003100e55
View file https://github.com/youknowone/RustPython/blob/d587fb71231ab0dd64b250b0b91ffe0a2552d2ae/src/interpreter.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/5049/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/5049/files#diff-60405aaba3dc351a041fce3e90f17b63dee9a214bc9c35ae6a5126d003100e55
https://github.com/RustPython/RustPython/pull/5049/files#diff-60405aaba3dc351a041fce3e90f17b63dee9a214bc9c35ae6a5126d003100e55
src/lib.rshttps://github.com/RustPython/RustPython/pull/5049/files#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759
View file https://github.com/youknowone/RustPython/blob/d587fb71231ab0dd64b250b0b91ffe0a2552d2ae/src/lib.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/5049/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/5049/files#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759
https://github.com/RustPython/RustPython/pull/5049/files#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759
vm/src/vm/mod.rshttps://github.com/RustPython/RustPython/pull/5049/files#diff-ff3611b35b56a4b3849268552fd67a4d8673b049608bbb68a9ccd6ffa4d1699d
View file https://github.com/youknowone/RustPython/blob/d587fb71231ab0dd64b250b0b91ffe0a2552d2ae/vm/src/vm/mod.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/5049/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/5049/files#diff-ff3611b35b56a4b3849268552fd67a4d8673b049608bbb68a9ccd6ffa4d1699d
https://github.com/RustPython/RustPython/pull/5049/files#diff-ff3611b35b56a4b3849268552fd67a4d8673b049608bbb68a9ccd6ffa4d1699d
https://github.com/RustPython/RustPython/pull/5049/files#diff-ff3611b35b56a4b3849268552fd67a4d8673b049608bbb68a9ccd6ffa4d1699d
https://github.com/RustPython/RustPython/pull/5049/files#diff-ff3611b35b56a4b3849268552fd67a4d8673b049608bbb68a9ccd6ffa4d1699d
https://github.com/RustPython/RustPython/pull/5049/files#diff-ff3611b35b56a4b3849268552fd67a4d8673b049608bbb68a9ccd6ffa4d1699d
https://github.com/RustPython/RustPython/pull/5049/files#diff-ff3611b35b56a4b3849268552fd67a4d8673b049608bbb68a9ccd6ffa4d1699d
vm/src/vm/setting.rshttps://github.com/RustPython/RustPython/pull/5049/files#diff-6069c7347fb3b638643f83d349915be5d736b1900aa1bb04633916baebbb7dd1
View file https://github.com/youknowone/RustPython/blob/d587fb71231ab0dd64b250b0b91ffe0a2552d2ae/vm/src/vm/setting.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/5049/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/5049/files#diff-6069c7347fb3b638643f83d349915be5d736b1900aa1bb04633916baebbb7dd1
https://github.com/RustPython/RustPython/pull/5049/files#diff-6069c7347fb3b638643f83d349915be5d736b1900aa1bb04633916baebbb7dd1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.