René's URL Explorer Experiment


Title: Fix `encodings` related error messages to be less confusing by youknowone · Pull Request #5049 · RustPython/RustPython · GitHub

Open Graph Title: Fix `encodings` related error messages to be less confusing by youknowone · Pull Request #5049 · RustPython/RustPython

X Title: Fix `encodings` related error messages to be less confusing by youknowone · Pull Request #5049 · RustPython/RustPython

Description: A Python Interpreter written in Rust. Contribute to RustPython/RustPython development by creating an account on GitHub.

Open Graph Description: Don't try import encodings when Settings::path_list is empty And adding . is now part of rustpython crate. Users can skip it when they don't want to add cwd to path_list when they create t...

X Description: Don't try import encodings when Settings::path_list is empty And adding . is now part of rustpython crate. Users can skip it when they don't want to add cwd to path_list when they ...

Opengraph URL: https://github.com/RustPython/RustPython/pull/5049

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d6f74d1a-b8cd-26f1-8b17-b4b69c938e72
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD2A4:5314B:2E730FA:3D555AF:6B00266F
html-safe-noncea22082864e0debb48d162f82a152b76f16e7a18e2f35d285ce17334277bf058f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkE0OjUzMTRCOjJFNzMwRkE6M0Q1NTVBRjo2QjAwMjY2RiIsInZpc2l0b3JfaWQiOiIxMjQ5MDc2NDAxMDAxMjExNTAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2b311a5b21b54f7da987dc1cded1034f38e5dec30111e7ce712ef71b086650a3
hovercard-subject-tagpull_request:1491038255
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/5049/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/07a976a9ae5d31e9432aef7d5e4cc661e77e0f17cd258c7d12810c93bd5b0342/RustPython/RustPython/pull/5049
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/07a976a9ae5d31e9432aef7d5e4cc661e77e0f17cd258c7d12810c93bd5b0342/RustPython/RustPython/pull/5049
og:image:altDon't try import encodings when Settings::path_list is empty And adding . is now part of rustpython crate. Users can skip it when they don't want to add cwd to path_list when they create t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameyouknowone
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-cache
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/5049#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5049
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5049
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/5049
Reloadhttps://github.com/RustPython/RustPython/pull/5049
Reloadhttps://github.com/RustPython/RustPython/pull/5049
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests144 (144)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
https://github.com/RustPython/RustPython
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:import-encodingshttps://github.com/youknowone/RustPython/tree/import-encodings
Conversationhttps://github.com/RustPython/RustPython/pull/5049
Commits8 (8)https://github.com/RustPython/RustPython/pull/5049/commits
Checkshttps://github.com/RustPython/RustPython/pull/5049/checks
Files changedhttps://github.com/RustPython/RustPython/pull/5049/files
Fix encodings related error messages to be less confusinghttps://github.com/RustPython/RustPython/pull/5049#top
youknowonehttps://github.com/youknowone
RustPython:mainhttps://github.com/RustPython/RustPython/tree/main
youknowone:import-encodingshttps://github.com/youknowone/RustPython/tree/import-encodings
https://github.com/youknowone
youknowonehttps://github.com/youknowone
Aug 27, 2023https://github.com/RustPython/RustPython/pull/5049#issue-1868587017
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5049
@dannasmanhttps://github.com/dannasman
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5049
https://github.com/youknowone
youknowonehttps://github.com/youknowone
DimitrisJimhttps://github.com/DimitrisJim
coolreader18https://github.com/coolreader18
August 27, 2023 18:23https://github.com/RustPython/RustPython/pull/5049#event-10202274635
https://github.com/fanninpm
fanninpmhttps://github.com/fanninpm
Aug 27, 2023 https://github.com/RustPython/RustPython/pull/5049#pullrequestreview-1597173201
View reviewed changes https://github.com/RustPython/RustPython/pull/5049/files
fanninpmhttps://github.com/fanninpm
https://github.com/RustPython/RustPython/pull/5049#pullrequestreview-1597173201
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5049
vm/src/vm/mod.rshttps://github.com/RustPython/RustPython/pull/5049/files#diff-ff3611b35b56a4b3849268552fd67a4d8673b049608bbb68a9ccd6ffa4d1699d
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5049
vm/src/vm/mod.rshttps://github.com/RustPython/RustPython/pull/5049/files#diff-ff3611b35b56a4b3849268552fd67a4d8673b049608bbb68a9ccd6ffa4d1699d
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5049
vm/src/vm/mod.rshttps://github.com/RustPython/RustPython/pull/5049/files#diff-ff3611b35b56a4b3849268552fd67a4d8673b049608bbb68a9ccd6ffa4d1699d
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5049
https://github.com/youknowone
youknowonehttps://github.com/youknowone
August 28, 2023 05:39https://github.com/RustPython/RustPython/pull/5049#event-10204718661
https://github.com/youknowone
youknowonehttps://github.com/youknowone
August 29, 2023 11:26https://github.com/RustPython/RustPython/pull/5049#event-10219962824
https://github.com/youknowone
youknowonehttps://github.com/youknowone
Aug 29, 2023https://github.com/RustPython/RustPython/pull/5049#issuecomment-1697258706
@fanninpmhttps://github.com/fanninpm
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5049
https://github.com/youknowone
youknowonehttps://github.com/youknowone
Aug 29, 2023 https://github.com/RustPython/RustPython/pull/5049#pullrequestreview-1600265337
View reviewed changes https://github.com/RustPython/RustPython/pull/5049/files
vm/src/vm/mod.rshttps://github.com/RustPython/RustPython/pull/5049/files#diff-ff3611b35b56a4b3849268552fd67a4d8673b049608bbb68a9ccd6ffa4d1699d
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5049
youknowonehttps://github.com/youknowone
August 30, 2023 19:32https://github.com/RustPython/RustPython/pull/5049#commits-pushed-7aea958
https://github.com/youknowone
Move cwd setup to interpreter codehttps://github.com/RustPython/RustPython/pull/5049/commits/7aea958306e3c0a64abb0e4284ffbc7d70da7054
7aea958https://github.com/RustPython/RustPython/pull/5049/commits/7aea958306e3c0a64abb0e4284ffbc7d70da7054
https://github.com/youknowone
rework import encodings failure messagehttps://github.com/RustPython/RustPython/pull/5049/commits/159c3a7913cc0dfc8c8f694a96c821f2aa473425
159c3a7https://github.com/RustPython/RustPython/pull/5049/commits/159c3a7913cc0dfc8c8f694a96c821f2aa473425
https://github.com/youknowone
try import_encodings only when path_list is sethttps://github.com/RustPython/RustPython/pull/5049/commits/e970ff8e569c115f9f40692b616b45a3dc4a6169
e970ff8https://github.com/RustPython/RustPython/pull/5049/commits/e970ff8e569c115f9f40692b616b45a3dc4a6169
https://github.com/youknowone
https://github.com/fanninpm
Fix grammarshttps://github.com/RustPython/RustPython/pull/5049/commits/9b8f9f6b4eb98b8565b63bec4ec7dedbda0cd82b
9b8f9f6https://github.com/RustPython/RustPython/pull/5049/commits/9b8f9f6b4eb98b8565b63bec4ec7dedbda0cd82b
https://github.com/youknowone
std::mem::take instead of drain(..).collect()https://github.com/RustPython/RustPython/pull/5049/commits/0f3fa4b96193bdfdda63c4bd12e38346da24d96a
0f3fa4bhttps://github.com/RustPython/RustPython/pull/5049/commits/0f3fa4b96193bdfdda63c4bd12e38346da24d96a
https://github.com/youknowone
Add empty path_list warnings to import_encodingshttps://github.com/RustPython/RustPython/pull/5049/commits/dae977d1245504442bfa43a5f249fe9e3f4aa120
dae977dhttps://github.com/RustPython/RustPython/pull/5049/commits/dae977d1245504442bfa43a5f249fe9e3f4aa120
https://github.com/youknowone
Prepend current working directory when !safe_pathhttps://github.com/RustPython/RustPython/pull/5049/commits/3fa877321488e1c1b119457a3cce707733858cfb
3fa8773https://github.com/RustPython/RustPython/pull/5049/commits/3fa877321488e1c1b119457a3cce707733858cfb
https://github.com/youknowone
youknowonehttps://github.com/youknowone
force-pushedhttps://github.com/RustPython/RustPython/compare/cbd82b61d8f58fe09b9de42b787bd9114b44419a..3fa877321488e1c1b119457a3cce707733858cfb
cbd82b6https://github.com/RustPython/RustPython/commit/cbd82b61d8f58fe09b9de42b787bd9114b44419a
3fa8773https://github.com/RustPython/RustPython/commit/3fa877321488e1c1b119457a3cce707733858cfb
Compare https://github.com/RustPython/RustPython/compare/cbd82b61d8f58fe09b9de42b787bd9114b44419a..3fa877321488e1c1b119457a3cce707733858cfb
August 30, 2023 10:46https://github.com/RustPython/RustPython/pull/5049#event-10231502650
https://github.com/youknowone
https://github.com/fanninpm
Apply suggestions from code reviewhttps://github.com/RustPython/RustPython/pull/5049/commits/d587fb71231ab0dd64b250b0b91ffe0a2552d2ae
d587fb7https://github.com/RustPython/RustPython/pull/5049/commits/d587fb71231ab0dd64b250b0b91ffe0a2552d2ae
https://github.com/youknowone
youknowonehttps://github.com/youknowone
64c66e0https://github.com/RustPython/RustPython/commit/64c66e00d68c70fed261f8b46720438efda746b5
Aug 30, 2023https://github.com/RustPython/RustPython/pull/5049#event-10232661286
https://github.com/youknowone
youknowonehttps://github.com/youknowone
August 30, 2023 12:45https://github.com/RustPython/RustPython/pull/5049#event-10232661935
https://github.com/YangSiJun528
YangSiJun528https://github.com/YangSiJun528
Oct 6, 2026 https://github.com/RustPython/RustPython/pull/5049#ref-issue-5723894128
Review issues that appear resolved for closure #8982 https://github.com/RustPython/RustPython/issues/8982
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5049
https://github.com/fanninpm
fanninpm https://github.com/fanninpm
https://github.com/RustPython/RustPython/pull/5049/files/cbd82b61d8f58fe09b9de42b787bd9114b44419a
https://github.com/DimitrisJim
DimitrisJim https://github.com/DimitrisJim
https://github.com/coolreader18
coolreader18 https://github.com/coolreader18
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5049
Please reload this pagehttps://github.com/RustPython/RustPython/pull/5049
https://github.com/youknowone
https://github.com/fanninpm
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.