| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d6f74d1a-b8cd-26f1-8b17-b4b69c938e72 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D2A4:5314B:2E730FA:3D555AF:6B00266F |
| html-safe-nonce | a22082864e0debb48d162f82a152b76f16e7a18e2f35d285ce17334277bf058f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkE0OjUzMTRCOjJFNzMwRkE6M0Q1NTVBRjo2QjAwMjY2RiIsInZpc2l0b3JfaWQiOiIxMjQ5MDc2NDAxMDAxMjExNTAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2b311a5b21b54f7da987dc1cded1034f38e5dec30111e7ce712ef71b086650a3 |
| hovercard-subject-tag | pull_request:1491038255 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/5049/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/07a976a9ae5d31e9432aef7d5e4cc661e77e0f17cd258c7d12810c93bd5b0342/RustPython/RustPython/pull/5049 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/07a976a9ae5d31e9432aef7d5e4cc661e77e0f17cd258c7d12810c93bd5b0342/RustPython/RustPython/pull/5049 |
| og:image:alt | Don't try import encodings when Settings::path_list is empty
And adding . is now part of rustpython crate. Users can skip it when they don't want to add cwd to path_list when they create t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | youknowone |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/RustPython/RustPython/pull/5049#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5049 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5049 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/5049 |
| Reload | https://github.com/RustPython/RustPython/pull/5049 |
| Reload | https://github.com/RustPython/RustPython/pull/5049 |
| RustPython | https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
| Code | https://github.com/RustPython/RustPython |
| Issues195 (195) | https://github.com/RustPython/RustPython/issues |
| Pull requests144 (144) | https://github.com/RustPython/RustPython/pulls |
| Discussions | https://github.com/RustPython/RustPython/discussions |
| Actions | https://github.com/RustPython/RustPython/actions |
| Projects | https://github.com/RustPython/RustPython/projects |
| Wiki | https://github.com/RustPython/RustPython/wiki |
| Security and quality | https://github.com/RustPython/RustPython/security |
| Insights | https://github.com/RustPython/RustPython/insights |
| https://github.com/RustPython/RustPython |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| youknowone:import-encodings | https://github.com/youknowone/RustPython/tree/import-encodings |
| Conversation | https://github.com/RustPython/RustPython/pull/5049 |
| Commits8 (8) | https://github.com/RustPython/RustPython/pull/5049/commits |
| Checks | https://github.com/RustPython/RustPython/pull/5049/checks |
| Files changed | https://github.com/RustPython/RustPython/pull/5049/files |
| Fix encodings related error messages to be less confusing | https://github.com/RustPython/RustPython/pull/5049#top |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| youknowone:import-encodings | https://github.com/youknowone/RustPython/tree/import-encodings |
|
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Aug 27, 2023 | https://github.com/RustPython/RustPython/pull/5049#issue-1868587017 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5049 |
| @dannasman | https://github.com/dannasman |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5049 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| DimitrisJim | https://github.com/DimitrisJim |
| coolreader18 | https://github.com/coolreader18 |
| August 27, 2023 18:23 | https://github.com/RustPython/RustPython/pull/5049#event-10202274635 |
| https://github.com/fanninpm |
| fanninpm | https://github.com/fanninpm |
|
Aug 27, 2023
| https://github.com/RustPython/RustPython/pull/5049#pullrequestreview-1597173201 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/5049/files |
| fanninpm | https://github.com/fanninpm |
| https://github.com/RustPython/RustPython/pull/5049#pullrequestreview-1597173201 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5049 |
| vm/src/vm/mod.rs | https://github.com/RustPython/RustPython/pull/5049/files#diff-ff3611b35b56a4b3849268552fd67a4d8673b049608bbb68a9ccd6ffa4d1699d |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5049 |
| vm/src/vm/mod.rs | https://github.com/RustPython/RustPython/pull/5049/files#diff-ff3611b35b56a4b3849268552fd67a4d8673b049608bbb68a9ccd6ffa4d1699d |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5049 |
| vm/src/vm/mod.rs | https://github.com/RustPython/RustPython/pull/5049/files#diff-ff3611b35b56a4b3849268552fd67a4d8673b049608bbb68a9ccd6ffa4d1699d |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5049 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| August 28, 2023 05:39 | https://github.com/RustPython/RustPython/pull/5049#event-10204718661 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| August 29, 2023 11:26 | https://github.com/RustPython/RustPython/pull/5049#event-10219962824 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Aug 29, 2023 | https://github.com/RustPython/RustPython/pull/5049#issuecomment-1697258706 |
| @fanninpm | https://github.com/fanninpm |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5049 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Aug 29, 2023
| https://github.com/RustPython/RustPython/pull/5049#pullrequestreview-1600265337 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/5049/files |
| vm/src/vm/mod.rs | https://github.com/RustPython/RustPython/pull/5049/files#diff-ff3611b35b56a4b3849268552fd67a4d8673b049608bbb68a9ccd6ffa4d1699d |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5049 |
| youknowone | https://github.com/youknowone |
| August 30, 2023 19:32 | https://github.com/RustPython/RustPython/pull/5049#commits-pushed-7aea958 |
|
| https://github.com/youknowone |
| Move cwd setup to interpreter code | https://github.com/RustPython/RustPython/pull/5049/commits/7aea958306e3c0a64abb0e4284ffbc7d70da7054 |
| 7aea958 | https://github.com/RustPython/RustPython/pull/5049/commits/7aea958306e3c0a64abb0e4284ffbc7d70da7054 |
|
| https://github.com/youknowone |
| rework import encodings failure message | https://github.com/RustPython/RustPython/pull/5049/commits/159c3a7913cc0dfc8c8f694a96c821f2aa473425 |
| 159c3a7 | https://github.com/RustPython/RustPython/pull/5049/commits/159c3a7913cc0dfc8c8f694a96c821f2aa473425 |
|
| https://github.com/youknowone |
| try import_encodings only when path_list is set | https://github.com/RustPython/RustPython/pull/5049/commits/e970ff8e569c115f9f40692b616b45a3dc4a6169 |
| e970ff8 | https://github.com/RustPython/RustPython/pull/5049/commits/e970ff8e569c115f9f40692b616b45a3dc4a6169 |
|
| https://github.com/youknowone |
|
| https://github.com/fanninpm |
| Fix grammars | https://github.com/RustPython/RustPython/pull/5049/commits/9b8f9f6b4eb98b8565b63bec4ec7dedbda0cd82b |
| 9b8f9f6 | https://github.com/RustPython/RustPython/pull/5049/commits/9b8f9f6b4eb98b8565b63bec4ec7dedbda0cd82b |
|
| https://github.com/youknowone |
| std::mem::take instead of drain(..).collect() | https://github.com/RustPython/RustPython/pull/5049/commits/0f3fa4b96193bdfdda63c4bd12e38346da24d96a |
| 0f3fa4b | https://github.com/RustPython/RustPython/pull/5049/commits/0f3fa4b96193bdfdda63c4bd12e38346da24d96a |
|
| https://github.com/youknowone |
| Add empty path_list warnings to import_encodings | https://github.com/RustPython/RustPython/pull/5049/commits/dae977d1245504442bfa43a5f249fe9e3f4aa120 |
| dae977d | https://github.com/RustPython/RustPython/pull/5049/commits/dae977d1245504442bfa43a5f249fe9e3f4aa120 |
|
| https://github.com/youknowone |
| Prepend current working directory when !safe_path | https://github.com/RustPython/RustPython/pull/5049/commits/3fa877321488e1c1b119457a3cce707733858cfb |
| 3fa8773 | https://github.com/RustPython/RustPython/pull/5049/commits/3fa877321488e1c1b119457a3cce707733858cfb |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/cbd82b61d8f58fe09b9de42b787bd9114b44419a..3fa877321488e1c1b119457a3cce707733858cfb |
| cbd82b6 | https://github.com/RustPython/RustPython/commit/cbd82b61d8f58fe09b9de42b787bd9114b44419a |
| 3fa8773 | https://github.com/RustPython/RustPython/commit/3fa877321488e1c1b119457a3cce707733858cfb |
|
Compare
| https://github.com/RustPython/RustPython/compare/cbd82b61d8f58fe09b9de42b787bd9114b44419a..3fa877321488e1c1b119457a3cce707733858cfb |
| August 30, 2023 10:46 | https://github.com/RustPython/RustPython/pull/5049#event-10231502650 |
|
| https://github.com/youknowone |
|
| https://github.com/fanninpm |
| Apply suggestions from code review | https://github.com/RustPython/RustPython/pull/5049/commits/d587fb71231ab0dd64b250b0b91ffe0a2552d2ae |
| d587fb7 | https://github.com/RustPython/RustPython/pull/5049/commits/d587fb71231ab0dd64b250b0b91ffe0a2552d2ae |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| 64c66e0 | https://github.com/RustPython/RustPython/commit/64c66e00d68c70fed261f8b46720438efda746b5 |
| Aug 30, 2023 | https://github.com/RustPython/RustPython/pull/5049#event-10232661286 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| August 30, 2023 12:45 | https://github.com/RustPython/RustPython/pull/5049#event-10232661935 |
| https://github.com/YangSiJun528 |
| YangSiJun528 | https://github.com/YangSiJun528 |
|
Oct 6, 2026
| https://github.com/RustPython/RustPython/pull/5049#ref-issue-5723894128 |
|
Review issues that appear resolved for closure
#8982
| https://github.com/RustPython/RustPython/issues/8982 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F5049 |
|
| https://github.com/fanninpm |
|
fanninpm
| https://github.com/fanninpm |
|
| https://github.com/RustPython/RustPython/pull/5049/files/cbd82b61d8f58fe09b9de42b787bd9114b44419a |
|
| https://github.com/DimitrisJim |
|
DimitrisJim
| https://github.com/DimitrisJim |
|
| https://github.com/coolreader18 |
|
coolreader18
| https://github.com/coolreader18 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5049 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/5049 |
|
| https://github.com/youknowone |
|
| https://github.com/fanninpm |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |