René's URL Explorer Experiment


Title: Weakref callback by BenLewis-Seequent · Pull Request #488 · RustPython/RustPython · GitHub

Open Graph Title: Weakref callback by BenLewis-Seequent · Pull Request #488 · RustPython/RustPython

X Title: Weakref callback by BenLewis-Seequent · Pull Request #488 · RustPython/RustPython

Description: A Python Interpreter written in Rust. Contribute to RustPython/RustPython development by creating an account on GitHub.

Open Graph Description: I have made changes to allow weak references to have callbacks, but I have ran into a problem about how to run these callbacks during drop as we have no reference in the virual machine within the d...

X Description: I have made changes to allow weak references to have callbacks, but I have ran into a problem about how to run these callbacks during drop as we have no reference in the virual machine within the d...

Opengraph URL: https://github.com/RustPython/RustPython/pull/488

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d34839a7-f746-da77-ab5f-cf62dd1dbf51
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC566:1247D9:2C379C5:3F06640:6A5907D9
html-safe-nonce3de8afcab18921e4cf3716e7ca7538c52c6c3934983ca44d5aa0e116767dbe3d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTY2OjEyNDdEOToyQzM3OUM1OjNGMDY2NDA6NkE1OTA3RDkiLCJ2aXNpdG9yX2lkIjoiMTA3Njg5NjMzNzUyOTIxMDg0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac41fd5bd8e3649978bac48b4d3f9437a3adff80aa411cf82e08de9da7940cd896
hovercard-subject-tagpull_request:253679022
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/488/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b44eda1fe1abbb30e01ba1d1344ac9fbac75457a107de2ab471f2559e8c604c2/RustPython/RustPython/pull/488
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b44eda1fe1abbb30e01ba1d1344ac9fbac75457a107de2ab471f2559e8c604c2/RustPython/RustPython/pull/488
og:image:altI have made changes to allow weak references to have callbacks, but I have ran into a problem about how to run these callbacks during drop as we have no reference in the virual machine within the d...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBenLewis-Seequent
hostnamegithub.com
expected-hostnamegithub.com
None5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6
turbo-cache-controlno-cache
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9842457e8d7e3b2e1635a63af28da35614845510
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/488#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F488
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F488
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/488
Reloadhttps://github.com/RustPython/RustPython/pull/488
Reloadhttps://github.com/RustPython/RustPython/pull/488
Please reload this pagehttps://github.com/RustPython/RustPython/pull/488
RustPython https://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Notifications https://github.com/login?return_to=%2FRustPython%2FRustPython
Fork 1.5k https://github.com/login?return_to=%2FRustPython%2FRustPython
Star 22.2k https://github.com/login?return_to=%2FRustPython%2FRustPython
Code https://github.com/RustPython/RustPython
Issues 287 https://github.com/RustPython/RustPython/issues
Pull requests 100 https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality 0 https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
Code https://github.com/RustPython/RustPython
Issues https://github.com/RustPython/RustPython/issues
Pull requests https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
RustPython:masterhttps://github.com/RustPython/RustPython/tree/master
BenLewis-Seequent:weakref_callbackhttps://github.com/BenLewis-Seequent/RustPython/tree/weakref_callback
Conversationhttps://github.com/RustPython/RustPython/pull/488
Commits10 (10)https://github.com/RustPython/RustPython/pull/488/commits
Checkshttps://github.com/RustPython/RustPython/pull/488/checks
Files changedhttps://github.com/RustPython/RustPython/pull/488/files
Weakref callbackhttps://github.com/RustPython/RustPython/pull/488#top
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
RustPython:masterhttps://github.com/RustPython/RustPython/tree/master
BenLewis-Seequent:weakref_callbackhttps://github.com/BenLewis-Seequent/RustPython/tree/weakref_callback
https://github.com/BenLewis-Seequent
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
Feb 17, 2019https://github.com/RustPython/RustPython/pull/488#issue-411132730
Please reload this pagehttps://github.com/RustPython/RustPython/pull/488
skinnyBathttps://github.com/skinnyBat
February 17, 2019 08:15https://github.com/RustPython/RustPython/pull/488#commits-pushed-8dd5810
https://github.com/skinnyBat
Make PyObjectRef and PyObjectWeakRef it's own type.https://github.com/RustPython/RustPython/pull/488/commits/8dd58108485224bce8eeb672ad77468add7510f5
8dd5810https://github.com/RustPython/RustPython/pull/488/commits/8dd58108485224bce8eeb672ad77468add7510f5
https://github.com/skinnyBat
Move weakref type to obj folder, as it's a core type and needs to behttps://github.com/RustPython/RustPython/pull/488/commits/0c1bee994627f9af3dce46f03532397a0779ccb5
0c1bee9https://github.com/RustPython/RustPython/pull/488/commits/0c1bee994627f9af3dce46f03532397a0779ccb5
https://github.com/skinnyBat
Add callback to object being reference.https://github.com/RustPython/RustPython/pull/488/commits/eab6e2f3b2bfe27c773c9c45426cb22fc3ac2d33
eab6e2fhttps://github.com/RustPython/RustPython/pull/488/commits/eab6e2f3b2bfe27c773c9c45426cb22fc3ac2d33
https://github.com/windelbouwman
windelbouwmanhttps://github.com/windelbouwman
Feb 17, 2019https://github.com/RustPython/RustPython/pull/488#issuecomment-464424311
Please reload this pagehttps://github.com/RustPython/RustPython/pull/488
https://github.com/BenLewis-Seequent
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
Feb 17, 2019https://github.com/RustPython/RustPython/pull/488#issuecomment-464426281
Please reload this pagehttps://github.com/RustPython/RustPython/pull/488
Please reload this pagehttps://github.com/RustPython/RustPython/pull/488
skinnyBathttps://github.com/skinnyBat
February 18, 2019 19:26https://github.com/RustPython/RustPython/pull/488#commits-pushed-6a13a83
https://github.com/skinnyBat
Merge branch 'master' into weakref_callbackhttps://github.com/RustPython/RustPython/pull/488/commits/6a13a83e2d3de0888526aabefb7c0c60e4520b23
6a13a83https://github.com/RustPython/RustPython/pull/488/commits/6a13a83e2d3de0888526aabefb7c0c60e4520b23
https://github.com/skinnyBat
Queue up objects to be deleted to allow for weakref callbackshttps://github.com/RustPython/RustPython/pull/488/commits/435510570cfd5559a8de4d35117354c0f4f87294
4355105https://github.com/RustPython/RustPython/pull/488/commits/435510570cfd5559a8de4d35117354c0f4f87294
https://github.com/skinnyBat
Add more tests for weakref and fix objects not holding there weakhttps://github.com/RustPython/RustPython/pull/488/commits/195a56a66b67f117471057589872ab407f72703f
195a56ahttps://github.com/RustPython/RustPython/pull/488/commits/195a56a66b67f117471057589872ab407f72703f
https://github.com/skinnyBat
Merge branch 'master' into weakref_callbackhttps://github.com/RustPython/RustPython/pull/488/commits/80c72d0f6ef75411a7f423c013c0b403666327ef
80c72d0https://github.com/RustPython/RustPython/pull/488/commits/80c72d0f6ef75411a7f423c013c0b403666327ef
https://github.com/skinnyBat
Fix clippy warninghttps://github.com/RustPython/RustPython/pull/488/commits/e89f8fafe55082143b231b79098d0643e2b1c82c
e89f8fahttps://github.com/RustPython/RustPython/pull/488/commits/e89f8fafe55082143b231b79098d0643e2b1c82c
https://github.com/skinnyBat
Formattinghttps://github.com/RustPython/RustPython/pull/488/commits/b6d28cf425de8dd68a6bb12f7dfdea3ee300dc17
b6d28cfhttps://github.com/RustPython/RustPython/pull/488/commits/b6d28cf425de8dd68a6bb12f7dfdea3ee300dc17
https://github.com/BenLewis-Seequent
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
February 19, 2019 08:41https://github.com/RustPython/RustPython/pull/488#event-2148148415
https://github.com/BenLewis-Seequent
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
Feb 19, 2019https://github.com/RustPython/RustPython/pull/488#issuecomment-465041312
Please reload this pagehttps://github.com/RustPython/RustPython/pull/488
https://github.com/codecov-io
codecov-iohttps://github.com/codecov-io
Feb 19, 2019https://github.com/RustPython/RustPython/pull/488#issuecomment-465046711
Please reload this pagehttps://github.com/RustPython/RustPython/pull/488
Codecovhttps://codecov.io/gh/RustPython/RustPython/pull/488?src=pr&el=h1
#488https://codecov.io/gh/RustPython/RustPython/pull/488?src=pr&el=desc
masterhttps://codecov.io/gh/RustPython/RustPython/commit/fcea8455fad865f886959aaf8cca6aa6b08d3e3b?src=pr&el=desc
https://codecov.io/gh/RustPython/RustPython/pull/488?src=pr&el=tree
Impacted Fileshttps://codecov.io/gh/RustPython/RustPython/pull/488?src=pr&el=tree
vm/src/obj/objstr.rshttps://codecov.io/gh/RustPython/RustPython/pull/488/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmpzdHIucnM=
vm/src/sysmodule.rshttps://codecov.io/gh/RustPython/RustPython/pull/488/diff?src=pr&el=tree#diff-dm0vc3JjL3N5c21vZHVsZS5ycw==
vm/src/obj/objtype.rshttps://codecov.io/gh/RustPython/RustPython/pull/488/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmp0eXBlLnJz
vm/src/builtins.rshttps://codecov.io/gh/RustPython/RustPython/pull/488/diff?src=pr&el=tree#diff-dm0vc3JjL2J1aWx0aW5zLnJz
vm/src/stdlib/weakref.rshttps://codecov.io/gh/RustPython/RustPython/pull/488/diff?src=pr&el=tree#diff-dm0vc3JjL3N0ZGxpYi93ZWFrcmVmLnJz
vm/src/frame.rshttps://codecov.io/gh/RustPython/RustPython/pull/488/diff?src=pr&el=tree#diff-dm0vc3JjL2ZyYW1lLnJz
vm/src/pyobject.rshttps://codecov.io/gh/RustPython/RustPython/pull/488/diff?src=pr&el=tree#diff-dm0vc3JjL3B5b2JqZWN0LnJz
vm/src/obj/objweakref.rshttps://codecov.io/gh/RustPython/RustPython/pull/488/diff?src=pr&el=tree#diff-dm0vc3JjL29iai9vYmp3ZWFrcmVmLnJz
8 morehttps://codecov.io/gh/RustPython/RustPython/pull/488/diff?src=pr&el=tree-more
Continue to review full report at Codecovhttps://codecov.io/gh/RustPython/RustPython/pull/488?src=pr&el=continue
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta
Codecovhttps://codecov.io/gh/RustPython/RustPython/pull/488?src=pr&el=footer
fcea845...350bc30https://codecov.io/gh/RustPython/RustPython/pull/488?src=pr&el=lastupdated
comment docshttps://docs.codecov.io/docs/pull-request-comments
Please reload this pagehttps://github.com/RustPython/RustPython/pull/488
https://github.com/adrian17
adrian17https://github.com/adrian17
Feb 19, 2019 https://github.com/RustPython/RustPython/pull/488#pullrequestreview-205095028
View reviewed changes https://github.com/RustPython/RustPython/pull/488/files/b6d28cf425de8dd68a6bb12f7dfdea3ee300dc17
vm/src/pyobject.rshttps://github.com/RustPython/RustPython/pull/488/files/b6d28cf425de8dd68a6bb12f7dfdea3ee300dc17#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa
adrian17https://github.com/adrian17
Feb 19, 2019https://github.com/RustPython/RustPython/pull/488#discussion_r257944339
Please reload this pagehttps://github.com/RustPython/RustPython/pull/488
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#371https://github.com/RustPython/RustPython/issues/371
Please reload this pagehttps://github.com/RustPython/RustPython/pull/488
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
Feb 20, 2019https://github.com/RustPython/RustPython/pull/488#discussion_r258372454
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#371https://github.com/RustPython/RustPython/issues/371
Please reload this pagehttps://github.com/RustPython/RustPython/pull/488
https://github.com/skinnyBat
Move weak_refs attribute into Instance payloadhttps://github.com/RustPython/RustPython/pull/488/commits/350bc30311ef76fcbcfaf34a3521edd5c71eaa34
350bc30https://github.com/RustPython/RustPython/pull/488/commits/350bc30311ef76fcbcfaf34a3521edd5c71eaa34
https://github.com/windelbouwman
windelbouwmanhttps://github.com/windelbouwman
Mar 2, 2019https://github.com/RustPython/RustPython/pull/488#issuecomment-468904308
Please reload this pagehttps://github.com/RustPython/RustPython/pull/488
https://github.com/BenLewis-Seequent
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
Mar 3, 2019https://github.com/RustPython/RustPython/pull/488#issuecomment-468984097
Please reload this pagehttps://github.com/RustPython/RustPython/pull/488
https://github.com/BenLewis-Seequent
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
Mar 9, 2019 https://github.com/RustPython/RustPython/pull/488#ref-pullrequest-419032681
Move weakref object type to obj module #636 https://github.com/RustPython/RustPython/pull/636
https://github.com/BenLewis-Seequent
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
Mar 9, 2019https://github.com/RustPython/RustPython/pull/488#issuecomment-471145029
#636https://github.com/RustPython/RustPython/pull/636
Please reload this pagehttps://github.com/RustPython/RustPython/pull/488
https://github.com/BenLewis-Seequent
BenLewis-Seequenthttps://github.com/BenLewis-Seequent
Mar 9, 2019https://github.com/RustPython/RustPython/pull/488#event-2191614673
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F488
https://github.com/adrian17
adrian17 https://github.com/adrian17
https://github.com/RustPython/RustPython/pull/488/files/b6d28cf425de8dd68a6bb12f7dfdea3ee300dc17
Please reload this pagehttps://github.com/RustPython/RustPython/pull/488
https://github.com/BenLewis-Seequent
https://github.com/windelbouwman
https://github.com/codecov-io
https://github.com/adrian17
https://github.com/skinnyBat
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.