| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d4f6f89a-135f-2e08-69c4-6ce72c13da7d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A74C:140F48:219EE84:2CF8378:69705FBC |
| html-safe-nonce | b1e21a43ba7184f98fbc5e8ecf7346828c6561c1e8e44477825ed633b7074a47 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzRDOjE0MEY0ODoyMTlFRTg0OjJDRjgzNzg6Njk3MDVGQkMiLCJ2aXNpdG9yX2lkIjoiMzg4NDExODYwNzQ5ODYwMDM4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3d6f8c0c244bb6631648cee087efa0f2d8982e1854b25001f8d530779d245745 |
| hovercard-subject-tag | pull_request:1315162294 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/4878/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f5ef4dc35b7153df232a43e4bbc192fb50885ab014f6d4a5465b22b1c2f299dc/RustPython/RustPython/pull/4878 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f5ef4dc35b7153df232a43e4bbc192fb50885ab014f6d4a5465b22b1c2f299dc/RustPython/RustPython/pull/4878 |
| og:image:alt | The wasm-bindgen stuff is being addressed here: #4875
Also in that PR we are talking about time, but the PR doesn't address a solution to that. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lastmjs |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7d6181066430cc06553c8396ca201e194ae33cb9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/RustPython/RustPython/pull/4878#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F4878 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F4878 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/4878 |
| Reload | https://github.com/RustPython/RustPython/pull/4878 |
| Reload | https://github.com/RustPython/RustPython/pull/4878 |
|
RustPython
| https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
|
Notifications
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Fork
1.4k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Star
21.7k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
276
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
92
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
0
| https://github.com/RustPython/RustPython/projects |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/RustPython/RustPython/security |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4878 |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/RustPython/RustPython/pull/4878#issue-comment-box |
| lastmjs | https://github.com/lastmjs |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| demergent-labs:kybra_4_13_2023 | https://github.com/demergent-labs/RustPython/tree/kybra_4_13_2023 |
|
This is a draft to show our remaining reasons for having a fork of RustPython
| https://github.com/RustPython/RustPython/pull/4878#top |
| lastmjs | https://github.com/lastmjs |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| demergent-labs:kybra_4_13_2023 | https://github.com/demergent-labs/RustPython/tree/kybra_4_13_2023 |
|
Conversation
11
| https://github.com/RustPython/RustPython/pull/4878 |
|
Commits
7
| https://github.com/RustPython/RustPython/pull/4878/commits |
|
Checks
0
| https://github.com/RustPython/RustPython/pull/4878/checks |
|
Files changed
| https://github.com/RustPython/RustPython/pull/4878/files |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4878 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
|
| https://github.com/lastmjs |
| lastmjs | https://github.com/lastmjs |
| Apr 15, 2023 | https://github.com/RustPython/RustPython/pull/4878#issue-1669466867 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4878 |
| #4875 | https://github.com/RustPython/RustPython/pull/4875 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4878 |
|
| https://github.com/bdemann |
| add wasmbind feature | https://github.com/RustPython/RustPython/pull/4878/commits/48fa419b64d72446b065465cc88fecc9552790ff |
| 48fa419 | https://github.com/RustPython/RustPython/pull/4878/commits/48fa419b64d72446b065465cc88fecc9552790ff |
| https://github.com/DimitrisJim |
| DimitrisJim | https://github.com/DimitrisJim |
|
Apr 15, 2023
| https://github.com/RustPython/RustPython/pull/4878#pullrequestreview-1386548740 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/4878/files |
| compiler/parser/src/python.rs | https://github.com/RustPython/RustPython/pull/4878/files#diff-43b0ebf15d892b2533343b7e248258ce3eb965a06d9f4907f94dab40c916c568 |
| DimitrisJim | https://github.com/DimitrisJim |
| Apr 15, 2023 | https://github.com/RustPython/RustPython/pull/4878#discussion_r1167574560 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4878 |
| lastmjs | https://github.com/lastmjs |
| Apr 15, 2023 | https://github.com/RustPython/RustPython/pull/4878#discussion_r1167576593 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| our environment | https://internetcomputer.org/ |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4878 |
| DimitrisJim | https://github.com/DimitrisJim |
| Apr 15, 2023 | https://github.com/RustPython/RustPython/pull/4878#discussion_r1167577551 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| lalrpop/lalrpop#304 | https://github.com/lalrpop/lalrpop/issues/304 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4878 |
| youknowone | https://github.com/youknowone |
| Apr 17, 2023 | https://github.com/RustPython/RustPython/pull/4878#discussion_r1168281104 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4878 |
| https://github.com/DimitrisJim |
| DimitrisJim | https://github.com/DimitrisJim |
|
Apr 15, 2023
| https://github.com/RustPython/RustPython/pull/4878#pullrequestreview-1386551523 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/4878/files |
| vm/src/vm/interpreter.rs | https://github.com/RustPython/RustPython/pull/4878/files#diff-a491ecf3bf2d6de6c747ee410b40be06de501b193a11a376bdb1bd8c59b268ea |
| DimitrisJim | https://github.com/DimitrisJim |
| Apr 15, 2023 | https://github.com/RustPython/RustPython/pull/4878#discussion_r1167576475 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4878 |
| https://github.com/fanninpm |
| fanninpm | https://github.com/fanninpm |
|
Apr 18, 2023
| https://github.com/RustPython/RustPython/pull/4878#pullrequestreview-1390590062 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/4878/files |
| fanninpm | https://github.com/fanninpm |
| https://github.com/RustPython/RustPython/pull/4878#pullrequestreview-1390590062 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @lastmjs | https://github.com/lastmjs |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4878 |
| vm/src/stdlib/time.rs | https://github.com/RustPython/RustPython/pull/4878/files#diff-d6e06231082cee70ab1dbfd3845ae4f634b70f79c0f2b25b5f08cbfa0e90d73b |
| fanninpm | https://github.com/fanninpm |
| Apr 18, 2023 | https://github.com/RustPython/RustPython/pull/4878#discussion_r1170347522 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4878 |
| bdemann | https://github.com/bdemann |
| Apr 19, 2023 | https://github.com/RustPython/RustPython/pull/4878#discussion_r1171490105 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #4875 | https://github.com/RustPython/RustPython/pull/4875 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4878 |
| vm/src/vm/vm_object.rs | https://github.com/RustPython/RustPython/pull/4878/files#diff-c04eb0ae39865642904235319d9f2767f3c184fe53821ba347fa6484025ac4fb |
| fanninpm | https://github.com/fanninpm |
| Apr 18, 2023 | https://github.com/RustPython/RustPython/pull/4878#discussion_r1170350498 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4878 |
| bdemann | https://github.com/bdemann |
| Apr 19, 2023 | https://github.com/RustPython/RustPython/pull/4878#discussion_r1171490197 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #4875 | https://github.com/RustPython/RustPython/pull/4875 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4878 |
| https://github.com/lastmjs |
| lastmjs | https://github.com/lastmjs |
| Apr 19, 2023 | https://github.com/RustPython/RustPython/pull/4878#issuecomment-1514142158 |
| @lastmjs | https://github.com/lastmjs |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4878 |
| bdemann | https://github.com/bdemann |
| April 19, 2023 09:09 | https://github.com/RustPython/RustPython/pull/4878#commits-pushed-5b89a3f |
|
| https://github.com/bdemann |
| address pr notes | https://github.com/RustPython/RustPython/pull/4878/commits/5b89a3f5ffa2c85e2a16460227d0415fa31d29ca |
| 5b89a3f | https://github.com/RustPython/RustPython/pull/4878/commits/5b89a3f5ffa2c85e2a16460227d0415fa31d29ca |
|
| https://github.com/bdemann |
| run the first block if wasmbind is not present | https://github.com/RustPython/RustPython/pull/4878/commits/578f206aaf1d944d3b5d5379c9c1b73b165dc327 |
| 578f206 | https://github.com/RustPython/RustPython/pull/4878/commits/578f206aaf1d944d3b5d5379c9c1b73b165dc327 |
|
| https://github.com/bdemann |
| add cfg for not wasmbind for time | https://github.com/RustPython/RustPython/pull/4878/commits/b88e25f780b3275f9abc568d9c607de55720cb1c |
| b88e25f | https://github.com/RustPython/RustPython/pull/4878/commits/b88e25f780b3275f9abc568d9c607de55720cb1c |
|
| https://github.com/bdemann |
| make the vm public | https://github.com/RustPython/RustPython/pull/4878/commits/776287cd3d6fa9f40cb49430de02f538f2197796 |
| 776287c | https://github.com/RustPython/RustPython/pull/4878/commits/776287cd3d6fa9f40cb49430de02f538f2197796 |
|
| https://github.com/bdemann |
| Add ic feature for ic_cdk time | https://github.com/RustPython/RustPython/pull/4878/commits/05dd10135afcf43c92f946a3232536088f0ba6e2 |
| 05dd101 | https://github.com/RustPython/RustPython/pull/4878/commits/05dd10135afcf43c92f946a3232536088f0ba6e2 |
|
| https://github.com/lastmjs |
|
| https://github.com/bdemann |
| adding lolrpop workaround because of complexity limit of 15_000 per f… | https://github.com/RustPython/RustPython/pull/4878/commits/b7b0a4994d7871bf1e21fedb6bd0f0e5639fa874 |
| b7b0a49 | https://github.com/RustPython/RustPython/pull/4878/commits/b7b0a4994d7871bf1e21fedb6bd0f0e5639fa874 |
| https://github.com/bdemann |
| bdemann | https://github.com/bdemann |
| force-pushed | https://github.com/RustPython/RustPython/compare/b64a9f9c4e3aec6a26ecc69101140a2ff2c6e4c4..b7b0a4994d7871bf1e21fedb6bd0f0e5639fa874 |
| b64a9f9 | https://github.com/RustPython/RustPython/commit/b64a9f9c4e3aec6a26ecc69101140a2ff2c6e4c4 |
| b7b0a49 | https://github.com/RustPython/RustPython/commit/b7b0a4994d7871bf1e21fedb6bd0f0e5639fa874 |
|
Compare
| https://github.com/RustPython/RustPython/compare/b64a9f9c4e3aec6a26ecc69101140a2ff2c6e4c4..b7b0a4994d7871bf1e21fedb6bd0f0e5639fa874 |
| April 19, 2023 16:31 | https://github.com/RustPython/RustPython/pull/4878#event-9048691218 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F4878 |
|
| https://github.com/youknowone |
|
youknowone
| https://github.com/youknowone |
|
| https://github.com/RustPython/RustPython/pull/4878/files/7483ff7959103d7c4b2a15d718d4f7ad9b57b459 |
|
| https://github.com/DimitrisJim |
|
DimitrisJim
| https://github.com/DimitrisJim |
|
| https://github.com/RustPython/RustPython/pull/4878/files/7483ff7959103d7c4b2a15d718d4f7ad9b57b459 |
|
| https://github.com/fanninpm |
|
fanninpm
| https://github.com/fanninpm |
|
| https://github.com/RustPython/RustPython/pull/4878/files/b64a9f9c4e3aec6a26ecc69101140a2ff2c6e4c4 |
|
| https://github.com/bdemann |
|
bdemann
| https://github.com/bdemann |
|
| https://github.com/RustPython/RustPython/pull/4878/files/b64a9f9c4e3aec6a26ecc69101140a2ff2c6e4c4 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4878 |
|
| https://github.com/lastmjs |
|
| https://github.com/youknowone |
|
| https://github.com/DimitrisJim |
|
| https://github.com/bdemann |
|
| https://github.com/fanninpm |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |