| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:dfd94908-da55-5c7a-040f-eb818ba8be85 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DF44:1A1C04:2313B23:2FE21B1:6B002DDE |
| html-safe-nonce | 2af3c4203e5ef65cf0807a86e018bc12eeae915619054a423c13837a1132e333 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjQ0OjFBMUMwNDoyMzEzQjIzOjJGRTIxQjE6NkIwMDJEREUiLCJ2aXNpdG9yX2lkIjoiNjkyODc0MjgxNTM4Mzk1Njk1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 08b21d195aba54bb0d5884bcdccf99eef3296f4c361f4d7682e7171937389a9a |
| hovercard-subject-tag | pull_request:1311277473 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/4873/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3b1596e2eae9b55690bae54fd43b48020dba8f5fb41a45541786aa52ddfec87d/RustPython/RustPython/pull/4873 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3b1596e2eae9b55690bae54fd43b48020dba8f5fb41a45541786aa52ddfec87d/RustPython/RustPython/pull/4873 |
| og:image:alt | I found #4686 is related to multiple design caveats. I originally tried to edit small enough to support the original PR, but found this way will reduce total cost of effort about them.
closes #4686... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | youknowone |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/RustPython/RustPython/pull/4873#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F4873 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F4873 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/4873 |
| Reload | https://github.com/RustPython/RustPython/pull/4873 |
| Reload | https://github.com/RustPython/RustPython/pull/4873 |
| RustPython | https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
| Code | https://github.com/RustPython/RustPython |
| Issues195 (195) | https://github.com/RustPython/RustPython/issues |
| Pull requests144 (144) | https://github.com/RustPython/RustPython/pulls |
| Discussions | https://github.com/RustPython/RustPython/discussions |
| Actions | https://github.com/RustPython/RustPython/actions |
| Projects | https://github.com/RustPython/RustPython/projects |
| Wiki | https://github.com/RustPython/RustPython/wiki |
| Security and quality | https://github.com/RustPython/RustPython/security |
| Insights | https://github.com/RustPython/RustPython/insights |
| https://github.com/RustPython/RustPython |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| youknowone:method | https://github.com/youknowone/RustPython/tree/method |
| Conversation | https://github.com/RustPython/RustPython/pull/4873 |
| Commits6 (6) | https://github.com/RustPython/RustPython/pull/4873/commits |
| Checks | https://github.com/RustPython/RustPython/pull/4873/checks |
| Files changed | https://github.com/RustPython/RustPython/pull/4873/files |
| Method overhaul with static PyMethodDef | https://github.com/RustPython/RustPython/pull/4873#top |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| youknowone:method | https://github.com/youknowone/RustPython/tree/method |
|
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Apr 12, 2023 | https://github.com/RustPython/RustPython/pull/4873#issue-1665018907 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4873 |
| #4686 | https://github.com/RustPython/RustPython/pull/4686 |
| #4686 | https://github.com/RustPython/RustPython/pull/4686 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4873 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| April 12, 2023 18:10 | https://github.com/RustPython/RustPython/pull/4873#event-8988549022 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/b6605fe1753dc71885f6d1d9e92d31cddfd7bf91..2fd0c36818a972f7a1073a36cb878d92349a11ff |
| b6605fe | https://github.com/RustPython/RustPython/commit/b6605fe1753dc71885f6d1d9e92d31cddfd7bf91 |
| 2fd0c36 | https://github.com/RustPython/RustPython/commit/2fd0c36818a972f7a1073a36cb878d92349a11ff |
|
Compare
| https://github.com/RustPython/RustPython/compare/b6605fe1753dc71885f6d1d9e92d31cddfd7bf91..2fd0c36818a972f7a1073a36cb878d92349a11ff |
| April 19, 2023 10:23 | https://github.com/RustPython/RustPython/pull/4873#event-9044932039 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Apr 19, 2023 | https://github.com/RustPython/RustPython/pull/4873#issuecomment-1514709196 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4873 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/2fd0c36818a972f7a1073a36cb878d92349a11ff..b3f26c2af70dd6335c56edfbd0c166f4f3b83cad |
| 2fd0c36 | https://github.com/RustPython/RustPython/commit/2fd0c36818a972f7a1073a36cb878d92349a11ff |
| b3f26c2 | https://github.com/RustPython/RustPython/commit/b3f26c2af70dd6335c56edfbd0c166f4f3b83cad |
|
Compare
| https://github.com/RustPython/RustPython/compare/2fd0c36818a972f7a1073a36cb878d92349a11ff..b3f26c2af70dd6335c56edfbd0c166f4f3b83cad |
| April 19, 2023 14:06 | https://github.com/RustPython/RustPython/pull/4873#event-9047089900 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Apr 21, 2023 | https://github.com/RustPython/RustPython/pull/4873#issuecomment-1518304670 |
| #4886 | https://github.com/RustPython/RustPython/pull/4886 |
| #4898 | https://github.com/RustPython/RustPython/pull/4898 |
| #4899 | https://github.com/RustPython/RustPython/pull/4899 |
| #4900 | https://github.com/RustPython/RustPython/pull/4900 |
| #4901 | https://github.com/RustPython/RustPython/pull/4901 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4873 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Apr 21, 2023 | https://github.com/RustPython/RustPython/pull/4873#issuecomment-1518305550 |
| @moreal | https://github.com/moreal |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4873 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/ae464381adf60d2e736913d4e3bb8977d3ffac16..2d5364da913e9cdbe64709584dab6afbbfd39b50 |
| ae46438 | https://github.com/RustPython/RustPython/commit/ae464381adf60d2e736913d4e3bb8977d3ffac16 |
| 2d5364d | https://github.com/RustPython/RustPython/commit/2d5364da913e9cdbe64709584dab6afbbfd39b50 |
|
Compare
| https://github.com/RustPython/RustPython/compare/ae464381adf60d2e736913d4e3bb8977d3ffac16..2d5364da913e9cdbe64709584dab6afbbfd39b50 |
| April 29, 2023 13:57 | https://github.com/RustPython/RustPython/pull/4873#event-9130781482 |
| youknowone | https://github.com/youknowone |
| April 30, 2023 00:17 | https://github.com/RustPython/RustPython/pull/4873#commits-pushed-2abf21b |
|
| https://github.com/youknowone |
| PyObject_SelfIter | https://github.com/RustPython/RustPython/pull/4873/commits/2abf21b134c699303ea41b29b84d16d7edde4f40 |
| 2abf21b | https://github.com/RustPython/RustPython/pull/4873/commits/2abf21b134c699303ea41b29b84d16d7edde4f40 |
|
| https://github.com/youknowone |
| Add missing with(Iterable) | https://github.com/RustPython/RustPython/pull/4873/commits/9b9dd1100a4331ee77ad00ab00684a95a6462286 |
| 9b9dd11 | https://github.com/RustPython/RustPython/pull/4873/commits/9b9dd1100a4331ee77ad00ab00684a95a6462286 |
|
| https://github.com/youknowone |
| Rename IterNextIterable -> SelfIter by following CPython | https://github.com/RustPython/RustPython/pull/4873/commits/9f58921a6f4cf423365649c69ab2c1e04f4566ac |
| 9f58921 | https://github.com/RustPython/RustPython/pull/4873/commits/9f58921a6f4cf423365649c69ab2c1e04f4566ac |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Apr 29, 2023
| https://github.com/RustPython/RustPython/pull/4873#ref-pullrequest-1689422977 |
|
Implement PyObject_SelfIter to actually share same function
#4945
| https://github.com/RustPython/RustPython/pull/4945 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Apr 29, 2023 | https://github.com/RustPython/RustPython/pull/4873#issuecomment-1528855248 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4873 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4873 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| April 30, 2023 03:27 | https://github.com/RustPython/RustPython/pull/4873#event-9131604107 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| DimitrisJim | https://github.com/DimitrisJim |
| coolreader18 | https://github.com/coolreader18 |
| qingshi163 | https://github.com/qingshi163 |
| April 30, 2023 03:27 | https://github.com/RustPython/RustPython/pull/4873#event-9131604282 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Apr 30, 2023 | https://github.com/RustPython/RustPython/pull/4873#issuecomment-1528929650 |
| @seungha-kim | https://github.com/seungha-kim |
| @moreal | https://github.com/moreal |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4873 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| fanninpm | https://github.com/fanninpm |
| April 30, 2023 03:27 | https://github.com/RustPython/RustPython/pull/4873#event-9131604446 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Apr 30, 2023
| https://github.com/RustPython/RustPython/pull/4873#ref-pullrequest-1620815347 |
|
[Draft] Make builtin method type same as that of builtin function
#4686
| https://github.com/RustPython/RustPython/pull/4686 |
|
| https://github.com/blue-pandaa |
|
| https://github.com/youknowone |
| Make builtin method type same as that of builtin function | https://github.com/RustPython/RustPython/pull/4873/commits/4a099ab6bc3e2029879e92feca5d18e425656a63 |
| 4a099ab | https://github.com/RustPython/RustPython/pull/4873/commits/4a099ab6bc3e2029879e92feca5d18e425656a63 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Apr 30, 2023 | https://github.com/RustPython/RustPython/pull/4873#event-9131822143 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/aacbe6210ae3937662d45dc8781e55e13cee2ca3..1dc96ad59948eb4a2a2c6ffac22035d6b166bf79 |
| aacbe62 | https://github.com/RustPython/RustPython/commit/aacbe6210ae3937662d45dc8781e55e13cee2ca3 |
| 1dc96ad | https://github.com/RustPython/RustPython/commit/1dc96ad59948eb4a2a2c6ffac22035d6b166bf79 |
|
Compare
| https://github.com/RustPython/RustPython/compare/aacbe6210ae3937662d45dc8781e55e13cee2ca3..1dc96ad59948eb4a2a2c6ffac22035d6b166bf79 |
| April 30, 2023 07:31 | https://github.com/RustPython/RustPython/pull/4873#event-9131824671 |
|
| https://github.com/youknowone |
| Method overhaul with PyMethodDef | https://github.com/RustPython/RustPython/pull/4873/commits/98eef0804e3e34def6e2610e9c1c57b3cb40075d |
| 98eef08 | https://github.com/RustPython/RustPython/pull/4873/commits/98eef0804e3e34def6e2610e9c1c57b3cb40075d |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/1dc96ad59948eb4a2a2c6ffac22035d6b166bf79..8d4d7bc25cff9b8607d7e49aa72c38c58ffddab5 |
| 1dc96ad | https://github.com/RustPython/RustPython/commit/1dc96ad59948eb4a2a2c6ffac22035d6b166bf79 |
| 8d4d7bc | https://github.com/RustPython/RustPython/commit/8d4d7bc25cff9b8607d7e49aa72c38c58ffddab5 |
|
Compare
| https://github.com/RustPython/RustPython/compare/1dc96ad59948eb4a2a2c6ffac22035d6b166bf79..8d4d7bc25cff9b8607d7e49aa72c38c58ffddab5 |
| April 30, 2023 08:34 | https://github.com/RustPython/RustPython/pull/4873#event-9131901212 |
|
| https://github.com/youknowone |
| Rename PyTypeFlags::METHOD_{DESCR => DESCRIPTOR} | https://github.com/RustPython/RustPython/pull/4873/commits/e73603945db23140fb540c65b7db623ac7cdd1ae |
| e736039 | https://github.com/RustPython/RustPython/pull/4873/commits/e73603945db23140fb540c65b7db623ac7cdd1ae |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/8d4d7bc25cff9b8607d7e49aa72c38c58ffddab5..e73603945db23140fb540c65b7db623ac7cdd1ae |
| 8d4d7bc | https://github.com/RustPython/RustPython/commit/8d4d7bc25cff9b8607d7e49aa72c38c58ffddab5 |
| e736039 | https://github.com/RustPython/RustPython/commit/e73603945db23140fb540c65b7db623ac7cdd1ae |
|
Compare
| https://github.com/RustPython/RustPython/compare/8d4d7bc25cff9b8607d7e49aa72c38c58ffddab5..e73603945db23140fb540c65b7db623ac7cdd1ae |
| April 30, 2023 08:45 | https://github.com/RustPython/RustPython/pull/4873#event-9131915020 |
| https://github.com/moreal |
| moreal | https://github.com/moreal |
|
Apr 30, 2023
| https://github.com/RustPython/RustPython/pull/4873#pullrequestreview-1407095011 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/4873/files/e73603945db23140fb540c65b7db623ac7cdd1ae |
| moreal | https://github.com/moreal |
| https://github.com/RustPython/RustPython/pull/4873#pullrequestreview-1407095011 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4873 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| 1dd5e84 | https://github.com/RustPython/RustPython/commit/1dd5e84c9a953b14503f5c8df419b1782991e3cd |
| May 5, 2023 | https://github.com/RustPython/RustPython/pull/4873#event-9175250773 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| May 5, 2023 09:53 | https://github.com/RustPython/RustPython/pull/4873#event-9175251249 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
May 20, 2023
| https://github.com/RustPython/RustPython/pull/4873#ref-issue-1002429083 |
|
BuiltinFunctionType and BuiltinMethodType are different
#3100
| https://github.com/RustPython/RustPython/issues/3100 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F4873 |
|
| https://github.com/moreal |
|
moreal
| https://github.com/moreal |
|
| https://github.com/RustPython/RustPython/pull/4873/files/e73603945db23140fb540c65b7db623ac7cdd1ae |
|
| https://github.com/qingshi163 |
|
qingshi163
| https://github.com/qingshi163 |
|
| https://github.com/DimitrisJim |
|
DimitrisJim
| https://github.com/DimitrisJim |
|
| https://github.com/coolreader18 |
|
coolreader18
| https://github.com/coolreader18 |
|
| https://github.com/fanninpm |
|
fanninpm
| https://github.com/fanninpm |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4873 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4873 |
|
| https://github.com/youknowone |
|
| https://github.com/moreal |
|
| https://github.com/blue-pandaa |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |