| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5a146dc6-71e4-d151-5759-370a52ac5576 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D2B0:9E1B2:2F2E0A9:3E63597:6B002670 |
| html-safe-nonce | a157f219223b9a6275694f815ed23f4c6fb66c1a884bf1cb46eb4318ba908669 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkIwOjlFMUIyOjJGMkUwQTk6M0U2MzU5Nzo2QjAwMjY3MCIsInZpc2l0b3JfaWQiOiI1MzEwNzY3NjYzNjI1MDIxMDQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8e57b1ed8c1951d3f2ebe41344da6792525577c66a36df2779514b1f53f50ca5 |
| hovercard-subject-tag | pull_request:1290008216 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/4766/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/02ea974fd760cc51eb2f45cfa1056149e4bad4d6af1100a12cc81317c4e554f0/RustPython/RustPython/pull/4766 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/02ea974fd760cc51eb2f45cfa1056149e4bad4d6af1100a12cc81317c4e554f0/RustPython/RustPython/pull/4766 |
| og:image:alt | More details can be found here
#4762
It was the last issue that made test_mod to fail, so I also removed the expectedFailure flag from that test. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MegasKomnenos |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/RustPython/RustPython/pull/4766#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F4766 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F4766 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/4766 |
| Reload | https://github.com/RustPython/RustPython/pull/4766 |
| Reload | https://github.com/RustPython/RustPython/pull/4766 |
| RustPython | https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
| Code | https://github.com/RustPython/RustPython |
| Issues195 (195) | https://github.com/RustPython/RustPython/issues |
| Pull requests144 (144) | https://github.com/RustPython/RustPython/pulls |
| Discussions | https://github.com/RustPython/RustPython/discussions |
| Actions | https://github.com/RustPython/RustPython/actions |
| Projects | https://github.com/RustPython/RustPython/projects |
| Wiki | https://github.com/RustPython/RustPython/wiki |
| Security and quality | https://github.com/RustPython/RustPython/security |
| Insights | https://github.com/RustPython/RustPython/insights |
| https://github.com/RustPython/RustPython |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| MegasKomnenos:test_mod | https://github.com/MegasKomnenos/RustPython/tree/test_mod |
| Conversation | https://github.com/RustPython/RustPython/pull/4766 |
| Commits5 (5) | https://github.com/RustPython/RustPython/pull/4766/commits |
| Checks | https://github.com/RustPython/RustPython/pull/4766/checks |
| Files changed | https://github.com/RustPython/RustPython/pull/4766/files |
| Allow try_update_quantity_from_tuple to set left alignment when needed | https://github.com/RustPython/RustPython/pull/4766#top |
| youknowone | https://github.com/youknowone |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| MegasKomnenos:test_mod | https://github.com/MegasKomnenos/RustPython/tree/test_mod |
|
| https://github.com/MegasKomnenos |
| MegasKomnenos | https://github.com/MegasKomnenos |
| Mar 25, 2023 | https://github.com/RustPython/RustPython/pull/4766#issue-1640484584 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4766 |
| #4762 | https://github.com/RustPython/RustPython/issues/4762 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4766 |
| MegasKomnenos | https://github.com/MegasKomnenos |
| March 25, 2023 20:32 | https://github.com/RustPython/RustPython/pull/4766#commits-pushed-84d91ab |
|
| https://github.com/MegasKomnenos |
| Fix | https://github.com/RustPython/RustPython/pull/4766/commits/84d91abaa1e4aaddc42539909f2061a6855a9f1d |
| RustPython#4762 | https://github.com/RustPython/RustPython/issues/4762 |
| 84d91ab | https://github.com/RustPython/RustPython/pull/4766/commits/84d91abaa1e4aaddc42539909f2061a6855a9f1d |
|
| https://github.com/MegasKomnenos |
| Remove expectedFailure flag from test_mod | https://github.com/RustPython/RustPython/pull/4766/commits/88bb32297832339f05effac9ae722af05b5b4add |
| 88bb322 | https://github.com/RustPython/RustPython/pull/4766/commits/88bb32297832339f05effac9ae722af05b5b4add |
|
| https://github.com/MegasKomnenos |
| Fix styling issues | https://github.com/RustPython/RustPython/pull/4766/commits/653cf2ee3881448d4ff57151a1395d8a9ba999a0 |
| 653cf2e | https://github.com/RustPython/RustPython/pull/4766/commits/653cf2ee3881448d4ff57151a1395d8a9ba999a0 |
| https://github.com/MegasKomnenos |
| MegasKomnenos | https://github.com/MegasKomnenos |
| Mar 25, 2023 | https://github.com/RustPython/RustPython/pull/4766#event-8845249219 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Mar 25, 2023
| https://github.com/RustPython/RustPython/pull/4766#pullrequestreview-1357859046 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/4766/files/653cf2ee3881448d4ff57151a1395d8a9ba999a0 |
| vm/src/cformat.rs | https://github.com/RustPython/RustPython/pull/4766/files/653cf2ee3881448d4ff57151a1395d8a9ba999a0#diff-9921a2eb7ba95db11a39c43319cb33f3239f88b50b0f30cb7da6b377a297609f |
| youknowone | https://github.com/youknowone |
| Mar 25, 2023 | https://github.com/RustPython/RustPython/pull/4766#discussion_r1148395280 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4766 |
| MegasKomnenos | https://github.com/MegasKomnenos |
| Mar 26, 2023 | https://github.com/RustPython/RustPython/pull/4766#discussion_r1148457548 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4766 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| DimitrisJim | https://github.com/DimitrisJim |
| March 25, 2023 16:02 | https://github.com/RustPython/RustPython/pull/4766#event-8845605855 |
| https://github.com/DimitrisJim |
| DimitrisJim | https://github.com/DimitrisJim |
|
Mar 25, 2023
| https://github.com/RustPython/RustPython/pull/4766#pullrequestreview-1357874020 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/4766/files/653cf2ee3881448d4ff57151a1395d8a9ba999a0 |
| common/src/cformat.rs | https://github.com/RustPython/RustPython/pull/4766/files/653cf2ee3881448d4ff57151a1395d8a9ba999a0#diff-d66cf24d02d47f562106667fda01d0ffbc50bb19a52072fd6667e2c06334613c |
| DimitrisJim | https://github.com/DimitrisJim |
| Mar 25, 2023 | https://github.com/RustPython/RustPython/pull/4766#discussion_r1148409495 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4766 |
| https://github.com/DimitrisJim |
| DimitrisJim | https://github.com/DimitrisJim |
|
Mar 25, 2023
| https://github.com/RustPython/RustPython/pull/4766#pullrequestreview-1357874595 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/4766/files/653cf2ee3881448d4ff57151a1395d8a9ba999a0 |
| vm/src/cformat.rs | https://github.com/RustPython/RustPython/pull/4766/files/653cf2ee3881448d4ff57151a1395d8a9ba999a0#diff-9921a2eb7ba95db11a39c43319cb33f3239f88b50b0f30cb7da6b377a297609f |
| DimitrisJim | https://github.com/DimitrisJim |
| Mar 25, 2023 | https://github.com/RustPython/RustPython/pull/4766#discussion_r1148409974 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4766 |
| MegasKomnenos | https://github.com/MegasKomnenos |
| Mar 26, 2023 | https://github.com/RustPython/RustPython/pull/4766#discussion_r1148458234 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4766 |
|
| https://github.com/MegasKomnenos |
| Separate left-adjustment logic from try_update_quantity_from_element … | https://github.com/RustPython/RustPython/pull/4766/commits/c3881ddf89042f37e19407bfda9e9cee4df89070 |
| c3881dd | https://github.com/RustPython/RustPython/pull/4766/commits/c3881ddf89042f37e19407bfda9e9cee4df89070 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Mar 26, 2023
| https://github.com/RustPython/RustPython/pull/4766#pullrequestreview-1357932640 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/4766/files/c3881ddf89042f37e19407bfda9e9cee4df89070 |
| youknowone | https://github.com/youknowone |
| https://github.com/RustPython/RustPython/pull/4766#pullrequestreview-1357932640 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4766 |
| vm/src/cformat.rs | https://github.com/RustPython/RustPython/pull/4766/files/c3881ddf89042f37e19407bfda9e9cee4df89070#diff-9921a2eb7ba95db11a39c43319cb33f3239f88b50b0f30cb7da6b377a297609f |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4766 |
| vm/src/cformat.rs | https://github.com/RustPython/RustPython/pull/4766/files/c3881ddf89042f37e19407bfda9e9cee4df89070#diff-9921a2eb7ba95db11a39c43319cb33f3239f88b50b0f30cb7da6b377a297609f |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4766 |
| vm/src/cformat.rs | https://github.com/RustPython/RustPython/pull/4766/files/c3881ddf89042f37e19407bfda9e9cee4df89070#diff-9921a2eb7ba95db11a39c43319cb33f3239f88b50b0f30cb7da6b377a297609f |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4766 |
| vm/src/cformat.rs | https://github.com/RustPython/RustPython/pull/4766/files/c3881ddf89042f37e19407bfda9e9cee4df89070#diff-9921a2eb7ba95db11a39c43319cb33f3239f88b50b0f30cb7da6b377a297609f |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4766 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
A-stdlib
| https://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3AA-stdlib |
|
z-ca-2023
| https://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3Az-ca-2023 |
| Mar 26, 2023 | https://github.com/RustPython/RustPython/pull/4766#event-8846565316 |
|
| https://github.com/MegasKomnenos |
| Implement styling feedback | https://github.com/RustPython/RustPython/pull/4766/commits/b7bb7a1f5267a0ea582e09276b8d3e9fb9c9d636 |
| b7bb7a1 | https://github.com/RustPython/RustPython/pull/4766/commits/b7bb7a1f5267a0ea582e09276b8d3e9fb9c9d636 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Mar 26, 2023
| https://github.com/RustPython/RustPython/pull/4766#pullrequestreview-1358004667 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/4766/files/b7bb7a1f5267a0ea582e09276b8d3e9fb9c9d636 |
| youknowone | https://github.com/youknowone |
| https://github.com/RustPython/RustPython/pull/4766#pullrequestreview-1358004667 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4766 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| 1795740 | https://github.com/RustPython/RustPython/commit/17957405175cd9a62cb15685c2a97ea9f53be28d |
| Mar 26, 2023 | https://github.com/RustPython/RustPython/pull/4766#event-8847099172 |
| https://github.com/YangSiJun528 |
| YangSiJun528 | https://github.com/YangSiJun528 |
|
Oct 6, 2026
| https://github.com/RustPython/RustPython/pull/4766#ref-issue-5723894128 |
|
Review issues that appear resolved for closure
#8982
| https://github.com/RustPython/RustPython/issues/8982 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F4766 |
|
| https://github.com/DimitrisJim |
|
DimitrisJim
| https://github.com/DimitrisJim |
|
| https://github.com/RustPython/RustPython/pull/4766/files/653cf2ee3881448d4ff57151a1395d8a9ba999a0 |
|
| https://github.com/youknowone |
|
youknowone
| https://github.com/youknowone |
|
| https://github.com/RustPython/RustPython/pull/4766/files/b7bb7a1f5267a0ea582e09276b8d3e9fb9c9d636 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4766 |
|
A-stdlib
| https://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3AA-stdlib |
|
z-ca-2023
| https://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3Az-ca-2023 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/4766 |
|
| https://github.com/MegasKomnenos |
|
| https://github.com/youknowone |
|
| https://github.com/DimitrisJim |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |