René's URL Explorer Experiment


Title: Support float() and float() by OddCoincidence · Pull Request #442 · RustPython/RustPython · GitHub

Open Graph Title: Support float() and float() by OddCoincidence · Pull Request #442 · RustPython/RustPython

X Title: Support float() and float() by OddCoincidence · Pull Request #442 · RustPython/RustPython

Description: NOTE: instead of using rust's f64::from_str, I used the lexical crate, whose flexibility more closely matches Python's float parsing (e.g. it correctly supports all the variations in the test case of this PR, while the former does not). As a nice bonus, it's 4000x faster. You can read more about it here.

Open Graph Description: NOTE: instead of using rust's f64::from_str, I used the lexical crate, whose flexibility more closely matches Python's float parsing (e.g. it correctly supports all the variations in the te...

X Description: NOTE: instead of using rust's f64::from_str, I used the lexical crate, whose flexibility more closely matches Python's float parsing (e.g. it correctly supports all the variations i...

Opengraph URL: https://github.com/RustPython/RustPython/pull/442

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:13572884-9a89-1fc0-1520-2d3331d303fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD5EE:183F01:B8B899:10D2EDA:6A58A35F
html-safe-nonce7bd4042d1f00c1a6bfe96be88a73be630bb6ea4ef283500b761e362945ceb021
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUVFOjE4M0YwMTpCOEI4OTk6MTBEMkVEQTo2QTU4QTM1RiIsInZpc2l0b3JfaWQiOiI3NjQ4MzcxMDA2NzkzODg0NTExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf84ef47876724798f5e734d3be84c8364275380b987e1e6c73939c601c1712ca
hovercard-subject-tagpull_request:252167701
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/442/files
twitter:imagehttps://avatars.githubusercontent.com/u/45985108?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/45985108?s=400&v=4
og:image:altNOTE: instead of using rust's f64::from_str, I used the lexical crate, whose flexibility more closely matches Python's float parsing (e.g. it correctly supports all the variations in the te...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/442/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F442%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F442%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/442/files
Reloadhttps://github.com/RustPython/RustPython/pull/442/files
Reloadhttps://github.com/RustPython/RustPython/pull/442/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/442/files
RustPython https://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Notifications https://github.com/login?return_to=%2FRustPython%2FRustPython
Fork 1.5k https://github.com/login?return_to=%2FRustPython%2FRustPython
Star 22.2k https://github.com/login?return_to=%2FRustPython%2FRustPython
Code https://github.com/RustPython/RustPython
Issues 287 https://github.com/RustPython/RustPython/issues
Pull requests 101 https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality 0 https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
Code https://github.com/RustPython/RustPython
Issues https://github.com/RustPython/RustPython/issues
Pull requests https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
windelbouwmanhttps://github.com/windelbouwman
RustPython:masterhttps://github.com/RustPython/RustPython/tree/master
OddCoincidence:float-parsinghttps://github.com/OddCoincidence/RustPython/tree/float-parsing
Conversation 3 https://github.com/RustPython/RustPython/pull/442
Commits 1 https://github.com/RustPython/RustPython/pull/442/commits
Checks 0 https://github.com/RustPython/RustPython/pull/442/checks
Files changed https://github.com/RustPython/RustPython/pull/442/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/442/files
Support float() and float() https://github.com/RustPython/RustPython/pull/442/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/442/files
38c0ea0 Support float() and float() OddCoincidence Feb 12, 2019 https://github.com/RustPython/RustPython/pull/442/commits/38c0ea06e53e49412d7e8e356b879321ee305923
Clear filters https://github.com/RustPython/RustPython/pull/442/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/442/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/442/files
Cargo.lock https://github.com/RustPython/RustPython/pull/442/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87e
floats.py https://github.com/RustPython/RustPython/pull/442/files#diff-cb2aba8acfd95e8a0030c1b837f606b06a966ca48a756f7994e9bb65f8e019d4
Cargo.toml https://github.com/RustPython/RustPython/pull/442/files#diff-98def556b29f953c96db531b74917518dd012025da819292b7d0a956710c2d2d
lib.rs https://github.com/RustPython/RustPython/pull/442/files#diff-76838f6ab6fdbcf4f9cc064b8ca4707ab930c026067eb62ae888def5752a06ba
objfloat.rs https://github.com/RustPython/RustPython/pull/442/files#diff-1db24a6c0b412c950f1c403aabca8899cc03e889f655e0acaa1a5e2bcb4196c6
Cargo.lockhttps://github.com/RustPython/RustPython/pull/442/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87e
View file https://github.com/OddCoincidence/RustPython/blob/38c0ea06e53e49412d7e8e356b879321ee305923/Cargo.lock
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/RustPython/RustPython/pull/442/files
tests/snippets/floats.pyhttps://github.com/RustPython/RustPython/pull/442/files#diff-cb2aba8acfd95e8a0030c1b837f606b06a966ca48a756f7994e9bb65f8e019d4
View file https://github.com/OddCoincidence/RustPython/blob/38c0ea06e53e49412d7e8e356b879321ee305923/tests/snippets/floats.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/442/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/442/files#diff-cb2aba8acfd95e8a0030c1b837f606b06a966ca48a756f7994e9bb65f8e019d4
https://github.com/RustPython/RustPython/pull/442/files#diff-cb2aba8acfd95e8a0030c1b837f606b06a966ca48a756f7994e9bb65f8e019d4
vm/Cargo.tomlhttps://github.com/RustPython/RustPython/pull/442/files#diff-98def556b29f953c96db531b74917518dd012025da819292b7d0a956710c2d2d
View file https://github.com/OddCoincidence/RustPython/blob/38c0ea06e53e49412d7e8e356b879321ee305923/vm/Cargo.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/442/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/442/files#diff-98def556b29f953c96db531b74917518dd012025da819292b7d0a956710c2d2d
vm/src/lib.rshttps://github.com/RustPython/RustPython/pull/442/files#diff-76838f6ab6fdbcf4f9cc064b8ca4707ab930c026067eb62ae888def5752a06ba
View file https://github.com/OddCoincidence/RustPython/blob/38c0ea06e53e49412d7e8e356b879321ee305923/vm/src/lib.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/442/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/442/files#diff-76838f6ab6fdbcf4f9cc064b8ca4707ab930c026067eb62ae888def5752a06ba
https://github.com/RustPython/RustPython/pull/442/files#diff-76838f6ab6fdbcf4f9cc064b8ca4707ab930c026067eb62ae888def5752a06ba
vm/src/obj/objfloat.rshttps://github.com/RustPython/RustPython/pull/442/files#diff-1db24a6c0b412c950f1c403aabca8899cc03e889f655e0acaa1a5e2bcb4196c6
View file https://github.com/OddCoincidence/RustPython/blob/38c0ea06e53e49412d7e8e356b879321ee305923/vm/src/obj/objfloat.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/442/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/442/files#diff-1db24a6c0b412c950f1c403aabca8899cc03e889f655e0acaa1a5e2bcb4196c6
https://github.com/RustPython/RustPython/pull/442/files#diff-1db24a6c0b412c950f1c403aabca8899cc03e889f655e0acaa1a5e2bcb4196c6
https://github.com/RustPython/RustPython/pull/442/files#diff-1db24a6c0b412c950f1c403aabca8899cc03e889f655e0acaa1a5e2bcb4196c6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.