Title: Use NotImplemented in binary operations by OddCoincidence · Pull Request #433 · RustPython/RustPython · GitHub
Open Graph Title: Use NotImplemented in binary operations by OddCoincidence · Pull Request #433 · RustPython/RustPython
X Title: Use NotImplemented in binary operations by OddCoincidence · Pull Request #433 · RustPython/RustPython
Description: Fixes #419. Updated VirtualMachine::call_or_unsupported to fallback on a returned NotImplemented value, rather than catching NotImplementedError. Updated objint and objfloat binary ops to return NotImplemented instead of raising NotImplementedError or raising ValueError directly. Factored out ValueError construction from VirtualMachine::call_or_unsupported as the TODO suggested. Use call_or_unsupported on eq/ne operations
Open Graph Description: Fixes #419. Updated VirtualMachine::call_or_unsupported to fallback on a returned NotImplemented value, rather than catching NotImplementedError. Updated objint and objfloat binary ops to return N...
X Description: Fixes #419. Updated VirtualMachine::call_or_unsupported to fallback on a returned NotImplemented value, rather than catching NotImplementedError. Updated objint and objfloat binary ops to return N...
Opengraph URL: https://github.com/RustPython/RustPython/pull/433
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3a59d0e4-ee14-f6b5-9892-2ff42ac87958 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E766:DD525:15E8E61:1D8E1DB:6A596C46 |
| html-safe-nonce | 61c8a048c1b2b196d4611d4d6a44bf72d0b0260b5de38cdb4ae732db8d7406c7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzY2OkRENTI1OjE1RThFNjE6MUQ4RTFEQjo2QTU5NkM0NiIsInZpc2l0b3JfaWQiOiIxMTc4Mjk5MDYzNjg4ODUwNTAyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b0be653bfc50a5feccb29f1d68c6902c6fc063d0091195094adde90fb306a568 |
| hovercard-subject-tag | pull_request:251753295 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/433/files |
| twitter:image | https://avatars.githubusercontent.com/u/45985108?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/45985108?s=400&v=4 |
| og:image:alt | Fixes #419. Updated VirtualMachine::call_or_unsupported to fallback on a returned NotImplemented value, rather than catching NotImplementedError. Updated objint and objfloat binary ops to return N... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | a540949572872b935b393b36db38922db390ae71c859537d741b8f3eb7e545b5 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 624bb50a7497aa346bef8cc3743af408a9ea10ca |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width