| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:dfde406b-a14e-c499-2204-493c2a2f5c92 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E8FC:20C95F:39EB8C:521777:6A59DA67 |
| html-safe-nonce | fb1f6a8c6407d7fbae46b9401a86d4989e4fcca0f475b41aeb9c5880516f5065 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOEZDOjIwQzk1RjozOUVCOEM6NTIxNzc3OjZBNTlEQTY3IiwidmlzaXRvcl9pZCI6IjE1MDgwMTEwOTYxNTIzNzczNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | dc4ab12927b43c6c50e33b8f51d2ac3606e27b9b5650d5f8b714f6577477d220 |
| hovercard-subject-tag | pull_request:251647142 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/410/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/727ed00bd63a62da941dfeb885a3681f5e8383fadba3e8d31aeb9f875ca73687/RustPython/RustPython/pull/410 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/727ed00bd63a62da941dfeb885a3681f5e8383fadba3e8d31aeb9f875ca73687/RustPython/RustPython/pull/410 |
| og:image:alt | The former required the addition of the NotImplemented constant to match cpython`s behavior. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | OddCoincidence |
| hostname | github.com |
| expected-hostname | github.com |
| None | ba3976babb66479b1c943a8edc0777d96157da48fadc0161f9ddb219deee8353 |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bfacf98c3b7ad151665d6ddd216469389872b251 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/RustPython/RustPython/pull/410#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F410 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F410 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/410 |
| Reload | https://github.com/RustPython/RustPython/pull/410 |
| Reload | https://github.com/RustPython/RustPython/pull/410 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/410 |
|
RustPython
| https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
|
Notifications
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Fork
1.5k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Star
22.2k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
288
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
100
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security and quality
0
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security and quality
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
| windelbouwman | https://github.com/windelbouwman |
| RustPython:master | https://github.com/RustPython/RustPython/tree/master |
| OddCoincidence:complex | https://github.com/OddCoincidence/RustPython/tree/complex |
| Conversation | https://github.com/RustPython/RustPython/pull/410 |
| Commits6 (6) | https://github.com/RustPython/RustPython/pull/410/commits |
| Checks | https://github.com/RustPython/RustPython/pull/410/checks |
| Files changed | https://github.com/RustPython/RustPython/pull/410/files |
| Add complex.{__abs__, __eq__, __neg__} | https://github.com/RustPython/RustPython/pull/410#top |
| windelbouwman | https://github.com/windelbouwman |
| RustPython:master | https://github.com/RustPython/RustPython/tree/master |
| OddCoincidence:complex | https://github.com/OddCoincidence/RustPython/tree/complex |
|
| https://github.com/OddCoincidence |
| OddCoincidence | https://github.com/OddCoincidence |
| Feb 9, 2019 | https://github.com/RustPython/RustPython/pull/410#issue-408388329 |
| NotImplemented | https://docs.python.org/3/library/constants.html#NotImplemented |
| Please reload this page | https://github.com/RustPython/RustPython/pull/410 |
| OddCoincidence | https://github.com/OddCoincidence |
| February 8, 2019 18:20 | https://github.com/RustPython/RustPython/pull/410#commits-pushed-fc863aa |
|
| https://github.com/OddCoincidence |
| Add complex.__abs__ | https://github.com/RustPython/RustPython/pull/410/commits/fc863aaba5466e8c109fa3f8e9b2209aaeaa3e11 |
| fc863aa | https://github.com/RustPython/RustPython/pull/410/commits/fc863aaba5466e8c109fa3f8e9b2209aaeaa3e11 |
|
| https://github.com/OddCoincidence |
| Add complex.{__eq__, __neg__} | https://github.com/RustPython/RustPython/pull/410/commits/d66ca54a2d05d83b1629b53921cd79a6eba0350f |
| d66ca54 | https://github.com/RustPython/RustPython/pull/410/commits/d66ca54a2d05d83b1629b53921cd79a6eba0350f |
|
| https://github.com/OddCoincidence |
| Add NotImplemented built-in constant | https://github.com/RustPython/RustPython/pull/410/commits/520f71f354ff5ec1af554cc4b8fdc603f48b84c9 |
| 520f71f | https://github.com/RustPython/RustPython/pull/410/commits/520f71f354ff5ec1af554cc4b8fdc603f48b84c9 |
| https://github.com/OddCoincidence |
| OddCoincidence | https://github.com/OddCoincidence |
| force-pushed | https://github.com/RustPython/RustPython/compare/17fc07b7664ebfbd9e703703db4dd56feaa16906..520f71f354ff5ec1af554cc4b8fdc603f48b84c9 |
| 17fc07b | https://github.com/RustPython/RustPython/commit/17fc07b7664ebfbd9e703703db4dd56feaa16906 |
| 520f71f | https://github.com/RustPython/RustPython/commit/520f71f354ff5ec1af554cc4b8fdc603f48b84c9 |
|
Compare
| https://github.com/RustPython/RustPython/compare/17fc07b7664ebfbd9e703703db4dd56feaa16906..520f71f354ff5ec1af554cc4b8fdc603f48b84c9 |
| February 9, 2019 03:24 | https://github.com/RustPython/RustPython/pull/410#event-2128551843 |
| https://github.com/cthulahoops |
| cthulahoops | https://github.com/cthulahoops |
| Feb 9, 2019 | https://github.com/RustPython/RustPython/pull/410#issuecomment-462033980 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/410 |
| https://github.com/windelbouwman |
| windelbouwman | https://github.com/windelbouwman |
| Feb 9, 2019 | https://github.com/RustPython/RustPython/pull/410#issuecomment-462053849 |
| @cthulahoops | https://github.com/cthulahoops |
| Please reload this page | https://github.com/RustPython/RustPython/pull/410 |
| https://github.com/windelbouwman |
| windelbouwman | https://github.com/windelbouwman |
|
Feb 9, 2019
| https://github.com/RustPython/RustPython/pull/410#pullrequestreview-201866633 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/410/files/520f71f354ff5ec1af554cc4b8fdc603f48b84c9 |
| vm/src/pyobject.rs | https://github.com/RustPython/RustPython/pull/410/files/520f71f354ff5ec1af554cc4b8fdc603f48b84c9#diff-84524dac95852f23d03df0b427c833911eb825066c10e1bbeac03a99db0d5caa |
| windelbouwman | https://github.com/windelbouwman |
| Feb 9, 2019 | https://github.com/RustPython/RustPython/pull/410#discussion_r255302142 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/410 |
| https://github.com/OddCoincidence |
| OddCoincidence | https://github.com/OddCoincidence |
| Feb 9, 2019 | https://github.com/RustPython/RustPython/pull/410#event-2128794745 |
|
| https://github.com/OddCoincidence |
| Avoid using magic methods in tests where possible | https://github.com/RustPython/RustPython/pull/410/commits/09dc751869e1216c97132004baba42cc5872e9ec |
| 09dc751 | https://github.com/RustPython/RustPython/pull/410/commits/09dc751869e1216c97132004baba42cc5872e9ec |
|
Add reversed builtin and range.__reversed__
#385
| https://github.com/RustPython/RustPython/pull/385 |
|
Conflation of NotImplemented and NotImplementedError
#419
| https://github.com/RustPython/RustPython/issues/419 |
| https://github.com/OddCoincidence |
| OddCoincidence | https://github.com/OddCoincidence |
| Feb 9, 2019 | https://github.com/RustPython/RustPython/pull/410#issuecomment-462066996 |
| @cthulahoops | https://github.com/cthulahoops |
| #419 | https://github.com/RustPython/RustPython/issues/419 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/410 |
|
| https://github.com/OddCoincidence |
| Disable broken test for now | https://github.com/RustPython/RustPython/pull/410/commits/d3d73bdc227a8711f1b45b85950163be7aa6200c |
| d3d73bd | https://github.com/RustPython/RustPython/pull/410/commits/d3d73bdc227a8711f1b45b85950163be7aa6200c |
| https://github.com/cthulahoops |
| cthulahoops | https://github.com/cthulahoops |
| Feb 10, 2019 | https://github.com/RustPython/RustPython/pull/410#issuecomment-462120794 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/410 |
|
| https://github.com/windelbouwman |
| Merge branch 'master' into complex | https://github.com/RustPython/RustPython/pull/410/commits/94db145ae8591d153f209ac8a2d2a62439fa3900 |
| 94db145 | https://github.com/RustPython/RustPython/pull/410/commits/94db145ae8591d153f209ac8a2d2a62439fa3900 |
| https://github.com/windelbouwman |
| windelbouwman | https://github.com/windelbouwman |
| Feb 10, 2019 | https://github.com/RustPython/RustPython/pull/410#issuecomment-462121550 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/410 |
| https://github.com/windelbouwman |
| windelbouwman | https://github.com/windelbouwman |
| 03a2aad | https://github.com/RustPython/RustPython/commit/03a2aad82ddcfe2e800097604c60066f466548ca |
| Feb 10, 2019 | https://github.com/RustPython/RustPython/pull/410#event-2129163967 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F410 |
|
| https://github.com/windelbouwman |
|
windelbouwman
| https://github.com/windelbouwman |
|
| https://github.com/RustPython/RustPython/pull/410/files/520f71f354ff5ec1af554cc4b8fdc603f48b84c9 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/410 |
|
| https://github.com/OddCoincidence |
|
| https://github.com/cthulahoops |
|
| https://github.com/windelbouwman |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |