| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5d8dd05a-0b0b-2515-c7e1-a2444819c9d3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CD6C:1B38B1:2857376:34A4024:696B5F1F |
| html-safe-nonce | 359334ee24b04677edd3367259538a4eb9203110be6d8e307fe3478d1a6fea59 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDZDOjFCMzhCMToyODU3Mzc2OjM0QTQwMjQ6Njk2QjVGMUYiLCJ2aXNpdG9yX2lkIjoiODk0NDEyMTI3NTE1MTUwNzIzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d50c12c35da94bf3016726998e9fc65ef32d09ac6be515ea15c3fea7b1ac08d0 |
| hovercard-subject-tag | pull_request:784050498 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/3445/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b6be50a5f4cb578dcf65c6fa1819e68352517588a4590dfa2cadf1690e3d06af/RustPython/RustPython/pull/3445 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b6be50a5f4cb578dcf65c6fa1819e68352517588a4590dfa2cadf1690e3d06af/RustPython/RustPython/pull/3445 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | qingshi163 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/RustPython/RustPython/pull/3445#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F3445 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F3445 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/3445 |
| Reload | https://github.com/RustPython/RustPython/pull/3445 |
| Reload | https://github.com/RustPython/RustPython/pull/3445 |
|
RustPython
| https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
|
Notifications
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Fork
1.4k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Star
21.7k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
278
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
89
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
0
| https://github.com/RustPython/RustPython/projects |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/RustPython/RustPython/security |
| Please reload this page | https://github.com/RustPython/RustPython/pull/3445 |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/RustPython/RustPython/pull/3445#issue-comment-box |
| qingshi163 | https://github.com/qingshi163 |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| qingshi163:main | https://github.com/qingshi163/RustPython/tree/main |
|
Refactor and new sequence traits, generic sequence operation
| https://github.com/RustPython/RustPython/pull/3445#top |
| qingshi163 | https://github.com/qingshi163 |
| RustPython:main | https://github.com/RustPython/RustPython/tree/main |
| qingshi163:main | https://github.com/qingshi163/RustPython/tree/main |
|
Conversation
10
| https://github.com/RustPython/RustPython/pull/3445 |
|
Commits
7
| https://github.com/RustPython/RustPython/pull/3445/commits |
|
Checks
0
| https://github.com/RustPython/RustPython/pull/3445/checks |
|
Files changed
| https://github.com/RustPython/RustPython/pull/3445/files |
| Please reload this page | https://github.com/RustPython/RustPython/pull/3445 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
|
| https://github.com/qingshi163 |
| qingshi163 | https://github.com/qingshi163 |
| Nov 18, 2021 | https://github.com/RustPython/RustPython/pull/3445#issue-1057721630 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/3445 |
| https://github.com/qingshi163 |
| qingshi163 | https://github.com/qingshi163 |
| Nov 19, 2021 | https://github.com/RustPython/RustPython/pull/3445#issuecomment-973778825 |
| #3316 | https://github.com/RustPython/RustPython/pull/3316 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/3445 |
| https://github.com/qingshi163 |
| qingshi163 | https://github.com/qingshi163 |
| November 19, 2021 06:02 | https://github.com/RustPython/RustPython/pull/3445#event-5643254247 |
| https://github.com/qingshi163 |
| qingshi163 | https://github.com/qingshi163 |
| Nov 19, 2021 | https://github.com/RustPython/RustPython/pull/3445#event-5643254731 |
| https://github.com/qingshi163 |
| qingshi163 | https://github.com/qingshi163 |
| youknowone | https://github.com/youknowone |
| November 19, 2021 06:02 | https://github.com/RustPython/RustPython/pull/3445#event-5643254906 |
| https://github.com/qingshi163 |
| qingshi163 | https://github.com/qingshi163 |
|
Nov 19, 2021
| https://github.com/RustPython/RustPython/pull/3445#pullrequestreview-811516025 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/3445/files |
| vm/src/stdlib/collections.rs | https://github.com/RustPython/RustPython/pull/3445/files#diff-ce464b2d355a28bc8044537a60f49fa306d844a8aa54b8c0b04cfbe2e121e5f9 |
| qingshi163 | https://github.com/qingshi163 |
| Nov 19, 2021 | https://github.com/RustPython/RustPython/pull/3445#discussion_r753411447 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/3445 |
| qingshi163 | https://github.com/qingshi163 |
| Nov 19, 2021 | https://github.com/RustPython/RustPython/pull/3445#discussion_r753421627 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @DimitrisJim | https://github.com/DimitrisJim |
| @youknowone | https://github.com/youknowone |
| Please reload this page | https://github.com/RustPython/RustPython/pull/3445 |
| youknowone | https://github.com/youknowone |
| Nov 20, 2021 | https://github.com/RustPython/RustPython/pull/3445#discussion_r753612205 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/3445 |
| https://github.com/Snowapril |
| Snowapril | https://github.com/Snowapril |
|
Nov 20, 2021
| https://github.com/RustPython/RustPython/pull/3445#pullrequestreview-811830777 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/3445/files |
| vm/src/sequence.rs | https://github.com/RustPython/RustPython/pull/3445/files#diff-a8d786316431a8ee2a4715ddec2708b8925f027f4c47f08463e775a4595cc15e |
| Snowapril | https://github.com/Snowapril |
| Nov 20, 2021 | https://github.com/RustPython/RustPython/pull/3445#discussion_r753676351 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/3445 |
| qingshi163 | https://github.com/qingshi163 |
| Nov 20, 2021 | https://github.com/RustPython/RustPython/pull/3445#discussion_r753682078 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/3445 |
| youknowone | https://github.com/youknowone |
| Nov 20, 2021 | https://github.com/RustPython/RustPython/pull/3445#discussion_r753714353 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/3445 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Nov 21, 2021
| https://github.com/RustPython/RustPython/pull/3445#pullrequestreview-811794747 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/3445/files |
| vm/src/builtins/list.rs | https://github.com/RustPython/RustPython/pull/3445/files#diff-cf69cd941706585c03d2f19797d6ead7a3d9d789be406bab23d454a830ee625a |
| youknowone | https://github.com/youknowone |
| Nov 20, 2021 | https://github.com/RustPython/RustPython/pull/3445#discussion_r753628646 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/3445 |
| vm/src/sequence.rs | https://github.com/RustPython/RustPython/pull/3445/files#diff-a8d786316431a8ee2a4715ddec2708b8925f027f4c47f08463e775a4595cc15e |
| youknowone | https://github.com/youknowone |
| Nov 20, 2021 | https://github.com/RustPython/RustPython/pull/3445#discussion_r753629400 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/3445 |
| vm/src/sequence.rs | https://github.com/RustPython/RustPython/pull/3445/files#diff-a8d786316431a8ee2a4715ddec2708b8925f027f4c47f08463e775a4595cc15e |
| youknowone | https://github.com/youknowone |
| Nov 20, 2021 | https://github.com/RustPython/RustPython/pull/3445#discussion_r753713849 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/3445 |
| vm/src/sequence.rs | https://github.com/RustPython/RustPython/pull/3445/files#diff-a8d786316431a8ee2a4715ddec2708b8925f027f4c47f08463e775a4595cc15e |
| youknowone | https://github.com/youknowone |
| Nov 20, 2021 | https://github.com/RustPython/RustPython/pull/3445#discussion_r753714353 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/3445 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Nov 21, 2021
| https://github.com/RustPython/RustPython/pull/3445#pullrequestreview-811931777 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/3445/files |
| qingshi163 | https://github.com/qingshi163 |
| November 22, 2021 08:12 | https://github.com/RustPython/RustPython/pull/3445#commits-pushed-aef9531 |
|
| https://github.com/qingshi163 |
| refactor sequence generic mutable sequence item equal op | https://github.com/RustPython/RustPython/pull/3445/commits/aef9531bdc1c1fe6ddee2dd4ac9caa7bfc266618 |
| aef9531 | https://github.com/RustPython/RustPython/pull/3445/commits/aef9531bdc1c1fe6ddee2dd4ac9caa7bfc266618 |
|
| https://github.com/qingshi163 |
| sequence generic for pydeque | https://github.com/RustPython/RustPython/pull/3445/commits/66cf6b5309ec83bb1f38fca4569a8a3bb5eb36ae |
| 66cf6b5 | https://github.com/RustPython/RustPython/pull/3445/commits/66cf6b5309ec83bb1f38fca4569a8a3bb5eb36ae |
|
| https://github.com/qingshi163 |
| replace usize::MAX with Optioned | https://github.com/RustPython/RustPython/pull/3445/commits/aff1e3dd6f4c9c918c23ab43b23767960f50dd38 |
| aff1e3d | https://github.com/RustPython/RustPython/pull/3445/commits/aff1e3dd6f4c9c918c23ab43b23767960f50dd38 |
|
| https://github.com/qingshi163 |
| sequence op for array | https://github.com/RustPython/RustPython/pull/3445/commits/bc9e1ea74fbe3b78ee27883150dd169f16872b61 |
| bc9e1ea | https://github.com/RustPython/RustPython/pull/3445/commits/bc9e1ea74fbe3b78ee27883150dd169f16872b61 |
|
| https://github.com/qingshi163 |
| fix overflow error instead memory error for index overflow | https://github.com/RustPython/RustPython/pull/3445/commits/d52c3ec1d1322724d1b7c34b79183abf3a8dc52a |
| d52c3ec | https://github.com/RustPython/RustPython/pull/3445/commits/d52c3ec1d1322724d1b7c34b79183abf3a8dc52a |
|
| https://github.com/qingshi163 |
| fixup | https://github.com/RustPython/RustPython/pull/3445/commits/d8d9113d6286e9315023c9a254036a321b4760aa |
| d8d9113 | https://github.com/RustPython/RustPython/pull/3445/commits/d8d9113d6286e9315023c9a254036a321b4760aa |
|
| https://github.com/qingshi163 |
| optimize reserve vec for imul | https://github.com/RustPython/RustPython/pull/3445/commits/878f52bdbe6641bd21aa828ebff0d590e4a38031 |
| 878f52b | https://github.com/RustPython/RustPython/pull/3445/commits/878f52bdbe6641bd21aa828ebff0d590e4a38031 |
| https://github.com/qingshi163 |
| qingshi163 | https://github.com/qingshi163 |
| force-pushed | https://github.com/RustPython/RustPython/compare/a253ab133d8fd033c49484d8bc1e6e74d16842f4..878f52bdbe6641bd21aa828ebff0d590e4a38031 |
| a253ab1 | https://github.com/RustPython/RustPython/commit/a253ab133d8fd033c49484d8bc1e6e74d16842f4 |
| 878f52b | https://github.com/RustPython/RustPython/commit/878f52bdbe6641bd21aa828ebff0d590e4a38031 |
|
Compare
| https://github.com/RustPython/RustPython/compare/a253ab133d8fd033c49484d8bc1e6e74d16842f4..878f52bdbe6641bd21aa828ebff0d590e4a38031 |
| November 22, 2021 06:23 | https://github.com/RustPython/RustPython/pull/3445#event-5651640704 |
| https://github.com/qingshi163 |
| qingshi163 | https://github.com/qingshi163 |
| 908b239 | https://github.com/RustPython/RustPython/commit/908b239572725cea277a3a27952f76085cc058eb |
| Nov 22, 2021 | https://github.com/RustPython/RustPython/pull/3445#event-5651861737 |
| https://github.com/qingshi163 |
| qingshi163 | https://github.com/qingshi163 |
| November 22, 2021 07:21 | https://github.com/RustPython/RustPython/pull/3445#event-5651862016 |
| youknowone | https://github.com/youknowone |
|
Nov 26, 2021
| https://github.com/RustPython/RustPython/pull/3445#ref-commit-448f7e4 |
|
| https://github.com/youknowone |
| test_bigrepeat is fixed | https://github.com/youknowone/RustPython/commit/448f7e46cc0fb0e0b7328cc607f302800f262b01 |
| 448f7e4 | https://github.com/youknowone/RustPython/commit/448f7e46cc0fb0e0b7328cc607f302800f262b01 |
| RustPython#3445 | https://github.com/RustPython/RustPython/pull/3445 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
May 28, 2022
| https://github.com/RustPython/RustPython/pull/3445#ref-issue-1020089102 |
|
Implement protocols (Abstract obejcts layer)
#3244
| https://github.com/RustPython/RustPython/issues/3244 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F3445 |
|
| https://github.com/youknowone |
|
youknowone
| https://github.com/youknowone |
|
| https://github.com/RustPython/RustPython/pull/3445/files/a253ab133d8fd033c49484d8bc1e6e74d16842f4 |
|
| https://github.com/Snowapril |
|
Snowapril
| https://github.com/Snowapril |
|
| https://github.com/RustPython/RustPython/pull/3445/files/528a641bc989faf0cd725961938754fd24b727ab |
| Please reload this page | https://github.com/RustPython/RustPython/pull/3445 |
|
| https://github.com/qingshi163 |
|
| https://github.com/youknowone |
|
| https://github.com/Snowapril |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |