René's URL Explorer Experiment


Title: make dict iterator use atomic operation by eldpswp99 · Pull Request #2927 · RustPython/RustPython · GitHub

Open Graph Title: make dict iterator use atomic operation by eldpswp99 · Pull Request #2927 · RustPython/RustPython

X Title: make dict iterator use atomic operation by eldpswp99 · Pull Request #2927 · RustPython/RustPython

Description: A Python Interpreter written in Rust. Contribute to RustPython/RustPython development by creating an account on GitHub.

Open Graph Description: in #2915, there was a comment to use only fetch_add, not using load & store to maintain atomic operation. since dict iterator has this load & store, change to use fetch_add.

X Description: in #2915, there was a comment to use only fetch_add, not using load & store to maintain atomic operation. since dict iterator has this load & store, change to use fetch_add.

Opengraph URL: https://github.com/RustPython/RustPython/pull/2927

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5bf269fe-910a-7d68-5e4e-0e3b7b9822dc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id810A:E0ADF:188F142:1EF4199:6B022475
html-safe-nonce39a88990f5a1f6894a21b83ad527510fe701ab387572d478be06c681fa93ca33
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTBBOkUwQURGOjE4OEYxNDI6MUVGNDE5OTo2QjAyMjQ3NSIsInZpc2l0b3JfaWQiOiIzMTU4MzQzMDY4MDY3OTY0MDIxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5b91294ec236b61d16cdf4accdffcaa132d9cdb0d9da18da5b1e559522156fc3
hovercard-subject-tagpull_request:717248161
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/2927/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3186fe9bd7a29d2ff3fb4980edef8f935d0602246fb7313fc948efc085b86706/RustPython/RustPython/pull/2927
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3186fe9bd7a29d2ff3fb4980edef8f935d0602246fb7313fc948efc085b86706/RustPython/RustPython/pull/2927
og:image:altin #2915, there was a comment to use only fetch_add, not using load & store to maintain atomic operation. since dict iterator has this load & store, change to use fetch_add.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameeldpswp99
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/2927#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2927
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2927
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/2927
Reloadhttps://github.com/RustPython/RustPython/pull/2927
Reloadhttps://github.com/RustPython/RustPython/pull/2927
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests130 (130)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
https://github.com/RustPython/RustPython
youknowonehttps://github.com/youknowone
RustPython:masterhttps://github.com/RustPython/RustPython/tree/master
eldpswp99:make-dict-iterator-use-atomic-operationhttps://github.com/eldpswp99/RustPython/tree/make-dict-iterator-use-atomic-operation
Conversationhttps://github.com/RustPython/RustPython/pull/2927
Commits2 (2)https://github.com/RustPython/RustPython/pull/2927/commits
Checkshttps://github.com/RustPython/RustPython/pull/2927/checks
Files changedhttps://github.com/RustPython/RustPython/pull/2927/files
make dict iterator use atomic operationhttps://github.com/RustPython/RustPython/pull/2927#top
youknowonehttps://github.com/youknowone
RustPython:masterhttps://github.com/RustPython/RustPython/tree/master
eldpswp99:make-dict-iterator-use-atomic-operationhttps://github.com/eldpswp99/RustPython/tree/make-dict-iterator-use-atomic-operation
https://github.com/eldpswp99
eldpswp99https://github.com/eldpswp99
Aug 22, 2021https://github.com/RustPython/RustPython/pull/2927#issue-976283254
#2915https://github.com/RustPython/RustPython/pull/2915
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2927
https://github.com/eldpswp99
make dict iterator use atomic operationhttps://github.com/RustPython/RustPython/pull/2927/commits/b6cd761e01102ca7d2913265f1bfda180fcdb446
b6cd761https://github.com/RustPython/RustPython/pull/2927/commits/b6cd761e01102ca7d2913265f1bfda180fcdb446
https://github.com/youknowone
youknowonehttps://github.com/youknowone
DimitrisJimhttps://github.com/DimitrisJim
coolreader18https://github.com/coolreader18
youknowonehttps://github.com/youknowone
youknowonehttps://github.com/youknowone
August 22, 2021 06:19https://github.com/RustPython/RustPython/pull/2927#event-5190497292
https://github.com/coolreader18
coolreader18https://github.com/coolreader18
Aug 22, 2021 https://github.com/RustPython/RustPython/pull/2927#pullrequestreview-735544307
View reviewed changes https://github.com/RustPython/RustPython/pull/2927/files/b6cd761e01102ca7d2913265f1bfda180fcdb446
coolreader18https://github.com/coolreader18
https://github.com/RustPython/RustPython/pull/2927#pullrequestreview-735544307
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2927
vm/src/dictdatatype.rshttps://github.com/RustPython/RustPython/pull/2927/files/b6cd761e01102ca7d2913265f1bfda180fcdb446#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
coolreader18https://github.com/coolreader18
Aug 22, 2021https://github.com/RustPython/RustPython/pull/2927#discussion_r693451125
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2927
eldpswp99https://github.com/eldpswp99
Aug 22, 2021https://github.com/RustPython/RustPython/pull/2927#discussion_r693454166
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2927
eldpswp99https://github.com/eldpswp99
Aug 22, 2021https://github.com/RustPython/RustPython/pull/2927#discussion_r693476389
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@coolreader18https://github.com/coolreader18
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2927
https://github.com/eldpswp99
change function name to represent atomic functionhttps://github.com/RustPython/RustPython/pull/2927/commits/19ce63720022d8e1afabe4dc2683a4137d6ceb1d
19ce637https://github.com/RustPython/RustPython/pull/2927/commits/19ce63720022d8e1afabe4dc2683a4137d6ceb1d
https://github.com/youknowone
youknowonehttps://github.com/youknowone
Aug 22, 2021 https://github.com/RustPython/RustPython/pull/2927#pullrequestreview-735566643
View reviewed changes https://github.com/RustPython/RustPython/pull/2927/files/19ce63720022d8e1afabe4dc2683a4137d6ceb1d
vm/src/builtins/dict.rshttps://github.com/RustPython/RustPython/pull/2927/files/19ce63720022d8e1afabe4dc2683a4137d6ceb1d#diff-aec5b89f34446c0d6c48bc4c4ddd59a83757612cc4b9705186d967c7234f7984
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2927
vm/src/builtins/dict.rshttps://github.com/RustPython/RustPython/pull/2927/files/19ce63720022d8e1afabe4dc2683a4137d6ceb1d#diff-aec5b89f34446c0d6c48bc4c4ddd59a83757612cc4b9705186d967c7234f7984
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2927
vm/src/dictdatatype.rshttps://github.com/RustPython/RustPython/pull/2927/files/19ce63720022d8e1afabe4dc2683a4137d6ceb1d#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2927
vm/src/dictdatatype.rshttps://github.com/RustPython/RustPython/pull/2927/files/19ce63720022d8e1afabe4dc2683a4137d6ceb1d#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2927
https://github.com/youknowone
youknowonehttps://github.com/youknowone
force-pushedhttps://github.com/RustPython/RustPython/compare/a75c279897abc39fd0559c3910e54450b6ca2226..19ce63720022d8e1afabe4dc2683a4137d6ceb1d
a75c279https://github.com/RustPython/RustPython/commit/a75c279897abc39fd0559c3910e54450b6ca2226
19ce637https://github.com/RustPython/RustPython/commit/19ce63720022d8e1afabe4dc2683a4137d6ceb1d
Compare https://github.com/RustPython/RustPython/compare/a75c279897abc39fd0559c3910e54450b6ca2226..19ce63720022d8e1afabe4dc2683a4137d6ceb1d
August 22, 2021 11:26https://github.com/RustPython/RustPython/pull/2927#event-5190736759
https://github.com/youknowone
youknowonehttps://github.com/youknowone
488e756https://github.com/RustPython/RustPython/commit/488e756f67e04a7f1bc0e2b062f4813342a6b3cb
Aug 22, 2021https://github.com/RustPython/RustPython/pull/2927#event-5190736995
https://github.com/youknowone
youknowonehttps://github.com/youknowone
z-ca-2021 https://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3Az-ca-2021
Oct 16, 2021https://github.com/RustPython/RustPython/pull/2927#event-5472929486
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2927
https://github.com/youknowone
youknowone https://github.com/youknowone
https://github.com/RustPython/RustPython/pull/2927/files/19ce63720022d8e1afabe4dc2683a4137d6ceb1d
https://github.com/coolreader18
coolreader18 https://github.com/coolreader18
https://github.com/RustPython/RustPython/pull/2927/files/b6cd761e01102ca7d2913265f1bfda180fcdb446
https://github.com/DimitrisJim
DimitrisJim https://github.com/DimitrisJim
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2927
z-ca-2021 https://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3Az-ca-2021
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2927
https://github.com/eldpswp99
https://github.com/youknowone
https://github.com/coolreader18
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.