| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5bf269fe-910a-7d68-5e4e-0e3b7b9822dc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 810A:E0ADF:188F142:1EF4199:6B022475 |
| html-safe-nonce | 39a88990f5a1f6894a21b83ad527510fe701ab387572d478be06c681fa93ca33 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTBBOkUwQURGOjE4OEYxNDI6MUVGNDE5OTo2QjAyMjQ3NSIsInZpc2l0b3JfaWQiOiIzMTU4MzQzMDY4MDY3OTY0MDIxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5b91294ec236b61d16cdf4accdffcaa132d9cdb0d9da18da5b1e559522156fc3 |
| hovercard-subject-tag | pull_request:717248161 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/2927/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3186fe9bd7a29d2ff3fb4980edef8f935d0602246fb7313fc948efc085b86706/RustPython/RustPython/pull/2927 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3186fe9bd7a29d2ff3fb4980edef8f935d0602246fb7313fc948efc085b86706/RustPython/RustPython/pull/2927 |
| og:image:alt | in #2915, there was a comment to use only fetch_add, not using load & store to maintain atomic operation.
since dict iterator has this load & store, change to use fetch_add. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | eldpswp99 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/RustPython/RustPython/pull/2927#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2927 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2927 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/2927 |
| Reload | https://github.com/RustPython/RustPython/pull/2927 |
| Reload | https://github.com/RustPython/RustPython/pull/2927 |
| RustPython | https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
| Code | https://github.com/RustPython/RustPython |
| Issues195 (195) | https://github.com/RustPython/RustPython/issues |
| Pull requests130 (130) | https://github.com/RustPython/RustPython/pulls |
| Discussions | https://github.com/RustPython/RustPython/discussions |
| Actions | https://github.com/RustPython/RustPython/actions |
| Projects | https://github.com/RustPython/RustPython/projects |
| Wiki | https://github.com/RustPython/RustPython/wiki |
| Security and quality | https://github.com/RustPython/RustPython/security |
| Insights | https://github.com/RustPython/RustPython/insights |
| https://github.com/RustPython/RustPython |
| youknowone | https://github.com/youknowone |
| RustPython:master | https://github.com/RustPython/RustPython/tree/master |
| eldpswp99:make-dict-iterator-use-atomic-operation | https://github.com/eldpswp99/RustPython/tree/make-dict-iterator-use-atomic-operation |
| Conversation | https://github.com/RustPython/RustPython/pull/2927 |
| Commits2 (2) | https://github.com/RustPython/RustPython/pull/2927/commits |
| Checks | https://github.com/RustPython/RustPython/pull/2927/checks |
| Files changed | https://github.com/RustPython/RustPython/pull/2927/files |
| make dict iterator use atomic operation | https://github.com/RustPython/RustPython/pull/2927#top |
| youknowone | https://github.com/youknowone |
| RustPython:master | https://github.com/RustPython/RustPython/tree/master |
| eldpswp99:make-dict-iterator-use-atomic-operation | https://github.com/eldpswp99/RustPython/tree/make-dict-iterator-use-atomic-operation |
|
| https://github.com/eldpswp99 |
| eldpswp99 | https://github.com/eldpswp99 |
| Aug 22, 2021 | https://github.com/RustPython/RustPython/pull/2927#issue-976283254 |
| #2915 | https://github.com/RustPython/RustPython/pull/2915 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2927 |
|
| https://github.com/eldpswp99 |
| make dict iterator use atomic operation | https://github.com/RustPython/RustPython/pull/2927/commits/b6cd761e01102ca7d2913265f1bfda180fcdb446 |
| b6cd761 | https://github.com/RustPython/RustPython/pull/2927/commits/b6cd761e01102ca7d2913265f1bfda180fcdb446 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| DimitrisJim | https://github.com/DimitrisJim |
| coolreader18 | https://github.com/coolreader18 |
| youknowone | https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| August 22, 2021 06:19 | https://github.com/RustPython/RustPython/pull/2927#event-5190497292 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
|
Aug 22, 2021
| https://github.com/RustPython/RustPython/pull/2927#pullrequestreview-735544307 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/2927/files/b6cd761e01102ca7d2913265f1bfda180fcdb446 |
| coolreader18 | https://github.com/coolreader18 |
| https://github.com/RustPython/RustPython/pull/2927#pullrequestreview-735544307 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2927 |
| vm/src/dictdatatype.rs | https://github.com/RustPython/RustPython/pull/2927/files/b6cd761e01102ca7d2913265f1bfda180fcdb446#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656 |
| coolreader18 | https://github.com/coolreader18 |
| Aug 22, 2021 | https://github.com/RustPython/RustPython/pull/2927#discussion_r693451125 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2927 |
| eldpswp99 | https://github.com/eldpswp99 |
| Aug 22, 2021 | https://github.com/RustPython/RustPython/pull/2927#discussion_r693454166 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2927 |
| eldpswp99 | https://github.com/eldpswp99 |
| Aug 22, 2021 | https://github.com/RustPython/RustPython/pull/2927#discussion_r693476389 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @coolreader18 | https://github.com/coolreader18 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2927 |
|
| https://github.com/eldpswp99 |
| change function name to represent atomic function | https://github.com/RustPython/RustPython/pull/2927/commits/19ce63720022d8e1afabe4dc2683a4137d6ceb1d |
| 19ce637 | https://github.com/RustPython/RustPython/pull/2927/commits/19ce63720022d8e1afabe4dc2683a4137d6ceb1d |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
Aug 22, 2021
| https://github.com/RustPython/RustPython/pull/2927#pullrequestreview-735566643 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/2927/files/19ce63720022d8e1afabe4dc2683a4137d6ceb1d |
| vm/src/builtins/dict.rs | https://github.com/RustPython/RustPython/pull/2927/files/19ce63720022d8e1afabe4dc2683a4137d6ceb1d#diff-aec5b89f34446c0d6c48bc4c4ddd59a83757612cc4b9705186d967c7234f7984 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2927 |
| vm/src/builtins/dict.rs | https://github.com/RustPython/RustPython/pull/2927/files/19ce63720022d8e1afabe4dc2683a4137d6ceb1d#diff-aec5b89f34446c0d6c48bc4c4ddd59a83757612cc4b9705186d967c7234f7984 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2927 |
| vm/src/dictdatatype.rs | https://github.com/RustPython/RustPython/pull/2927/files/19ce63720022d8e1afabe4dc2683a4137d6ceb1d#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2927 |
| vm/src/dictdatatype.rs | https://github.com/RustPython/RustPython/pull/2927/files/19ce63720022d8e1afabe4dc2683a4137d6ceb1d#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2927 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| force-pushed | https://github.com/RustPython/RustPython/compare/a75c279897abc39fd0559c3910e54450b6ca2226..19ce63720022d8e1afabe4dc2683a4137d6ceb1d |
| a75c279 | https://github.com/RustPython/RustPython/commit/a75c279897abc39fd0559c3910e54450b6ca2226 |
| 19ce637 | https://github.com/RustPython/RustPython/commit/19ce63720022d8e1afabe4dc2683a4137d6ceb1d |
|
Compare
| https://github.com/RustPython/RustPython/compare/a75c279897abc39fd0559c3910e54450b6ca2226..19ce63720022d8e1afabe4dc2683a4137d6ceb1d |
| August 22, 2021 11:26 | https://github.com/RustPython/RustPython/pull/2927#event-5190736759 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| 488e756 | https://github.com/RustPython/RustPython/commit/488e756f67e04a7f1bc0e2b062f4813342a6b3cb |
| Aug 22, 2021 | https://github.com/RustPython/RustPython/pull/2927#event-5190736995 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
|
z-ca-2021
| https://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3Az-ca-2021 |
| Oct 16, 2021 | https://github.com/RustPython/RustPython/pull/2927#event-5472929486 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2927 |
|
| https://github.com/youknowone |
|
youknowone
| https://github.com/youknowone |
|
| https://github.com/RustPython/RustPython/pull/2927/files/19ce63720022d8e1afabe4dc2683a4137d6ceb1d |
|
| https://github.com/coolreader18 |
|
coolreader18
| https://github.com/coolreader18 |
|
| https://github.com/RustPython/RustPython/pull/2927/files/b6cd761e01102ca7d2913265f1bfda180fcdb446 |
|
| https://github.com/DimitrisJim |
|
DimitrisJim
| https://github.com/DimitrisJim |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2927 |
|
z-ca-2021
| https://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3Az-ca-2021 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2927 |
|
| https://github.com/eldpswp99 |
|
| https://github.com/youknowone |
|
| https://github.com/coolreader18 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |