René's URL Explorer Experiment


Title: Fix __class_getitem__ slightly by coolreader18 · Pull Request #2924 · RustPython/RustPython · GitHub

Open Graph Title: Fix __class_getitem__ slightly by coolreader18 · Pull Request #2924 · RustPython/RustPython

X Title: Fix __class_getitem__ slightly by coolreader18 · Pull Request #2924 · RustPython/RustPython

Description: A Python Interpreter written in Rust. Contribute to RustPython/RustPython development by creating an account on GitHub.

Open Graph Description: Because it was treating __class_getitem__ as a special method, subscripting a type from typing would just always return type instead of some sort of _GenericAlias

X Description: Because it was treating __class_getitem__ as a special method, subscripting a type from typing would just always return type instead of some sort of _GenericAlias

Opengraph URL: https://github.com/RustPython/RustPython/pull/2924

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9d53c044-f756-19dc-fad3-5130447a002c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD196:2AF0D8:9E7389:C67A97:6B021AAA
html-safe-nonce57ed3bbaac6fa66e56987b24c68ba8d8202a0cb967438207fa06dc25ebe1b190
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTk2OjJBRjBEODo5RTczODk6QzY3QTk3OjZCMDIxQUFBIiwidmlzaXRvcl9pZCI6IjE1NDQ3MjAwNjI1MDQ2MzkxNDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccf4952bedac8d6c4cf2bd5a1ba9390b2ab6d6f7b1b96ab8198f98b9a16f49ca1
hovercard-subject-tagpull_request:717210367
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/2924/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0ae85b0e1ad844e31d8f1c32a2c315a04743cd6d28d8981a504d12a14944d990/RustPython/RustPython/pull/2924
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0ae85b0e1ad844e31d8f1c32a2c315a04743cd6d28d8981a504d12a14944d990/RustPython/RustPython/pull/2924
og:image:altBecause it was treating __class_getitem__ as a special method, subscripting a type from typing would just always return type instead of some sort of _GenericAlias
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecoolreader18
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/2924#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2924
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2924
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/2924
Reloadhttps://github.com/RustPython/RustPython/pull/2924
Reloadhttps://github.com/RustPython/RustPython/pull/2924
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests130 (130)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
https://github.com/RustPython/RustPython
youknowonehttps://github.com/youknowone
masterhttps://github.com/RustPython/RustPython/tree/master
fix-class_getitemhttps://github.com/RustPython/RustPython/tree/fix-class_getitem
Conversationhttps://github.com/RustPython/RustPython/pull/2924
Commits4 (4)https://github.com/RustPython/RustPython/pull/2924/commits
Checkshttps://github.com/RustPython/RustPython/pull/2924/checks
Files changedhttps://github.com/RustPython/RustPython/pull/2924/files
Fix __class_getitem__ slightlyhttps://github.com/RustPython/RustPython/pull/2924#top
youknowonehttps://github.com/youknowone
masterhttps://github.com/RustPython/RustPython/tree/master
fix-class_getitemhttps://github.com/RustPython/RustPython/tree/fix-class_getitem
https://github.com/coolreader18
coolreader18https://github.com/coolreader18
Aug 21, 2021https://github.com/RustPython/RustPython/pull/2924#issue-976223988
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2924
coolreader18https://github.com/coolreader18
August 21, 2021 16:11https://github.com/RustPython/RustPython/pull/2924#commits-pushed-95a947d
https://github.com/coolreader18
__class_getitem__ isn't a special methodhttps://github.com/RustPython/RustPython/pull/2924/commits/95a947d7e35e7dc8a8cb1c4da30c90a052f6bec1
95a947dhttps://github.com/RustPython/RustPython/pull/2924/commits/95a947d7e35e7dc8a8cb1c4da30c90a052f6bec1
https://github.com/coolreader18
Don't define object.__class_getitem__https://github.com/RustPython/RustPython/pull/2924/commits/0494472c0eaafecafd078a8a68d99a09c8129bf4
0494472https://github.com/RustPython/RustPython/pull/2924/commits/0494472c0eaafecafd078a8a68d99a09c8129bf4
https://github.com/coolreader18
Add test.test_genericclass from CPython 3.8https://github.com/RustPython/RustPython/pull/2924/commits/5cfdb3361ebe45fe061693b150200fd93a1d5668
5cfdb33https://github.com/RustPython/RustPython/pull/2924/commits/5cfdb3361ebe45fe061693b150200fd93a1d5668
https://github.com/coolreader18
Give correct error message for type with __mro_entries__ passed to ty…https://github.com/RustPython/RustPython/pull/2924/commits/4a71420f4ff891171c715313509b069426511fa5
4a71420https://github.com/RustPython/RustPython/pull/2924/commits/4a71420f4ff891171c715313509b069426511fa5
https://github.com/youknowone
youknowonehttps://github.com/youknowone
Aug 22, 2021https://github.com/RustPython/RustPython/pull/2924#issuecomment-903209619
@fanninpmhttps://github.com/fanninpm
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2924
https://github.com/youknowone
youknowonehttps://github.com/youknowone
Aug 22, 2021https://github.com/RustPython/RustPython/pull/2924#issuecomment-903209689
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2924
https://github.com/youknowone
youknowonehttps://github.com/youknowone
Aug 22, 2021 https://github.com/RustPython/RustPython/pull/2924#pullrequestreview-735539253
View reviewed changes https://github.com/RustPython/RustPython/pull/2924/files/4a71420f4ff891171c715313509b069426511fa5
https://github.com/youknowone
youknowonehttps://github.com/youknowone
3f25fachttps://github.com/RustPython/RustPython/commit/3f25fac4d541c276ad2042fb3521876138daeae3
Aug 22, 2021https://github.com/RustPython/RustPython/pull/2924#event-5190444268
https://github.com/youknowone
youknowonehttps://github.com/youknowone
August 22, 2021 04:51https://github.com/RustPython/RustPython/pull/2924#event-5190444273
https://github.com/moreal
morealhttps://github.com/moreal
Aug 22, 2021 https://github.com/RustPython/RustPython/pull/2924#ref-issue-874547070
Missing dataclasses module #2623 https://github.com/RustPython/RustPython/issues/2623
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2924
https://github.com/youknowone
youknowone https://github.com/youknowone
https://github.com/RustPython/RustPython/pull/2924/files/4a71420f4ff891171c715313509b069426511fa5
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2924
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2924
https://github.com/coolreader18
https://github.com/youknowone
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.