René's URL Explorer Experiment


Title: adjust dict reverse iterator next to new dict entries structure by eldpswp99 · Pull Request #2915 · RustPython/RustPython · GitHub

Open Graph Title: adjust dict reverse iterator next to new dict entries structure by eldpswp99 · Pull Request #2915 · RustPython/RustPython

X Title: adjust dict reverse iterator next to new dict entries structure by eldpswp99 · Pull Request #2915 · RustPython/RustPython

Description: dict entries was changed due to remain order even when delete any element. #2902 in this PR, i only adjust dict reverse iterator next function to this new dict entries structure. however, there remains some issue about detecting the change while iteration. before, the size change was equivalent to the change of the dictionary entries, so it was easy to detect it however, making deletion not to erase entries, and insertion occurs on next_new_entry_idx, it is hard to detect change during iteration. all iterators with dict may have this issue.

Open Graph Description: dict entries was changed due to remain order even when delete any element. #2902 in this PR, i only adjust dict reverse iterator next function to this new dict entries structure. however, there rem...

X Description: dict entries was changed due to remain order even when delete any element. #2902 in this PR, i only adjust dict reverse iterator next function to this new dict entries structure. however, there rem...

Opengraph URL: https://github.com/RustPython/RustPython/pull/2915

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3fd15b3e-5974-ed90-7012-e0226d5847b4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9FCE:22DB35:4613391:593A408:6B022D9F
html-safe-noncec23e65d57c4a63d008e3dd7d7f9dce67ff8bbeeb3d49e12c646a34b0defdeafe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RkNFOjIyREIzNTo0NjEzMzkxOjU5M0E0MDg6NkIwMjJEOUYiLCJ2aXNpdG9yX2lkIjoiODI0NjU1NTA4NTIxNjI5NjM1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbc2eb8dffa358b556cc708958f77b1cc9c3b49924f861220eefdfec8d6039946
hovercard-subject-tagpull_request:715936882
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/2915/files
twitter:imagehttps://avatars.githubusercontent.com/u/58476210?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/58476210?s=400&v=4
og:image:altdict entries was changed due to remain order even when delete any element. #2902 in this PR, i only adjust dict reverse iterator next function to this new dict entries structure. however, there rem...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/2915/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2915%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2915%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/2915/files
Reloadhttps://github.com/RustPython/RustPython/pull/2915/files
Reloadhttps://github.com/RustPython/RustPython/pull/2915/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests130 (130)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:masterhttps://github.com/RustPython/RustPython/tree/master
eldpswp99:adjust-dict-reverse-iterator-to-new-dict-entrieshttps://github.com/eldpswp99/RustPython/tree/adjust-dict-reverse-iterator-to-new-dict-entries
Conversation 2 https://github.com/RustPython/RustPython/pull/2915
Commits 2 https://github.com/RustPython/RustPython/pull/2915/commits
Checks 0 https://github.com/RustPython/RustPython/pull/2915/checks
Files changed https://github.com/RustPython/RustPython/pull/2915/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2915/files
adjust dict reverse iterator next to new dict entries structure https://github.com/RustPython/RustPython/pull/2915/files#top
Show all changes 2 commits https://github.com/RustPython/RustPython/pull/2915/files
509c6ba adjust dict reverse iterator next to new dict entries structure eldpswp99 Aug 19, 2021 https://github.com/RustPython/RustPython/pull/2915/commits/509c6ba2f3cc9ecc38ab712c13fc6b4c23e8270c
7f5f84b make position to use only atomic operation eldpswp99 Aug 21, 2021 https://github.com/RustPython/RustPython/pull/2915/commits/7f5f84b3a18292c5b2c617a3a4ca08027619169d
Clear filters https://github.com/RustPython/RustPython/pull/2915/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2915/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2915/files
test_dict.py https://github.com/RustPython/RustPython/pull/2915/files#diff-a040eea55332ac71f2f5db3966f7261f844ceceaac675cc0f30eb973d2593a26
dict.rs https://github.com/RustPython/RustPython/pull/2915/files#diff-aec5b89f34446c0d6c48bc4c4ddd59a83757612cc4b9705186d967c7234f7984
dictdatatype.rs https://github.com/RustPython/RustPython/pull/2915/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Lib/test/test_dict.pyhttps://github.com/RustPython/RustPython/pull/2915/files#diff-a040eea55332ac71f2f5db3966f7261f844ceceaac675cc0f30eb973d2593a26
View file https://github.com/eldpswp99/RustPython/blob/7f5f84b3a18292c5b2c617a3a4ca08027619169d/Lib/test/test_dict.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/2915/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/2915/files#diff-a040eea55332ac71f2f5db3966f7261f844ceceaac675cc0f30eb973d2593a26
https://github.com/RustPython/RustPython/pull/2915/files#diff-a040eea55332ac71f2f5db3966f7261f844ceceaac675cc0f30eb973d2593a26
vm/src/builtins/dict.rshttps://github.com/RustPython/RustPython/pull/2915/files#diff-aec5b89f34446c0d6c48bc4c4ddd59a83757612cc4b9705186d967c7234f7984
View file https://github.com/eldpswp99/RustPython/blob/7f5f84b3a18292c5b2c617a3a4ca08027619169d/vm/src/builtins/dict.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/2915/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/2915/files#diff-aec5b89f34446c0d6c48bc4c4ddd59a83757612cc4b9705186d967c7234f7984
https://github.com/RustPython/RustPython/pull/2915/files#diff-aec5b89f34446c0d6c48bc4c4ddd59a83757612cc4b9705186d967c7234f7984
https://github.com/RustPython/RustPython/pull/2915/files#diff-aec5b89f34446c0d6c48bc4c4ddd59a83757612cc4b9705186d967c7234f7984
https://github.com/RustPython/RustPython/pull/2915/files#diff-aec5b89f34446c0d6c48bc4c4ddd59a83757612cc4b9705186d967c7234f7984
vm/src/dictdatatype.rshttps://github.com/RustPython/RustPython/pull/2915/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
View file https://github.com/eldpswp99/RustPython/blob/7f5f84b3a18292c5b2c617a3a4ca08027619169d/vm/src/dictdatatype.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/2915/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/2915/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2915/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2915/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2915/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.