René's URL Explorer Experiment


Title: make dict remain order after delete by eldpswp99 · Pull Request #2902 · RustPython/RustPython · GitHub

Open Graph Title: make dict remain order after delete by eldpswp99 · Pull Request #2902 · RustPython/RustPython

X Title: make dict remain order after delete by eldpswp99 · Pull Request #2902 · RustPython/RustPython

Description: closes #2550 before: dict is insertion order in CPython, but in RustPython the order was broken when deletion is occured after: it follows the CPython way. when it is deleted, make the entry to None, and remove this None only if resize occurs. added nentries to optimize popitem. it is equal to the index for next insertion (= last valid entry index + 1)

Open Graph Description: closes #2550 before: dict is insertion order in CPython, but in RustPython the order was broken when deletion is occured after: it follows the CPython way. when it is deleted, make the entry t...

X Description: closes #2550 before: dict is insertion order in CPython, but in RustPython the order was broken when deletion is occured after: it follows the CPython way. when it is deleted, make the entry t...

Opengraph URL: https://github.com/RustPython/RustPython/pull/2902

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ebd2828d-7095-3b5a-4d29-1cd7c18eaf70
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8180:2E9831:1BC8CA0:24AE157:6B022043
html-safe-nonce3619e926c217f345061bf8197517c0368721a0bc59d0c71ef9836bab8216a265
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTgwOjJFOTgzMToxQkM4Q0EwOjI0QUUxNTc6NkIwMjIwNDMiLCJ2aXNpdG9yX2lkIjoiNDU4MTUzMDE1MTg3MjE4NDk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace9b5f040b12d355620c938315a1bc4227ef80f6b240958c6f1b4c0b388b2f841
hovercard-subject-tagpull_request:714200466
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/2902/files
twitter:imagehttps://avatars.githubusercontent.com/u/58476210?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/58476210?s=400&v=4
og:image:altcloses #2550 before: dict is insertion order in CPython, but in RustPython the order was broken when deletion is occured after: it follows the CPython way. when it is deleted, make the entry t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/2902/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2902%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2902%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/2902/files
Reloadhttps://github.com/RustPython/RustPython/pull/2902/files
Reloadhttps://github.com/RustPython/RustPython/pull/2902/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests130 (130)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
coolreader18https://github.com/coolreader18
RustPython:masterhttps://github.com/RustPython/RustPython/tree/master
eldpswp99:dict-remain-order-after-deletehttps://github.com/eldpswp99/RustPython/tree/dict-remain-order-after-delete
Conversation 36 https://github.com/RustPython/RustPython/pull/2902
Commits 6 https://github.com/RustPython/RustPython/pull/2902/commits
Checks 0 https://github.com/RustPython/RustPython/pull/2902/checks
Files changed https://github.com/RustPython/RustPython/pull/2902/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2902/files
make dict remain order after delete https://github.com/RustPython/RustPython/pull/2902/files#top
Show all changes 6 commits https://github.com/RustPython/RustPython/pull/2902/files
b1207ab Update test_collections.py fermian Apr 12, 2021 https://github.com/RustPython/RustPython/pull/2902/commits/b1207ab39e9ba085b9b1624f2f01829904ffd08f
4e9f9ff change Dict Entries type Vec to Vec> eldpswp99 Aug 16, 2021 https://github.com/RustPython/RustPython/pull/2902/commits/4e9f9ff129c68b252742e2518a440914fbeef3f8
ce99057 make dict delete remains order eldpswp99 Aug 17, 2021 https://github.com/RustPython/RustPython/pull/2902/commits/ce99057c8103e19dee486fca212668e8d07e5b61
fca7b41 optimize popitem using nentries which implies next insertion index eldpswp99 Aug 17, 2021 https://github.com/RustPython/RustPython/pull/2902/commits/fca7b4174427cdb97011d97c86a65cd7c733fda7
b49a1e9 remove test_ordered_dict delitem expected failure to passed test eldpswp99 Aug 17, 2021 https://github.com/RustPython/RustPython/pull/2902/commits/b49a1e9f5ed03ee16d6125987497143582d38609
564eb29 resolving deadlock and redundant lookup, grammatic mistakes eldpswp99 Aug 17, 2021 https://github.com/RustPython/RustPython/pull/2902/commits/564eb2991e194e2d85abf259bfdd4efa9679bd5d
Clear filters https://github.com/RustPython/RustPython/pull/2902/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2902/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2902/files
test_collections.py https://github.com/RustPython/RustPython/pull/2902/files#diff-a2a882635e20e8e9439f090d33513502a7af648286efebfa4e4bc37270c44784
test_dict.py https://github.com/RustPython/RustPython/pull/2902/files#diff-a040eea55332ac71f2f5db3966f7261f844ceceaac675cc0f30eb973d2593a26
test_ordered_dict.py https://github.com/RustPython/RustPython/pull/2902/files#diff-f19d3282864344be60adeaf4a9307e192a8e871155bca771d000449d74aa5639
dictdatatype.rs https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Lib/test/test_collections.pyhttps://github.com/RustPython/RustPython/pull/2902/files#diff-a2a882635e20e8e9439f090d33513502a7af648286efebfa4e4bc37270c44784
View file https://github.com/eldpswp99/RustPython/blob/564eb2991e194e2d85abf259bfdd4efa9679bd5d/Lib/test/test_collections.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/2902/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/2902/files#diff-a2a882635e20e8e9439f090d33513502a7af648286efebfa4e4bc37270c44784
https://github.com/RustPython/RustPython/pull/2902/files#diff-a2a882635e20e8e9439f090d33513502a7af648286efebfa4e4bc37270c44784
Lib/test/test_dict.pyhttps://github.com/RustPython/RustPython/pull/2902/files#diff-a040eea55332ac71f2f5db3966f7261f844ceceaac675cc0f30eb973d2593a26
View file https://github.com/eldpswp99/RustPython/blob/564eb2991e194e2d85abf259bfdd4efa9679bd5d/Lib/test/test_dict.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/2902/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/2902/files#diff-a040eea55332ac71f2f5db3966f7261f844ceceaac675cc0f30eb973d2593a26
https://github.com/RustPython/RustPython/pull/2902/files#diff-a040eea55332ac71f2f5db3966f7261f844ceceaac675cc0f30eb973d2593a26
https://github.com/RustPython/RustPython/pull/2902/files#diff-a040eea55332ac71f2f5db3966f7261f844ceceaac675cc0f30eb973d2593a26
https://github.com/RustPython/RustPython/pull/2902/files#diff-a040eea55332ac71f2f5db3966f7261f844ceceaac675cc0f30eb973d2593a26
Lib/test/test_ordered_dict.pyhttps://github.com/RustPython/RustPython/pull/2902/files#diff-f19d3282864344be60adeaf4a9307e192a8e871155bca771d000449d74aa5639
View file https://github.com/eldpswp99/RustPython/blob/564eb2991e194e2d85abf259bfdd4efa9679bd5d/Lib/test/test_ordered_dict.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/2902/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/2902/files#diff-f19d3282864344be60adeaf4a9307e192a8e871155bca771d000449d74aa5639
https://github.com/RustPython/RustPython/pull/2902/files#diff-f19d3282864344be60adeaf4a9307e192a8e871155bca771d000449d74aa5639
vm/src/dictdatatype.rshttps://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
View file https://github.com/eldpswp99/RustPython/blob/564eb2991e194e2d85abf259bfdd4efa9679bd5d/vm/src/dictdatatype.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/2902/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.