react-profiling 0
react-import-map react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern /:user_id/:repository/pull/:id/commits(.:format)
route-controller pull_requests
route-action commits
fetch-nonce v2:06f74954-95f0-62db-afe7-1060483ba820
current-catalog-service-hash ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id 8F46:187C1E:1BD13A8:24A8781:6B02204A
html-safe-nonce 52b583efad8dc1ce98cb0fcf0acb0aaddf7071c12413543aaef4ee82bf6809c3
visitor-payload eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjQ2OjE4N0MxRToxQkQxM0E4OjI0QTg3ODE6NkIwMjIwNEEiLCJ2aXNpdG9yX2lkIjoiMTk4MDg1MDEzMjg3MDExMTMwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac 3c2697d59a5c3c7ef661ff2340ba68c8740dadb342f99d84fef4569889017f06
hovercard-subject-tag pull_request:714200466
github-keyboard-shortcuts repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verification Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-url https://collector.github.com/github/collect
analytics-location ///pull_requests/show/commits
fb:app_id 1401488693436528
apple-itunes-app app-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/2902/commits
twitter:image https://opengraph.githubassets.com/3186fe9bd7a29d2ff3fb4980edef8f935d0602246fb7313fc948efc085b86706/RustPython/RustPython/pull/2902
twitter:card summary_large_image
og:image https://opengraph.githubassets.com/3186fe9bd7a29d2ff3fb4980edef8f935d0602246fb7313fc948efc085b86706/RustPython/RustPython/pull/2902
og:image:alt closes #2550
before:
dict is insertion order in CPython, but in RustPython the order was broken when deletion is occured
after:
it follows the CPython way. when it is deleted, make the entry t...
og:image:width 1200
og:image:height 600
og:site_name GitHub
og:type object
og:author:username eldpswp99
hostname github.com
expected-hostname github.com
None 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-control no-cache
go-import github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id 39710557
octolytics-dimension-user_login RustPython
octolytics-dimension-repository_id 135201145
octolytics-dimension-repository_nwo RustPython/RustPython
octolytics-dimension-repository_public true
octolytics-dimension-repository_is_fork false
octolytics-dimension-repository_network_root_id 135201145
octolytics-dimension-repository_network_root_nwo RustPython/RustPython
turbo-body-classes logged-out env-production page-responsive
disable-turbo false
browser-stats-url https://api.github.com/_private/browser/stats
browser-errors-url https://api.github.com/_private/browser/errors
release 423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-target full
theme-color #1e2327
color-scheme light dark
react-app-name pull-requests
Skip to content https://github.com/RustPython/RustPython/pull/2902/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2902%2Fcommits
GitHubRepository hosting, code review, and collaboration https://github.com/platform
CopilotAI coding agent for tasks, projects, and automated work https://github.com/features/copilot
ActionsCI/CD and automation https://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcement https://github.com/features/code-quality
CodespacesCloud development environments https://github.com/features/codespaces
Code SecurityVulnerability detection and remediation https://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak prevention https://github.com/security/advanced-security/secret-protection
All Features https://github.com/features
Documentation https://docs.github.com/en
Training https://learn.github.com/skills
Certifications https://learn.github.com/credentials
Build with Copilot https://github.com/features/ai
Customize Copilot https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrations https://github.com/marketplace
Trending repos https://github.com/trending
GitHub Sponsors https://github.com/open-source/sponsors
Developer articles https://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. https://github.blog/changelog/
Enterprises https://github.com/enterprise
Team https://github.com/team
Startups https://github.com/enterprise/startups
Nonprofits https://github.com/solutions/industry/nonprofits
Healthcare https://github.com/solutions/industry/healthcare
Financial services https://github.com/solutions/industry/financial-services
Manufacturing https://github.com/solutions/industry/manufacturing
Government https://github.com/solutions/industry/government
See all industries https://github.com/solutions/industry
Why GitHub https://github.com/why-github
Customer Stories https://github.com/customer-stories
Business insights https://github.com/solutions/executive-insights
Trust Center https://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code security https://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI features https://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 support https://github.com/enterprise/premium-support
Documentation https://docs.github.com/en
Resource center https://github.com/resources
Blog https://github.blog/
Events & webinars https://github.com/resources/events
Community Forum https://github.com/orgs/community/discussions
Customer Stories https://github.com/customer-stories
Integrations https://github.com/marketplace
Customer support https://help.github.com/
Training https://learn.github.com/skills
GitHub Status https://www.githubstatus.com/
About https://github.com/about
Partners https://github.com/partners
Changelog https://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. https://githubuniverse.com/
Pricing https://github.com/pricing
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2902%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=RustPython%2FRustPython
Reload https://github.com/RustPython/RustPython/pull/2902/commits
Reload https://github.com/RustPython/RustPython/pull/2902/commits
Reload https://github.com/RustPython/RustPython/pull/2902/commits
RustPython https://github.com/RustPython
RustPython https://github.com/RustPython/RustPython
Code https://github.com/RustPython/RustPython
Issues195 (195) https://github.com/RustPython/RustPython/issues
Pull requests130 (130) https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/insights
https://github.com/RustPython/RustPython
coolreader18 https://github.com/coolreader18
RustPython:master https://github.com/RustPython/RustPython/tree/master
eldpswp99:dict-remain-order-after-delete https://github.com/eldpswp99/RustPython/tree/dict-remain-order-after-delete
Conversation https://github.com/RustPython/RustPython/pull/2902
Commits6 (6) https://github.com/RustPython/RustPython/pull/2902/commits
Checks https://github.com/RustPython/RustPython/pull/2902/checks
Files changed https://github.com/RustPython/RustPython/pull/2902/files
make dict remain order after delete https://github.com/RustPython/RustPython/pull/2902/commits#top
coolreader18 https://github.com/coolreader18
RustPython:master https://github.com/RustPython/RustPython/tree/master
eldpswp99:dict-remain-order-after-delete https://github.com/eldpswp99/RustPython/tree/dict-remain-order-after-delete
Update test_collections.py https://github.com/RustPython/RustPython/pull/2902/commits/b1207ab39e9ba085b9b1624f2f01829904ffd08f
fermian https://github.com/RustPython/RustPython/commits?author=fermian
eldpswp99 https://github.com/RustPython/RustPython/commits?author=eldpswp99
b1207ab https://github.com/RustPython/RustPython/pull/2902/commits/b1207ab39e9ba085b9b1624f2f01829904ffd08f
https://github.com/RustPython/RustPython/tree/b1207ab39e9ba085b9b1624f2f01829904ffd08f
change Dict Entries type Vec to Vec> https://github.com/RustPython/RustPython/pull/2902/commits/4e9f9ff129c68b252742e2518a440914fbeef3f8
https://github.com/eldpswp99
eldpswp99 https://github.com/RustPython/RustPython/commits?author=eldpswp99
4e9f9ff https://github.com/RustPython/RustPython/pull/2902/commits/4e9f9ff129c68b252742e2518a440914fbeef3f8
https://github.com/RustPython/RustPython/tree/4e9f9ff129c68b252742e2518a440914fbeef3f8
make dict delete remains order https://github.com/RustPython/RustPython/pull/2902/commits/ce99057c8103e19dee486fca212668e8d07e5b61
https://github.com/eldpswp99
eldpswp99 https://github.com/RustPython/RustPython/commits?author=eldpswp99
ce99057 https://github.com/RustPython/RustPython/pull/2902/commits/ce99057c8103e19dee486fca212668e8d07e5b61
https://github.com/RustPython/RustPython/tree/ce99057c8103e19dee486fca212668e8d07e5b61
optimize popitem using nentries which implies next insertion index https://github.com/RustPython/RustPython/pull/2902/commits/fca7b4174427cdb97011d97c86a65cd7c733fda7
https://github.com/eldpswp99
eldpswp99 https://github.com/RustPython/RustPython/commits?author=eldpswp99
fca7b41 https://github.com/RustPython/RustPython/pull/2902/commits/fca7b4174427cdb97011d97c86a65cd7c733fda7
https://github.com/RustPython/RustPython/tree/fca7b4174427cdb97011d97c86a65cd7c733fda7
remove test_ordered_dict delitem expected failure to passed test https://github.com/RustPython/RustPython/pull/2902/commits/b49a1e9f5ed03ee16d6125987497143582d38609
https://github.com/eldpswp99
eldpswp99 https://github.com/RustPython/RustPython/commits?author=eldpswp99
b49a1e9 https://github.com/RustPython/RustPython/pull/2902/commits/b49a1e9f5ed03ee16d6125987497143582d38609
https://github.com/RustPython/RustPython/tree/b49a1e9f5ed03ee16d6125987497143582d38609
resolving deadlock and redundant lookup, grammatic mistakes https://github.com/RustPython/RustPython/pull/2902/commits/564eb2991e194e2d85abf259bfdd4efa9679bd5d
https://github.com/eldpswp99
eldpswp99 https://github.com/RustPython/RustPython/commits?author=eldpswp99
564eb29 https://github.com/RustPython/RustPython/pull/2902/commits/564eb2991e194e2d85abf259bfdd4efa9679bd5d
https://github.com/RustPython/RustPython/tree/564eb2991e194e2d85abf259bfdd4efa9679bd5d
https://github.com
Terms https://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacy https://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Security https://github.com/security
Status https://www.githubstatus.com/
Community https://github.community/
Docs https://docs.github.com/
Contact https://support.github.com?tags=dotcom-footer