react-profiling 0
react-import-map react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controller voltron_pull_requests_fragments
route-action pull_request_layout
fetch-nonce v2:151513e8-1eed-2f6f-1d8f-3b2eb4b38f32
current-catalog-service-hash ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id 86BC:16AB79:4034790:518971F:6B021DB7
html-safe-nonce 0d49e1e871150f88a6ae4d57664df9491d5ec333b1386e41d62e48f64ea38563
visitor-payload eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkJDOjE2QUI3OTo0MDM0NzkwOjUxODk3MUY6NkIwMjFEQjciLCJ2aXNpdG9yX2lkIjoiMzA2NjA1MjI2NTM1MDY2NzcwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac 7d370afd5fad371a6276b1c4d13b029229feb8141a4347058a98ffb23f83b934
hovercard-subject-tag pull_request:714200466
github-keyboard-shortcuts repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verification Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-url https://collector.github.com/github/collect
analytics-location ///voltron/pull_requests_fragments/pull_request_layout
fb:app_id 1401488693436528
apple-itunes-app app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/2902/pull_request_layout
twitter:image https://opengraph.githubassets.com/3186fe9bd7a29d2ff3fb4980edef8f935d0602246fb7313fc948efc085b86706/RustPython/RustPython/pull/2902
twitter:card summary_large_image
og:image https://opengraph.githubassets.com/3186fe9bd7a29d2ff3fb4980edef8f935d0602246fb7313fc948efc085b86706/RustPython/RustPython/pull/2902
og:image:alt closes #2550
before:
dict is insertion order in CPython, but in RustPython the order was broken when deletion is occured
after:
it follows the CPython way. when it is deleted, make the entry t...
og:image:width 1200
og:image:height 600
og:site_name GitHub
og:type object
og:author:username eldpswp99
hostname github.com
expected-hostname github.com
None 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-control no-cache
go-import github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id 39710557
octolytics-dimension-user_login RustPython
octolytics-dimension-repository_id 135201145
octolytics-dimension-repository_nwo RustPython/RustPython
octolytics-dimension-repository_public true
octolytics-dimension-repository_is_fork false
octolytics-dimension-repository_network_root_id 135201145
octolytics-dimension-repository_network_root_nwo RustPython/RustPython
turbo-body-classes logged-out env-production page-responsive
disable-turbo false
browser-stats-url https://api.github.com/_private/browser/stats
browser-errors-url https://api.github.com/_private/browser/errors
release 423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-target full
theme-color #1e2327
color-scheme light dark
react-app-name pull-requests
Skip to content https://github.com/RustPython/RustPython/pull/2902#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2902
GitHubRepository hosting, code review, and collaboration https://github.com/platform
CopilotAI coding agent for tasks, projects, and automated work https://github.com/features/copilot
ActionsCI/CD and automation https://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcement https://github.com/features/code-quality
CodespacesCloud development environments https://github.com/features/codespaces
Code SecurityVulnerability detection and remediation https://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak prevention https://github.com/security/advanced-security/secret-protection
All Features https://github.com/features
Documentation https://docs.github.com/en
Training https://learn.github.com/skills
Certifications https://learn.github.com/credentials
Build with Copilot https://github.com/features/ai
Customize Copilot https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrations https://github.com/marketplace
Trending repos https://github.com/trending
GitHub Sponsors https://github.com/open-source/sponsors
Developer articles https://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. https://github.blog/changelog/
Enterprises https://github.com/enterprise
Team https://github.com/team
Startups https://github.com/enterprise/startups
Nonprofits https://github.com/solutions/industry/nonprofits
Healthcare https://github.com/solutions/industry/healthcare
Financial services https://github.com/solutions/industry/financial-services
Manufacturing https://github.com/solutions/industry/manufacturing
Government https://github.com/solutions/industry/government
See all industries https://github.com/solutions/industry
Why GitHub https://github.com/why-github
Customer Stories https://github.com/customer-stories
Business insights https://github.com/solutions/executive-insights
Trust Center https://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code security https://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI features https://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 support https://github.com/enterprise/premium-support
Documentation https://docs.github.com/en
Resource center https://github.com/resources
Blog https://github.blog/
Events & webinars https://github.com/resources/events
Community Forum https://github.com/orgs/community/discussions
Customer Stories https://github.com/customer-stories
Integrations https://github.com/marketplace
Customer support https://help.github.com/
Training https://learn.github.com/skills
GitHub Status https://www.githubstatus.com/
About https://github.com/about
Partners https://github.com/partners
Changelog https://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. https://githubuniverse.com/
Pricing https://github.com/pricing
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2902
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython
Reload https://github.com/RustPython/RustPython/pull/2902
Reload https://github.com/RustPython/RustPython/pull/2902
Reload https://github.com/RustPython/RustPython/pull/2902
RustPython https://github.com/RustPython
RustPython https://github.com/RustPython/RustPython
Code https://github.com/RustPython/RustPython
Issues195 (195) https://github.com/RustPython/RustPython/issues
Pull requests130 (130) https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/insights
https://github.com/RustPython/RustPython
coolreader18 https://github.com/coolreader18
RustPython:master https://github.com/RustPython/RustPython/tree/master
eldpswp99:dict-remain-order-after-delete https://github.com/eldpswp99/RustPython/tree/dict-remain-order-after-delete
Conversation https://github.com/RustPython/RustPython/pull/2902
Commits6 (6) https://github.com/RustPython/RustPython/pull/2902/commits
Checks https://github.com/RustPython/RustPython/pull/2902/checks
Files changed https://github.com/RustPython/RustPython/pull/2902/files
make dict remain order after delete https://github.com/RustPython/RustPython/pull/2902#top
coolreader18 https://github.com/coolreader18
RustPython:master https://github.com/RustPython/RustPython/tree/master
eldpswp99:dict-remain-order-after-delete https://github.com/eldpswp99/RustPython/tree/dict-remain-order-after-delete
https://github.com/eldpswp99
eldpswp99 https://github.com/eldpswp99
Aug 17, 2021 https://github.com/RustPython/RustPython/pull/2902#issue-972634185
Please reload this page https://github.com/RustPython/RustPython/pull/2902
#2550 https://github.com/RustPython/RustPython/pull/2550
Please reload this page https://github.com/RustPython/RustPython/pull/2902
fermian https://github.com/fermian
August 14, 2021 17:27 https://github.com/RustPython/RustPython/pull/2902#commits-pushed-b1207ab
https://github.com/fermian
https://github.com/eldpswp99
Update test_collections.py https://github.com/RustPython/RustPython/pull/2902/commits/b1207ab39e9ba085b9b1624f2f01829904ffd08f
b1207ab https://github.com/RustPython/RustPython/pull/2902/commits/b1207ab39e9ba085b9b1624f2f01829904ffd08f
https://github.com/eldpswp99
change Dict Entries type Vec to Vec> https://github.com/RustPython/RustPython/pull/2902/commits/4e9f9ff129c68b252742e2518a440914fbeef3f8
4e9f9ff https://github.com/RustPython/RustPython/pull/2902/commits/4e9f9ff129c68b252742e2518a440914fbeef3f8
https://github.com/eldpswp99
make dict delete remains order https://github.com/RustPython/RustPython/pull/2902/commits/ce99057c8103e19dee486fca212668e8d07e5b61
ce99057 https://github.com/RustPython/RustPython/pull/2902/commits/ce99057c8103e19dee486fca212668e8d07e5b61
https://github.com/eldpswp99
optimize popitem using nentries which implies next insertion index https://github.com/RustPython/RustPython/pull/2902/commits/fca7b4174427cdb97011d97c86a65cd7c733fda7
fca7b41 https://github.com/RustPython/RustPython/pull/2902/commits/fca7b4174427cdb97011d97c86a65cd7c733fda7
https://github.com/eldpswp99
eldpswp99 https://github.com/eldpswp99
Aug 17, 2021 https://github.com/RustPython/RustPython/pull/2902#event-5168626865
https://github.com/DimitrisJim
DimitrisJim https://github.com/DimitrisJim
Aug 17, 2021 https://github.com/RustPython/RustPython/pull/2902#issuecomment-900303974
Please reload this page https://github.com/RustPython/RustPython/pull/2902
https://github.com/eldpswp99
remove test_ordered_dict delitem expected failure to passed test https://github.com/RustPython/RustPython/pull/2902/commits/b49a1e9f5ed03ee16d6125987497143582d38609
b49a1e9 https://github.com/RustPython/RustPython/pull/2902/commits/b49a1e9f5ed03ee16d6125987497143582d38609
https://github.com/eldpswp99
eldpswp99 https://github.com/eldpswp99
Aug 17, 2021 https://github.com/RustPython/RustPython/pull/2902#issuecomment-900320264
Please reload this page https://github.com/RustPython/RustPython/pull/2902
@DimitrisJim https://github.com/DimitrisJim
Please reload this page https://github.com/RustPython/RustPython/pull/2902
https://github.com/DimitrisJim
DimitrisJim https://github.com/DimitrisJim
Aug 17, 2021 https://github.com/RustPython/RustPython/pull/2902#issuecomment-900347978
Please reload this page https://github.com/RustPython/RustPython/pull/2902
https://github.com/youknowone
youknowone https://github.com/youknowone
Aug 17, 2021
https://github.com/RustPython/RustPython/pull/2902#pullrequestreview-731856636
View reviewed changes
https://github.com/RustPython/RustPython/pull/2902/files/b49a1e9f5ed03ee16d6125987497143582d38609
vm/src/dictdatatype.rs https://github.com/RustPython/RustPython/pull/2902/files/b49a1e9f5ed03ee16d6125987497143582d38609#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Please reload this page https://github.com/RustPython/RustPython/pull/2902
vm/src/dictdatatype.rs https://github.com/RustPython/RustPython/pull/2902/files/b49a1e9f5ed03ee16d6125987497143582d38609#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Please reload this page https://github.com/RustPython/RustPython/pull/2902
vm/src/dictdatatype.rs https://github.com/RustPython/RustPython/pull/2902/files/b49a1e9f5ed03ee16d6125987497143582d38609#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Please reload this page https://github.com/RustPython/RustPython/pull/2902
vm/src/dictdatatype.rs https://github.com/RustPython/RustPython/pull/2902/files/b49a1e9f5ed03ee16d6125987497143582d38609#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Please reload this page https://github.com/RustPython/RustPython/pull/2902
vm/src/dictdatatype.rs https://github.com/RustPython/RustPython/pull/2902/files/b49a1e9f5ed03ee16d6125987497143582d38609#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Please reload this page https://github.com/RustPython/RustPython/pull/2902
vm/src/dictdatatype.rs https://github.com/RustPython/RustPython/pull/2902/files/b49a1e9f5ed03ee16d6125987497143582d38609#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Please reload this page https://github.com/RustPython/RustPython/pull/2902
vm/src/dictdatatype.rs https://github.com/RustPython/RustPython/pull/2902/files/b49a1e9f5ed03ee16d6125987497143582d38609#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Please reload this page https://github.com/RustPython/RustPython/pull/2902
vm/src/dictdatatype.rs https://github.com/RustPython/RustPython/pull/2902/files/b49a1e9f5ed03ee16d6125987497143582d38609#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Please reload this page https://github.com/RustPython/RustPython/pull/2902
https://github.com/youknowone
youknowone https://github.com/youknowone
Aug 17, 2021
https://github.com/RustPython/RustPython/pull/2902#pullrequestreview-731910264
View reviewed changes
https://github.com/RustPython/RustPython/pull/2902/files/b49a1e9f5ed03ee16d6125987497143582d38609
vm/src/dictdatatype.rs https://github.com/RustPython/RustPython/pull/2902/files/b49a1e9f5ed03ee16d6125987497143582d38609#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Please reload this page https://github.com/RustPython/RustPython/pull/2902
https://github.com/youknowone
youknowone https://github.com/youknowone
Aug 17, 2021
https://github.com/RustPython/RustPython/pull/2902#pullrequestreview-731912496
View reviewed changes
https://github.com/RustPython/RustPython/pull/2902/files/b49a1e9f5ed03ee16d6125987497143582d38609
vm/src/dictdatatype.rs https://github.com/RustPython/RustPython/pull/2902/files/b49a1e9f5ed03ee16d6125987497143582d38609#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Please reload this page https://github.com/RustPython/RustPython/pull/2902
https://github.com/youknowone
youknowone https://github.com/youknowone
Aug 17, 2021
https://github.com/RustPython/RustPython/pull/2902#ref-pullrequest-855953400
Retain order of keys in dict when deleting a key
#2550
https://github.com/RustPython/RustPython/pull/2550
https://github.com/eldpswp99
eldpswp99 https://github.com/eldpswp99
youknowone https://github.com/youknowone
August 17, 2021 16:46 https://github.com/RustPython/RustPython/pull/2902#event-5170144872
https://github.com/coolreader18
coolreader18 https://github.com/coolreader18
Aug 17, 2021
https://github.com/RustPython/RustPython/pull/2902#pullrequestreview-732002679
View reviewed changes
https://github.com/RustPython/RustPython/pull/2902/files
vm/src/dictdatatype.rs https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Please reload this page https://github.com/RustPython/RustPython/pull/2902
https://github.com/youknowone
youknowone https://github.com/youknowone
Aug 17, 2021
https://github.com/RustPython/RustPython/pull/2902#pullrequestreview-732012348
View reviewed changes
https://github.com/RustPython/RustPython/pull/2902/files
vm/src/dictdatatype.rs https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Please reload this page https://github.com/RustPython/RustPython/pull/2902
https://github.com/eldpswp99
eldpswp99 https://github.com/eldpswp99
force-pushed https://github.com/RustPython/RustPython/compare/c80bcdf3221ed7b3043141c9c026b98807c47292..abdbca05b8d56cfa543740a405d970f3aeef6fab
c80bcdf https://github.com/RustPython/RustPython/commit/c80bcdf3221ed7b3043141c9c026b98807c47292
abdbca0 https://github.com/RustPython/RustPython/commit/abdbca05b8d56cfa543740a405d970f3aeef6fab
Compare
https://github.com/RustPython/RustPython/compare/c80bcdf3221ed7b3043141c9c026b98807c47292..abdbca05b8d56cfa543740a405d970f3aeef6fab
August 17, 2021 17:16 https://github.com/RustPython/RustPython/pull/2902#event-5170294493
https://github.com/youknowone
youknowone https://github.com/youknowone
Aug 17, 2021
https://github.com/RustPython/RustPython/pull/2902#pullrequestreview-732033608
View reviewed changes
https://github.com/RustPython/RustPython/pull/2902/files
vm/src/dictdatatype.rs https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Please reload this page https://github.com/RustPython/RustPython/pull/2902
https://github.com/youknowone
youknowone https://github.com/youknowone
Aug 17, 2021
https://github.com/RustPython/RustPython/pull/2902#pullrequestreview-732037364
View reviewed changes
https://github.com/RustPython/RustPython/pull/2902/files
vm/src/dictdatatype.rs https://github.com/RustPython/RustPython/pull/2902/files#diff-c0addcccfa43701f0715aedb612d613ae5805693bdc6eb65f1870d33982df656
Please reload this page https://github.com/RustPython/RustPython/pull/2902
https://github.com/eldpswp99
resolving deadlock and redundant lookup, grammatic mistakes https://github.com/RustPython/RustPython/pull/2902/commits/564eb2991e194e2d85abf259bfdd4efa9679bd5d
564eb29 https://github.com/RustPython/RustPython/pull/2902/commits/564eb2991e194e2d85abf259bfdd4efa9679bd5d
https://github.com/eldpswp99
eldpswp99 https://github.com/eldpswp99
force-pushed https://github.com/RustPython/RustPython/compare/abdbca05b8d56cfa543740a405d970f3aeef6fab..564eb2991e194e2d85abf259bfdd4efa9679bd5d
abdbca0 https://github.com/RustPython/RustPython/commit/abdbca05b8d56cfa543740a405d970f3aeef6fab
564eb29 https://github.com/RustPython/RustPython/commit/564eb2991e194e2d85abf259bfdd4efa9679bd5d
Compare
https://github.com/RustPython/RustPython/compare/abdbca05b8d56cfa543740a405d970f3aeef6fab..564eb2991e194e2d85abf259bfdd4efa9679bd5d
August 17, 2021 17:29 https://github.com/RustPython/RustPython/pull/2902#event-5170352104
https://github.com/youknowone
youknowone https://github.com/youknowone
Aug 17, 2021
https://github.com/RustPython/RustPython/pull/2902#pullrequestreview-732103347
View reviewed changes
https://github.com/RustPython/RustPython/pull/2902/files/564eb2991e194e2d85abf259bfdd4efa9679bd5d
https://github.com/coolreader18
coolreader18 https://github.com/coolreader18
e277acc https://github.com/RustPython/RustPython/commit/e277acc7477f47114f1cd85536dc7974477ea801
Aug 17, 2021 https://github.com/RustPython/RustPython/pull/2902#event-5171243269
https://github.com/eldpswp99
eldpswp99 https://github.com/eldpswp99
Aug 17, 2021 https://github.com/RustPython/RustPython/pull/2902#issuecomment-900691510
Please reload this page https://github.com/RustPython/RustPython/pull/2902
https://github.com/DimitrisJim
DimitrisJim https://github.com/DimitrisJim
Aug 18, 2021
https://github.com/RustPython/RustPython/pull/2902#ref-pullrequest-889247145
Update typing to CPython 3.8
#2633
https://github.com/RustPython/RustPython/pull/2633
https://github.com/eldpswp99
eldpswp99 https://github.com/eldpswp99
Aug 19, 2021
https://github.com/RustPython/RustPython/pull/2902#ref-pullrequest-974665404
adjust dict reverse iterator next to new dict entries structure
#2915
https://github.com/RustPython/RustPython/pull/2915
https://github.com/youknowone
youknowone https://github.com/youknowone
z-ca-2021
https://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3Az-ca-2021
Oct 16, 2021 https://github.com/RustPython/RustPython/pull/2902#event-5472929476
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }}
Sign up for free https://github.com/join?source=comment-repo
Sign in to comment https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2902
https://github.com/coolreader18
coolreader18
https://github.com/coolreader18
https://github.com/RustPython/RustPython/pull/2902/files/c80bcdf3221ed7b3043141c9c026b98807c47292
https://github.com/youknowone
youknowone
https://github.com/youknowone
https://github.com/RustPython/RustPython/pull/2902/files/564eb2991e194e2d85abf259bfdd4efa9679bd5d
Please reload this page https://github.com/RustPython/RustPython/pull/2902
z-ca-2021
https://github.com/RustPython/RustPython/issues?q=state%3Aopen%20label%3Az-ca-2021
Please reload this page https://github.com/RustPython/RustPython/pull/2902
https://github.com/eldpswp99
https://github.com/DimitrisJim
https://github.com/youknowone
https://github.com/coolreader18
https://github.com/fermian
https://github.com
Terms https://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacy https://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Security https://github.com/security
Status https://www.githubstatus.com/
Community https://github.community/
Docs https://docs.github.com/
Contact https://support.github.com?tags=dotcom-footer