René's URL Explorer Experiment


Title: Further tweaking whats_left: allow differing implementation by jamestwebber · Pull Request #2764 · RustPython/RustPython · GitHub

Open Graph Title: Further tweaking whats_left: allow differing implementation by jamestwebber · Pull Request #2764 · RustPython/RustPython

X Title: Further tweaking whats_left: allow differing implementation by jamestwebber · Pull Request #2764 · RustPython/RustPython

Description: In #2760 I introduced a regression. Sometimes RustPython will have an object defined in a different module from the one CPython defines it in. This is probably fine (implementations can be different) as long as the code is working (which this script doesn't test anyway). For example, CPython's posix module defines its own chdir, cpu_count, etc. In RustPython the implementations are coming from os.py (maybe actually in os.rs?). Or for instance, CPython sys.stderr has no module defined (getmodule returns None) but RustPython will return _io. In these cases I think we'd want to count those as implemented, even though the code location is different. So, this just adds an option keep_other to the scanning code. When in CPython, the script only keeps members from the module itself (as well as those that are undefined), to reduce redundancy in the output. But in the RustPython code it will consider anything, in case implementations are coming from other modules. This takes another 177 lines off the output 😁

Open Graph Description: In #2760 I introduced a regression. Sometimes RustPython will have an object defined in a different module from the one CPython defines it in. This is probably fine (implementations can be differen...

X Description: In #2760 I introduced a regression. Sometimes RustPython will have an object defined in a different module from the one CPython defines it in. This is probably fine (implementations can be differen...

Opengraph URL: https://github.com/RustPython/RustPython/pull/2764

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d80d793a-fec5-0221-2a92-ecbfa0a8d7ca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F0A:158DF1:1C14F0F:25055E6:6B022046
html-safe-nonced17efa6fbee15784c49922271104fb2af6194f1113dd3863f4a96a99c7603b71
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjBBOjE1OERGMToxQzE0RjBGOjI1MDU1RTY6NkIwMjIwNDYiLCJ2aXNpdG9yX2lkIjoiODYwNTU4NTgxMTEwNDIxMTAxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac89f7cc849a7b46f3000b1596d2ce3ac416a761342b438223f217063cd9f9f5a8
hovercard-subject-tagpull_request:699712843
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/2764/files
twitter:imagehttps://avatars.githubusercontent.com/u/963647?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/963647?s=400&v=4
og:image:altIn #2760 I introduced a regression. Sometimes RustPython will have an object defined in a different module from the one CPython defines it in. This is probably fine (implementations can be differen...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/2764/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2764%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2764%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/2764/files
Reloadhttps://github.com/RustPython/RustPython/pull/2764/files
Reloadhttps://github.com/RustPython/RustPython/pull/2764/files
RustPythonhttps://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Codehttps://github.com/RustPython/RustPython
Issues195 (195)https://github.com/RustPython/RustPython/issues
Pull requests130 (130)https://github.com/RustPython/RustPython/pulls
Discussionshttps://github.com/RustPython/RustPython/discussions
Actionshttps://github.com/RustPython/RustPython/actions
Projectshttps://github.com/RustPython/RustPython/projects
Wikihttps://github.com/RustPython/RustPython/wiki
Security and qualityhttps://github.com/RustPython/RustPython/security
Insightshttps://github.com/RustPython/RustPython/insights
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
youknowonehttps://github.com/youknowone
RustPython:masterhttps://github.com/RustPython/RustPython/tree/master
jamestwebber:further-tweak-whats-lefthttps://github.com/jamestwebber/RustPython/tree/further-tweak-whats-left
Conversation 0 https://github.com/RustPython/RustPython/pull/2764
Commits 1 https://github.com/RustPython/RustPython/pull/2764/commits
Checks 0 https://github.com/RustPython/RustPython/pull/2764/checks
Files changed https://github.com/RustPython/RustPython/pull/2764/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2764/files
Further tweaking whats_left: allow differing implementation https://github.com/RustPython/RustPython/pull/2764/files#top
Show all changes 1 commit https://github.com/RustPython/RustPython/pull/2764/files
b0e5675 allow rustpython to move things Jul 29, 2021 https://github.com/RustPython/RustPython/pull/2764/commits/b0e5675cb6d601e41dd6892db4eee9ae7da26851
Clear filters https://github.com/RustPython/RustPython/pull/2764/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2764/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2764/files
extra_tests/not_impl_gen.pyhttps://github.com/RustPython/RustPython/pull/2764/files#diff-09a16abf793a3573ad4596556ea31d8c2d00819c0a8a96291e741ced0ee60b58
View file https://github.com/jamestwebber/RustPython/blob/b0e5675cb6d601e41dd6892db4eee9ae7da26851/extra_tests/not_impl_gen.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/2764/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/2764/files#diff-09a16abf793a3573ad4596556ea31d8c2d00819c0a8a96291e741ced0ee60b58
https://github.com/RustPython/RustPython/pull/2764/files#diff-09a16abf793a3573ad4596556ea31d8c2d00819c0a8a96291e741ced0ee60b58
https://github.com/RustPython/RustPython/pull/2764/files#diff-09a16abf793a3573ad4596556ea31d8c2d00819c0a8a96291e741ced0ee60b58
https://github.com/RustPython/RustPython/pull/2764/files#diff-09a16abf793a3573ad4596556ea31d8c2d00819c0a8a96291e741ced0ee60b58
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.