| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4a3f2b30-abb8-45a6-e4d2-69e68fe58bf1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B5BA:90EFB:19A2F8A:24EA29F:6A58C8BF |
| html-safe-nonce | 9836117801f32b5a6d798062f5d838dbbbd0507d93cd272eebc7bc9dd6689fdf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUJBOjkwRUZCOjE5QTJGOEE6MjRFQTI5Rjo2QTU4QzhCRiIsInZpc2l0b3JfaWQiOiI4ODQ4NDM5NTIyNzU1MTM1Njc5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c15ce2de312690ac52e1968254f5a906a0d780c08d8c1ca2313e9ec2df432e11 |
| hovercard-subject-tag | pull_request:536366069 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/RustPython/RustPython/2367/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/902f021ca2819e7ce8828d35e440bac995d9366e59b722818a15fa6b3454cf9b/RustPython/RustPython/pull/2367 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/902f021ca2819e7ce8828d35e440bac995d9366e59b722818a15fa6b3454cf9b/RustPython/RustPython/pull/2367 |
| og:image:alt | This PR refactors the benchmark suite to use Criterion (https://docs.rs/criterion/0.3.3/criterion/).
I've completely re-written the benchmarks, which I don't think where running correctly b... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | orf |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6 |
| turbo-cache-control | no-cache |
| go-import | github.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git |
| octolytics-dimension-user_id | 39710557 |
| octolytics-dimension-user_login | RustPython |
| octolytics-dimension-repository_id | 135201145 |
| octolytics-dimension-repository_nwo | RustPython/RustPython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 135201145 |
| octolytics-dimension-repository_network_root_nwo | RustPython/RustPython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/RustPython/RustPython/pull/2367#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2367 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2367 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=RustPython%2FRustPython |
| Reload | https://github.com/RustPython/RustPython/pull/2367 |
| Reload | https://github.com/RustPython/RustPython/pull/2367 |
| Reload | https://github.com/RustPython/RustPython/pull/2367 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2367 |
|
RustPython
| https://github.com/RustPython |
| RustPython | https://github.com/RustPython/RustPython |
|
Notifications
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Fork
1.5k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Star
22.2k
| https://github.com/login?return_to=%2FRustPython%2FRustPython |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
287
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
101
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security and quality
0
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
|
Code
| https://github.com/RustPython/RustPython |
|
Issues
| https://github.com/RustPython/RustPython/issues |
|
Pull requests
| https://github.com/RustPython/RustPython/pulls |
|
Discussions
| https://github.com/RustPython/RustPython/discussions |
|
Actions
| https://github.com/RustPython/RustPython/actions |
|
Projects
| https://github.com/RustPython/RustPython/projects |
|
Models
| https://github.com/RustPython/RustPython/models |
|
Wiki
| https://github.com/RustPython/RustPython/wiki |
|
Security and quality
| https://github.com/RustPython/RustPython/security |
|
Insights
| https://github.com/RustPython/RustPython/pulse |
| coolreader18 | https://github.com/coolreader18 |
| RustPython:master | https://github.com/RustPython/RustPython/tree/master |
| Conversation | https://github.com/RustPython/RustPython/pull/2367 |
| Commits16 (16) | https://github.com/RustPython/RustPython/pull/2367/commits |
| Checks | https://github.com/RustPython/RustPython/pull/2367/checks |
| Files changed | https://github.com/RustPython/RustPython/pull/2367/files |
| Refactor benchmarking suite to use Criterion and add microbenchmarks | https://github.com/RustPython/RustPython/pull/2367#top |
| coolreader18 | https://github.com/coolreader18 |
| RustPython:master | https://github.com/RustPython/RustPython/tree/master |
|
| https://github.com/orf |
| orf | https://github.com/orf |
| Dec 11, 2020 | https://github.com/RustPython/RustPython/pull/2367#issue-761744683 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2367 |
| https://docs.rs/criterion/0.3.3/criterion/ | https://docs.rs/criterion/0.3.3/criterion/ |
| https://user-images.githubusercontent.com/1027207/102023143-4bffd680-3d83-11eb-872c-b3d27ed1f685.png |
| this github action | https://github.com/boa-dev/criterion-compare-action |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2367 |
| orf | https://github.com/orf |
| December 11, 2020 00:28 | https://github.com/RustPython/RustPython/pull/2367#commits-pushed-5788e7b |
|
| https://github.com/orf |
| Refactor benchmarking suite to use Criterion | https://github.com/RustPython/RustPython/pull/2367/commits/5788e7bf8e1e0019e47f24ad6521c5836f3b146e |
| 5788e7b | https://github.com/RustPython/RustPython/pull/2367/commits/5788e7bf8e1e0019e47f24ad6521c5836f3b146e |
|
| https://github.com/orf |
| Remove dependency | https://github.com/RustPython/RustPython/pull/2367/commits/3a859672dea50a9a1e84e6ceb5d3fcdb14a45fe3 |
| 3a85967 | https://github.com/RustPython/RustPython/pull/2367/commits/3a859672dea50a9a1e84e6ceb5d3fcdb14a45fe3 |
|
| https://github.com/orf |
| Reduce to 30k | https://github.com/RustPython/RustPython/pull/2367/commits/a788df4eaf71557d7becd02a28cba70e6b8e2d6b |
| a788df4 | https://github.com/RustPython/RustPython/pull/2367/commits/a788df4eaf71557d7becd02a28cba70e6b8e2d6b |
|
| https://github.com/orf |
| Remove pystone second run | https://github.com/RustPython/RustPython/pull/2367/commits/6a841c07f1786badcfc25f0d3e26d725b3f75afe |
| 6a841c0 | https://github.com/RustPython/RustPython/pull/2367/commits/6a841c07f1786badcfc25f0d3e26d725b3f75afe |
|
| https://github.com/orf |
| Switch to 500 | https://github.com/RustPython/RustPython/pull/2367/commits/184f9aa59c60cc1ff05bba424373f46b3a79309b |
| 184f9aa | https://github.com/RustPython/RustPython/pull/2367/commits/184f9aa59c60cc1ff05bba424373f46b3a79309b |
|
| https://github.com/orf |
| Fix strings | https://github.com/RustPython/RustPython/pull/2367/commits/9f04f377cd1561b6f4a65837e8e8042c1598c90e |
| 9f04f37 | https://github.com/RustPython/RustPython/pull/2367/commits/9f04f377cd1561b6f4a65837e8e8042c1598c90e |
|
| https://github.com/orf |
| Improve benchmarks | https://github.com/RustPython/RustPython/pull/2367/commits/a605b93d0fff15dbfd5c0182f9fa2d0900e3a310 |
| a605b93 | https://github.com/RustPython/RustPython/pull/2367/commits/a605b93d0fff15dbfd5c0182f9fa2d0900e3a310 |
|
| https://github.com/orf |
| fmt | https://github.com/RustPython/RustPython/pull/2367/commits/1e4fc5c70f879b59a8d6cb02adb0a13a0a4f8be8 |
| 1e4fc5c | https://github.com/RustPython/RustPython/pull/2367/commits/1e4fc5c70f879b59a8d6cb02adb0a13a0a4f8be8 |
|
| https://github.com/orf |
| Exclude benchmarks from flake8 | https://github.com/RustPython/RustPython/pull/2367/commits/e7458059fd41abe1ff66b71645c05783119eb37a |
| e745805 | https://github.com/RustPython/RustPython/pull/2367/commits/e7458059fd41abe1ff66b71645c05783119eb37a |
|
| https://github.com/orf |
| Fix loading | https://github.com/RustPython/RustPython/pull/2367/commits/c447ffd7591cf93a10237cfc0821593d62d77408 |
| c447ffd | https://github.com/RustPython/RustPython/pull/2367/commits/c447ffd7591cf93a10237cfc0821593d62d77408 |
|
| https://github.com/orf |
| Switch benchmarkid | https://github.com/RustPython/RustPython/pull/2367/commits/bfd05eee24491856111330b9c5e2ca397b2edaef |
| bfd05ee | https://github.com/RustPython/RustPython/pull/2367/commits/bfd05eee24491856111330b9c5e2ca397b2edaef |
| https://github.com/orf |
| orf | https://github.com/orf |
| Dec 11, 2020 | https://github.com/RustPython/RustPython/pull/2367#issuecomment-743336076 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2367 |
| https://user-images.githubusercontent.com/1027207/101936891-0d2e1d00-3bd9-11eb-8437-3d718c37bbec.png |
| https://user-images.githubusercontent.com/1027207/101936963-233bdd80-3bd9-11eb-88fd-677cb2d78dbd.png |
| https://user-images.githubusercontent.com/1027207/101939533-07d2d180-3bdd-11eb-800a-2fcd3b23fc26.png |
| https://user-images.githubusercontent.com/1027207/101939538-086b6800-3bdd-11eb-88d0-82dc09c9717b.png |
| https://user-images.githubusercontent.com/1027207/101939540-0903fe80-3bdd-11eb-9810-9c814ee36e26.png |
| criterion.zip | https://github.com/RustPython/RustPython/files/5683679/criterion.zip |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2367 |
|
| https://github.com/orf |
| Add microbenchmarks | https://github.com/RustPython/RustPython/pull/2367/commits/dde8af14f4912d3a96f941b75e8a48ec9e0de6b5 |
| dde8af1 | https://github.com/RustPython/RustPython/pull/2367/commits/dde8af14f4912d3a96f941b75e8a48ec9e0de6b5 |
| https://github.com/orf |
| orf | https://github.com/orf |
| Dec 13, 2020 | https://github.com/RustPython/RustPython/pull/2367#event-4106223187 |
| orf | https://github.com/orf |
| December 13, 2020 17:07 | https://github.com/RustPython/RustPython/pull/2367#commits-pushed-eb22ba1 |
|
| https://github.com/orf |
| Add microbenchmarks | https://github.com/RustPython/RustPython/pull/2367/commits/eb22ba12c61414771decf6c4f1215b1ec9209fb5 |
| eb22ba1 | https://github.com/RustPython/RustPython/pull/2367/commits/eb22ba12c61414771decf6c4f1215b1ec9209fb5 |
|
| https://github.com/orf |
| Fix micro benchmarks | https://github.com/RustPython/RustPython/pull/2367/commits/7818fd20833b7c3de8fdf7abe9681492a81f55ad |
| 7818fd2 | https://github.com/RustPython/RustPython/pull/2367/commits/7818fd20833b7c3de8fdf7abe9681492a81f55ad |
|
| https://github.com/orf |
| Ignore benches | https://github.com/RustPython/RustPython/pull/2367/commits/d36e1500ebbdfc69ec5af0a14fdb2e9210f81bc9 |
| d36e150 | https://github.com/RustPython/RustPython/pull/2367/commits/d36e1500ebbdfc69ec5af0a14fdb2e9210f81bc9 |
|
| https://github.com/coolreader18 |
| Allow running pystone standalone | https://github.com/RustPython/RustPython/pull/2367/commits/b221dbb5d65f1bf7321a22a0111c345c623fccc1 |
| b221dbb | https://github.com/RustPython/RustPython/pull/2367/commits/b221dbb5d65f1bf7321a22a0111c345c623fccc1 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
|
Dec 13, 2020
| https://github.com/RustPython/RustPython/pull/2367#pullrequestreview-550974073 |
|
View reviewed changes
| https://github.com/RustPython/RustPython/pull/2367/files/d36e1500ebbdfc69ec5af0a14fdb2e9210f81bc9 |
| coolreader18 | https://github.com/coolreader18 |
| https://github.com/RustPython/RustPython/pull/2367#pullrequestreview-550974073 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2367 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| Dec 13, 2020 | https://github.com/RustPython/RustPython/pull/2367#issuecomment-744087464 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2367 |
| https://github.com/orf |
| orf | https://github.com/orf |
| Dec 13, 2020 | https://github.com/RustPython/RustPython/pull/2367#issuecomment-744087561 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2367 |
| https://github.com/orf |
| orf | https://github.com/orf |
| Dec 13, 2020 | https://github.com/RustPython/RustPython/pull/2367#issuecomment-744089526 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2367 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| Dec 14, 2020 | https://github.com/RustPython/RustPython/pull/2367#issuecomment-744112536 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2367 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| c9a332c | https://github.com/RustPython/RustPython/commit/c9a332c309994f855acd445754d3996aba90a2c2 |
| Dec 14, 2020 | https://github.com/RustPython/RustPython/pull/2367#event-4106738420 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| Dec 14, 2020 | https://github.com/RustPython/RustPython/pull/2367#issuecomment-744112725 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2367 |
| https://github.com/orf |
| orf | https://github.com/orf |
| December 14, 2020 13:24 | https://github.com/RustPython/RustPython/pull/2367#event-4109198362 |
| https://github.com/mireille-raad |
| mireille-raad | https://github.com/mireille-raad |
|
Dec 16, 2020
| https://github.com/RustPython/RustPython/pull/2367#ref-issue-419096623 |
|
Micro-benchmarks for performance critical operations
#644
| https://github.com/RustPython/RustPython/issues/644 |
| https://github.com/mireille-raad |
| mireille-raad | https://github.com/mireille-raad |
| Dec 16, 2020 | https://github.com/RustPython/RustPython/pull/2367#issuecomment-746772724 |
| https://github.com/RustPython/rustpython.github.io | https://github.com/RustPython/rustpython.github.io |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2367 |
| https://github.com/youknowone |
| youknowone | https://github.com/youknowone |
| Dec 21, 2020 | https://github.com/RustPython/RustPython/pull/2367#issuecomment-748915723 |
| @mireille-raad | https://github.com/mireille-raad |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2367 |
| https://github.com/coolreader18 |
| coolreader18 | https://github.com/coolreader18 |
| Dec 21, 2020 | https://github.com/RustPython/RustPython/pull/2367#issuecomment-749129824 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2367 |
| https://github.com/mireille-raad |
| mireille-raad | https://github.com/mireille-raad |
| Jan 8, 2021 | https://github.com/RustPython/RustPython/pull/2367#issuecomment-756848187 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2367 |
| https://github.com/mireille-raad |
| mireille-raad | https://github.com/mireille-raad |
|
Jan 8, 2021
| https://github.com/RustPython/RustPython/pull/2367#ref-issue-782241030 |
|
Automate generation of benchmarks and display them on website
#2396
| https://github.com/RustPython/RustPython/issues/2396 |
| https://github.co/hiddenchars |
| https://github.com/RustPython/RustPython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2367 |
|
| https://github.com/coolreader18 |
|
coolreader18
| https://github.com/coolreader18 |
|
| https://github.com/RustPython/RustPython/pull/2367/files/d36e1500ebbdfc69ec5af0a14fdb2e9210f81bc9 |
| Please reload this page | https://github.com/RustPython/RustPython/pull/2367 |
|
| https://github.com/orf |
|
| https://github.com/coolreader18 |
|
| https://github.com/mireille-raad |
|
| https://github.com/youknowone |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |