René's URL Explorer Experiment


Title: Update pystruct + array by coolreader18 · Pull Request #2297 · RustPython/RustPython · GitHub

Open Graph Title: Update pystruct + array by coolreader18 · Pull Request #2297 · RustPython/RustPython

X Title: Update pystruct + array by coolreader18 · Pull Request #2297 · RustPython/RustPython

Description: This is sort of a big lump change, and there aren't necessarily tests to prove it, since there aren't any tests in test_struct.py that verify the native ordering -- even though there's padding now and correct alignment/size, the tests that I unskipped aren't related to that 😞 . Still, I think this is cleaner then it was before; there's an enum for the codes now, and finding the pack() function for a code is a bit cleaner now and respects endianness/architecture

Open Graph Description: This is sort of a big lump change, and there aren't necessarily tests to prove it, since there aren't any tests in test_struct.py that verify the native ordering -- even though there's ...

X Description: This is sort of a big lump change, and there aren't necessarily tests to prove it, since there aren't any tests in test_struct.py that verify the native ordering -- even though ther...

Opengraph URL: https://github.com/RustPython/RustPython/pull/2297

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7bfab759-9826-82ef-3513-003ebfdb9215
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8E72:2D49:16170:1D198:6A59676C
html-safe-noncebaf4b6ed56c085f07d71f0eda0f7cda7a14bac21e8bd5bc3deb375ee671f1a74
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTcyOjJENDk6MTYxNzA6MUQxOTg6NkE1OTY3NkMiLCJ2aXNpdG9yX2lkIjoiMTU1MjIwMDYwNzAzMzAyNjQxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac271f8b43b00346bab7cad698d99c3e52ffeadbfbed9adc36d7c7e2fbd7c1a278
hovercard-subject-tagpull_request:506962355
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/RustPython/RustPython/pull/2297/files
twitter:imagehttps://avatars.githubusercontent.com/u/33094578?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/33094578?s=400&v=4
og:image:altThis is sort of a big lump change, and there aren't necessarily tests to prove it, since there aren't any tests in test_struct.py that verify the native ordering -- even though there's ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonea540949572872b935b393b36db38922db390ae71c859537d741b8f3eb7e545b5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/RustPython/RustPython git https://github.com/RustPython/RustPython.git
octolytics-dimension-user_id39710557
octolytics-dimension-user_loginRustPython
octolytics-dimension-repository_id135201145
octolytics-dimension-repository_nwoRustPython/RustPython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id135201145
octolytics-dimension-repository_network_root_nwoRustPython/RustPython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4aa391d605ba491481565840251a4b0fec3f4807
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/RustPython/RustPython/pull/2297/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2297%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FRustPython%2FRustPython%2Fpull%2F2297%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=RustPython%2FRustPython
Reloadhttps://github.com/RustPython/RustPython/pull/2297/files
Reloadhttps://github.com/RustPython/RustPython/pull/2297/files
Reloadhttps://github.com/RustPython/RustPython/pull/2297/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2297/files
RustPython https://github.com/RustPython
RustPythonhttps://github.com/RustPython/RustPython
Notifications https://github.com/login?return_to=%2FRustPython%2FRustPython
Fork 1.5k https://github.com/login?return_to=%2FRustPython%2FRustPython
Star 22.2k https://github.com/login?return_to=%2FRustPython%2FRustPython
Code https://github.com/RustPython/RustPython
Issues 287 https://github.com/RustPython/RustPython/issues
Pull requests 104 https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality 0 https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
Code https://github.com/RustPython/RustPython
Issues https://github.com/RustPython/RustPython/issues
Pull requests https://github.com/RustPython/RustPython/pulls
Discussions https://github.com/RustPython/RustPython/discussions
Actions https://github.com/RustPython/RustPython/actions
Projects https://github.com/RustPython/RustPython/projects
Models https://github.com/RustPython/RustPython/models
Wiki https://github.com/RustPython/RustPython/wiki
Security and quality https://github.com/RustPython/RustPython/security
Insights https://github.com/RustPython/RustPython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FRustPython%2FRustPython%2Fissues%2Fnew%2Fchoose
coolreader18https://github.com/coolreader18
masterhttps://github.com/RustPython/RustPython/tree/master
coolreader18/rework-pystructhttps://github.com/RustPython/RustPython/tree/coolreader18/rework-pystruct
Conversation 5 https://github.com/RustPython/RustPython/pull/2297
Commits 3 https://github.com/RustPython/RustPython/pull/2297/commits
Checks 0 https://github.com/RustPython/RustPython/pull/2297/checks
Files changed https://github.com/RustPython/RustPython/pull/2297/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2297/files
Update pystruct + array https://github.com/RustPython/RustPython/pull/2297/files#top
Show all changes 3 commits https://github.com/RustPython/RustPython/pull/2297/files
0f84bd4 Update pystruct + array coolreader18 Oct 20, 2020 https://github.com/RustPython/RustPython/pull/2297/commits/0f84bd4070073fcb99d6d02f9aeecb26402db09f
59169aa Use a static type for struct.error coolreader18 Oct 20, 2020 https://github.com/RustPython/RustPython/pull/2297/commits/59169aa2ce51e5e6b35217fe306327b806198560
026f396 Use std::os::raw::c_* instead of libc::c_* for wasm compat coolreader18 Oct 20, 2020 https://github.com/RustPython/RustPython/pull/2297/commits/026f396e983691bb2e1d0fcdaa9664d93729e876
Clear filters https://github.com/RustPython/RustPython/pull/2297/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2297/files
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2297/files
test_struct.py https://github.com/RustPython/RustPython/pull/2297/files#diff-a0f40287846c29f492aa60945faa2d6d0d7632def72b2e230c30c559d7a48c07
array.rs https://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
pystruct.rs https://github.com/RustPython/RustPython/pull/2297/files#diff-7aa53b8b38a644b88a0d8d949c648e30ce3a426ef6613d72adc2253a16357702
Lib/test/test_struct.pyhttps://github.com/RustPython/RustPython/pull/2297/files#diff-a0f40287846c29f492aa60945faa2d6d0d7632def72b2e230c30c559d7a48c07
View file https://github.com/RustPython/RustPython/blob/026f396e983691bb2e1d0fcdaa9664d93729e876/Lib/test/test_struct.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/2297/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/2297/files#diff-a0f40287846c29f492aa60945faa2d6d0d7632def72b2e230c30c559d7a48c07
https://github.com/RustPython/RustPython/pull/2297/files#diff-a0f40287846c29f492aa60945faa2d6d0d7632def72b2e230c30c559d7a48c07
https://github.com/RustPython/RustPython/pull/2297/files#diff-a0f40287846c29f492aa60945faa2d6d0d7632def72b2e230c30c559d7a48c07
https://github.com/RustPython/RustPython/pull/2297/files#diff-a0f40287846c29f492aa60945faa2d6d0d7632def72b2e230c30c559d7a48c07
vm/src/stdlib/array.rshttps://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
View file https://github.com/RustPython/RustPython/blob/026f396e983691bb2e1d0fcdaa9664d93729e876/vm/src/stdlib/array.rs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/RustPython/RustPython/pull/2297/{{ revealButtonHref }}
https://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
https://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
https://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
https://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
https://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
https://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
https://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
https://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
https://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
https://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
https://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
https://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
https://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
https://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
https://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
https://github.com/RustPython/RustPython/pull/2297/files#diff-4635d6f0dfc1734825480f0a3a1a8b351da9aa1d1dccc6491411b26c73cd6617
Please reload this pagehttps://github.com/RustPython/RustPython/pull/2297/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.